--- gvpe/src/vpn_tcp.C	2007/11/10 05:14:23	1.17
+++ gvpe/src/vpn_tcp.C	2007/12/06 00:35:29	1.24
@@ -1,6 +1,6 @@
 /*
     vpn_tcp.C -- handle the tcp part of the protocol.
-    Copyright (C) 2003-2005 Marc Lehmann <gvpe@schmorp.de>
+    Copyright (C) 2003-2007 Marc Lehmann <gvpe@schmorp.de>
  
     This file is part of GVPE.
 
@@ -23,10 +23,10 @@
 
 #if ENABLE_TCP
 
-// tcp processing is extremely ugly, since the vpe protocol is simply
+// tcp processing is extremely ugly, since the gvpe protocol is simply
 // designed for unreliable datagram networks. tcp is implemented by
 // multiplexing packets over tcp. errors are completely ignored, as we
-// rely on the higher level protocol to time out and reconnect.
+// rely on the higher level layers to time out and reconnect.
 
 #include <cstring>
 
@@ -59,18 +59,21 @@
   }
 };
 
-struct tcp_si_map : public map<const sockinfo *, tcp_connection *, lt_sockinfo> {
-  void cleaner_cb (ev::timer &w, int revents); ev::timer cleaner;
+struct tcp_si_map : public map<const sockinfo *, tcp_connection *, lt_sockinfo>
+{
+  inline void cleaner_cb (ev::timer &w, int revents); ev::timer cleaner;
 
   tcp_si_map ()
-  : cleaner(this, &tcp_si_map::cleaner_cb)
   {
-    cleaner.start (300, 300);
+    cleaner.set<tcp_si_map, &tcp_si_map::cleaner_cb> (this);
+    cleaner.start (::conf.keepalive / 2, ::conf.keepalive / 2);
   }
 
 } tcp_si;
 
-struct tcp_connection : ev::io {
+struct tcp_connection : ev::io
+{
+  int tos;
   tstamp last_activity;
   const sockinfo si;
   vpn &v;
@@ -88,7 +91,7 @@
   int proxy_req_len;
 #endif
 
-  void tcpv4_ev (ev::io &w, int revents);
+  inline void tcpv4_ev (ev::io &w, int revents);
 
   bool send_packet (vpn_packet *pkt, int tos);
   bool write_packet ();
@@ -106,13 +109,14 @@
 
 void tcp_si_map::cleaner_cb (ev::timer &w, int revents)
 {
-  tstamp to = ev::ev_now () - ::conf.keepalive - 30 - 60;
+  tstamp to = ev_now () - ::conf.keepalive - 30 - 60;
 
   for (iterator i = begin (); i != end(); )
     if (i->second->last_activity >= to)
       ++i;
     else
       {
+        delete i->second;
         erase (i);
         i = begin ();
       }
@@ -202,7 +206,7 @@
 void
 tcp_connection::tcpv4_ev (ev::io &w, int revents)
 {
-  last_activity = ev::ev_now ();
+  last_activity = ev_now ();
 
   if (revents & EV_WRITE)
     {
@@ -347,7 +351,7 @@
 bool
 tcp_connection::send_packet (vpn_packet *pkt, int tos)
 {
-  last_activity = ev::ev_now ();
+  last_activity = ev_now ();
 
   if (state == IDLE)
     {
@@ -410,7 +414,11 @@
           // how this maps to the underlying tcp packets we don't know
           // and we don't care. at least we tried ;)
 #if defined(SOL_IP) && defined(IP_TOS)
-          setsockopt (fd, SOL_IP, IP_TOS, &tos, sizeof tos);
+          if (tos != this->tos)
+            {
+              this->tos = tos;
+              setsockopt (fd, SOL_IP, IP_TOS, &tos, sizeof tos);
+            }
 #endif
 
           w_pkt = pkt;
@@ -434,10 +442,13 @@
 
 void tcp_connection::error ()
 {
+  stop ();
+
   if (fd >= 0)
     {
       close (fd);
-      fd = -1;
+      tos = -1;
+      fd  = -1;
     }
 
   delete r_pkt; r_pkt = 0;
@@ -446,19 +457,18 @@
   free (proxy_req); proxy_req = 0;
 #endif
 
-  stop ();
   state = active ? IDLE : ERROR;
 }
 
 tcp_connection::tcp_connection (int fd_, const sockinfo &si_, vpn &v_)
-: v(v_), si(si_), ev::io(this, &tcp_connection::tcpv4_ev)
+: v(v_), si(si_)
 {
-  if (!tcp_si.cleaner.active)
-    tcp_si.cleaner.start (0);
+  set<tcp_connection, &tcp_connection::tcpv4_ev> (this);
 
-  last_activity = ev::ev_now ();
+  last_activity = ev_now ();
   r_pkt = 0;
   w_pkt = 0;
+  tos = -1;
   fd = fd_;
 #if ENABLE_HTTP_PROXY
   proxy_req = 0;