ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/libcoro/coro.c
(Generate patch)

Comparing libcoro/coro.c (file contents):
Revision 1.36 by root, Wed Nov 5 01:54:34 2008 UTC vs.
Revision 1.50 by root, Fri Apr 2 19:13:54 2010 UTC

1/* 1/*
2 * Copyright (c) 2001-2008 Marc Alexander Lehmann <schmorp@schmorp.de> 2 * Copyright (c) 2001-2009 Marc Alexander Lehmann <schmorp@schmorp.de>
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without modifica- 4 * Redistribution and use in source and binary forms, with or without modifica-
5 * tion, are permitted provided that the following conditions are met: 5 * tion, are permitted provided that the following conditions are met:
6 * 6 *
7 * 1. Redistributions of source code must retain the above copyright notice, 7 * 1. Redistributions of source code must retain the above copyright notice,
… …
38 * go to Ralf S. Engelschall <rse@engelschall.com>. 38 * go to Ralf S. Engelschall <rse@engelschall.com>.
39 */ 39 */
40 40
41#include "coro.h" 41#include "coro.h"
42 42
43#include <string.h>
44
45/*****************************************************************************/
46/* ucontext/setjmp/asm backends */
47/*****************************************************************************/
48#if CORO_UCONTEXT || CORO_SJLJ || CORO_LOSER || CORO_LINUX || CORO_IRIX || CORO_ASM
49
50# if CORO_UCONTEXT
51# include <stddef.h>
52# endif
53
43#if !defined(STACK_ADJUST_PTR) 54# if !defined(STACK_ADJUST_PTR)
55# if __sgi
44/* IRIX is decidedly NON-unix */ 56/* IRIX is decidedly NON-unix */
45# if __sgi
46# define STACK_ADJUST_PTR(sp,ss) ((char *)(sp) + (ss) - 8) 57# define STACK_ADJUST_PTR(sp,ss) ((char *)(sp) + (ss) - 8)
47# define STACK_ADJUST_SIZE(sp,ss) ((ss) - 8) 58# define STACK_ADJUST_SIZE(sp,ss) ((ss) - 8)
48# elif (__i386__ && CORO_LINUX) || (_M_IX86 && CORO_LOSER) 59# elif (__i386__ && CORO_LINUX) || (_M_IX86 && CORO_LOSER)
49# define STACK_ADJUST_PTR(sp,ss) ((char *)(sp) + (ss)) 60# define STACK_ADJUST_PTR(sp,ss) ((char *)(sp) + (ss))
50# define STACK_ADJUST_SIZE(sp,ss) (ss) 61# define STACK_ADJUST_SIZE(sp,ss) (ss)
51# elif (__amd64__ && CORO_LINUX) || ((_M_AMD64 || _M_IA64) && CORO_LOSER) 62# elif (__amd64__ && CORO_LINUX) || ((_M_AMD64 || _M_IA64) && CORO_LOSER)
52# define STACK_ADJUST_PTR(sp,ss) ((char *)(sp) + (ss) - 8) 63# define STACK_ADJUST_PTR(sp,ss) ((char *)(sp) + (ss) - 8)
53# define STACK_ADJUST_SIZE(sp,ss) (ss) 64# define STACK_ADJUST_SIZE(sp,ss) (ss)
54# else 65# else
55# define STACK_ADJUST_PTR(sp,ss) (sp) 66# define STACK_ADJUST_PTR(sp,ss) (sp)
56# define STACK_ADJUST_SIZE(sp,ss) (ss) 67# define STACK_ADJUST_SIZE(sp,ss) (ss)
57# endif 68# endif
58#endif 69# endif
59 70
60#if CORO_UCONTEXT
61# include <stddef.h>
62#endif
63
64#if CORO_SJLJ || CORO_LOSER || CORO_LINUX || CORO_IRIX || CORO_ASM
65
66#include <stdlib.h> 71# include <stdlib.h>
67 72
68#if CORO_SJLJ 73# if CORO_SJLJ
69# include <stdio.h> 74# include <stdio.h>
70# include <signal.h> 75# include <signal.h>
71# include <unistd.h> 76# include <unistd.h>
72#endif 77# endif
73 78
74static volatile coro_func coro_init_func; 79static coro_func coro_init_func;
75static volatile void *coro_init_arg; 80static void *coro_init_arg;
76static volatile coro_context *new_coro, *create_coro; 81static coro_context *new_coro, *create_coro;
77
78/* what we really want to detect here is wether we use a new-enough version of GAS */
79/* instead, check for gcc 3, ELF and GNU/Linux and hope for the best */
80#if __GNUC__ >= 3 && __ELF__ && __linux__
81# define HAVE_CFI 1
82#endif
83 82
84static void 83static void
85coro_init (void) 84coro_init (void)
86{ 85{
87 volatile coro_func func = coro_init_func; 86 volatile coro_func func = coro_init_func;
88 volatile void *arg = coro_init_arg; 87 volatile void *arg = coro_init_arg;
89 88
90 coro_transfer ((coro_context *)new_coro, (coro_context *)create_coro); 89 coro_transfer (new_coro, create_coro);
91 90
92 func ((void *)arg); 91 func ((void *)arg);
93 92
94 /* the new coro returned. bad. just abort() for now */ 93 /* the new coro returned. bad. just abort() for now */
95 abort (); 94 abort ();
96} 95}
97 96
98# if CORO_SJLJ 97# if CORO_SJLJ
99 98
100static volatile int trampoline_count; 99static volatile int trampoline_done;
101 100
102/* trampoline signal handler */ 101/* trampoline signal handler */
103static void 102static void
104trampoline (int sig) 103trampoline (int sig)
105{ 104{
106 if (setjmp (((coro_context *)new_coro)->env)) 105 if (coro_setjmp (new_coro->env))
107 {
108#if HAVE_CFI
109 asm (".cfi_startproc");
110#endif
111 coro_init (); /* start it */ 106 coro_init (); /* start it */
112#if HAVE_CFI
113 asm (".cfi_endproc");
114#endif
115 }
116 else 107 else
117 trampoline_count++; 108 trampoline_done = 1;
118} 109}
119 110
120# endif
121
122#endif 111# endif
123 112
124#if CORO_ASM 113# if CORO_ASM
114
125asm ( 115 asm (
126 ".text\n" 116 ".text\n"
127 ".globl coro_transfer\n" 117 ".globl coro_transfer\n"
128 ".type coro_transfer, @function\n" 118 ".type coro_transfer, @function\n"
129 "coro_transfer:\n" 119 "coro_transfer:\n"
130#if __amd64 120 #if __amd64
131# define NUM_ALIGN 1
132# define NUM_SAVED 5 121 #define NUM_SAVED 6
122 "\tpush %rbp\n"
133 "\tpush %rbx\n" 123 "\tpush %rbx\n"
134 "\tpush %r12\n" 124 "\tpush %r12\n"
135 "\tpush %r13\n" 125 "\tpush %r13\n"
136 "\tpush %r14\n" 126 "\tpush %r14\n"
137 "\tpush %r15\n" 127 "\tpush %r15\n"
128 #if CORO_WIN_TIB
129 "\tpush %fs:0xc\n"
130 "\tpush %fs:0x8\n"
131 "\tpush %fs:0x0\n"
132 #endif
138 "\tmov %rsp, (%rdi)\n" 133 "\tmov %rsp, (%rdi)\n"
139 "\tmov (%rsi), %rsp\n" 134 "\tmov (%rsi), %rsp\n"
135 #if CORO_WIN_TIB
136 "\tpop %fs:0x0\n"
137 "\tpop %fs:0x8\n"
138 "\tpop %fs:0xc\n"
139 #endif
140 "\tpop %r15\n" 140 "\tpop %r15\n"
141 "\tpop %r14\n" 141 "\tpop %r14\n"
142 "\tpop %r13\n" 142 "\tpop %r13\n"
143 "\tpop %r12\n" 143 "\tpop %r12\n"
144 "\tpop %rbx\n" 144 "\tpop %rbx\n"
145 "\tpop %rbp\n"
145#elif __i386 146 #elif __i386
146# define NUM_ALIGN 1
147# define NUM_SAVED 4 147 #define NUM_SAVED 4
148 "\tpush %ebx\n"
149 "\tpush %esi\n"
150 "\tpush %edi\n"
151 "\tpush %ebp\n" 148 "\tpush %ebp\n"
149 "\tpush %ebx\n"
150 "\tpush %esi\n"
151 "\tpush %edi\n"
152 #if CORO_WIN_TIB
153 "\tpush %fs:8\n"
154 "\tpush %fs:4\n"
155 "\tpush %fs:0\n"
156 #endif
152 "\tmov %esp, (%eax)\n" 157 "\tmov %esp, (%eax)\n"
153 "\tmov (%edx), %esp\n" 158 "\tmov (%edx), %esp\n"
154 "\tpop %ebp\n" 159 #if CORO_WIN_TIB
160 "\tpop %fs:0\n"
161 "\tpop %fs:4\n"
162 "\tpop %fs:8\n"
163 #endif
155 "\tpop %edi\n" 164 "\tpop %edi\n"
156 "\tpop %esi\n" 165 "\tpop %esi\n"
157 "\tpop %ebx\n" 166 "\tpop %ebx\n"
158#else 167 "\tpop %ebp\n"
168 #else
159# error unsupported architecture 169 #error unsupported architecture
160#endif 170 #endif
161 "\tret\n" 171 "\tret\n"
162); 172 );
173
163#endif 174# endif
164 175
165#if CORO_PTHREAD 176void
166 177coro_create (coro_context *ctx, coro_func coro, void *arg, void *sptr, long ssize)
167struct coro_init_args {
168 coro_func func;
169 void *arg;
170 coro_context *self, *main;
171};
172
173pthread_mutex_t coro_mutex = PTHREAD_MUTEX_INITIALIZER;
174
175static void *
176trampoline (void *args_)
177{ 178{
178 struct coro_init_args *args = (struct coro_init_args *)args_; 179 coro_context nctx;
179 coro_func func = args->func;
180 void *arg = args->arg;
181
182 pthread_mutex_lock (&coro_mutex);
183 pthread_cond_destroy (&args->self->c);
184 coro_transfer (args->self, args->main);
185 func (arg);
186 pthread_mutex_unlock (&coro_mutex);
187
188 return 0;
189}
190
191asm("");
192
193void coro_transfer(coro_context *prev, coro_context *next)
194{
195 pthread_cond_init (&prev->c, 0);
196 pthread_cond_signal (&next->c);
197 pthread_cond_wait (&prev->c, &coro_mutex);
198 pthread_cond_destroy (&prev->c);
199}
200
201#endif
202
203/* initialize a machine state */
204void coro_create (coro_context *ctx,
205 coro_func coro, void *arg,
206 void *sptr, long ssize)
207{
208#if CORO_UCONTEXT
209
210 getcontext (&(ctx->uc));
211
212 ctx->uc.uc_link = 0;
213 ctx->uc.uc_stack.ss_sp = STACK_ADJUST_PTR (sptr,ssize);
214 ctx->uc.uc_stack.ss_size = (size_t)STACK_ADJUST_SIZE (sptr,ssize);
215 ctx->uc.uc_stack.ss_flags = 0;
216
217 makecontext (&(ctx->uc), (void (*)()) coro, 1, arg);
218
219#elif CORO_SJLJ || CORO_LOSER || CORO_LINUX || CORO_IRIX || CORO_ASM
220
221# if CORO_SJLJ 180# if CORO_SJLJ
222 stack_t ostk, nstk; 181 stack_t ostk, nstk;
223 struct sigaction osa, nsa; 182 struct sigaction osa, nsa;
224 sigset_t nsig, osig; 183 sigset_t nsig, osig;
225# endif 184# endif
226 coro_context nctx; 185
186 if (!coro)
187 return;
227 188
228 coro_init_func = coro; 189 coro_init_func = coro;
229 coro_init_arg = arg; 190 coro_init_arg = arg;
230 191
231 new_coro = ctx; 192 new_coro = ctx;
… …
257 { 218 {
258 perror ("sigaltstack"); 219 perror ("sigaltstack");
259 abort (); 220 abort ();
260 } 221 }
261 222
262 trampoline_count = 0; 223 trampoline_done = 0;
263 kill (getpid (), SIGUSR2); 224 kill (getpid (), SIGUSR2);
264 sigfillset (&nsig); sigdelset (&nsig, SIGUSR2); 225 sigfillset (&nsig); sigdelset (&nsig, SIGUSR2);
265 226
266 while (!trampoline_count) 227 while (!trampoline_done)
267 sigsuspend (&nsig); 228 sigsuspend (&nsig);
268 229
269 sigaltstack (0, &nstk); 230 sigaltstack (0, &nstk);
270 nstk.ss_flags = SS_DISABLE; 231 nstk.ss_flags = SS_DISABLE;
271 if (sigaltstack (&nstk, 0) < 0) 232 if (sigaltstack (&nstk, 0) < 0)
… …
277 238
278 if (~ostk.ss_flags & SS_DISABLE) 239 if (~ostk.ss_flags & SS_DISABLE)
279 sigaltstack (&ostk, 0); 240 sigaltstack (&ostk, 0);
280 241
281 sigaction (SIGUSR2, &osa, 0); 242 sigaction (SIGUSR2, &osa, 0);
282
283 sigprocmask (SIG_SETMASK, &osig, 0); 243 sigprocmask (SIG_SETMASK, &osig, 0);
284 244
285# elif CORO_LOSER 245# elif CORO_LOSER
286 246
287 setjmp (ctx->env); 247 coro_setjmp (ctx->env);
288#if __CYGWIN__ 248 #if __CYGWIN__ && __i386
249 ctx->env[8] = (long) coro_init;
289 ctx->env[7] = (long)((char *)sptr + ssize) - sizeof (long); 250 ctx->env[7] = (long) ((char *)sptr + ssize) - sizeof (long);
290 ctx->env[8] = (long)coro_init; 251 #elif __CYGWIN__ && __x86_64
252 ctx->env[7] = (long) coro_init;
253 ctx->env[6] = (long) ((char *)sptr + ssize) - sizeof (long);
254 #elif defined(__MINGW32__)
255 ctx->env[5] = (long) coro_init;
256 ctx->env[4] = (long) ((char *)sptr + ssize) - sizeof (long);
291#elif defined(_M_IX86) 257 #elif defined(_M_IX86)
292 ((_JUMP_BUFFER *)&ctx->env)->Eip = (long)coro_init; 258 ((_JUMP_BUFFER *)&ctx->env)->Eip = (long) coro_init;
293 ((_JUMP_BUFFER *)&ctx->env)->Esp = (long)STACK_ADJUST_PTR (sptr, ssize) - sizeof (long); 259 ((_JUMP_BUFFER *)&ctx->env)->Esp = (long) STACK_ADJUST_PTR (sptr, ssize) - sizeof (long);
294#elif defined(_M_AMD64) 260 #elif defined(_M_AMD64)
295 ((_JUMP_BUFFER *)&ctx->env)->Rip = (__int64)coro_init; 261 ((_JUMP_BUFFER *)&ctx->env)->Rip = (__int64) coro_init;
296 ((_JUMP_BUFFER *)&ctx->env)->Rsp = (__int64)STACK_ADJUST_PTR (sptr, ssize) - sizeof (long); 262 ((_JUMP_BUFFER *)&ctx->env)->Rsp = (__int64) STACK_ADJUST_PTR (sptr, ssize) - sizeof (__int64);
297#elif defined(_M_IA64) 263 #elif defined(_M_IA64)
298 ((_JUMP_BUFFER *)&ctx->env)->StIIP = (__int64)coro_init; 264 ((_JUMP_BUFFER *)&ctx->env)->StIIP = (__int64) coro_init;
299 ((_JUMP_BUFFER *)&ctx->env)->IntSp = (__int64)STACK_ADJUST_PTR (sptr, ssize) - sizeof (long); 265 ((_JUMP_BUFFER *)&ctx->env)->IntSp = (__int64) STACK_ADJUST_PTR (sptr, ssize) - sizeof (__int64);
300#else 266 #else
301# error "microsoft libc or architecture not supported" 267 #error "microsoft libc or architecture not supported"
302#endif 268 #endif
303 269
304# elif CORO_LINUX 270# elif CORO_LINUX
305 271
306 _setjmp (ctx->env); 272 coro_setjmp (ctx->env);
307#if __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 0 && defined (JB_PC) && defined (JB_SP) 273 #if __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 0 && defined (JB_PC) && defined (JB_SP)
308 ctx->env[0].__jmpbuf[JB_PC] = (long)coro_init; 274 ctx->env[0].__jmpbuf[JB_PC] = (long) coro_init;
309 ctx->env[0].__jmpbuf[JB_SP] = (long)STACK_ADJUST_PTR (sptr, ssize) - sizeof (long); 275 ctx->env[0].__jmpbuf[JB_SP] = (long) STACK_ADJUST_PTR (sptr, ssize) - sizeof (long);
310#elif __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 0 && defined (__mc68000__) 276 #elif __GLIBC__ >= 2 && __GLIBC_MINOR__ >= 0 && defined (__mc68000__)
311 ctx->env[0].__jmpbuf[0].__aregs[0] = (long int)coro_init; 277 ctx->env[0].__jmpbuf[0].__aregs[0] = (long int)coro_init;
312 ctx->env[0].__jmpbuf[0].__sp = (int *)((char *)sptr + ssize) - sizeof (long); 278 ctx->env[0].__jmpbuf[0].__sp = (int *) ((char *)sptr + ssize) - sizeof (long);
313#elif defined (__GNU_LIBRARY__) && defined (__i386__) 279 #elif defined (__GNU_LIBRARY__) && defined (__i386__)
314 ctx->env[0].__jmpbuf[0].__pc = (char *)coro_init; 280 ctx->env[0].__jmpbuf[0].__pc = (char *) coro_init;
315 ctx->env[0].__jmpbuf[0].__sp = (void *)((char *)sptr + ssize) - sizeof (long); 281 ctx->env[0].__jmpbuf[0].__sp = (void *) ((char *)sptr + ssize) - sizeof (long);
316#elif defined (__GNU_LIBRARY__) && defined (__amd64__) 282 #elif defined (__GNU_LIBRARY__) && defined (__amd64__)
317 ctx->env[0].__jmpbuf[JB_PC] = (long)coro_init; 283 ctx->env[0].__jmpbuf[JB_PC] = (long) coro_init;
318 ctx->env[0].__jmpbuf[0].__sp = (void *)((char *)sptr + ssize) - sizeof (long); 284 ctx->env[0].__jmpbuf[0].__sp = (void *) ((char *)sptr + ssize) - sizeof (long);
319#else 285 #else
320# error "linux libc or architecture not supported" 286 #error "linux libc or architecture not supported"
321#endif 287 #endif
322 288
323# elif CORO_IRIX 289# elif CORO_IRIX
324 290
325 setjmp (ctx->env); 291 coro_setjmp (ctx->env, 0);
326 ctx->env[JB_PC] = (__uint64_t)coro_init; 292 ctx->env[JB_PC] = (__uint64_t)coro_init;
327 ctx->env[JB_SP] = (__uint64_t)STACK_ADJUST_PTR (sptr, ssize) - sizeof (long); 293 ctx->env[JB_SP] = (__uint64_t)STACK_ADJUST_PTR (sptr, ssize) - sizeof (long);
328 294
329# elif CORO_ASM 295# elif CORO_ASM
330 296
331 ctx->sp = (volatile void **)(ssize + (char *)sptr); 297 ctx->sp = (void **)(ssize + (char *)sptr);
332 ctx->sp -= NUM_ALIGN; 298 *--ctx->sp = (void *)abort; /* needed for alignment only */
333 *--ctx->sp = (void *)coro_init; 299 *--ctx->sp = (void *)coro_init;
334 ctx->sp -= NUM_SAVED; 300 ctx->sp -= NUM_SAVED;
335 301
302 #if CORO_WIN_TIB
303 *--ctx->sp = sptr; /* StackLimit */
304 *--ctx->sp = (char *)sptr + ssize; /* StackBase */
305 *--ctx->sp = 0; /* ExceptionList */
336# endif 306 #endif
337 307
338 coro_transfer ((coro_context *)create_coro, (coro_context *)new_coro); 308# elif CORO_UCONTEXT
339 309
310 getcontext (&(ctx->uc));
311
312 ctx->uc.uc_link = 0;
313 ctx->uc.uc_stack.ss_sp = sptr;
314 ctx->uc.uc_stack.ss_size = (size_t)ssize;
315 ctx->uc.uc_stack.ss_flags = 0;
316
317 makecontext (&(ctx->uc), (void (*)())coro_init, 0);
318
319# endif
320
321 coro_transfer (create_coro, new_coro);
322}
323
324/*****************************************************************************/
325/* pthread backend */
326/*****************************************************************************/
340# elif CORO_PTHREAD 327#elif CORO_PTHREAD
341 328
342 pthread_t id; 329/* this mutex will be locked by the running coroutine */
343 pthread_attr_t attr; 330pthread_mutex_t coro_mutex = PTHREAD_MUTEX_INITIALIZER;
331
332struct coro_init_args
333{
334 coro_func func;
335 void *arg;
336 coro_context *self, *main;
337};
338
339static pthread_t null_tid;
340
341/* I'd so love to cast pthread_mutex_unlock to void (*)(void *)... */
342static void
343mutex_unlock_wrapper (void *arg)
344{
345 pthread_mutex_unlock ((pthread_mutex_t *)arg);
346}
347
348static void *
349coro_init (void *args_)
350{
351 struct coro_init_args *args = (struct coro_init_args *)args_;
352 coro_func func = args->func;
353 void *arg = args->arg;
354
355 pthread_mutex_lock (&coro_mutex);
356
357 /* we try to be good citizens and use deferred cancellation and cleanup handlers */
358 pthread_cleanup_push (mutex_unlock_wrapper, &coro_mutex);
359 coro_transfer (args->self, args->main);
360 func (arg);
361 pthread_cleanup_pop (1);
362
363 return 0;
364}
365
366void
367coro_transfer (coro_context *prev, coro_context *next)
368{
369 pthread_cond_signal (&next->cv);
370 pthread_cond_wait (&prev->cv, &coro_mutex);
371#if __FreeBSD__ /* freebsd is of course broken and needs manual testcancel calls... yay... */
372 pthread_testcancel ();
373#endif
374}
375
376void
377coro_create (coro_context *ctx, coro_func coro, void *arg, void *sptr, long ssize)
378{
344 coro_context nctx; 379 static coro_context nctx;
345 struct coro_init_args args;
346 static int once; 380 static int once;
347 381
348 if (!once) 382 if (!once)
349 { 383 {
384 once = 1;
385
350 pthread_mutex_lock (&coro_mutex); 386 pthread_mutex_lock (&coro_mutex);
351 once = 1; 387 pthread_cond_init (&nctx.cv, 0);
388 null_tid = pthread_self ();
352 } 389 }
353 390
391 pthread_cond_init (&ctx->cv, 0);
392
393 if (coro)
394 {
395 pthread_attr_t attr;
396 struct coro_init_args args;
397
354 args.func = coro; 398 args.func = coro;
355 args.arg = arg; 399 args.arg = arg;
356 args.self = ctx; 400 args.self = ctx;
357 args.main = &nctx; 401 args.main = &nctx;
358 402
359 pthread_attr_init (&attr); 403 pthread_attr_init (&attr);
360 pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED);
361 pthread_attr_setstack (&attr, sptr, (size_t)ssize); 404 pthread_attr_setstack (&attr, sptr, (size_t)ssize);
405 pthread_attr_setscope (&attr, PTHREAD_SCOPE_PROCESS);
362 pthread_create (&id, &attr, trampoline, &args); 406 pthread_create (&ctx->id, &attr, coro_init, &args);
363 407
364 pthread_cond_init (&args.self->c, 0);
365 coro_transfer (args.main, args.self); 408 coro_transfer (args.main, args.self);
409 }
410 else
411 ctx->id = null_tid;
412}
413
414void
415coro_destroy (coro_context *ctx)
416{
417 if (!pthread_equal (ctx->id, null_tid))
418 {
419 pthread_cancel (ctx->id);
420 pthread_mutex_unlock (&coro_mutex);
421 pthread_join (ctx->id, 0);
422 pthread_mutex_lock (&coro_mutex);
423 }
424
425 pthread_cond_destroy (&ctx->cv);
426}
366 427
367#else 428#else
368# error unsupported backend 429# error unsupported backend
369#endif 430#endif
370}
371 431

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines