ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/libeio/eio.c
(Generate patch)

Comparing libeio/eio.c (file contents):
Revision 1.133 by root, Thu Jun 25 13:42:18 2015 UTC vs.
Revision 1.150 by root, Fri Jun 15 02:57:36 2018 UTC

1/* 1/*
2 * libeio implementation 2 * libeio implementation
3 * 3 *
4 * Copyright (c) 2007,2008,2009,2010,2011,2012,2013 Marc Alexander Lehmann <libeio@schmorp.de> 4 * Copyright (c) 2007,2008,2009,2010,2011,2012,2013,2016,2017 Marc Alexander Lehmann <libeio@schmorp.de>
5 * All rights reserved. 5 * All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without modifica- 7 * Redistribution and use in source and binary forms, with or without modifica-
8 * tion, are permitted provided that the following conditions are met: 8 * tion, are permitted provided that the following conditions are met:
9 * 9 *
… …
42#endif 42#endif
43 43
44#include "eio.h" 44#include "eio.h"
45#include "ecb.h" 45#include "ecb.h"
46 46
47#ifdef EIO_STACKSIZE
48# define X_STACKSIZE EIO_STACKSIZE
49#endif
50#include "xthread.h"
51
52#include <errno.h> 47#include <errno.h>
53#include <stddef.h> 48#include <stddef.h>
54#include <stdlib.h> 49#include <stdlib.h>
55#include <string.h> 50#include <string.h>
56#include <errno.h> 51#include <errno.h>
… …
122 #define chmod(path,mode) _chmod (path, mode) 117 #define chmod(path,mode) _chmod (path, mode)
123 #define dup(fd) _dup (fd) 118 #define dup(fd) _dup (fd)
124 #define dup2(fd1,fd2) _dup2 (fd1, fd2) 119 #define dup2(fd1,fd2) _dup2 (fd1, fd2)
125 #define pipe(fds) _pipe (fds, 4096, O_BINARY) 120 #define pipe(fds) _pipe (fds, 4096, O_BINARY)
126 121
122 #define fcntl(fd,cmd,arg) EIO_ENOSYS ()
123 #define ioctl(fd,cmd,arg) EIO_ENOSYS ()
127 #define fchmod(fd,mode) EIO_ENOSYS () 124 #define fchmod(fd,mode) EIO_ENOSYS ()
128 #define chown(path,uid,gid) EIO_ENOSYS () 125 #define chown(path,uid,gid) EIO_ENOSYS ()
129 #define fchown(fd,uid,gid) EIO_ENOSYS () 126 #define fchown(fd,uid,gid) EIO_ENOSYS ()
130 #define truncate(path,offs) EIO_ENOSYS () /* far-miss: SetEndOfFile */ 127 #define truncate(path,offs) EIO_ENOSYS () /* far-miss: SetEndOfFile */
131 #define ftruncate(fd,offs) EIO_ENOSYS () /* near-miss: SetEndOfFile */ 128 #define ftruncate(fd,offs) EIO_ENOSYS () /* near-miss: SetEndOfFile */
… …
204 /* we could even stat and see if it exists */ 201 /* we could even stat and see if it exists */
205 static int 202 static int
206 symlink (const char *old, const char *neu) 203 symlink (const char *old, const char *neu)
207 { 204 {
208 #if WINVER >= 0x0600 205 #if WINVER >= 0x0600
206 int flags;
207
208 /* This tries out all combinations of SYMBOLIC_LINK_FLAG_DIRECTORY
209 * and SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE,
210 * with directory first.
211 */
212 for (flags = 3; flags >= 0; --flags)
209 if (CreateSymbolicLink (neu, old, 1)) 213 if (CreateSymbolicLink (neu, old, flags))
210 return 0; 214 return 0;
211
212 if (CreateSymbolicLink (neu, old, 0))
213 return 0;
214 #endif 215 #endif
215 216
216 return EIO_ERRNO (ENOENT, -1); 217 return EIO_ERRNO (ENOENT, -1);
217 } 218 }
218 219
… …
230 #define D_NAME(entp) entp.cFileName 231 #define D_NAME(entp) entp.cFileName
231 #define D_TYPE(entp) (entp.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY ? DT_DIR : DT_REG) 232 #define D_TYPE(entp) (entp.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY ? DT_DIR : DT_REG)
232 233
233#else 234#else
234 235
236 #include <sys/ioctl.h>
235 #include <sys/time.h> 237 #include <sys/time.h>
236 #include <sys/select.h> 238 #include <sys/select.h>
237 #include <unistd.h> 239 #include <unistd.h>
238 #include <signal.h> 240 #include <signal.h>
239 #include <dirent.h> 241 #include <dirent.h>
… …
281# include <utime.h> 283# include <utime.h>
282#endif 284#endif
283 285
284#if HAVE_SYS_SYSCALL_H 286#if HAVE_SYS_SYSCALL_H
285# include <sys/syscall.h> 287# include <sys/syscall.h>
286#endif
287
288#if HAVE_SYS_PRCTL_H
289# include <sys/prctl.h>
290#endif 288#endif
291 289
292#if HAVE_SENDFILE 290#if HAVE_SENDFILE
293# if __linux 291# if __linux
294# include <sys/sendfile.h> 292# include <sys/sendfile.h>
… …
302# else 300# else
303# error sendfile support requested but not available 301# error sendfile support requested but not available
304# endif 302# endif
305#endif 303#endif
306 304
305#if HAVE_RENAMEAT2
306# include <sys/syscall.h>
307# include <linux/fs.h>
308#endif
309
307#ifndef D_TYPE 310#ifndef D_TYPE
308# define D_TYPE(de) 0 311# define D_TYPE(de) 0
309#endif 312#endif
310#ifndef D_INO 313#ifndef D_INO
311# define D_INO(de) 0 314# define D_INO(de) 0
… …
319# define NAME_MAX 4096 322# define NAME_MAX 4096
320#endif 323#endif
321 324
322/* used for readlink etc. */ 325/* used for readlink etc. */
323#ifndef PATH_MAX 326#ifndef PATH_MAX
324# define PATH_MAX 4096 327# define PATH_MAX 0
325#endif 328#endif
329
330#ifndef O_CLOEXEC
331 #define O_CLOEXEC 0
332#endif
333
334#ifndef EIO_PATH_MIN
335# define EIO_PATH_MIN 8160
336#endif
337
338#define EIO_PATH_MAX (PATH_MAX <= EIO_PATH_MIN ? EIO_PATH_MIN : PATH_MAX)
326 339
327/* buffer size for various temporary buffers */ 340/* buffer size for various temporary buffers */
328#define EIO_BUFSIZE 65536 341#define EIO_BUFSIZE 65536
329 342
330#define dBUF \ 343#define dBUF \
… …
336#define FUBd \ 349#define FUBd \
337 free (eio_buf) 350 free (eio_buf)
338 351
339/*****************************************************************************/ 352/*****************************************************************************/
340 353
341struct tmpbuf
342{
343 void *ptr;
344 int len;
345};
346
347static void *
348tmpbuf_get (struct tmpbuf *buf, int len)
349{
350 if (buf->len < len)
351 {
352 free (buf->ptr);
353 buf->ptr = malloc (buf->len = len);
354 }
355
356 return buf->ptr;
357}
358
359struct tmpbuf; 354struct etp_tmpbuf;
360 355
361#if _POSIX_VERSION >= 200809L 356#if _POSIX_VERSION >= 200809L
362 #define HAVE_AT 1 357 #define HAVE_AT 1
363 #define WD2FD(wd) ((wd) ? (wd)->fd : AT_FDCWD) 358 #define WD2FD(wd) ((wd) ? (wd)->fd : AT_FDCWD)
364 #ifndef O_SEARCH 359 #ifndef O_SEARCH
365 #define O_SEARCH O_RDONLY 360 #define O_SEARCH O_RDONLY
366 #endif 361 #endif
367#else 362#else
368 #define HAVE_AT 0 363 #define HAVE_AT 0
369 static const char *wd_expand (struct tmpbuf *tmpbuf, eio_wd wd, const char *path); 364 static const char *wd_expand (struct etp_tmpbuf *tmpbuf, eio_wd wd, const char *path);
370#endif 365#endif
371 366
372struct eio_pwd 367struct eio_pwd
373{ 368{
374#if HAVE_AT 369#if HAVE_AT
… …
384#define ETP_PRI_MAX EIO_PRI_MAX 379#define ETP_PRI_MAX EIO_PRI_MAX
385 380
386#define ETP_TYPE_QUIT -1 381#define ETP_TYPE_QUIT -1
387#define ETP_TYPE_GROUP EIO_GROUP 382#define ETP_TYPE_GROUP EIO_GROUP
388 383
384static void eio_nop_callback (void) { }
385static void (*eio_want_poll_cb)(void) = eio_nop_callback;
386static void (*eio_done_poll_cb)(void) = eio_nop_callback;
387
388#define ETP_WANT_POLL(pool) eio_want_poll_cb ()
389#define ETP_DONE_POLL(pool) eio_done_poll_cb ()
390
389struct etp_worker; 391struct etp_worker;
390
391#define ETP_REQ eio_req 392#define ETP_REQ eio_req
392#define ETP_DESTROY(req) eio_destroy (req) 393#define ETP_DESTROY(req) eio_destroy (req)
393static int eio_finish (eio_req *req); 394static int eio_finish (eio_req *req);
394#define ETP_FINISH(req) eio_finish (req) 395#define ETP_FINISH(req) eio_finish (req)
395static void eio_execute (struct etp_worker *self, eio_req *req); 396static void eio_execute (struct etp_worker *self, eio_req *req);
396#define ETP_EXECUTE(wrk,req) eio_execute (wrk, req) 397#define ETP_EXECUTE(wrk,req) eio_execute (wrk, req)
397 398
398#include "etp.c" 399#include "etp.c"
399 400
401static struct etp_pool eio_pool;
402#define EIO_POOL (&eio_pool)
403
400/*****************************************************************************/ 404/*****************************************************************************/
401 405
402static void 406static void
403grp_try_feed (eio_req *grp) 407grp_try_feed (eio_req *grp)
404{ 408{
405 while (grp->size < grp->int2 && !EIO_CANCELLED (grp)) 409 while (grp->size < grp->int2 && !EIO_CANCELLED (grp))
406 { 410 {
407 grp->flags &= ~EIO_FLAG_GROUPADD; 411 grp->flags &= ~ETP_FLAG_GROUPADD;
408 412
409 EIO_FEED (grp); 413 EIO_FEED (grp);
410 414
411 /* stop if no progress has been made */ 415 /* stop if no progress has been made */
412 if (!(grp->flags & EIO_FLAG_GROUPADD)) 416 if (!(grp->flags & ETP_FLAG_GROUPADD))
413 { 417 {
414 grp->feed = 0; 418 grp->feed = 0;
415 break; 419 break;
416 } 420 }
417 } 421 }
… …
424 428
425 /* call feeder, if applicable */ 429 /* call feeder, if applicable */
426 grp_try_feed (grp); 430 grp_try_feed (grp);
427 431
428 /* finish, if done */ 432 /* finish, if done */
429 if (!grp->size && grp->int1) 433 if (!grp->size && grp->flags & ETP_FLAG_DELAYED)
430 return eio_finish (grp); 434 return eio_finish (grp);
431 else 435 else
432 return 0; 436 return 0;
433} 437}
434 438
… …
470} 474}
471 475
472void 476void
473eio_grp_cancel (eio_req *grp) 477eio_grp_cancel (eio_req *grp)
474{ 478{
475 etp_grp_cancel (grp); 479 etp_grp_cancel (EIO_POOL, grp);
476} 480}
477 481
478void 482void
479eio_cancel (eio_req *req) 483eio_cancel (eio_req *req)
480{ 484{
481 etp_cancel (req); 485 etp_cancel (EIO_POOL, req);
482} 486}
483 487
484void 488void
485eio_submit (eio_req *req) 489eio_submit (eio_req *req)
486{ 490{
487 etp_submit (req); 491 etp_submit (EIO_POOL, req);
488} 492}
489 493
490unsigned int 494unsigned int
491eio_nreqs (void) 495eio_nreqs (void)
492{ 496{
493 return etp_nreqs (); 497 return etp_nreqs (EIO_POOL);
494} 498}
495 499
496unsigned int 500unsigned int
497eio_nready (void) 501eio_nready (void)
498{ 502{
499 return etp_nready (); 503 return etp_nready (EIO_POOL);
500} 504}
501 505
502unsigned int 506unsigned int
503eio_npending (void) 507eio_npending (void)
504{ 508{
505 return etp_npending (); 509 return etp_npending (EIO_POOL);
506} 510}
507 511
508unsigned int ecb_cold 512unsigned int ecb_cold
509eio_nthreads (void) 513eio_nthreads (void)
510{ 514{
511 return etp_nthreads (); 515 return etp_nthreads (EIO_POOL);
512} 516}
513 517
514void ecb_cold 518void ecb_cold
515eio_set_max_poll_time (double nseconds) 519eio_set_max_poll_time (double nseconds)
516{ 520{
517 etp_set_max_poll_time (nseconds); 521 etp_set_max_poll_time (EIO_POOL, nseconds);
518} 522}
519 523
520void ecb_cold 524void ecb_cold
521eio_set_max_poll_reqs (unsigned int maxreqs) 525eio_set_max_poll_reqs (unsigned int maxreqs)
522{ 526{
523 etp_set_max_poll_reqs (maxreqs); 527 etp_set_max_poll_reqs (EIO_POOL, maxreqs);
524} 528}
525 529
526void ecb_cold 530void ecb_cold
527eio_set_max_idle (unsigned int nthreads) 531eio_set_max_idle (unsigned int nthreads)
528{ 532{
529 etp_set_max_idle (nthreads); 533 etp_set_max_idle (EIO_POOL, nthreads);
530} 534}
531 535
532void ecb_cold 536void ecb_cold
533eio_set_idle_timeout (unsigned int seconds) 537eio_set_idle_timeout (unsigned int seconds)
534{ 538{
535 etp_set_idle_timeout (seconds); 539 etp_set_idle_timeout (EIO_POOL, seconds);
536} 540}
537 541
538void ecb_cold 542void ecb_cold
539eio_set_min_parallel (unsigned int nthreads) 543eio_set_min_parallel (unsigned int nthreads)
540{ 544{
541 etp_set_min_parallel (nthreads); 545 etp_set_min_parallel (EIO_POOL, nthreads);
542} 546}
543 547
544void ecb_cold 548void ecb_cold
545eio_set_max_parallel (unsigned int nthreads) 549eio_set_max_parallel (unsigned int nthreads)
546{ 550{
547 etp_set_max_parallel (nthreads); 551 etp_set_max_parallel (EIO_POOL, nthreads);
548} 552}
549 553
550int eio_poll (void) 554int eio_poll (void)
551{ 555{
552 return etp_poll (); 556 return etp_poll (EIO_POOL);
553} 557}
554 558
555/*****************************************************************************/ 559/*****************************************************************************/
556/* work around various missing functions */ 560/* work around various missing functions */
561
562#if HAVE_POSIX_CLOSE && !__linux
563# define eio__close(fd) posix_close (fd, 0)
564#else
565# define eio__close(fd) close (fd)
566#endif
567
568/* close() without disturbing errno */
569static void
570silent_close (int fd)
571{
572 int saved_errno = errno;
573 eio__close (fd);
574 errno = saved_errno;
575}
557 576
558#ifndef HAVE_UTIMES 577#ifndef HAVE_UTIMES
559 578
560# undef utimes 579# undef utimes
561# define utimes(path,times) eio__utimes (path, times) 580# define utimes(path,times) eio__utimes (path, times)
… …
940 intptr_t end = addr + len; 959 intptr_t end = addr + len;
941 intptr_t page = eio_pagesize (); 960 intptr_t page = eio_pagesize ();
942 961
943 if (addr < end) 962 if (addr < end)
944 if (flags & EIO_MT_MODIFY) /* modify */ 963 if (flags & EIO_MT_MODIFY) /* modify */
945 do { *((volatile sig_atomic_t *)addr) |= 0; } while ((addr += page) < len && !EIO_CANCELLED (req)); 964 do { *((volatile sig_atomic_t *)addr) |= 0; } while ((addr += page) < end && !EIO_CANCELLED (req));
946 else 965 else
947 do { *((volatile sig_atomic_t *)addr) ; } while ((addr += page) < len && !EIO_CANCELLED (req)); 966 do { *((volatile sig_atomic_t *)addr) ; } while ((addr += page) < end && !EIO_CANCELLED (req));
948 } 967 }
949 968
950 return 0; 969 return 0;
951} 970}
952 971
… …
967 req->result = req->offs == (off_t)-1 ? -1 : 0; 986 req->result = req->offs == (off_t)-1 ? -1 : 0;
968} 987}
969 988
970/* result will always end up in tmpbuf, there is always space for adding a 0-byte */ 989/* result will always end up in tmpbuf, there is always space for adding a 0-byte */
971static int 990static int
972eio__realpath (struct tmpbuf *tmpbuf, eio_wd wd, const char *path) 991eio__realpath (struct etp_tmpbuf *tmpbuf, eio_wd wd, const char *path)
973{ 992{
974 char *res; 993 char *res;
975 const char *rel = path; 994 const char *rel = path;
976 char *tmp1, *tmp2; 995 char *tmp1, *tmp2;
977#if SYMLOOP_MAX > 32 996#if SYMLOOP_MAX > 32
… …
986 1005
987 errno = ENOENT; 1006 errno = ENOENT;
988 if (!*rel) 1007 if (!*rel)
989 return -1; 1008 return -1;
990 1009
991 res = tmpbuf_get (tmpbuf, PATH_MAX * 3); 1010 res = etp_tmpbuf_get (tmpbuf, EIO_PATH_MAX * 3);
992#ifdef _WIN32 1011#ifdef _WIN32
993 if (_access (rel, 4) != 0) 1012 if (_access (rel, 4) != 0)
994 return -1; 1013 return -1;
995 1014
996 symlinks = GetFullPathName (rel, PATH_MAX * 3, res, 0); 1015 symlinks = GetFullPathName (rel, EIO_PATH_MAX * 3, res, 0);
997 1016
998 errno = ENAMETOOLONG; 1017 errno = ENAMETOOLONG;
999 if (symlinks >= PATH_MAX * 3) 1018 if (symlinks >= EIO_PATH_MAX * 3)
1000 return -1; 1019 return -1;
1001 1020
1002 errno = EIO; 1021 errno = EIO;
1003 if (symlinks <= 0) 1022 if (symlinks <= 0)
1004 return -1; 1023 return -1;
1005 1024
1006 return symlinks; 1025 return symlinks;
1007 1026
1008#else 1027#else
1009 tmp1 = res + PATH_MAX; 1028 tmp1 = res + EIO_PATH_MAX;
1010 tmp2 = tmp1 + PATH_MAX; 1029 tmp2 = tmp1 + EIO_PATH_MAX;
1011 1030
1012#if 0 /* disabled, the musl way to do things is just too racy */ 1031#if 0 /* disabled, the musl way to do things is just too racy */
1013#if __linux && defined(O_NONBLOCK) && defined(O_NOATIME) 1032#if __linux && defined(O_NONBLOCK) && defined(O_NOATIME)
1014 /* on linux we may be able to ask the kernel */ 1033 /* on linux we may be able to ask the kernel */
1015 { 1034 {
1016 int fd = open (rel, O_RDONLY | O_NONBLOCK | O_NOCTTY | O_NOATIME); 1035 int fd = open (rel, O_RDONLY | O_NONBLOCK | O_NOCTTY | O_NOATIME);
1017 1036
1018 if (fd >= 0) 1037 if (fd >= 0)
1019 { 1038 {
1020 sprintf (tmp1, "/proc/self/fd/%d", fd); 1039 sprintf (tmp1, "/proc/self/fd/%d", fd);
1021 req->result = readlink (tmp1, res, PATH_MAX); 1040 req->result = readlink (tmp1, res, EIO_PATH_MAX);
1022 /* here we should probably stat the open file and the disk file, to make sure they still match */ 1041 /* here we should probably stat the open file and the disk file, to make sure they still match */
1023 close (fd); 1042 eio__close (fd);
1024 1043
1025 if (req->result > 0) 1044 if (req->result > 0)
1026 goto done; 1045 goto done;
1027 } 1046 }
1028 else if (errno == ELOOP || errno == ENAMETOOLONG || errno == ENOENT || errno == ENOTDIR || errno == EIO) 1047 else if (errno == ELOOP || errno == ENAMETOOLONG || errno == ENOENT || errno == ENOTDIR || errno == EIO)
… …
1039 if (wd == EIO_INVALID_WD) 1058 if (wd == EIO_INVALID_WD)
1040 return -1; 1059 return -1;
1041 1060
1042 if (wd == EIO_CWD) 1061 if (wd == EIO_CWD)
1043 { 1062 {
1044 if (!getcwd (res, PATH_MAX)) 1063 if (!getcwd (res, EIO_PATH_MAX))
1045 return -1; 1064 return -1;
1046 1065
1047 len = strlen (res); 1066 len = strlen (res);
1048 } 1067 }
1049 else 1068 else
… …
1096 1115
1097 /* zero-terminate, for readlink */ 1116 /* zero-terminate, for readlink */
1098 res [len + 1] = 0; 1117 res [len + 1] = 0;
1099 1118
1100 /* now check if it's a symlink */ 1119 /* now check if it's a symlink */
1101 linklen = readlink (tmpbuf->ptr, tmp1, PATH_MAX); 1120 linklen = readlink (tmpbuf->ptr, tmp1, EIO_PATH_MAX);
1102 1121
1103 if (linklen < 0) 1122 if (linklen < 0)
1104 { 1123 {
1105 if (errno != EINVAL) 1124 if (errno != EINVAL)
1106 return -1; 1125 return -1;
… …
1112 { 1131 {
1113 /* yay, it was a symlink - build new path in tmp2 */ 1132 /* yay, it was a symlink - build new path in tmp2 */
1114 int rellen = strlen (rel); 1133 int rellen = strlen (rel);
1115 1134
1116 errno = ENAMETOOLONG; 1135 errno = ENAMETOOLONG;
1117 if (linklen + 1 + rellen >= PATH_MAX) 1136 if (linklen + 1 + rellen >= EIO_PATH_MAX) /* also catch linklen >= EIO_PATH_MAX */
1118 return -1; 1137 return -1;
1119 1138
1120 errno = ELOOP; 1139 errno = ELOOP;
1121 if (!--symlinks) 1140 if (!--symlinks)
1122 return -1; 1141 return -1;
… …
1386 return; 1405 return;
1387 1406
1388 dirp = fdopendir (fd); 1407 dirp = fdopendir (fd);
1389 1408
1390 if (!dirp) 1409 if (!dirp)
1391 close (fd); 1410 silent_close (fd);
1392 } 1411 }
1393 else 1412 else
1394 dirp = opendir (req->ptr1); 1413 dirp = opendir (req->ptr1);
1395 #else 1414 #else
1396 dirp = opendir (wd_expand (&self->tmpbuf, req->wd, req->ptr1)); 1415 dirp = opendir (wd_expand (&self->tmpbuf, req->wd, req->ptr1));
… …
1605#if !HAVE_AT 1624#if !HAVE_AT
1606 1625
1607/* a bit like realpath, but usually faster because it doesn'T have to return */ 1626/* a bit like realpath, but usually faster because it doesn'T have to return */
1608/* an absolute or canonical path */ 1627/* an absolute or canonical path */
1609static const char * 1628static const char *
1610wd_expand (struct tmpbuf *tmpbuf, eio_wd wd, const char *path) 1629wd_expand (struct etp_tmpbuf *tmpbuf, eio_wd wd, const char *path)
1611{ 1630{
1612 if (!wd || *path == '/') 1631 if (!wd || *path == '/')
1613 return path; 1632 return path;
1614 1633
1615 if (path [0] == '.' && !path [1]) 1634 if (path [0] == '.' && !path [1])
… …
1617 1636
1618 { 1637 {
1619 int l1 = wd->len; 1638 int l1 = wd->len;
1620 int l2 = strlen (path); 1639 int l2 = strlen (path);
1621 1640
1622 char *res = tmpbuf_get (tmpbuf, l1 + l2 + 2); 1641 char *res = etp_tmpbuf_get (tmpbuf, l1 + l2 + 2);
1623 1642
1624 memcpy (res, wd->str, l1); 1643 memcpy (res, wd->str, l1);
1625 res [l1] = '/'; 1644 res [l1] = '/';
1626 memcpy (res + l1 + 1, path, l2 + 1); 1645 memcpy (res + l1 + 1, path, l2 + 1);
1627 1646
… …
1630} 1649}
1631 1650
1632#endif 1651#endif
1633 1652
1634static eio_wd 1653static eio_wd
1635eio__wd_open_sync (struct tmpbuf *tmpbuf, eio_wd wd, const char *path) 1654eio__wd_open_sync (struct etp_tmpbuf *tmpbuf, eio_wd wd, const char *path)
1636{ 1655{
1637 int fd; 1656 int fd;
1638 eio_wd res; 1657 eio_wd res;
1639 int len = eio__realpath (tmpbuf, wd, path); 1658 int len = eio__realpath (tmpbuf, wd, path);
1640 1659
… …
1662} 1681}
1663 1682
1664eio_wd 1683eio_wd
1665eio_wd_open_sync (eio_wd wd, const char *path) 1684eio_wd_open_sync (eio_wd wd, const char *path)
1666{ 1685{
1667 struct tmpbuf tmpbuf = { 0 }; 1686 struct etp_tmpbuf tmpbuf = { };
1668 wd = eio__wd_open_sync (&tmpbuf, wd, path); 1687 wd = eio__wd_open_sync (&tmpbuf, wd, path);
1669 free (tmpbuf.ptr); 1688 free (tmpbuf.ptr);
1670 1689
1671 return wd; 1690 return wd;
1672} 1691}
… …
1675eio_wd_close_sync (eio_wd wd) 1694eio_wd_close_sync (eio_wd wd)
1676{ 1695{
1677 if (wd != EIO_INVALID_WD && wd != EIO_CWD) 1696 if (wd != EIO_INVALID_WD && wd != EIO_CWD)
1678 { 1697 {
1679 #if HAVE_AT 1698 #if HAVE_AT
1680 close (wd->fd); 1699 eio__close (wd->fd);
1681 #endif 1700 #endif
1682 free (wd); 1701 free (wd);
1683 } 1702 }
1684} 1703}
1685 1704
1686#if HAVE_AT 1705#if HAVE_AT
1687 1706
1707static int
1708eio__renameat2 (int olddirfd, const char *oldpath, int newdirfd, const char *newpath, unsigned int flags)
1709{
1710#if HAVE_RENAMEAT2
1711 return syscall (SYS_renameat2, olddirfd, oldpath, newdirfd, newpath, flags);
1712#else
1713 if (flags)
1714 return EIO_ENOSYS ();
1715
1716 return renameat (olddirfd, oldpath, newdirfd, newpath);
1717#endif
1718}
1719
1688/* they forgot these */ 1720/* they forgot these */
1689 1721
1690static int 1722static int
1691eio__truncateat (int dirfd, const char *path, off_t length) 1723eio__truncateat (int dirfd, const char *path, off_t length)
1692{ 1724{
… …
1695 1727
1696 if (fd < 0) 1728 if (fd < 0)
1697 return fd; 1729 return fd;
1698 1730
1699 res = ftruncate (fd, length); 1731 res = ftruncate (fd, length);
1700 close (fd); 1732 silent_close (fd);
1701 return res; 1733 return res;
1702} 1734}
1703 1735
1704static int 1736static int
1705eio__statvfsat (int dirfd, const char *path, struct statvfs *buf) 1737eio__statvfsat (int dirfd, const char *path, struct statvfs *buf)
… …
1709 1741
1710 if (fd < 0) 1742 if (fd < 0)
1711 return fd; 1743 return fd;
1712 1744
1713 res = fstatvfs (fd, buf); 1745 res = fstatvfs (fd, buf);
1714 close (fd); 1746 silent_close (fd);
1715 return res; 1747 return res;
1716
1717} 1748}
1718 1749
1719#endif 1750#endif
1720 1751
1721/*****************************************************************************/ 1752/*****************************************************************************/
1722 1753
1723#define ALLOC(len) \ 1754#define ALLOC(len) \
1724 if (!req->ptr2) \ 1755 if (!req->ptr2) \
1725 { \ 1756 { \
1726 X_LOCK (wrklock); \ 1757 X_LOCK (EIO_POOL->wrklock); \
1727 req->flags |= EIO_FLAG_PTR2_FREE; \ 1758 req->flags |= EIO_FLAG_PTR2_FREE; \
1728 X_UNLOCK (wrklock); \ 1759 X_UNLOCK (EIO_POOL->wrklock); \
1729 req->ptr2 = malloc (len); \ 1760 req->ptr2 = malloc (len); \
1730 if (!req->ptr2) \ 1761 if (!req->ptr2) \
1731 { \ 1762 { \
1732 errno = ENOMEM; \ 1763 errno = ENOMEM; \
1733 req->result = -1; \ 1764 req->result = -1; \
1734 break; \ 1765 goto alloc_fail; \
1735 } \ 1766 } \
1736 } 1767 }
1737 1768
1738static void ecb_noinline ecb_cold 1769/*****************************************************************************/
1739etp_proc_init (void)
1740{
1741#if HAVE_PRCTL_SET_NAME
1742 /* provide a more sensible "thread name" */
1743 char name[16 + 1];
1744 const int namelen = sizeof (name) - 1;
1745 int len;
1746 1770
1747 prctl (PR_GET_NAME, (unsigned long)name, 0, 0, 0); 1771static void
1748 name [namelen] = 0; 1772eio__slurp (int fd, eio_req *req)
1749 len = strlen (name);
1750 strcpy (name + (len <= namelen - 4 ? len : namelen - 4), "/eio");
1751 prctl (PR_SET_NAME, (unsigned long)name, 0, 0, 0);
1752#endif
1753}
1754
1755/* TODO: move somehow to etp.c */
1756X_THREAD_PROC (etp_proc)
1757{ 1773{
1758 ETP_REQ *req; 1774 req->result = fd;
1759 struct timespec ts;
1760 etp_worker *self = (etp_worker *)thr_arg;
1761 1775
1762 etp_proc_init (); 1776 if (fd < 0)
1777 return;
1763 1778
1764 /* try to distribute timeouts somewhat evenly */ 1779 if (req->offs < 0 || !req->size) /* do we need the size? */
1765 ts.tv_nsec = ((unsigned long)self & 1023UL) * (1000000000UL / 1024UL);
1766
1767 for (;;)
1768 { 1780 {
1769 ts.tv_sec = 0; 1781 off_t size = lseek (fd, 0, SEEK_END);
1770 1782
1771 X_LOCK (reqlock); 1783 if (req->offs < 0)
1784 req->offs += size;
1772 1785
1773 for (;;) 1786 if (!req->size)
1774 { 1787 req->size = size - req->offs;
1775 req = reqq_shift (&req_queue);
1776
1777 if (req)
1778 break;
1779
1780 if (ts.tv_sec == 1) /* no request, but timeout detected, let's quit */
1781 {
1782 X_UNLOCK (reqlock);
1783 X_LOCK (wrklock);
1784 --started;
1785 X_UNLOCK (wrklock);
1786 goto quit;
1787 }
1788
1789 ++idle;
1790
1791 if (idle <= max_idle)
1792 /* we are allowed to idle, so do so without any timeout */
1793 X_COND_WAIT (reqwait, reqlock);
1794 else
1795 {
1796 /* initialise timeout once */
1797 if (!ts.tv_sec)
1798 ts.tv_sec = time (0) + idle_timeout;
1799
1800 if (X_COND_TIMEDWAIT (reqwait, reqlock, ts) == ETIMEDOUT)
1801 ts.tv_sec = 1; /* assuming this is not a value computed above.,.. */
1802 }
1803
1804 --idle;
1805 }
1806
1807 --nready;
1808
1809 X_UNLOCK (reqlock);
1810
1811 if (req->type == ETP_TYPE_QUIT)
1812 goto quit;
1813
1814 ETP_EXECUTE (self, req);
1815
1816 X_LOCK (reslock);
1817
1818 ++npending;
1819
1820 if (!reqq_push (&res_queue, req) && want_poll_cb)
1821 want_poll_cb ();
1822
1823 etp_worker_clear (self);
1824
1825 X_UNLOCK (reslock);
1826 } 1788 }
1827 1789
1828quit: 1790 ALLOC (req->size);
1829 free (req); 1791 req->result = pread (fd, req->ptr2, req->size, req->offs);
1830 1792
1831 X_LOCK (wrklock); 1793 silent_close (fd);
1832 etp_worker_free (self);
1833 X_UNLOCK (wrklock);
1834 1794
1835 return 0; 1795alloc_fail:
1796 ;
1836} 1797}
1837
1838/*****************************************************************************/
1839 1798
1840int ecb_cold 1799int ecb_cold
1841eio_init (void (*want_poll)(void), void (*done_poll)(void)) 1800eio_init (void (*want_poll)(void), void (*done_poll)(void))
1842{ 1801{
1843 return etp_init (want_poll, done_poll); 1802 eio_want_poll_cb = want_poll;
1803 eio_done_poll_cb = done_poll;
1804
1805 return etp_init (EIO_POOL, 0, 0, 0);
1844} 1806}
1845 1807
1846ecb_inline void 1808ecb_inline void
1847eio_api_destroy (eio_req *req) 1809eio_api_destroy (eio_req *req)
1848{ 1810{
… …
1922 : read (req->int1, req->ptr2, req->size); break; 1884 : read (req->int1, req->ptr2, req->size); break;
1923 case EIO_WRITE: req->result = req->offs >= 0 1885 case EIO_WRITE: req->result = req->offs >= 0
1924 ? pwrite (req->int1, req->ptr2, req->size, req->offs) 1886 ? pwrite (req->int1, req->ptr2, req->size, req->offs)
1925 : write (req->int1, req->ptr2, req->size); break; 1887 : write (req->int1, req->ptr2, req->size); break;
1926 1888
1889 case EIO_FCNTL: req->result = fcntl (req->int1, (int) req->int2, req->ptr2); break;
1890 case EIO_IOCTL: req->result = ioctl (req->int1, (unsigned long)req->int2, req->ptr2); break;
1891
1927 case EIO_READAHEAD: req->result = readahead (req->int1, req->offs, req->size); break; 1892 case EIO_READAHEAD: req->result = readahead (req->int1, req->offs, req->size); break;
1928 case EIO_SENDFILE: req->result = eio__sendfile (req->int1, req->int2, req->offs, req->size); break; 1893 case EIO_SENDFILE: req->result = eio__sendfile (req->int1, req->int2, req->offs, req->size); break;
1929 1894
1930#if HAVE_AT 1895#if HAVE_AT
1931 1896
… …
1935 req->result = fstatat (dirfd, req->ptr1, (EIO_STRUCT_STAT *)req->ptr2, AT_SYMLINK_NOFOLLOW); break; 1900 req->result = fstatat (dirfd, req->ptr1, (EIO_STRUCT_STAT *)req->ptr2, AT_SYMLINK_NOFOLLOW); break;
1936 case EIO_CHOWN: req->result = fchownat (dirfd, req->ptr1, req->int2, req->int3, 0); break; 1901 case EIO_CHOWN: req->result = fchownat (dirfd, req->ptr1, req->int2, req->int3, 0); break;
1937 case EIO_CHMOD: req->result = fchmodat (dirfd, req->ptr1, (mode_t)req->int2, 0); break; 1902 case EIO_CHMOD: req->result = fchmodat (dirfd, req->ptr1, (mode_t)req->int2, 0); break;
1938 case EIO_TRUNCATE: req->result = eio__truncateat (dirfd, req->ptr1, req->offs); break; 1903 case EIO_TRUNCATE: req->result = eio__truncateat (dirfd, req->ptr1, req->offs); break;
1939 case EIO_OPEN: req->result = openat (dirfd, req->ptr1, req->int1, (mode_t)req->int2); break; 1904 case EIO_OPEN: req->result = openat (dirfd, req->ptr1, req->int1, (mode_t)req->int2); break;
1905 case EIO_SLURP: eio__slurp ( openat (dirfd, req->ptr1, O_RDONLY | O_CLOEXEC), req); break;
1940 1906
1941 case EIO_UNLINK: req->result = unlinkat (dirfd, req->ptr1, 0); break; 1907 case EIO_UNLINK: req->result = unlinkat (dirfd, req->ptr1, 0); break;
1942 case EIO_RMDIR: /* complications arise because "." cannot be removed, so we might have to expand */ 1908 case EIO_RMDIR: /* complications arise because "." cannot be removed, so we might have to expand */
1943 req->result = req->wd && SINGLEDOT (req->ptr1) 1909 req->result = req->wd && SINGLEDOT (req->ptr1)
1944 ? rmdir (req->wd->str) 1910 ? rmdir (req->wd->str)
1945 : unlinkat (dirfd, req->ptr1, AT_REMOVEDIR); break; 1911 : unlinkat (dirfd, req->ptr1, AT_REMOVEDIR); break;
1946 case EIO_MKDIR: req->result = mkdirat (dirfd, req->ptr1, (mode_t)req->int2); break; 1912 case EIO_MKDIR: req->result = mkdirat (dirfd, req->ptr1, (mode_t)req->int2); break;
1913 case EIO_RENAME: req->result = eio__renameat2 (
1914 dirfd,
1947 case EIO_RENAME: /* complications arise because "." cannot be renamed, so we might have to expand */ 1915 /* complications arise because "." cannot be renamed, so we might have to expand */
1948 req->result = req->wd && SINGLEDOT (req->ptr1) 1916 req->wd && SINGLEDOT (req->ptr1) ? req->wd->str : req->ptr1,
1949 ? rename (req->wd->str, req->ptr2) 1917 WD2FD ((eio_wd)req->int3),
1950 : renameat (dirfd, req->ptr1, WD2FD ((eio_wd)req->int3), req->ptr2); break; 1918 req->ptr2,
1919 req->int2
1920 );
1921 break;
1951 case EIO_LINK: req->result = linkat (dirfd, req->ptr1, WD2FD ((eio_wd)req->int3), req->ptr2, 0); break; 1922 case EIO_LINK: req->result = linkat (dirfd, req->ptr1, WD2FD ((eio_wd)req->int3), req->ptr2, 0); break;
1952 case EIO_SYMLINK: req->result = symlinkat (req->ptr1, dirfd, req->ptr2); break; 1923 case EIO_SYMLINK: req->result = symlinkat (req->ptr1, dirfd, req->ptr2); break;
1953 case EIO_MKNOD: req->result = mknodat (dirfd, req->ptr1, (mode_t)req->int2, (dev_t)req->offs); break; 1924 case EIO_MKNOD: req->result = mknodat (dirfd, req->ptr1, (mode_t)req->int2, (dev_t)req->offs); break;
1954 case EIO_READLINK: ALLOC (PATH_MAX);
1955 req->result = readlinkat (dirfd, req->ptr1, req->ptr2, PATH_MAX); break;
1956 case EIO_STATVFS: ALLOC (sizeof (EIO_STRUCT_STATVFS)); 1925 case EIO_STATVFS: ALLOC (sizeof (EIO_STRUCT_STATVFS));
1957 req->result = eio__statvfsat (dirfd, req->ptr1, (EIO_STRUCT_STATVFS *)req->ptr2); break; 1926 req->result = eio__statvfsat (dirfd, req->ptr1, (EIO_STRUCT_STATVFS *)req->ptr2); break;
1927 case EIO_READLINK: ALLOC (EIO_PATH_MAX);
1928 req->result = readlinkat (dirfd, req->ptr1, req->ptr2, EIO_PATH_MAX);
1929 if (req->result == EIO_PATH_MAX)
1930 {
1931 req->result = -1;
1932 errno = ENAMETOOLONG;
1933 }
1934 break;
1958 case EIO_UTIME: 1935 case EIO_UTIME:
1959 case EIO_FUTIME: 1936 case EIO_FUTIME:
1960 { 1937 {
1961 struct timespec ts[2]; 1938 struct timespec ts[2];
1962 struct timespec *times; 1939 struct timespec *times;
… …
1987 req->result = lstat (path , (EIO_STRUCT_STAT *)req->ptr2); break; 1964 req->result = lstat (path , (EIO_STRUCT_STAT *)req->ptr2); break;
1988 case EIO_CHOWN: req->result = chown (path , req->int2, req->int3); break; 1965 case EIO_CHOWN: req->result = chown (path , req->int2, req->int3); break;
1989 case EIO_CHMOD: req->result = chmod (path , (mode_t)req->int2); break; 1966 case EIO_CHMOD: req->result = chmod (path , (mode_t)req->int2); break;
1990 case EIO_TRUNCATE: req->result = truncate (path , req->offs); break; 1967 case EIO_TRUNCATE: req->result = truncate (path , req->offs); break;
1991 case EIO_OPEN: req->result = open (path , req->int1, (mode_t)req->int2); break; 1968 case EIO_OPEN: req->result = open (path , req->int1, (mode_t)req->int2); break;
1969 case EIO_SLURP: eio__slurp ( open (path , O_RDONLY | O_CLOEXEC), req); break;
1992 1970
1993 case EIO_UNLINK: req->result = unlink (path ); break; 1971 case EIO_UNLINK: req->result = unlink (path ); break;
1994 case EIO_RMDIR: req->result = rmdir (path ); break; 1972 case EIO_RMDIR: req->result = rmdir (path ); break;
1995 case EIO_MKDIR: req->result = mkdir (path , (mode_t)req->int2); break; 1973 case EIO_MKDIR: req->result = mkdir (path , (mode_t)req->int2); break;
1996 case EIO_RENAME: req->result = rename (path , req->ptr2); break; 1974 case EIO_RENAME: req->result = req->int2 ? EIO_ENOSYS () : rename (path, req->ptr2); break;
1997 case EIO_LINK: req->result = link (path , req->ptr2); break; 1975 case EIO_LINK: req->result = link (path , req->ptr2); break;
1998 case EIO_SYMLINK: req->result = symlink (path , req->ptr2); break; 1976 case EIO_SYMLINK: req->result = symlink (path , req->ptr2); break;
1999 case EIO_MKNOD: req->result = mknod (path , (mode_t)req->int2, (dev_t)req->offs); break; 1977 case EIO_MKNOD: req->result = mknod (path , (mode_t)req->int2, (dev_t)req->offs); break;
2000 case EIO_READLINK: ALLOC (PATH_MAX);
2001 req->result = readlink (path, req->ptr2, PATH_MAX); break;
2002 case EIO_STATVFS: ALLOC (sizeof (EIO_STRUCT_STATVFS)); 1978 case EIO_STATVFS: ALLOC (sizeof (EIO_STRUCT_STATVFS));
2003 req->result = statvfs (path , (EIO_STRUCT_STATVFS *)req->ptr2); break; 1979 req->result = statvfs (path , (EIO_STRUCT_STATVFS *)req->ptr2); break;
1980 case EIO_READLINK: ALLOC (EIO_PATH_MAX);
1981 req->result = readlink (path, req->ptr2, EIO_PATH_MAX);
1982 if (req->result == EIO_PATH_MAX)
1983 {
1984 req->result = -1;
1985 errno = ENAMETOOLONG;
1986 }
1987 break;
2004 1988
2005 case EIO_UTIME: 1989 case EIO_UTIME:
2006 case EIO_FUTIME: 1990 case EIO_FUTIME:
2007 { 1991 {
2008 struct timeval tv[2]; 1992 struct timeval tv[2];
… …
2043 2027
2044 case EIO_FCHOWN: req->result = fchown (req->int1, req->int2, req->int3); break; 2028 case EIO_FCHOWN: req->result = fchown (req->int1, req->int2, req->int3); break;
2045 case EIO_FCHMOD: req->result = fchmod (req->int1, (mode_t)req->int2); break; 2029 case EIO_FCHMOD: req->result = fchmod (req->int1, (mode_t)req->int2); break;
2046 case EIO_FTRUNCATE: req->result = ftruncate (req->int1, req->offs); break; 2030 case EIO_FTRUNCATE: req->result = ftruncate (req->int1, req->offs); break;
2047 2031
2048 case EIO_CLOSE: req->result = close (req->int1); break; 2032 case EIO_CLOSE: req->result = eio__close (req->int1); break;
2049 case EIO_DUP2: req->result = dup2 (req->int1, req->int2); break; 2033 case EIO_DUP2: req->result = dup2 (req->int1, req->int2); break;
2050 case EIO_SYNC: req->result = 0; sync (); break; 2034 case EIO_SYNC: req->result = 0; sync (); break;
2051 case EIO_FSYNC: req->result = fsync (req->int1); break; 2035 case EIO_FSYNC: req->result = fsync (req->int1); break;
2052 case EIO_FDATASYNC: req->result = fdatasync (req->int1); break; 2036 case EIO_FDATASYNC: req->result = fdatasync (req->int1); break;
2053 case EIO_SYNCFS: req->result = eio__syncfs (req->int1); break; 2037 case EIO_SYNCFS: req->result = eio__syncfs (req->int1); break;
… …
2073 req->result = select (0, 0, 0, 0, &tv); 2057 req->result = select (0, 0, 0, 0, &tv);
2074 } 2058 }
2075#endif 2059#endif
2076 break; 2060 break;
2077 2061
2062#if 0
2078 case EIO_GROUP: 2063 case EIO_GROUP:
2079 abort (); /* handled in eio_request */ 2064 abort (); /* handled in eio_request */
2065#endif
2080 2066
2081 case EIO_NOP: 2067 case EIO_NOP:
2082 req->result = 0; 2068 req->result = 0;
2083 break; 2069 break;
2084 2070
… …
2089 default: 2075 default:
2090 req->result = EIO_ENOSYS (); 2076 req->result = EIO_ENOSYS ();
2091 break; 2077 break;
2092 } 2078 }
2093 2079
2080alloc_fail:
2094 req->errorno = errno; 2081 req->errorno = errno;
2095} 2082}
2096 2083
2097#ifndef EIO_NO_WRAPPERS 2084#ifndef EIO_NO_WRAPPERS
2098 2085
… …
2187} 2174}
2188 2175
2189eio_req *eio_write (int fd, void *buf, size_t length, off_t offset, int pri, eio_cb cb, void *data) 2176eio_req *eio_write (int fd, void *buf, size_t length, off_t offset, int pri, eio_cb cb, void *data)
2190{ 2177{
2191 REQ (EIO_WRITE); req->int1 = fd; req->offs = offset; req->size = length; req->ptr2 = buf; SEND; 2178 REQ (EIO_WRITE); req->int1 = fd; req->offs = offset; req->size = length; req->ptr2 = buf; SEND;
2179}
2180
2181eio_req *eio_fcntl (int fd, int cmd, void *arg, int pri, eio_cb cb, void *data)
2182{
2183 REQ (EIO_IOCTL); req->int1 = fd; req->int2 = cmd; req->ptr2 = arg; SEND;
2184}
2185
2186eio_req *eio_ioctl (int fd, unsigned long request, void *buf, int pri, eio_cb cb, void *data)
2187{
2188 REQ (EIO_IOCTL); req->int1 = fd; req->int2 = request; req->ptr2 = buf; SEND;
2192} 2189}
2193 2190
2194eio_req *eio_fstat (int fd, int pri, eio_cb cb, void *data) 2191eio_req *eio_fstat (int fd, int pri, eio_cb cb, void *data)
2195{ 2192{
2196 REQ (EIO_FSTAT); req->int1 = fd; SEND; 2193 REQ (EIO_FSTAT); req->int1 = fd; SEND;
… …
2341eio_req *eio_rename (const char *path, const char *new_path, int pri, eio_cb cb, void *data) 2338eio_req *eio_rename (const char *path, const char *new_path, int pri, eio_cb cb, void *data)
2342{ 2339{
2343 return eio__2path (EIO_RENAME, path, new_path, pri, cb, data); 2340 return eio__2path (EIO_RENAME, path, new_path, pri, cb, data);
2344} 2341}
2345 2342
2343eio_req *eio_slurp (const char *path, void *buf, size_t length, off_t offset, int pri, eio_cb cb, void *data)
2344{
2345 REQ (EIO_SLURP); PATH; req->offs = offset; req->size = length; req->ptr2 = buf; SEND;
2346}
2347
2346eio_req *eio_custom (void (*execute)(eio_req *), int pri, eio_cb cb, void *data) 2348eio_req *eio_custom (void (*execute)(eio_req *), int pri, eio_cb cb, void *data)
2347{ 2349{
2348 REQ (EIO_CUSTOM); req->feed = execute; SEND; 2350 REQ (EIO_CUSTOM); req->feed = execute; SEND;
2349} 2351}
2350 2352
… …
2384void 2386void
2385eio_grp_add (eio_req *grp, eio_req *req) 2387eio_grp_add (eio_req *grp, eio_req *req)
2386{ 2388{
2387 assert (("cannot add requests to IO::AIO::GRP after the group finished", grp->int1 != 2)); 2389 assert (("cannot add requests to IO::AIO::GRP after the group finished", grp->int1 != 2));
2388 2390
2389 grp->flags |= EIO_FLAG_GROUPADD; 2391 grp->flags |= ETP_FLAG_GROUPADD;
2390 2392
2391 ++grp->size; 2393 ++grp->size;
2392 req->grp = grp; 2394 req->grp = grp;
2393 2395
2394 req->grp_prev = 0; 2396 req->grp_prev = 0;

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines