ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/libeio/eio.h
(Generate patch)

Comparing libeio/eio.h (file contents):
Revision 1.17 by root, Sun Oct 12 22:30:33 2008 UTC vs.
Revision 1.40 by root, Sun Jul 17 04:20:04 2011 UTC

1/* 1/*
2 * libeio API header 2 * libeio API header
3 * 3 *
4 * Copyright (c) 2007,2008 Marc Alexander Lehmann <libeio@schmorp.de> 4 * Copyright (c) 2007,2008,2009,2010,2011 Marc Alexander Lehmann <libeio@schmorp.de>
5 * All rights reserved. 5 * All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without modifica- 7 * Redistribution and use in source and binary forms, with or without modifica-
8 * tion, are permitted provided that the following conditions are met: 8 * tion, are permitted provided that the following conditions are met:
9 * 9 *
43#ifdef __cplusplus 43#ifdef __cplusplus
44extern "C" { 44extern "C" {
45#endif 45#endif
46 46
47#include <stddef.h> 47#include <stddef.h>
48#include <signal.h>
48#include <sys/types.h> 49#include <sys/types.h>
49 50
50typedef struct eio_req eio_req; 51typedef struct eio_req eio_req;
52typedef struct eio_dirent eio_dirent;
51 53
52typedef int (*eio_cb)(eio_req *req); 54typedef int (*eio_cb)(eio_req *req);
53 55
54#ifndef EIO_REQ_MEMBERS 56#ifndef EIO_REQ_MEMBERS
55# define EIO_REQ_MEMBERS 57# define EIO_REQ_MEMBERS
56#endif 58#endif
57 59
58#ifndef EIO_STRUCT_STAT 60#ifndef EIO_STRUCT_STAT
61# ifdef _WIN32
62# define EIO_STRUCT_STAT struct _stati64
63# define EIO_STRUCT_STATI64
64# else
59# define EIO_STRUCT_STAT struct stat 65# define EIO_STRUCT_STAT struct stat
60#endif 66# endif
67#endif
61 68
69#ifdef _WIN32
70 typedef int eio_uid_t;
71 typedef int eio_gid_t;
72 typedef intptr_t eio_ssize_t; /* or SSIZE_T */
73 #if __GNUC__
74 typedef long long eio_ino_t;
75 #else
76 typedef __int64 eio_ino_t; /* unsigned not supported by msvc */
77 #endif
78#else
79 typedef uid_t eio_uid_t;
80 typedef gid_t eio_gid_t;
81 typedef ssize_t eio_ssize_t;
82 typedef ino_t eio_ino_t;
83#endif
84
85#ifndef EIO_STRUCT_STATVFS
86# define EIO_STRUCT_STATVFS struct statvfs
87#endif
88
89/* for readdir */
90
91/* eio_readdir flags */
62enum { 92enum
93{
94 EIO_READDIR_DENTS = 0x01, /* ptr2 contains eio_dirents, not just the (unsorted) names */
95 EIO_READDIR_DIRS_FIRST = 0x02, /* dirents gets sorted into a good stat() ing order to find directories first */
96 EIO_READDIR_STAT_ORDER = 0x04, /* dirents gets sorted into a good stat() ing order to quickly stat all files */
97 EIO_READDIR_FOUND_UNKNOWN = 0x80, /* set by eio_readdir when *_ARRAY was set and any TYPE=UNKNOWN's were found */
98
99 EIO_READDIR_CUSTOM1 = 0x100, /* for use by apps */
100 EIO_READDIR_CUSTOM2 = 0x200 /* for use by apps */
101};
102
103/* using "typical" values in the hope that the compiler will do something sensible */
104enum eio_dtype
105{
106 EIO_DT_UNKNOWN = 0,
107 EIO_DT_FIFO = 1,
108 EIO_DT_CHR = 2,
109 EIO_DT_MPC = 3, /* multiplexed char device (v7+coherent) */
110 EIO_DT_DIR = 4,
111 EIO_DT_NAM = 5, /* xenix special named file */
112 EIO_DT_BLK = 6,
113 EIO_DT_MPB = 7, /* multiplexed block device (v7+coherent) */
114 EIO_DT_REG = 8,
115 EIO_DT_NWK = 9, /* HP-UX network special */
116 EIO_DT_CMP = 9, /* VxFS compressed */
117 EIO_DT_LNK = 10,
118 /* DT_SHAD = 11,*/
119 EIO_DT_SOCK = 12,
120 EIO_DT_DOOR = 13, /* solaris door */
121 EIO_DT_WHT = 14,
122 EIO_DT_MAX = 15 /* highest DT_VALUE ever, hopefully */
123};
124
125struct eio_dirent
126{
127 int nameofs; /* offset of null-terminated name string in (char *)req->ptr2 */
128 unsigned short namelen; /* size of filename without trailing 0 */
129 unsigned char type; /* one of EIO_DT_* */
130 signed char score; /* internal use */
131 eio_ino_t inode; /* the inode number, if available, otherwise unspecified */
132};
133
134/* eio_msync flags */
135enum
136{
137 EIO_MS_ASYNC = 1,
138 EIO_MS_INVALIDATE = 2,
139 EIO_MS_SYNC = 4
140};
141
142/* eio_mtouch flags */
143enum
144{
145 EIO_MT_MODIFY = 1
146};
147
148/* eio_sync_file_range flags */
149enum
150{
151 EIO_SYNC_FILE_RANGE_WAIT_BEFORE = 1,
152 EIO_SYNC_FILE_RANGE_WRITE = 2,
153 EIO_SYNC_FILE_RANGE_WAIT_AFTER = 4
154};
155
156/* eio_fallocate flags */
157enum
158{
159 EIO_FALLOC_FL_KEEP_SIZE = 1 /* MUST match the value in linux/falloc.h */
160};
161
162/* timestamps and differences - feel free to use double in your code directly */
163typedef double eio_tstamp;
164
165/* the eio request structure */
166enum
167{
63 EIO_CUSTOM, 168 EIO_CUSTOM,
64 EIO_OPEN, EIO_CLOSE, EIO_DUP2, 169 EIO_OPEN, EIO_CLOSE, EIO_DUP2,
65 EIO_READ, EIO_WRITE, 170 EIO_READ, EIO_WRITE,
66 EIO_READAHEAD, EIO_SENDFILE, 171 EIO_READAHEAD, EIO_SENDFILE,
67 EIO_STAT, EIO_LSTAT, EIO_FSTAT, 172 EIO_STAT, EIO_LSTAT, EIO_FSTAT,
173 EIO_STATVFS, EIO_FSTATVFS,
68 EIO_TRUNCATE, EIO_FTRUNCATE, 174 EIO_TRUNCATE, EIO_FTRUNCATE,
69 EIO_UTIME, EIO_FUTIME, 175 EIO_UTIME, EIO_FUTIME,
70 EIO_CHMOD, EIO_FCHMOD, 176 EIO_CHMOD, EIO_FCHMOD,
71 EIO_CHOWN, EIO_FCHOWN, 177 EIO_CHOWN, EIO_FCHOWN,
72 EIO_SYNC, EIO_FSYNC, EIO_FDATASYNC, EIO_MSYNC, EIO_MTOUCH, 178 EIO_SYNC, EIO_FSYNC, EIO_FDATASYNC,
179 EIO_MSYNC, EIO_MTOUCH, EIO_SYNC_FILE_RANGE, EIO_FALLOCATE,
180 EIO_MLOCK, EIO_MLOCKALL,
73 EIO_UNLINK, EIO_RMDIR, EIO_MKDIR, EIO_RENAME, 181 EIO_UNLINK, EIO_RMDIR, EIO_MKDIR, EIO_RENAME,
74 EIO_MKNOD, EIO_READDIR, 182 EIO_MKNOD, EIO_READDIR,
75 EIO_LINK, EIO_SYMLINK, EIO_READLINK, 183 EIO_LINK, EIO_SYMLINK, EIO_READLINK, EIO_REALPATH,
76 EIO_GROUP, EIO_NOP, 184 EIO_GROUP, EIO_NOP,
77 EIO_BUSY, 185 EIO_BUSY
78}; 186};
79 187
80typedef double eio_tstamp; /* feel free to use double in your code directly */ 188/* mlockall constants */
81
82/* eio request structure */
83/* this structure is mostly read-only */
84struct eio_req
85{
86 eio_req volatile *next; /* private ETP */
87
88 ssize_t result; /* result of syscall, e.g. result = read (... */
89 off_t offs; /* read, write, truncate, readahead: file offset */
90 size_t size; /* read, write, readahead, sendfile, msync: length */
91 void *ptr1; /* all applicable requests: pathname, old name */
92 void *ptr2; /* all applicable requests: new name or memory buffer */
93 eio_tstamp nv1; /* utime, futime: atime; busy: sleep time */
94 eio_tstamp nv2; /* utime, futime: mtime */
95
96 int type; /* EIO_xxx constant ETP */
97 int int1; /* all applicable requests: file descriptor; sendfile: output fd; open, msync: flags */
98 long int2; /* chown, fchown: uid; sendfile: input fd; open, chmod, mkdir, mknod: file mode */
99 long int3; /* chown, fchown: gid; mknod: dev_t */
100 int errorno; /* errno value on syscall return */
101
102 unsigned char flags; /* private */
103 signed char pri; /* the priority */
104
105 void *data;
106 eio_cb finish;
107 void (*destroy)(eio_req *req); /* called when requets no longer needed */
108 void (*feed)(eio_req *req); /* only used for group requests */
109
110 EIO_REQ_MEMBERS
111
112 eio_req *grp, *grp_prev, *grp_next, *grp_first; /* private */
113};
114
115/* _private_ flags */
116enum { 189enum
117 EIO_FLAG_CANCELLED = 0x01, /* request was cancelled */ 190{
118 EIO_FLAG_PTR1_FREE = 0x02, /* need to free(ptr1) */ 191 EIO_MCL_CURRENT = 1,
119 EIO_FLAG_PTR2_FREE = 0x04, /* need to free(ptr2) */ 192 EIO_MCL_FUTURE = 2,
120 EIO_FLAG_GROUPADD = 0x08 /* some request was added to the group */
121}; 193};
194
195/* request priorities */
122 196
123enum { 197enum {
124 EIO_PRI_MIN = -4, 198 EIO_PRI_MIN = -4,
125 EIO_PRI_MAX = 4, 199 EIO_PRI_MAX = 4,
126 EIO_PRI_DEFAULT = 0, 200 EIO_PRI_DEFAULT = 0,
127}; 201};
202
203/* eio request structure */
204/* this structure is mostly read-only */
205/* when initialising it, all members must be zero-initialised */
206struct eio_req
207{
208 eio_req volatile *next; /* private ETP */
209
210 eio_ssize_t result; /* result of syscall, e.g. result = read (... */
211 off_t offs; /* read, write, truncate, readahead, sync_file_range, fallocate: file offset, mknod: dev_t */
212 size_t size; /* read, write, readahead, sendfile, msync, mlock, sync_file_range, fallocate: length */
213 void *ptr1; /* all applicable requests: pathname, old name; readdir: optional eio_dirents */
214 void *ptr2; /* all applicable requests: new name or memory buffer; readdir: name strings */
215 eio_tstamp nv1; /* utime, futime: atime; busy: sleep time */
216 eio_tstamp nv2; /* utime, futime: mtime */
217
218 int type; /* EIO_xxx constant ETP */
219 int int1; /* all applicable requests: file descriptor; sendfile: output fd; open, msync, mlockall, readdir: flags */
220 long int2; /* chown, fchown: uid; sendfile: input fd; open, chmod, mkdir, mknod: file mode, sync_file_range, fallocate: flags */
221 long int3; /* chown, fchown: gid */
222 int errorno; /* errno value on syscall return */
223
224#if __i386 || __amd64
225 unsigned char cancelled;
226#else
227 sig_atomic_t cancelled;
228#endif
229
230 unsigned char flags; /* private */
231 signed char pri; /* the priority */
232
233 void *data;
234 eio_cb finish;
235 void (*destroy)(eio_req *req); /* called when request no longer needed */
236 void (*feed)(eio_req *req); /* only used for group requests */
237
238 EIO_REQ_MEMBERS
239
240 eio_req *grp, *grp_prev, *grp_next, *grp_first; /* private */
241};
242
243/* _private_ request flags */
244enum {
245 EIO_FLAG_PTR1_FREE = 0x01, /* need to free(ptr1) */
246 EIO_FLAG_PTR2_FREE = 0x02, /* need to free(ptr2) */
247 EIO_FLAG_GROUPADD = 0x04 /* some request was added to the group */
248};
249
250/* undocumented/unsupported/private helper */
251/*void eio_page_align (void **addr, size_t *length);*/
128 252
129/* returns < 0 on error, errno set 253/* returns < 0 on error, errno set
130 * need_poll, if non-zero, will be called when results are available 254 * need_poll, if non-zero, will be called when results are available
131 * and eio_poll_cb needs to be invoked (it MUST NOT call eio_poll_cb itself). 255 * and eio_poll_cb needs to be invoked (it MUST NOT call eio_poll_cb itself).
132 * done_poll is called when the need to poll is gone. 256 * done_poll is called when the need to poll is gone.
146 * maximum wanted number 270 * maximum wanted number
147 * or maximum idle number of threads */ 271 * or maximum idle number of threads */
148void eio_set_min_parallel (unsigned int nthreads); 272void eio_set_min_parallel (unsigned int nthreads);
149void eio_set_max_parallel (unsigned int nthreads); 273void eio_set_max_parallel (unsigned int nthreads);
150void eio_set_max_idle (unsigned int nthreads); 274void eio_set_max_idle (unsigned int nthreads);
275void eio_set_idle_timeout (unsigned int seconds);
151 276
152unsigned int eio_nreqs (void); /* number of requests in-flight */ 277unsigned int eio_nreqs (void); /* number of requests in-flight */
153unsigned int eio_nready (void); /* number of not-yet handled requests */ 278unsigned int eio_nready (void); /* number of not-yet handled requests */
154unsigned int eio_npending (void); /* numbe rof finished but unhandled requests */ 279unsigned int eio_npending (void); /* number of finished but unhandled requests */
155unsigned int eio_nthreads (void); /* number of worker threads in use currently */ 280unsigned int eio_nthreads (void); /* number of worker threads in use currently */
156 281
157/*****************************************************************************/ 282/*****************************************************************************/
158/* convinience wrappers */ 283/* convenience wrappers */
159 284
160#ifndef EIO_NO_WRAPPERS 285#ifndef EIO_NO_WRAPPERS
161eio_req *eio_nop (int pri, eio_cb cb, void *data); /* does nothing except go through the whole process */ 286eio_req *eio_nop (int pri, eio_cb cb, void *data); /* does nothing except go through the whole process */
162eio_req *eio_busy (eio_tstamp delay, int pri, eio_cb cb, void *data); /* ties a thread for this long, simulating busyness */ 287eio_req *eio_busy (eio_tstamp delay, int pri, eio_cb cb, void *data); /* ties a thread for this long, simulating busyness */
163eio_req *eio_sync (int pri, eio_cb cb, void *data); 288eio_req *eio_sync (int pri, eio_cb cb, void *data);
164eio_req *eio_fsync (int fd, int pri, eio_cb cb, void *data); 289eio_req *eio_fsync (int fd, int pri, eio_cb cb, void *data);
165eio_req *eio_fdatasync (int fd, int pri, eio_cb cb, void *data); 290eio_req *eio_fdatasync (int fd, int pri, eio_cb cb, void *data);
166eio_req *eio_msync (void *addr, size_t length, int flags, int pri, eio_cb cb, void *data); 291eio_req *eio_msync (void *addr, size_t length, int flags, int pri, eio_cb cb, void *data);
167eio_req *eio_mtouch (void *addr, size_t length, int flags, int pri, eio_cb cb, void *data); 292eio_req *eio_mtouch (void *addr, size_t length, int flags, int pri, eio_cb cb, void *data);
293eio_req *eio_mlock (void *addr, size_t length, int pri, eio_cb cb, void *data);
294eio_req *eio_mlockall (int flags, int pri, eio_cb cb, void *data);
295eio_req *eio_sync_file_range (int fd, off_t offset, size_t nbytes, unsigned int flags, int pri, eio_cb cb, void *data);
296eio_req *eio_fallocate (int fd, int mode, off_t offset, size_t len, int pri, eio_cb cb, void *data);
168eio_req *eio_close (int fd, int pri, eio_cb cb, void *data); 297eio_req *eio_close (int fd, int pri, eio_cb cb, void *data);
169eio_req *eio_readahead (int fd, off_t offset, size_t length, int pri, eio_cb cb, void *data); 298eio_req *eio_readahead (int fd, off_t offset, size_t length, int pri, eio_cb cb, void *data);
170eio_req *eio_read (int fd, void *buf, size_t length, off_t offset, int pri, eio_cb cb, void *data); 299eio_req *eio_read (int fd, void *buf, size_t length, off_t offset, int pri, eio_cb cb, void *data);
171eio_req *eio_write (int fd, void *buf, size_t length, off_t offset, int pri, eio_cb cb, void *data); 300eio_req *eio_write (int fd, void *buf, size_t length, off_t offset, int pri, eio_cb cb, void *data);
172eio_req *eio_fstat (int fd, int pri, eio_cb cb, void *data); /* stat buffer=ptr2 allocated dynamically */ 301eio_req *eio_fstat (int fd, int pri, eio_cb cb, void *data); /* stat buffer=ptr2 allocated dynamically */
302eio_req *eio_fstatvfs (int fd, int pri, eio_cb cb, void *data); /* stat buffer=ptr2 allocated dynamically */
173eio_req *eio_futime (int fd, eio_tstamp atime, eio_tstamp mtime, int pri, eio_cb cb, void *data); 303eio_req *eio_futime (int fd, eio_tstamp atime, eio_tstamp mtime, int pri, eio_cb cb, void *data);
174eio_req *eio_ftruncate (int fd, off_t offset, int pri, eio_cb cb, void *data); 304eio_req *eio_ftruncate (int fd, off_t offset, int pri, eio_cb cb, void *data);
175eio_req *eio_fchmod (int fd, mode_t mode, int pri, eio_cb cb, void *data); 305eio_req *eio_fchmod (int fd, mode_t mode, int pri, eio_cb cb, void *data);
176eio_req *eio_fchown (int fd, uid_t uid, gid_t gid, int pri, eio_cb cb, void *data); 306eio_req *eio_fchown (int fd, uid_t uid, gid_t gid, int pri, eio_cb cb, void *data);
177eio_req *eio_dup2 (int fd, int fd2, int pri, eio_cb cb, void *data); 307eio_req *eio_dup2 (int fd, int fd2, int pri, eio_cb cb, void *data);
180eio_req *eio_utime (const char *path, eio_tstamp atime, eio_tstamp mtime, int pri, eio_cb cb, void *data); 310eio_req *eio_utime (const char *path, eio_tstamp atime, eio_tstamp mtime, int pri, eio_cb cb, void *data);
181eio_req *eio_truncate (const char *path, off_t offset, int pri, eio_cb cb, void *data); 311eio_req *eio_truncate (const char *path, off_t offset, int pri, eio_cb cb, void *data);
182eio_req *eio_chown (const char *path, uid_t uid, gid_t gid, int pri, eio_cb cb, void *data); 312eio_req *eio_chown (const char *path, uid_t uid, gid_t gid, int pri, eio_cb cb, void *data);
183eio_req *eio_chmod (const char *path, mode_t mode, int pri, eio_cb cb, void *data); 313eio_req *eio_chmod (const char *path, mode_t mode, int pri, eio_cb cb, void *data);
184eio_req *eio_mkdir (const char *path, mode_t mode, int pri, eio_cb cb, void *data); 314eio_req *eio_mkdir (const char *path, mode_t mode, int pri, eio_cb cb, void *data);
185eio_req *eio_readdir (const char *path, int pri, eio_cb cb, void *data); /* result=ptr2 allocated dynamically */ 315eio_req *eio_readdir (const char *path, int flags, int pri, eio_cb cb, void *data); /* result=ptr2 allocated dynamically */
186eio_req *eio_rmdir (const char *path, int pri, eio_cb cb, void *data); 316eio_req *eio_rmdir (const char *path, int pri, eio_cb cb, void *data);
187eio_req *eio_unlink (const char *path, int pri, eio_cb cb, void *data); 317eio_req *eio_unlink (const char *path, int pri, eio_cb cb, void *data);
188eio_req *eio_readlink (const char *path, int pri, eio_cb cb, void *data); /* result=ptr2 allocated dynamically */ 318eio_req *eio_readlink (const char *path, int pri, eio_cb cb, void *data); /* result=ptr2 allocated dynamically */
319eio_req *eio_realpath (const char *path, int pri, eio_cb cb, void *data); /* result=ptr2 allocated dynamically */
189eio_req *eio_stat (const char *path, int pri, eio_cb cb, void *data); /* stat buffer=ptr2 allocated dynamically */ 320eio_req *eio_stat (const char *path, int pri, eio_cb cb, void *data); /* stat buffer=ptr2 allocated dynamically */
190eio_req *eio_lstat (const char *path, int pri, eio_cb cb, void *data); /* stat buffer=ptr2 allocated dynamically */ 321eio_req *eio_lstat (const char *path, int pri, eio_cb cb, void *data); /* stat buffer=ptr2 allocated dynamically */
322eio_req *eio_statvfs (const char *path, int pri, eio_cb cb, void *data); /* stat buffer=ptr2 allocated dynamically */
191eio_req *eio_mknod (const char *path, mode_t mode, dev_t dev, int pri, eio_cb cb, void *data); 323eio_req *eio_mknod (const char *path, mode_t mode, dev_t dev, int pri, eio_cb cb, void *data);
192eio_req *eio_link (const char *path, const char *new_path, int pri, eio_cb cb, void *data); 324eio_req *eio_link (const char *path, const char *new_path, int pri, eio_cb cb, void *data);
193eio_req *eio_symlink (const char *path, const char *new_path, int pri, eio_cb cb, void *data); 325eio_req *eio_symlink (const char *path, const char *new_path, int pri, eio_cb cb, void *data);
194eio_req *eio_rename (const char *path, const char *new_path, int pri, eio_cb cb, void *data); 326eio_req *eio_rename (const char *path, const char *new_path, int pri, eio_cb cb, void *data);
195eio_req *eio_custom (eio_cb execute, int pri, eio_cb cb, void *data); 327eio_req *eio_custom (void (*execute)(eio_req *), int pri, eio_cb cb, void *data);
196#endif 328#endif
197 329
198/*****************************************************************************/ 330/*****************************************************************************/
199/* groups */ 331/* groups */
200 332
206 338
207/*****************************************************************************/ 339/*****************************************************************************/
208/* request api */ 340/* request api */
209 341
210/* true if the request was cancelled, useful in the invoke callback */ 342/* true if the request was cancelled, useful in the invoke callback */
211#define EIO_CANCELLED(req) ((req)->flags & EIO_FLAG_CANCELLED) 343#define EIO_CANCELLED(req) ((req)->cancelled)
212 344
213#define EIO_RESULT(req) ((req)->result) 345#define EIO_RESULT(req) ((req)->result)
214/* returns a pointer to the result buffer allocated by eio */ 346/* returns a pointer to the result buffer allocated by eio */
215#define EIO_BUF(req) ((req)->ptr2) 347#define EIO_BUF(req) ((req)->ptr2)
216#define EIO_STAT_BUF(req) ((EIO_STRUCT_STAT *)EIO_BUF(req)) 348#define EIO_STAT_BUF(req) ((EIO_STRUCT_STAT *)EIO_BUF(req))
349#define EIO_STATVFS_BUF(req) ((EIO_STRUCT_STATVFS *)EIO_BUF(req))
217#define EIO_PATH(req) ((char *)(req)->ptr1) 350#define EIO_PATH(req) ((char *)(req)->ptr1)
218 351
219/* submit a request for execution */ 352/* submit a request for execution */
220void eio_submit (eio_req *req); 353void eio_submit (eio_req *req);
221/* cancel a request as soon fast as possible, if possible */ 354/* cancel a request as soon fast as possible, if possible */
222void eio_cancel (eio_req *req); 355void eio_cancel (eio_req *req);
223/* destroy a request that has never been submitted */
224void eio_destroy (eio_req *req);
225 356
226/*****************************************************************************/ 357/*****************************************************************************/
227/* convinience functions */ 358/* convenience functions */
228 359
229ssize_t eio_sendfile_sync (int ofd, int ifd, off_t offset, size_t count); 360eio_ssize_t eio_sendfile_sync (int ofd, int ifd, off_t offset, size_t count);
230 361
231#ifdef __cplusplus 362#ifdef __cplusplus
232} 363}
233#endif 364#endif
234 365

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines