[ViewVC] Diff of: cvs/libev/ev.c

Comparing libev/ev.c (file contents):
Revision 1.234 by root, Tue May 6 23:42:16 2008 UTC vs.
Revision 1.267 by root, Mon Oct 27 11:08:29 2008 UTC

 #   define EV_USE_EVENTFD 1
 #  else
 #   define EV_USE_EVENTFD 0
 #  endif
 # endif
 #endif
 #include <math.h>
 #include <stdlib.h>
 #include <fcntl.h>
 #ifndef _WIN32
 # include <sys/time.h>
 # include <sys/wait.h>
 # include <unistd.h>
 #else
+# include <io.h>
 # define WIN32_LEAN_AND_MEAN
 # include <windows.h>
 # ifndef EV_SELECT_IS_WINSOCKET
 #  define EV_SELECT_IS_WINSOCKET 1
 # endif
 #endif
 /* this block tries to deduce configuration from header-defined symbols and defaults */
 #ifndef EV_USE_MONOTONIC
+# if defined (_POSIX_MONOTONIC_CLOCK) && _POSIX_MONOTONIC_CLOCK >= 0
+#  define EV_USE_MONOTONIC 1
+# else
-# define EV_USE_MONOTONIC 0
+#  define EV_USE_MONOTONIC 0
+# endif
 #endif
 #ifndef EV_USE_REALTIME
 # define EV_USE_REALTIME 0
 #endif
 #ifndef EV_USE_NANOSLEEP
+# if _POSIX_C_SOURCE >= 199309L
+#  define EV_USE_NANOSLEEP 1
+# else
-# define EV_USE_NANOSLEEP 0
+#  define EV_USE_NANOSLEEP 0
+# endif
 #endif
 #ifndef EV_USE_SELECT
 # define EV_USE_SELECT 1
 #endif
 # else
 #  define EV_USE_EVENTFD 0
 # endif
 #endif
+#if 0 /* debugging */
+# define EV_VERIFY 3
+# define EV_USE_4HEAP 1
+# define EV_HEAP_CACHE_AT 1
+#endif
+#ifndef EV_VERIFY
+# define EV_VERIFY !EV_MINIMAL
+#endif
+#ifndef EV_USE_4HEAP
+# define EV_USE_4HEAP !EV_MINIMAL
+#endif
+#ifndef EV_HEAP_CACHE_AT
+# define EV_HEAP_CACHE_AT !EV_MINIMAL
+#endif
 /* this block fixes any misconfiguration where we know we run into trouble otherwise */
 #ifndef CLOCK_MONOTONIC
 # undef EV_USE_MONOTONIC
 # define EV_USE_MONOTONIC 0
 #  include <sys/select.h>
 # endif
 #endif
 #if EV_USE_INOTIFY
+# include <sys/utsname.h>
 # include <sys/inotify.h>
+/* some very old inotify.h headers don't have IN_DONT_FOLLOW */
+# ifndef IN_DONT_FOLLOW
+#  undef EV_USE_INOTIFY
+#  define EV_USE_INOTIFY 0
+# endif
 #endif
 #if EV_SELECT_IS_WINSOCKET
 # include <winsock.h>
 #endif
 }
 # endif
 #endif
 /**/
+#if EV_VERIFY >= 3
+# define EV_FREQUENT_CHECK ev_loop_verify (EV_A)
+#else
+# define EV_FREQUENT_CHECK do { } while (0)
+#endif
 /*
  * This is used to avoid floating point rounding problems.
  * It is added to ev_rt_now when scheduling periodics
  * to ensure progress, time-wise, even when rounding
 typedef struct
 {
   WL head;
   unsigned char events;
   unsigned char reify;
+  unsigned char emask; /* the epoll backend stores the actual kernel mask in here */
+  unsigned char egen;  /* generation counter to counter epoll bugs */
 #if EV_SELECT_IS_WINSOCKET
   SOCKET handle;
 #endif
 } ANFD;
   W w;
   int events;
 } ANPENDING;
 #if EV_USE_INOTIFY
+/* hash table entry per inotify-id */
 typedef struct
 {
   WL head;
 } ANFS;
+#endif
+/* Heap Entry */
+#if EV_HEAP_CACHE_AT
+  typedef struct {
+    ev_tstamp at;
+    WT w;
+  } ANHE;
+  #define ANHE_w(he)        (he).w     /* access watcher, read-write */
+  #define ANHE_at(he)       (he).at    /* access cached at, read-only */
+  #define ANHE_at_cache(he) (he).at = (he).w->at /* update at from watcher */
+#else
+  typedef WT ANHE;
+  #define ANHE_w(he)        (he)
+  #define ANHE_at(he)       (he)->at
+  #define ANHE_at_cache(he)
 #endif
 #if EV_MULTIPLICITY
   struct ev_loop
       struct timeval tv;
       tv.tv_sec  = (time_t)delay;
       tv.tv_usec = (long)((delay - (ev_tstamp)(tv.tv_sec)) * 1e6);
+      /* here we rely on sys/time.h + sys/types.h + unistd.h providing select */
+      /* somehting nto guaranteed by newer posix versions, but guaranteed */
+      /* by older ones */
       select (0, 0, 0, 0, &tv);
 #endif
     }
 }
 array_realloc (int elem, void *base, int *cur, int cnt)
 {
   *cur = array_nextsize (elem, *cur, cnt);
   return ev_realloc (base, elem * *cur);
 }
+#define array_init_zero(base,count)	\
+  memset ((void *)(base), 0, sizeof (*(base)) * (count))
 #define array_needsize(type,base,cur,cnt,init)			\
   if (expect_false ((cnt) > (cur)))				\
     {								\
       int ocur_ = (cur);					\
     ev_feed_event (EV_A_ events [i], type);
 }
 /*****************************************************************************/
-void inline_size
-anfds_init (ANFD *base, int count)
-{
-  while (count--)
-    {
-      base->head   = 0;
-      base->events = EV_NONE;
-      base->reify  = 0;
-      ++base;
-    }
-}
 void inline_speed
 fd_event (EV_P_ int fd, int revents)
 {
   ANFD *anfd = anfds + fd;
   ev_io *w;
         events |= (unsigned char)w->events;
 #if EV_SELECT_IS_WINSOCKET
       if (events)
         {
-          unsigned long argp;
+          unsigned long arg;
           #ifdef EV_FD_TO_WIN32_HANDLE
             anfd->handle = EV_FD_TO_WIN32_HANDLE (fd);
           #else
             anfd->handle = _get_osfhandle (fd);
           #endif
-          assert (("libev only supports socket fds in this configuration", ioctlsocket (anfd->handle, FIONREAD, &argp) == 0));
+          assert (("libev only supports socket fds in this configuration", ioctlsocket (anfd->handle, FIONREAD, &arg) == 0));
         }
 #endif
       {
         unsigned char o_events = anfd->events;
 {
   int fd;
   for (fd = 0; fd < anfdmax; ++fd)
     if (anfds [fd].events)
-      if (!fd_valid (fd) == -1 && errno == EBADF)
+      if (!fd_valid (fd) && errno == EBADF)
         fd_kill (EV_A_ fd);
 }
 /* called on ENOMEM in select/poll to kill some fds and retry */
 static void noinline
       }
 }
 /*****************************************************************************/
+/*
+ * the heap functions want a real array index. array index 0 uis guaranteed to not
+ * be in-use at any time. the first heap entry is at array [HEAP0]. DHEAP gives
+ * the branching factor of the d-tree.
+ */
+/*
+ * at the moment we allow libev the luxury of two heaps,
+ * a small-code-size 2-heap one and a ~1.5kb larger 4-heap
+ * which is more cache-efficient.
+ * the difference is about 5% with 50000+ watchers.
+ */
+#if EV_USE_4HEAP
+#define DHEAP 4
+#define HEAP0 (DHEAP - 1) /* index of first element in heap */
+#define HPARENT(k) ((((k) - HEAP0 - 1) / DHEAP) + HEAP0)
+#define UPHEAP_DONE(p,k) ((p) == (k))
+/* away from the root */
+void inline_speed
+downheap (ANHE *heap, int N, int k)
+{
+  ANHE he = heap [k];
+  ANHE *E = heap + N + HEAP0;
+  for (;;)
+    {
+      ev_tstamp minat;
+      ANHE *minpos;
+      ANHE *pos = heap + DHEAP * (k - HEAP0) + HEAP0 + 1;
+      /* find minimum child */
+      if (expect_true (pos + DHEAP - 1 < E))
+        {
+          /* fast path */                               (minpos = pos + 0), (minat = ANHE_at (*minpos));
+          if (               ANHE_at (pos [1]) < minat) (minpos = pos + 1), (minat = ANHE_at (*minpos));
+          if (               ANHE_at (pos [2]) < minat) (minpos = pos + 2), (minat = ANHE_at (*minpos));
+          if (               ANHE_at (pos [3]) < minat) (minpos = pos + 3), (minat = ANHE_at (*minpos));
+        }
+      else if (pos < E)
+        {
+          /* slow path */                               (minpos = pos + 0), (minat = ANHE_at (*minpos));
+          if (pos + 1 < E && ANHE_at (pos [1]) < minat) (minpos = pos + 1), (minat = ANHE_at (*minpos));
+          if (pos + 2 < E && ANHE_at (pos [2]) < minat) (minpos = pos + 2), (minat = ANHE_at (*minpos));
+          if (pos + 3 < E && ANHE_at (pos [3]) < minat) (minpos = pos + 3), (minat = ANHE_at (*minpos));
+        }
+      else
+        break;
+      if (ANHE_at (he) <= minat)
+        break;
+      heap [k] = *minpos;
+      ev_active (ANHE_w (*minpos)) = k;
+      k = minpos - heap;
+    }
+  heap [k] = he;
+  ev_active (ANHE_w (he)) = k;
+}
+#else /* 4HEAP */
+#define HEAP0 1
+#define HPARENT(k) ((k) >> 1)
+#define UPHEAP_DONE(p,k) (!(p))
+/* away from the root */
+void inline_speed
+downheap (ANHE *heap, int N, int k)
+{
+  ANHE he = heap [k];
+  for (;;)
+    {
+      int c = k << 1;
+      if (c > N + HEAP0 - 1)
+        break;
+      c += c + 1 < N + HEAP0 && ANHE_at (heap [c]) > ANHE_at (heap [c + 1])
+           ? 1 : 0;
+      if (ANHE_at (he) <= ANHE_at (heap [c]))
+        break;
+      heap [k] = heap [c];
+      ev_active (ANHE_w (heap [k])) = k;
+      k = c;
+    }
+  heap [k] = he;
+  ev_active (ANHE_w (he)) = k;
+}
+#endif
 /* towards the root */
 void inline_speed
-upheap (WT *heap, int k)
+upheap (ANHE *heap, int k)
 {
-  WT w = heap [k];
+  ANHE he = heap [k];
   for (;;)
     {
-      int p = k >> 1;
+      int p = HPARENT (k);
-      /* maybe we could use a dummy element at heap [0]? */
+      if (UPHEAP_DONE (p, k) || ANHE_at (heap [p]) <= ANHE_at (he))
-      if (!p || heap [p]->at <= w->at)
         break;
       heap [k] = heap [p];
-      ev_active (heap [k]) = k;
+      ev_active (ANHE_w (heap [k])) = k;
       k = p;
     }
-  heap [k] = w;
+  heap [k] = he;
-  ev_active (heap [k]) = k;
+  ev_active (ANHE_w (he)) = k;
-}
-/* away from the root */
-void inline_speed
-downheap (WT *heap, int N, int k)
-{
-  WT w = heap [k];
-  for (;;)
-    {
-      int c = k << 1;
-      if (c > N)
-        break;
-      c += c < N && heap [c]->at > heap [c + 1]->at
-           ? 1 : 0;
-      if (w->at <= heap [c]->at)
-        break;
-      heap [k] = heap [c];
-      ev_active (heap [k]) = k;
-      k = c;
-    }
-  heap [k] = w;
-  ev_active (heap [k]) = k;
 }
 void inline_size
-adjustheap (WT *heap, int N, int k)
+adjustheap (ANHE *heap, int N, int k)
 {
+  if (k > HEAP0 && ANHE_at (heap [HPARENT (k)]) >= ANHE_at (heap [k]))
-  upheap (heap, k);
+    upheap (heap, k);
+  else
-  downheap (heap, N, k);
+    downheap (heap, N, k);
+}
+/* rebuild the heap: this function is used only once and executed rarely */
+void inline_size
+reheap (ANHE *heap, int N)
+{
+  int i;
+  /* we don't use floyds algorithm, upheap is simpler and is more cache-efficient */
+  /* also, this is easy to implement and correct for both 2-heaps and 4-heaps */
+  for (i = 0; i < N; ++i)
+    upheap (heap, i + HEAP0);
 }
 /*****************************************************************************/
 typedef struct
 static ANSIG *signals;
 static int signalmax;
 static EV_ATOMIC_T gotsig;
-void inline_size
-signals_init (ANSIG *base, int count)
-{
-  while (count--)
-    {
-      base->head   = 0;
-      base->gotsig = 0;
-      ++base;
-    }
-}
 /*****************************************************************************/
 void inline_speed
 fd_intern (int fd)
 {
 #ifdef _WIN32
-  int arg = 1;
+  unsigned long arg = 1;
   ioctlsocket (_get_osfhandle (fd), FIONBIO, &arg);
 #else
   fcntl (fd, F_SETFD, FD_CLOEXEC);
   fcntl (fd, F_SETFL, O_NONBLOCK);
 #endif
   postfork = 0;
 }
 #if EV_MULTIPLICITY
 struct ev_loop *
 ev_loop_new (unsigned int flags)
 {
   struct ev_loop *loop = (struct ev_loop *)ev_malloc (sizeof (struct ev_loop));
 void
 ev_loop_fork (EV_P)
 {
   postfork = 1; /* must be in line with ev_default_fork */
 }
+#if EV_VERIFY
+static void noinline
+verify_watcher (EV_P_ W w)
+{
+  assert (("watcher has invalid priority", ABSPRI (w) >= 0 && ABSPRI (w) < NUMPRI));
+  if (w->pending)
+    assert (("pending watcher not on pending queue", pendings [ABSPRI (w)][w->pending - 1].w == w));
+}
+static void noinline
+verify_heap (EV_P_ ANHE *heap, int N)
+{
+  int i;
+  for (i = HEAP0; i < N + HEAP0; ++i)
+    {
+      assert (("active index mismatch in heap", ev_active (ANHE_w (heap [i])) == i));
+      assert (("heap condition violated", i == HEAP0 || ANHE_at (heap [HPARENT (i)]) <= ANHE_at (heap [i])));
+      assert (("heap at cache mismatch", ANHE_at (heap [i]) == ev_at (ANHE_w (heap [i]))));
+      verify_watcher (EV_A_ (W)ANHE_w (heap [i]));
+    }
+}
+static void noinline
+array_verify (EV_P_ W *ws, int cnt)
+{
+  while (cnt--)
+    {
+      assert (("active index mismatch", ev_active (ws [cnt]) == cnt + 1));
+      verify_watcher (EV_A_ ws [cnt]);
+    }
+}
+#endif
+void
+ev_loop_verify (EV_P)
+{
+#if EV_VERIFY
+  int i;
+  WL w;
+  assert (activecnt >= -1);
+  assert (fdchangemax >= fdchangecnt);
+  for (i = 0; i < fdchangecnt; ++i)
+    assert (("negative fd in fdchanges", fdchanges [i] >= 0));
+  assert (anfdmax >= 0);
+  for (i = 0; i < anfdmax; ++i)
+    for (w = anfds [i].head; w; w = w->next)
+      {
+        verify_watcher (EV_A_ (W)w);
+        assert (("inactive fd watcher on anfd list", ev_active (w) == 1));
+        assert (("fd mismatch between watcher and anfd", ((ev_io *)w)->fd == i));
+      }
+  assert (timermax >= timercnt);
+  verify_heap (EV_A_ timers, timercnt);
+#if EV_PERIODIC_ENABLE
+  assert (periodicmax >= periodiccnt);
+  verify_heap (EV_A_ periodics, periodiccnt);
+#endif
+  for (i = NUMPRI; i--; )
+    {
+      assert (pendingmax [i] >= pendingcnt [i]);
+#if EV_IDLE_ENABLE
+      assert (idleall >= 0);
+      assert (idlemax [i] >= idlecnt [i]);
+      array_verify (EV_A_ (W *)idles [i], idlecnt [i]);
+#endif
+    }
+#if EV_FORK_ENABLE
+  assert (forkmax >= forkcnt);
+  array_verify (EV_A_ (W *)forks, forkcnt);
+#endif
+#if EV_ASYNC_ENABLE
+  assert (asyncmax >= asynccnt);
+  array_verify (EV_A_ (W *)asyncs, asynccnt);
+#endif
+  assert (preparemax >= preparecnt);
+  array_verify (EV_A_ (W *)prepares, preparecnt);
+  assert (checkmax >= checkcnt);
+  array_verify (EV_A_ (W *)checks, checkcnt);
+# if 0
+  for (w = (ev_child *)childs [chain & (EV_PID_HASHSIZE - 1)]; w; w = (ev_child *)((WL)w)->next)
+  for (signum = signalmax; signum--; ) if (signals [signum].gotsig)
-#endif
+# endif
+#endif
+}
+#endif /* multiplicity */
 #if EV_MULTIPLICITY
 struct ev_loop *
 ev_default_loop_init (unsigned int flags)
 #else
 {
 #if EV_MULTIPLICITY
   struct ev_loop *loop = ev_default_loop_ptr;
 #endif
+  ev_default_loop_ptr = 0;
 #ifndef _WIN32
   ev_ref (EV_A); /* child watcher */
   ev_signal_stop (EV_A_ &childev);
 #endif
           {
             /*assert (("non-pending watcher on pending list", p->w->pending));*/
             p->w->pending = 0;
             EV_CB_INVOKE (p->w, p->events);
+            EV_FREQUENT_CHECK;
           }
       }
 }
 #if EV_IDLE_ENABLE
 #endif
 void inline_size
 timers_reify (EV_P)
 {
+  EV_FREQUENT_CHECK;
-  while (timercnt && ev_at (timers [1]) <= mn_now)
+  while (timercnt && ANHE_at (timers [HEAP0]) < mn_now)
     {
-      ev_timer *w = (ev_timer *)timers [1];
+      ev_timer *w = (ev_timer *)ANHE_w (timers [HEAP0]);
       /*assert (("inactive timer on timer heap detected", ev_is_active (w)));*/
       /* first reschedule or stop timer */
       if (w->repeat)
         {
-          assert (("negative ev_timer repeat value found while processing timers", w->repeat > 0.));
           ev_at (w) += w->repeat;
           if (ev_at (w) < mn_now)
             ev_at (w) = mn_now;
+          assert (("negative ev_timer repeat value found while processing timers", w->repeat > 0.));
+          ANHE_at_cache (timers [HEAP0]);
-          downheap (timers, timercnt, 1);
+          downheap (timers, timercnt, HEAP0);
         }
       else
         ev_timer_stop (EV_A_ w); /* nonrepeating: stop timer */
+      EV_FREQUENT_CHECK;
       ev_feed_event (EV_A_ (W)w, EV_TIMEOUT);
     }
 }
 #if EV_PERIODIC_ENABLE
 void inline_size
 periodics_reify (EV_P)
 {
+  EV_FREQUENT_CHECK;
-  while (periodiccnt && ev_at (periodics [1]) <= ev_rt_now)
+  while (periodiccnt && ANHE_at (periodics [HEAP0]) < ev_rt_now)
     {
-      ev_periodic *w = (ev_periodic *)periodics [1];
+      ev_periodic *w = (ev_periodic *)ANHE_w (periodics [HEAP0]);
       /*assert (("inactive timer on periodic heap detected", ev_is_active (w)));*/
       /* first reschedule or stop timer */
       if (w->reschedule_cb)
         {
-          ev_at (w) = w->reschedule_cb (w, ev_rt_now + TIME_EPSILON);
+          ev_at (w) = w->reschedule_cb (w, ev_rt_now);
-          assert (("ev_periodic reschedule callback returned time in the past", ev_at (w) > ev_rt_now));
+          assert (("ev_periodic reschedule callback returned time in the past", ev_at (w) >= ev_rt_now));
+          ANHE_at_cache (periodics [HEAP0]);
-          downheap (periodics, periodiccnt, 1);
+          downheap (periodics, periodiccnt, HEAP0);
         }
       else if (w->interval)
         {
           ev_at (w) = w->offset + ceil ((ev_rt_now - w->offset) / w->interval) * w->interval;
+          /* if next trigger time is not sufficiently in the future, put it there */
+          /* this might happen because of floating point inexactness */
-          if (ev_at (w) - ev_rt_now <= TIME_EPSILON) ev_at (w) += w->interval;
+          if (ev_at (w) - ev_rt_now < TIME_EPSILON)
-          assert (("ev_periodic timeout in the past detected while processing timers, negative interval?", ev_at (w) > ev_rt_now));
+            {
+              ev_at (w) += w->interval;
+              /* if interval is unreasonably low we might still have a time in the past */
+              /* so correct this. this will make the periodic very inexact, but the user */
+              /* has effectively asked to get triggered more often than possible */
+              if (ev_at (w) < ev_rt_now)
+                ev_at (w) = ev_rt_now;
+            }
+          ANHE_at_cache (periodics [HEAP0]);
-          downheap (periodics, periodiccnt, 1);
+          downheap (periodics, periodiccnt, HEAP0);
         }
       else
         ev_periodic_stop (EV_A_ w); /* nonrepeating: stop timer */
+      EV_FREQUENT_CHECK;
       ev_feed_event (EV_A_ (W)w, EV_PERIODIC);
     }
 }
 static void noinline
 periodics_reschedule (EV_P)
 {
   int i;
   /* adjust periodics after time jump */
-  for (i = 1; i <= periodiccnt; ++i)
+  for (i = HEAP0; i < periodiccnt + HEAP0; ++i)
     {
-      ev_periodic *w = (ev_periodic *)periodics [i];
+      ev_periodic *w = (ev_periodic *)ANHE_w (periodics [i]);
       if (w->reschedule_cb)
         ev_at (w) = w->reschedule_cb (w, ev_rt_now);
       else if (w->interval)
         ev_at (w) = w->offset + ceil ((ev_rt_now - w->offset) / w->interval) * w->interval;
-    }
-  /* now rebuild the heap */
+      ANHE_at_cache (periodics [i]);
-  for (i = periodiccnt >> 1; i--; )
+    }
-    downheap (periodics, periodiccnt, i);
+  reheap (periodics, periodiccnt);
 }
 #endif
 void inline_speed
 time_update (EV_P_ ev_tstamp max_block)
         {
 #if EV_PERIODIC_ENABLE
           periodics_reschedule (EV_A);
 #endif
           /* adjust timers. this is easy, as the offset is the same for all of them */
-          for (i = 1; i <= timercnt; ++i)
+          for (i = 0; i < timercnt; ++i)
-            ev_at (timers [i]) += ev_rt_now - mn_now;
+            {
+              ANHE *he = timers + i + HEAP0;
+              ANHE_w (*he)->at += ev_rt_now - mn_now;
+              ANHE_at_cache (*he);
+            }
         }
       mn_now = ev_rt_now;
     }
 }
 ev_unref (EV_P)
 {
   --activecnt;
 }
+void
+ev_now_update (EV_P)
+{
+  time_update (EV_A_ 1e100);
+}
 static int loop_done;
 void
 ev_loop (EV_P_ int flags)
 {
   call_pending (EV_A); /* in case we recurse, ensure ordering stays nice and clean */
   do
     {
+#if EV_VERIFY >= 2
+      ev_loop_verify (EV_A);
+#endif
 #ifndef _WIN32
       if (expect_false (curpid)) /* penalise the forking check even more */
         if (expect_false (getpid () != curpid))
           {
             curpid = getpid ();
             waittime = MAX_BLOCKTIME;
             if (timercnt)
               {
-                ev_tstamp to = ev_at (timers [1]) - mn_now + backend_fudge;
+                ev_tstamp to = ANHE_at (timers [HEAP0]) - mn_now + backend_fudge;
                 if (waittime > to) waittime = to;
               }
 #if EV_PERIODIC_ENABLE
             if (periodiccnt)
               {
-                ev_tstamp to = ev_at (periodics [1]) - ev_rt_now + backend_fudge;
+                ev_tstamp to = ANHE_at (periodics [HEAP0]) - ev_rt_now + backend_fudge;
                 if (waittime > to) waittime = to;
               }
 #endif
             if (expect_false (waittime < timeout_blocktime))
   if (expect_false (ev_is_active (w)))
     return;
   assert (("ev_io_start called with negative fd", fd >= 0));
+  assert (("ev_io start called with illegal event mask", !(w->events & ~(EV_IOFDSET | EV_READ | EV_WRITE))));
+  EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, 1);
-  array_needsize (ANFD, anfds, anfdmax, fd + 1, anfds_init);
+  array_needsize (ANFD, anfds, anfdmax, fd + 1, array_init_zero);
   wlist_add (&anfds[fd].head, (WL)w);
   fd_change (EV_A_ fd, w->events & EV_IOFDSET | 1);
   w->events &= ~EV_IOFDSET;
+  EV_FREQUENT_CHECK;
 }
 void noinline
 ev_io_stop (EV_P_ ev_io *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
-  assert (("ev_io_start called with illegal fd (must stay constant after start!)", w->fd >= 0 && w->fd < anfdmax));
+  assert (("ev_io_stop called with illegal fd (must stay constant after start!)", w->fd >= 0 && w->fd < anfdmax));
+  EV_FREQUENT_CHECK;
   wlist_del (&anfds[w->fd].head, (WL)w);
   ev_stop (EV_A_ (W)w);
   fd_change (EV_A_ w->fd, 1);
+  EV_FREQUENT_CHECK;
 }
 void noinline
 ev_timer_start (EV_P_ ev_timer *w)
 {
   ev_at (w) += mn_now;
   assert (("ev_timer_start called with negative timer repeat value", w->repeat >= 0.));
+  EV_FREQUENT_CHECK;
+  ++timercnt;
-  ev_start (EV_A_ (W)w, ++timercnt);
+  ev_start (EV_A_ (W)w, timercnt + HEAP0 - 1);
-  array_needsize (WT, timers, timermax, timercnt + 1, EMPTY2);
+  array_needsize (ANHE, timers, timermax, ev_active (w) + 1, EMPTY2);
-  timers [timercnt] = (WT)w;
+  ANHE_w (timers [ev_active (w)]) = (WT)w;
+  ANHE_at_cache (timers [ev_active (w)]);
-  upheap (timers, timercnt);
+  upheap (timers, ev_active (w));
+  EV_FREQUENT_CHECK;
-  /*assert (("internal timer heap corruption", timers [ev_active (w)] == w));*/
+  /*assert (("internal timer heap corruption", timers [ev_active (w)] == (WT)w));*/
 }
 void noinline
 ev_timer_stop (EV_P_ ev_timer *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   {
     int active = ev_active (w);
-    assert (("internal timer heap corruption", timers [active] == (WT)w));
+    assert (("internal timer heap corruption", ANHE_w (timers [active]) == (WT)w));
+    --timercnt;
-    if (expect_true (active < timercnt))
+    if (expect_true (active < timercnt + HEAP0))
       {
-        timers [active] = timers [timercnt];
+        timers [active] = timers [timercnt + HEAP0];
         adjustheap (timers, timercnt, active);
       }
-    --timercnt;
   }
+  EV_FREQUENT_CHECK;
   ev_at (w) -= mn_now;
   ev_stop (EV_A_ (W)w);
 }
 void noinline
 ev_timer_again (EV_P_ ev_timer *w)
 {
+  EV_FREQUENT_CHECK;
   if (ev_is_active (w))
     {
       if (w->repeat)
         {
           ev_at (w) = mn_now + w->repeat;
+          ANHE_at_cache (timers [ev_active (w)]);
           adjustheap (timers, timercnt, ev_active (w));
         }
       else
         ev_timer_stop (EV_A_ w);
     }
   else if (w->repeat)
     {
       ev_at (w) = w->repeat;
       ev_timer_start (EV_A_ w);
     }
+  EV_FREQUENT_CHECK;
 }
 #if EV_PERIODIC_ENABLE
 void noinline
 ev_periodic_start (EV_P_ ev_periodic *w)
       ev_at (w) = w->offset + ceil ((ev_rt_now - w->offset) / w->interval) * w->interval;
     }
   else
     ev_at (w) = w->offset;
+  EV_FREQUENT_CHECK;
+  ++periodiccnt;
-  ev_start (EV_A_ (W)w, ++periodiccnt);
+  ev_start (EV_A_ (W)w, periodiccnt + HEAP0 - 1);
-  array_needsize (WT, periodics, periodicmax, periodiccnt + 1, EMPTY2);
+  array_needsize (ANHE, periodics, periodicmax, ev_active (w) + 1, EMPTY2);
-  periodics [periodiccnt] = (WT)w;
+  ANHE_w (periodics [ev_active (w)]) = (WT)w;
-  upheap (periodics, periodiccnt);
+  ANHE_at_cache (periodics [ev_active (w)]);
+  upheap (periodics, ev_active (w));
+  EV_FREQUENT_CHECK;
-  /*assert (("internal periodic heap corruption", periodics [ev_active (w)] == w));*/
+  /*assert (("internal periodic heap corruption", ANHE_w (periodics [ev_active (w)]) == (WT)w));*/
 }
 void noinline
 ev_periodic_stop (EV_P_ ev_periodic *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   {
     int active = ev_active (w);
-    assert (("internal periodic heap corruption", periodics [active] == (WT)w));
+    assert (("internal periodic heap corruption", ANHE_w (periodics [active]) == (WT)w));
+    --periodiccnt;
-    if (expect_true (active < periodiccnt))
+    if (expect_true (active < periodiccnt + HEAP0))
       {
-        periodics [active] = periodics [periodiccnt];
+        periodics [active] = periodics [periodiccnt + HEAP0];
         adjustheap (periodics, periodiccnt, active);
       }
-    --periodiccnt;
   }
+  EV_FREQUENT_CHECK;
   ev_stop (EV_A_ (W)w);
 }
 void noinline
     return;
   assert (("ev_signal_start called with illegal signal number", w->signum > 0));
   evpipe_init (EV_A);
+  EV_FREQUENT_CHECK;
   {
 #ifndef _WIN32
     sigset_t full, prev;
     sigfillset (&full);
     sigprocmask (SIG_SETMASK, &full, &prev);
 #endif
-    array_needsize (ANSIG, signals, signalmax, w->signum, signals_init);
+    array_needsize (ANSIG, signals, signalmax, w->signum, array_init_zero);
 #ifndef _WIN32
     sigprocmask (SIG_SETMASK, &prev, 0);
 #endif
   }
       sigfillset (&sa.sa_mask);
       sa.sa_flags = SA_RESTART; /* if restarting works we save one iteration */
       sigaction (w->signum, &sa, 0);
 #endif
     }
+  EV_FREQUENT_CHECK;
 }
 void noinline
 ev_signal_stop (EV_P_ ev_signal *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   wlist_del (&signals [w->signum - 1].head, (WL)w);
   ev_stop (EV_A_ (W)w);
   if (!signals [w->signum - 1].head)
     signal (w->signum, SIG_DFL);
+  EV_FREQUENT_CHECK;
 }
 void
 ev_child_start (EV_P_ ev_child *w)
 {
   assert (("child watchers are only supported in the default loop", loop == ev_default_loop_ptr));
 #endif
   if (expect_false (ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, 1);
   wlist_add (&childs [w->pid & (EV_PID_HASHSIZE - 1)], (WL)w);
+  EV_FREQUENT_CHECK;
 }
 void
 ev_child_stop (EV_P_ ev_child *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   wlist_del (&childs [w->pid & (EV_PID_HASHSIZE - 1)], (WL)w);
   ev_stop (EV_A_ (W)w);
+  EV_FREQUENT_CHECK;
 }
 #if EV_STAT_ENABLE
 # ifdef _WIN32
 static void noinline
 infy_wd (EV_P_ int slot, int wd, struct inotify_event *ev)
 {
   if (slot < 0)
-    /* overflow, need to check for all hahs slots */
+    /* overflow, need to check for all hash slots */
     for (slot = 0; slot < EV_INOTIFY_HASHSIZE; ++slot)
       infy_wd (EV_A_ slot, wd, ev);
   else
     {
       WL w_;
 infy_init (EV_P)
 {
   if (fs_fd != -2)
     return;
+  /* kernels < 2.6.25 are borked
+   * http://www.ussg.indiana.edu/hypermail/linux/kernel/0711.3/1208.html
+   */
+  {
+    struct utsname buf;
+    int major, minor, micro;
+    fs_fd = -1;
+    if (uname (&buf))
+      return;
+    if (sscanf (buf.release, "%d.%d.%d", &major, &minor, &micro) != 3)
+      return;
+    if (major < 2
+        || (major == 2 && minor < 6)
+        || (major == 2 && minor == 6 && micro < 25))
+      return;
+  }
   fs_fd = inotify_init ();
   if (fs_fd >= 0)
     {
       ev_io_init (&fs_w, infy_cb, fs_fd, EV_READ);
           if (fs_fd >= 0)
             infy_add (EV_A_ w); /* re-add, no matter what */
           else
             ev_timer_start (EV_A_ &w->timer);
         }
     }
 }
+#endif
+#ifdef _WIN32
+# define EV_LSTAT(p,b) _stati64 (p, b)
+#else
+# define EV_LSTAT(p,b) lstat (p, b)
 #endif
 void
 ev_stat_stat (EV_P_ ev_stat *w)
 {
     || w->prev.st_atime != w->attr.st_atime
     || w->prev.st_mtime != w->attr.st_mtime
     || w->prev.st_ctime != w->attr.st_ctime
   ) {
       #if EV_USE_INOTIFY
+        if (fs_fd >= 0)
+          {
-        infy_del (EV_A_ w);
+            infy_del (EV_A_ w);
-        infy_add (EV_A_ w);
+            infy_add (EV_A_ w);
-        ev_stat_stat (EV_A_ w); /* avoid race... */
+            ev_stat_stat (EV_A_ w); /* avoid race... */
+          }
       #endif
       ev_feed_event (EV_A_ w, EV_STAT);
     }
 }
   else
 #endif
     ev_timer_start (EV_A_ &w->timer);
   ev_start (EV_A_ (W)w, 1);
+  EV_FREQUENT_CHECK;
 }
 void
 ev_stat_stop (EV_P_ ev_stat *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
 #if EV_USE_INOTIFY
   infy_del (EV_A_ w);
 #endif
   ev_timer_stop (EV_A_ &w->timer);
   ev_stop (EV_A_ (W)w);
+  EV_FREQUENT_CHECK;
 }
 #endif
 #if EV_IDLE_ENABLE
 void
 {
   if (expect_false (ev_is_active (w)))
     return;
   pri_adjust (EV_A_ (W)w);
+  EV_FREQUENT_CHECK;
   {
     int active = ++idlecnt [ABSPRI (w)];
     ++idleall;
     ev_start (EV_A_ (W)w, active);
     array_needsize (ev_idle *, idles [ABSPRI (w)], idlemax [ABSPRI (w)], active, EMPTY2);
     idles [ABSPRI (w)][active - 1] = w;
   }
+  EV_FREQUENT_CHECK;
 }
 void
 ev_idle_stop (EV_P_ ev_idle *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   {
     int active = ev_active (w);
     idles [ABSPRI (w)][active - 1] = idles [ABSPRI (w)][--idlecnt [ABSPRI (w)]];
     ev_active (idles [ABSPRI (w)][active - 1]) = active;
     ev_stop (EV_A_ (W)w);
     --idleall;
   }
+  EV_FREQUENT_CHECK;
 }
 #endif
 void
 ev_prepare_start (EV_P_ ev_prepare *w)
 {
   if (expect_false (ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, ++preparecnt);
   array_needsize (ev_prepare *, prepares, preparemax, preparecnt, EMPTY2);
   prepares [preparecnt - 1] = w;
+  EV_FREQUENT_CHECK;
 }
 void
 ev_prepare_stop (EV_P_ ev_prepare *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   {
     int active = ev_active (w);
     prepares [active - 1] = prepares [--preparecnt];
     ev_active (prepares [active - 1]) = active;
   }
   ev_stop (EV_A_ (W)w);
+  EV_FREQUENT_CHECK;
 }
 void
 ev_check_start (EV_P_ ev_check *w)
 {
   if (expect_false (ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, ++checkcnt);
   array_needsize (ev_check *, checks, checkmax, checkcnt, EMPTY2);
   checks [checkcnt - 1] = w;
+  EV_FREQUENT_CHECK;
 }
 void
 ev_check_stop (EV_P_ ev_check *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   {
     int active = ev_active (w);
     checks [active - 1] = checks [--checkcnt];
     ev_active (checks [active - 1]) = active;
   }
   ev_stop (EV_A_ (W)w);
+  EV_FREQUENT_CHECK;
 }
 #if EV_EMBED_ENABLE
 void noinline
 ev_embed_sweep (EV_P_ ev_embed *w)
         ev_loop (EV_A_ EVLOOP_NONBLOCK);
       }
   }
 }
+static void
+embed_fork_cb (EV_P_ ev_fork *fork_w, int revents)
+{
+  ev_embed *w = (ev_embed *)(((char *)fork_w) - offsetof (ev_embed, fork));
+  {
+    struct ev_loop *loop = w->other;
+    ev_loop_fork (EV_A);
+  }
+}
 #if 0
 static void
 embed_idle_cb (EV_P_ ev_idle *idle, int revents)
 {
   ev_idle_stop (EV_A_ idle);
     struct ev_loop *loop = w->other;
     assert (("loop to be embedded is not embeddable", backend & ev_embeddable_backends ()));
     ev_io_init (&w->io, embed_io_cb, backend_fd, EV_READ);
   }
+  EV_FREQUENT_CHECK;
   ev_set_priority (&w->io, ev_priority (w));
   ev_io_start (EV_A_ &w->io);
   ev_prepare_init (&w->prepare, embed_prepare_cb);
   ev_set_priority (&w->prepare, EV_MINPRI);
   ev_prepare_start (EV_A_ &w->prepare);
+  ev_fork_init (&w->fork, embed_fork_cb);
+  ev_fork_start (EV_A_ &w->fork);
   /*ev_idle_init (&w->idle, e,bed_idle_cb);*/
   ev_start (EV_A_ (W)w, 1);
+  EV_FREQUENT_CHECK;
 }
 void
 ev_embed_stop (EV_P_ ev_embed *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
-  ev_io_stop (EV_A_ &w->io);
+  ev_io_stop      (EV_A_ &w->io);
   ev_prepare_stop (EV_A_ &w->prepare);
+  ev_fork_stop    (EV_A_ &w->fork);
-  ev_stop (EV_A_ (W)w);
+  EV_FREQUENT_CHECK;
 }
 #endif
 #if EV_FORK_ENABLE
 void
 ev_fork_start (EV_P_ ev_fork *w)
 {
   if (expect_false (ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, ++forkcnt);
   array_needsize (ev_fork *, forks, forkmax, forkcnt, EMPTY2);
   forks [forkcnt - 1] = w;
+  EV_FREQUENT_CHECK;
 }
 void
 ev_fork_stop (EV_P_ ev_fork *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   {
     int active = ev_active (w);
     forks [active - 1] = forks [--forkcnt];
     ev_active (forks [active - 1]) = active;
   }
   ev_stop (EV_A_ (W)w);
+  EV_FREQUENT_CHECK;
 }
 #endif
 #if EV_ASYNC_ENABLE
 void
 {
   if (expect_false (ev_is_active (w)))
     return;
   evpipe_init (EV_A);
+  EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, ++asynccnt);
   array_needsize (ev_async *, asyncs, asyncmax, asynccnt, EMPTY2);
   asyncs [asynccnt - 1] = w;
+  EV_FREQUENT_CHECK;
 }
 void
 ev_async_stop (EV_P_ ev_async *w)
 {
   clear_pending (EV_A_ (W)w);
   if (expect_false (!ev_is_active (w)))
     return;
+  EV_FREQUENT_CHECK;
   {
     int active = ev_active (w);
     asyncs [active - 1] = asyncs [--asynccnt];
     ev_active (asyncs [active - 1]) = active;
   }
   ev_stop (EV_A_ (W)w);
+  EV_FREQUENT_CHECK;
 }
 void
 ev_async_send (EV_P_ ev_async *w)
 {
 once_cb (EV_P_ struct ev_once *once, int revents)
 {
   void (*cb)(int revents, void *arg) = once->cb;
   void *arg = once->arg;
-  ev_io_stop (EV_A_ &once->io);
+  ev_io_stop    (EV_A_ &once->io);
   ev_timer_stop (EV_A_ &once->to);
   ev_free (once);
   cb (revents, arg);
 }
 static void
 once_cb_io (EV_P_ ev_io *w, int revents)
 {
-  once_cb (EV_A_ (struct ev_once *)(((char *)w) - offsetof (struct ev_once, io)), revents);
+  struct ev_once *once = (struct ev_once *)(((char *)w) - offsetof (struct ev_once, io));
+  once_cb (EV_A_ once, revents | ev_clear_pending (EV_A_ &once->to));
 }
 static void
 once_cb_to (EV_P_ ev_timer *w, int revents)
 {
-  once_cb (EV_A_ (struct ev_once *)(((char *)w) - offsetof (struct ev_once, to)), revents);
+  struct ev_once *once = (struct ev_once *)(((char *)w) - offsetof (struct ev_once, to));
+  once_cb (EV_A_ once, revents | ev_clear_pending (EV_A_ &once->io));
 }
 void
 ev_once (EV_P_ int fd, int events, ev_tstamp timeout, void (*cb)(int revents, void *arg), void *arg)
 {

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing libev/ev.c (file contents): Revision 1.234 by root, Tue May 6 23:42:16 2008 UTC vs. Revision 1.267 by root, Mon Oct 27 11:08:29 2008 UTC

Diff Legend

Comparing libev/ev.c (file contents):
Revision 1.234 by root, Tue May 6 23:42:16 2008 UTC vs.
Revision 1.267 by root, Mon Oct 27 11:08:29 2008 UTC