[ViewVC] Diff of: cvs/libev/ev.c

Comparing libev/ev.c (file contents):
Revision 1.263 by root, Wed Oct 1 18:50:03 2008 UTC vs.
Revision 1.272 by root, Mon Nov 3 12:17:40 2008 UTC

 #  include <sys/select.h>
 # endif
 #endif
 #if EV_USE_INOTIFY
+# include <sys/utsname.h>
 # include <sys/inotify.h>
 /* some very old inotify.h headers don't have IN_DONT_FOLLOW */
 # ifndef IN_DONT_FOLLOW
 #  undef EV_USE_INOTIFY
 #  define EV_USE_INOTIFY 0
 {
   syserr_cb = cb;
 }
 static void noinline
-syserr (const char *msg)
+ev_syserr (const char *msg)
 {
   if (!msg)
     msg = "(libev) system error";
   if (syserr_cb)
 typedef struct
 {
   WL head;
   unsigned char events;
   unsigned char reify;
+  unsigned char emask; /* the epoll backend stores the actual kernel mask in here */
+  unsigned char unused;
+#if EV_USE_EPOLL
+  unsigned int egen;  /* generation counter to counter epoll bugs */
+#endif
 #if EV_SELECT_IS_WINSOCKET
   SOCKET handle;
 #endif
 } ANFD;
 {
   *cur = array_nextsize (elem, *cur, cnt);
   return ev_realloc (base, elem * *cur);
 }
+#define array_init_zero(base,count)	\
+  memset ((void *)(base), 0, sizeof (*(base)) * (count))
 #define array_needsize(type,base,cur,cnt,init)			\
   if (expect_false ((cnt) > (cur)))				\
     {								\
       int ocur_ = (cur);					\
       (base) = (type *)array_realloc				\
   for (i = 0; i < eventcnt; ++i)
     ev_feed_event (EV_A_ events [i], type);
 }
 /*****************************************************************************/
-void inline_size
-anfds_init (ANFD *base, int count)
-{
-  while (count--)
-    {
-      base->head   = 0;
-      base->events = EV_NONE;
-      base->reify  = 0;
-      ++base;
-    }
-}
 void inline_speed
 fd_event (EV_P_ int fd, int revents)
 {
   ANFD *anfd = anfds + fd;
   for (fd = 0; fd < anfdmax; ++fd)
     if (anfds [fd].events)
       {
         anfds [fd].events = 0;
+        anfds [fd].emask  = 0;
         fd_change (EV_A_ fd, EV_IOFDSET | 1);
       }
 }
 /*****************************************************************************/
 static ANSIG *signals;
 static int signalmax;
 static EV_ATOMIC_T gotsig;
-void inline_size
-signals_init (ANSIG *base, int count)
-{
-  while (count--)
-    {
-      base->head   = 0;
-      base->gotsig = 0;
-      ++base;
-    }
-}
 /*****************************************************************************/
 void inline_speed
 fd_intern (int fd)
 {
         }
       else
 #endif
         {
           while (pipe (evpipe))
-            syserr ("(libev) error creating signal/async pipe");
+            ev_syserr ("(libev) error creating signal/async pipe");
           fd_intern (evpipe [0]);
           fd_intern (evpipe [1]);
           ev_io_set (&pipeev, evpipe [0], EV_READ);
         }
 {
 #if EV_MULTIPLICITY
   struct ev_loop *loop = ev_default_loop_ptr;
 #endif
+  ev_default_loop_ptr = 0;
 #ifndef _WIN32
   ev_ref (EV_A); /* child watcher */
   ev_signal_stop (EV_A_ &childev);
 #endif
 {
 #if EV_MULTIPLICITY
   struct ev_loop *loop = ev_default_loop_ptr;
 #endif
-  if (backend)
-    postfork = 1; /* must be in line with ev_loop_fork */
+  postfork = 1; /* must be in line with ev_loop_fork */
 }
 /*****************************************************************************/
 void
   if (expect_false (ev_is_active (w)))
     return;
   assert (("ev_io_start called with negative fd", fd >= 0));
+  assert (("ev_io start called with illegal event mask", !(w->events & ~(EV_IOFDSET | EV_READ | EV_WRITE))));
   EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, 1);
-  array_needsize (ANFD, anfds, anfdmax, fd + 1, anfds_init);
+  array_needsize (ANFD, anfds, anfdmax, fd + 1, array_init_zero);
   wlist_add (&anfds[fd].head, (WL)w);
   fd_change (EV_A_ fd, w->events & EV_IOFDSET | 1);
   w->events &= ~EV_IOFDSET;
     sigset_t full, prev;
     sigfillset (&full);
     sigprocmask (SIG_SETMASK, &full, &prev);
 #endif
-    array_needsize (ANSIG, signals, signalmax, w->signum, signals_init);
+    array_needsize (ANSIG, signals, signalmax, w->signum, array_init_zero);
 #ifndef _WIN32
     sigprocmask (SIG_SETMASK, &prev, 0);
 #endif
   }
   if (w->wd < 0)
     {
       ev_timer_start (EV_A_ &w->timer); /* this is not race-free, so we still need to recheck periodically */
       /* monitor some parent directory for speedup hints */
-      /* note that exceeding the hardcoded limit is not a correctness issue, */
+      /* note that exceeding the hardcoded path limit is not a correctness issue, */
       /* but an efficiency issue only */
       if ((errno == ENOENT || errno == EACCES) && strlen (w->path) < 4096)
         {
           char path [4096];
           strcpy (path, w->path);
 static void noinline
 infy_wd (EV_P_ int slot, int wd, struct inotify_event *ev)
 {
   if (slot < 0)
-    /* overflow, need to check for all hahs slots */
+    /* overflow, need to check for all hash slots */
     for (slot = 0; slot < EV_INOTIFY_HASHSIZE; ++slot)
       infy_wd (EV_A_ slot, wd, ev);
   else
     {
       WL w_;
 infy_init (EV_P)
 {
   if (fs_fd != -2)
     return;
+  /* kernels < 2.6.25 are borked
+   * http://www.ussg.indiana.edu/hypermail/linux/kernel/0711.3/1208.html
+   */
+  {
+    struct utsname buf;
+    int major, minor, micro;
+    fs_fd = -1;
+    if (uname (&buf))
+      return;
+    if (sscanf (buf.release, "%d.%d.%d", &major, &minor, &micro) != 3)
+      return;
+    if (major < 2
+        || (major == 2 && minor < 6)
+        || (major == 2 && minor == 6 && micro < 25))
+      return;
+  }
   fs_fd = inotify_init ();
   if (fs_fd >= 0)
     {
       ev_io_init (&fs_w, infy_cb, fs_fd, EV_READ);
           if (fs_fd >= 0)
             infy_add (EV_A_ w); /* re-add, no matter what */
           else
             ev_timer_start (EV_A_ &w->timer);
         }
     }
 }
 #endif
     || w->prev.st_atime != w->attr.st_atime
     || w->prev.st_mtime != w->attr.st_mtime
     || w->prev.st_ctime != w->attr.st_ctime
   ) {
       #if EV_USE_INOTIFY
+        if (fs_fd >= 0)
+          {
-        infy_del (EV_A_ w);
+            infy_del (EV_A_ w);
-        infy_add (EV_A_ w);
+            infy_add (EV_A_ w);
-        ev_stat_stat (EV_A_ w); /* avoid race... */
+            ev_stat_stat (EV_A_ w); /* avoid race... */
+          }
       #endif
       ev_feed_event (EV_A_ w, EV_STAT);
     }
 }

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing libev/ev.c (file contents): Revision 1.263 by root, Wed Oct 1 18:50:03 2008 UTC vs. Revision 1.272 by root, Mon Nov 3 12:17:40 2008 UTC

Diff Legend

Comparing libev/ev.c (file contents):
Revision 1.263 by root, Wed Oct 1 18:50:03 2008 UTC vs.
Revision 1.272 by root, Mon Nov 3 12:17:40 2008 UTC