ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/libev/ev.c
(Generate patch)

Comparing libev/ev.c (file contents):
Revision 1.316 by root, Fri Sep 18 21:02:12 2009 UTC vs.
Revision 1.330 by root, Tue Mar 9 08:46:17 2010 UTC

1/* 1/*
2 * libev event processing core, watcher management 2 * libev event processing core, watcher management
3 * 3 *
4 * Copyright (c) 2007,2008,2009 Marc Alexander Lehmann <libev@schmorp.de> 4 * Copyright (c) 2007,2008,2009,2010 Marc Alexander Lehmann <libev@schmorp.de>
5 * All rights reserved. 5 * All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without modifica- 7 * Redistribution and use in source and binary forms, with or without modifica-
8 * tion, are permitted provided that the following conditions are met: 8 * tion, are permitted provided that the following conditions are met:
9 * 9 *
110# define EV_USE_EPOLL 0 110# define EV_USE_EPOLL 0
111# endif 111# endif
112# endif 112# endif
113 113
114# ifndef EV_USE_KQUEUE 114# ifndef EV_USE_KQUEUE
115# if HAVE_KQUEUE && HAVE_SYS_EVENT_H && HAVE_SYS_QUEUE_H 115# if HAVE_KQUEUE && HAVE_SYS_EVENT_H
116# define EV_USE_KQUEUE 1 116# define EV_USE_KQUEUE 1
117# else 117# else
118# define EV_USE_KQUEUE 0 118# define EV_USE_KQUEUE 0
119# endif 119# endif
120# endif 120# endif
153 153
154#endif 154#endif
155 155
156#include <math.h> 156#include <math.h>
157#include <stdlib.h> 157#include <stdlib.h>
158#include <string.h>
158#include <fcntl.h> 159#include <fcntl.h>
159#include <stddef.h> 160#include <stddef.h>
160 161
161#include <stdio.h> 162#include <stdio.h>
162 163
163#include <assert.h> 164#include <assert.h>
164#include <errno.h> 165#include <errno.h>
165#include <sys/types.h> 166#include <sys/types.h>
166#include <time.h> 167#include <time.h>
168#include <limits.h>
167 169
168#include <signal.h> 170#include <signal.h>
169 171
170#ifdef EV_H 172#ifdef EV_H
171# include EV_H 173# include EV_H
343# endif 345# endif
344#endif 346#endif
345 347
346/* this block fixes any misconfiguration where we know we run into trouble otherwise */ 348/* this block fixes any misconfiguration where we know we run into trouble otherwise */
347 349
350#ifdef _AIX
351/* AIX has a completely broken poll.h header */
352# undef EV_USE_POLL
353# define EV_USE_POLL 0
354#endif
355
348#ifndef CLOCK_MONOTONIC 356#ifndef CLOCK_MONOTONIC
349# undef EV_USE_MONOTONIC 357# undef EV_USE_MONOTONIC
350# define EV_USE_MONOTONIC 0 358# define EV_USE_MONOTONIC 0
351#endif 359#endif
352 360
395# endif 403# endif
396# endif 404# endif
397# ifdef __cplusplus 405# ifdef __cplusplus
398extern "C" { 406extern "C" {
399# endif 407# endif
400int eventfd (unsigned int initval, int flags); 408int (eventfd) (unsigned int initval, int flags);
401# ifdef __cplusplus 409# ifdef __cplusplus
402} 410}
403# endif 411# endif
404#endif 412#endif
405 413
504 512
505#ifndef EV_FD_TO_WIN32_HANDLE 513#ifndef EV_FD_TO_WIN32_HANDLE
506# define EV_FD_TO_WIN32_HANDLE(fd) _get_osfhandle (fd) 514# define EV_FD_TO_WIN32_HANDLE(fd) _get_osfhandle (fd)
507#endif 515#endif
508#ifndef EV_WIN32_HANDLE_TO_FD 516#ifndef EV_WIN32_HANDLE_TO_FD
509# define EV_WIN32_HANDLE_TO_FD(handle) _open_osfhandle (fd, 0) 517# define EV_WIN32_HANDLE_TO_FD(handle) _open_osfhandle (handle, 0)
510#endif 518#endif
511#ifndef EV_WIN32_CLOSE_FD 519#ifndef EV_WIN32_CLOSE_FD
512# define EV_WIN32_CLOSE_FD(fd) close (fd) 520# define EV_WIN32_CLOSE_FD(fd) close (fd)
513#endif 521#endif
514 522
534 542
535 if (syserr_cb) 543 if (syserr_cb)
536 syserr_cb (msg); 544 syserr_cb (msg);
537 else 545 else
538 { 546 {
547#if EV_AVOID_STDIO
548 write (STDERR_FILENO, msg, strlen (msg));
549 write (STDERR_FILENO, ": ", 2);
550 msg = strerror (errno);
551 write (STDERR_FILENO, msg, strlen (msg));
552 write (STDERR_FILENO, "\n", 1);
553#else
539 perror (msg); 554 perror (msg);
555#endif
540 abort (); 556 abort ();
541 } 557 }
542} 558}
543 559
544static void * 560static void *
569{ 585{
570 ptr = alloc (ptr, size); 586 ptr = alloc (ptr, size);
571 587
572 if (!ptr && size) 588 if (!ptr && size)
573 { 589 {
590#if EV_AVOID_STDIO
591 write (STDERR_FILENO, "libev: memory allocation failed, aborting.",
592 sizeof ("libev: memory allocation failed, aborting.") - 1);
593#else
574 fprintf (stderr, "libev: cannot allocate %ld bytes, aborting.", size); 594 fprintf (stderr, "libev: cannot allocate %ld bytes, aborting.", size);
595#endif
575 abort (); 596 abort ();
576 } 597 }
577 598
578 return ptr; 599 return ptr;
579} 600}
963/* check whether the given fd is atcually valid, for error recovery */ 984/* check whether the given fd is atcually valid, for error recovery */
964inline_size int 985inline_size int
965fd_valid (int fd) 986fd_valid (int fd)
966{ 987{
967#ifdef _WIN32 988#ifdef _WIN32
968 return _get_osfhandle (fd) != -1; 989 return EV_FD_TO_WIN32_HANDLE (fd) != -1;
969#else 990#else
970 return fcntl (fd, F_GETFD) != -1; 991 return fcntl (fd, F_GETFD) != -1;
971#endif 992#endif
972} 993}
973 994
1178inline_speed void 1199inline_speed void
1179fd_intern (int fd) 1200fd_intern (int fd)
1180{ 1201{
1181#ifdef _WIN32 1202#ifdef _WIN32
1182 unsigned long arg = 1; 1203 unsigned long arg = 1;
1183 ioctlsocket (_get_osfhandle (fd), FIONBIO, &arg); 1204 ioctlsocket (EV_FD_TO_WIN32_HANDLE (fd), FIONBIO, &arg);
1184#else 1205#else
1185 fcntl (fd, F_SETFD, FD_CLOEXEC); 1206 fcntl (fd, F_SETFD, FD_CLOEXEC);
1186 fcntl (fd, F_SETFL, O_NONBLOCK); 1207 fcntl (fd, F_SETFL, O_NONBLOCK);
1187#endif 1208#endif
1188} 1209}
1293{ 1314{
1294#if EV_MULTIPLICITY 1315#if EV_MULTIPLICITY
1295 EV_P = signals [signum - 1].loop; 1316 EV_P = signals [signum - 1].loop;
1296#endif 1317#endif
1297 1318
1298#if _WIN32 1319#ifdef _WIN32
1299 signal (signum, ev_sighandler); 1320 signal (signum, ev_sighandler);
1300#endif 1321#endif
1301 1322
1302 signals [signum - 1].pending = 1; 1323 signals [signum - 1].pending = 1;
1303 evpipe_write (EV_A_ &sig_pending); 1324 evpipe_write (EV_A_ &sig_pending);
1604#endif 1625#endif
1605#if EV_USE_INOTIFY 1626#if EV_USE_INOTIFY
1606 fs_fd = flags & EVFLAG_NOINOTIFY ? -1 : -2; 1627 fs_fd = flags & EVFLAG_NOINOTIFY ? -1 : -2;
1607#endif 1628#endif
1608#if EV_USE_SIGNALFD 1629#if EV_USE_SIGNALFD
1609 sigfd = flags & EVFLAG_NOSIGFD ? -1 : -2; 1630 sigfd = flags & EVFLAG_SIGNALFD ? -2 : -1;
1610#endif 1631#endif
1611 1632
1612 if (!(flags & 0x0000ffffU)) 1633 if (!(flags & 0x0000ffffU))
1613 flags |= ev_recommended_backends (); 1634 flags |= ev_recommended_backends ();
1614 1635
1658 } 1679 }
1659 } 1680 }
1660 1681
1661#if EV_USE_SIGNALFD 1682#if EV_USE_SIGNALFD
1662 if (ev_is_active (&sigfd_w)) 1683 if (ev_is_active (&sigfd_w))
1663 {
1664 /*ev_ref (EV_A);*/
1665 /*ev_io_stop (EV_A_ &sigfd_w);*/
1666
1667 close (sigfd); 1684 close (sigfd);
1668 }
1669#endif 1685#endif
1670 1686
1671#if EV_USE_INOTIFY 1687#if EV_USE_INOTIFY
1672 if (fs_fd >= 0) 1688 if (fs_fd >= 0)
1673 close (fs_fd); 1689 close (fs_fd);
2161 ANHE_at_cache (*he); 2177 ANHE_at_cache (*he);
2162 } 2178 }
2163} 2179}
2164 2180
2165/* fetch new monotonic and realtime times from the kernel */ 2181/* fetch new monotonic and realtime times from the kernel */
2166/* also detetc if there was a timejump, and act accordingly */ 2182/* also detect if there was a timejump, and act accordingly */
2167inline_speed void 2183inline_speed void
2168time_update (EV_P_ ev_tstamp max_block) 2184time_update (EV_P_ ev_tstamp max_block)
2169{ 2185{
2170#if EV_USE_MONOTONIC 2186#if EV_USE_MONOTONIC
2171 if (expect_true (have_monotonic)) 2187 if (expect_true (have_monotonic))
2505 2521
2506 if (expect_false (ev_is_active (w))) 2522 if (expect_false (ev_is_active (w)))
2507 return; 2523 return;
2508 2524
2509 assert (("libev: ev_io_start called with negative fd", fd >= 0)); 2525 assert (("libev: ev_io_start called with negative fd", fd >= 0));
2510 assert (("libev: ev_io start called with illegal event mask", !(w->events & ~(EV__IOFDSET | EV_READ | EV_WRITE)))); 2526 assert (("libev: ev_io_start called with illegal event mask", !(w->events & ~(EV__IOFDSET | EV_READ | EV_WRITE))));
2511 2527
2512 EV_FREQUENT_CHECK; 2528 EV_FREQUENT_CHECK;
2513 2529
2514 ev_start (EV_A_ (W)w, 1); 2530 ev_start (EV_A_ (W)w, 1);
2515 array_needsize (ANFD, anfds, anfdmax, fd + 1, array_init_zero); 2531 array_needsize (ANFD, anfds, anfdmax, fd + 1, array_init_zero);
2585 timers [active] = timers [timercnt + HEAP0]; 2601 timers [active] = timers [timercnt + HEAP0];
2586 adjustheap (timers, timercnt, active); 2602 adjustheap (timers, timercnt, active);
2587 } 2603 }
2588 } 2604 }
2589 2605
2590 EV_FREQUENT_CHECK;
2591
2592 ev_at (w) -= mn_now; 2606 ev_at (w) -= mn_now;
2593 2607
2594 ev_stop (EV_A_ (W)w); 2608 ev_stop (EV_A_ (W)w);
2609
2610 EV_FREQUENT_CHECK;
2595} 2611}
2596 2612
2597void noinline 2613void noinline
2598ev_timer_again (EV_P_ ev_timer *w) 2614ev_timer_again (EV_P_ ev_timer *w)
2599{ 2615{
2678 periodics [active] = periodics [periodiccnt + HEAP0]; 2694 periodics [active] = periodics [periodiccnt + HEAP0];
2679 adjustheap (periodics, periodiccnt, active); 2695 adjustheap (periodics, periodiccnt, active);
2680 } 2696 }
2681 } 2697 }
2682 2698
2683 EV_FREQUENT_CHECK;
2684
2685 ev_stop (EV_A_ (W)w); 2699 ev_stop (EV_A_ (W)w);
2700
2701 EV_FREQUENT_CHECK;
2686} 2702}
2687 2703
2688void noinline 2704void noinline
2689ev_periodic_again (EV_P_ ev_periodic *w) 2705ev_periodic_again (EV_P_ ev_periodic *w)
2690{ 2706{
2751 if (!((WL)w)->next) 2767 if (!((WL)w)->next)
2752# if EV_USE_SIGNALFD 2768# if EV_USE_SIGNALFD
2753 if (sigfd < 0) /*TODO*/ 2769 if (sigfd < 0) /*TODO*/
2754# endif 2770# endif
2755 { 2771 {
2756# if _WIN32 2772# ifdef _WIN32
2773 evpipe_init (EV_A);
2774
2757 signal (w->signum, ev_sighandler); 2775 signal (w->signum, ev_sighandler);
2758# else 2776# else
2759 struct sigaction sa; 2777 struct sigaction sa;
2760 2778
2761 evpipe_init (EV_A); 2779 evpipe_init (EV_A);
2792 signals [w->signum - 1].loop = 0; /* unattach from signal */ 2810 signals [w->signum - 1].loop = 0; /* unattach from signal */
2793#endif 2811#endif
2794#if EV_USE_SIGNALFD 2812#if EV_USE_SIGNALFD
2795 if (sigfd >= 0) 2813 if (sigfd >= 0)
2796 { 2814 {
2797 sigprocmask (SIG_UNBLOCK, &sigfd_set, 0);//D 2815 sigset_t ss;
2816
2817 sigemptyset (&ss);
2818 sigaddset (&ss, w->signum);
2798 sigdelset (&sigfd_set, w->signum); 2819 sigdelset (&sigfd_set, w->signum);
2820
2799 signalfd (sigfd, &sigfd_set, 0); 2821 signalfd (sigfd, &sigfd_set, 0);
2800 sigprocmask (SIG_BLOCK, &sigfd_set, 0);//D 2822 sigprocmask (SIG_UNBLOCK, &ss, 0);
2801 /*TODO: maybe unblock signal? */
2802 } 2823 }
2803 else 2824 else
2804#endif 2825#endif
2805 signal (w->signum, SIG_DFL); 2826 signal (w->signum, SIG_DFL);
2806 } 2827 }
2852#define MIN_STAT_INTERVAL 0.1074891 2873#define MIN_STAT_INTERVAL 0.1074891
2853 2874
2854static void noinline stat_timer_cb (EV_P_ ev_timer *w_, int revents); 2875static void noinline stat_timer_cb (EV_P_ ev_timer *w_, int revents);
2855 2876
2856#if EV_USE_INOTIFY 2877#if EV_USE_INOTIFY
2857# define EV_INOTIFY_BUFSIZE 8192 2878
2879/* the * 2 is to allow for alignment padding, which for some reason is >> 8 */
2880# define EV_INOTIFY_BUFSIZE (sizeof (struct inotify_event) * 2 + NAME_MAX)
2858 2881
2859static void noinline 2882static void noinline
2860infy_add (EV_P_ ev_stat *w) 2883infy_add (EV_P_ ev_stat *w)
2861{ 2884{
2862 w->wd = inotify_add_watch (fs_fd, w->path, IN_ATTRIB | IN_DELETE_SELF | IN_MOVE_SELF | IN_MODIFY | IN_DONT_FOLLOW | IN_MASK_ADD); 2885 w->wd = inotify_add_watch (fs_fd, w->path, IN_ATTRIB | IN_DELETE_SELF | IN_MOVE_SELF | IN_MODIFY | IN_DONT_FOLLOW | IN_MASK_ADD);
2863 2886
2864 if (w->wd < 0) 2887 if (w->wd >= 0)
2888 {
2889 struct statfs sfs;
2890
2891 /* now local changes will be tracked by inotify, but remote changes won't */
2892 /* unless the filesystem is known to be local, we therefore still poll */
2893 /* also do poll on <2.6.25, but with normal frequency */
2894
2895 if (!fs_2625)
2896 w->timer.repeat = w->interval ? w->interval : DEF_STAT_INTERVAL;
2897 else if (!statfs (w->path, &sfs)
2898 && (sfs.f_type == 0x1373 /* devfs */
2899 || sfs.f_type == 0xEF53 /* ext2/3 */
2900 || sfs.f_type == 0x3153464a /* jfs */
2901 || sfs.f_type == 0x52654973 /* reiser3 */
2902 || sfs.f_type == 0x01021994 /* tempfs */
2903 || sfs.f_type == 0x58465342 /* xfs */))
2904 w->timer.repeat = 0.; /* filesystem is local, kernel new enough */
2905 else
2906 w->timer.repeat = w->interval ? w->interval : NFS_STAT_INTERVAL; /* remote, use reduced frequency */
2865 { 2907 }
2908 else
2909 {
2910 /* can't use inotify, continue to stat */
2866 w->timer.repeat = w->interval ? w->interval : DEF_STAT_INTERVAL; 2911 w->timer.repeat = w->interval ? w->interval : DEF_STAT_INTERVAL;
2867 ev_timer_again (EV_A_ &w->timer); /* this is not race-free, so we still need to recheck periodically */
2868 2912
2869 /* monitor some parent directory for speedup hints */ 2913 /* if path is not there, monitor some parent directory for speedup hints */
2870 /* note that exceeding the hardcoded path limit is not a correctness issue, */ 2914 /* note that exceeding the hardcoded path limit is not a correctness issue, */
2871 /* but an efficiency issue only */ 2915 /* but an efficiency issue only */
2872 if ((errno == ENOENT || errno == EACCES) && strlen (w->path) < 4096) 2916 if ((errno == ENOENT || errno == EACCES) && strlen (w->path) < 4096)
2873 { 2917 {
2874 char path [4096]; 2918 char path [4096];
2890 while (w->wd < 0 && (errno == ENOENT || errno == EACCES)); 2934 while (w->wd < 0 && (errno == ENOENT || errno == EACCES));
2891 } 2935 }
2892 } 2936 }
2893 2937
2894 if (w->wd >= 0) 2938 if (w->wd >= 0)
2895 {
2896 struct statfs sfs;
2897
2898 wlist_add (&fs_hash [w->wd & (EV_INOTIFY_HASHSIZE - 1)].head, (WL)w); 2939 wlist_add (&fs_hash [w->wd & (EV_INOTIFY_HASHSIZE - 1)].head, (WL)w);
2899 2940
2900 /* now local changes will be tracked by inotify, but remote changes won't */ 2941 /* now re-arm timer, if required */
2901 /* unless the filesystem it known to be local, we therefore still poll */ 2942 if (ev_is_active (&w->timer)) ev_ref (EV_A);
2902 /* also do poll on <2.6.25, but with normal frequency */
2903
2904 if (fs_2625 && !statfs (w->path, &sfs))
2905 if (sfs.f_type == 0x1373 /* devfs */
2906 || sfs.f_type == 0xEF53 /* ext2/3 */
2907 || sfs.f_type == 0x3153464a /* jfs */
2908 || sfs.f_type == 0x52654973 /* reiser3 */
2909 || sfs.f_type == 0x01021994 /* tempfs */
2910 || sfs.f_type == 0x58465342 /* xfs */)
2911 return;
2912
2913 w->timer.repeat = w->interval ? w->interval : fs_2625 ? NFS_STAT_INTERVAL : DEF_STAT_INTERVAL;
2914 ev_timer_again (EV_A_ &w->timer); 2943 ev_timer_again (EV_A_ &w->timer);
2915 } 2944 if (ev_is_active (&w->timer)) ev_unref (EV_A);
2916} 2945}
2917 2946
2918static void noinline 2947static void noinline
2919infy_del (EV_P_ ev_stat *w) 2948infy_del (EV_P_ ev_stat *w)
2920{ 2949{
2965 2994
2966static void 2995static void
2967infy_cb (EV_P_ ev_io *w, int revents) 2996infy_cb (EV_P_ ev_io *w, int revents)
2968{ 2997{
2969 char buf [EV_INOTIFY_BUFSIZE]; 2998 char buf [EV_INOTIFY_BUFSIZE];
2970 struct inotify_event *ev = (struct inotify_event *)buf;
2971 int ofs; 2999 int ofs;
2972 int len = read (fs_fd, buf, sizeof (buf)); 3000 int len = read (fs_fd, buf, sizeof (buf));
2973 3001
2974 for (ofs = 0; ofs < len; ofs += sizeof (struct inotify_event) + ev->len) 3002 for (ofs = 0; ofs < len; )
3003 {
3004 struct inotify_event *ev = (struct inotify_event *)(buf + ofs);
2975 infy_wd (EV_A_ ev->wd, ev->wd, ev); 3005 infy_wd (EV_A_ ev->wd, ev->wd, ev);
3006 ofs += sizeof (struct inotify_event) + ev->len;
3007 }
3008}
3009
3010inline_size unsigned int
3011ev_linux_version (void)
3012{
3013 struct utsname buf;
3014 unsigned int v;
3015 int i;
3016 char *p = buf.release;
3017
3018 if (uname (&buf))
3019 return 0;
3020
3021 for (i = 3+1; --i; )
3022 {
3023 unsigned int c = 0;
3024
3025 for (;;)
3026 {
3027 if (*p >= '0' && *p <= '9')
3028 c = c * 10 + *p++ - '0';
3029 else
3030 {
3031 p += *p == '.';
3032 break;
3033 }
3034 }
3035
3036 v = (v << 8) | c;
3037 }
3038
3039 return v;
2976} 3040}
2977 3041
2978inline_size void 3042inline_size void
2979check_2625 (EV_P) 3043ev_check_2625 (EV_P)
2980{ 3044{
2981 /* kernels < 2.6.25 are borked 3045 /* kernels < 2.6.25 are borked
2982 * http://www.ussg.indiana.edu/hypermail/linux/kernel/0711.3/1208.html 3046 * http://www.ussg.indiana.edu/hypermail/linux/kernel/0711.3/1208.html
2983 */ 3047 */
2984 struct utsname buf; 3048 if (ev_linux_version () < 0x020619)
2985 int major, minor, micro;
2986
2987 if (uname (&buf))
2988 return;
2989
2990 if (sscanf (buf.release, "%d.%d.%d", &major, &minor, &micro) != 3)
2991 return;
2992
2993 if (major < 2
2994 || (major == 2 && minor < 6)
2995 || (major == 2 && minor == 6 && micro < 25))
2996 return; 3049 return;
2997 3050
2998 fs_2625 = 1; 3051 fs_2625 = 1;
2999} 3052}
3000 3053
3015 if (fs_fd != -2) 3068 if (fs_fd != -2)
3016 return; 3069 return;
3017 3070
3018 fs_fd = -1; 3071 fs_fd = -1;
3019 3072
3020 check_2625 (EV_A); 3073 ev_check_2625 (EV_A);
3021 3074
3022 fs_fd = infy_newfd (); 3075 fs_fd = infy_newfd ();
3023 3076
3024 if (fs_fd >= 0) 3077 if (fs_fd >= 0)
3025 { 3078 {
3026 fd_intern (fs_fd); 3079 fd_intern (fs_fd);
3027 ev_io_init (&fs_w, infy_cb, fs_fd, EV_READ); 3080 ev_io_init (&fs_w, infy_cb, fs_fd, EV_READ);
3028 ev_set_priority (&fs_w, EV_MAXPRI); 3081 ev_set_priority (&fs_w, EV_MAXPRI);
3029 ev_io_start (EV_A_ &fs_w); 3082 ev_io_start (EV_A_ &fs_w);
3083 ev_unref (EV_A);
3030 } 3084 }
3031} 3085}
3032 3086
3033inline_size void 3087inline_size void
3034infy_fork (EV_P) 3088infy_fork (EV_P)
3036 int slot; 3090 int slot;
3037 3091
3038 if (fs_fd < 0) 3092 if (fs_fd < 0)
3039 return; 3093 return;
3040 3094
3095 ev_ref (EV_A);
3041 ev_io_stop (EV_A_ &fs_w); 3096 ev_io_stop (EV_A_ &fs_w);
3042 close (fs_fd); 3097 close (fs_fd);
3043 fs_fd = infy_newfd (); 3098 fs_fd = infy_newfd ();
3044 3099
3045 if (fs_fd >= 0) 3100 if (fs_fd >= 0)
3046 { 3101 {
3047 fd_intern (fs_fd); 3102 fd_intern (fs_fd);
3048 ev_io_set (&fs_w, fs_fd, EV_READ); 3103 ev_io_set (&fs_w, fs_fd, EV_READ);
3049 ev_io_start (EV_A_ &fs_w); 3104 ev_io_start (EV_A_ &fs_w);
3105 ev_unref (EV_A);
3050 } 3106 }
3051 3107
3052 for (slot = 0; slot < EV_INOTIFY_HASHSIZE; ++slot) 3108 for (slot = 0; slot < EV_INOTIFY_HASHSIZE; ++slot)
3053 { 3109 {
3054 WL w_ = fs_hash [slot].head; 3110 WL w_ = fs_hash [slot].head;
3062 w->wd = -1; 3118 w->wd = -1;
3063 3119
3064 if (fs_fd >= 0) 3120 if (fs_fd >= 0)
3065 infy_add (EV_A_ w); /* re-add, no matter what */ 3121 infy_add (EV_A_ w); /* re-add, no matter what */
3066 else 3122 else
3123 {
3124 w->timer.repeat = w->interval ? w->interval : DEF_STAT_INTERVAL;
3125 if (ev_is_active (&w->timer)) ev_ref (EV_A);
3067 ev_timer_again (EV_A_ &w->timer); 3126 ev_timer_again (EV_A_ &w->timer);
3127 if (ev_is_active (&w->timer)) ev_unref (EV_A);
3128 }
3068 } 3129 }
3069 } 3130 }
3070} 3131}
3071 3132
3072#endif 3133#endif
3089static void noinline 3150static void noinline
3090stat_timer_cb (EV_P_ ev_timer *w_, int revents) 3151stat_timer_cb (EV_P_ ev_timer *w_, int revents)
3091{ 3152{
3092 ev_stat *w = (ev_stat *)(((char *)w_) - offsetof (ev_stat, timer)); 3153 ev_stat *w = (ev_stat *)(((char *)w_) - offsetof (ev_stat, timer));
3093 3154
3094 /* we copy this here each the time so that */ 3155 ev_statdata prev = w->attr;
3095 /* prev has the old value when the callback gets invoked */
3096 w->prev = w->attr;
3097 ev_stat_stat (EV_A_ w); 3156 ev_stat_stat (EV_A_ w);
3098 3157
3099 /* memcmp doesn't work on netbsd, they.... do stuff to their struct stat */ 3158 /* memcmp doesn't work on netbsd, they.... do stuff to their struct stat */
3100 if ( 3159 if (
3101 w->prev.st_dev != w->attr.st_dev 3160 prev.st_dev != w->attr.st_dev
3102 || w->prev.st_ino != w->attr.st_ino 3161 || prev.st_ino != w->attr.st_ino
3103 || w->prev.st_mode != w->attr.st_mode 3162 || prev.st_mode != w->attr.st_mode
3104 || w->prev.st_nlink != w->attr.st_nlink 3163 || prev.st_nlink != w->attr.st_nlink
3105 || w->prev.st_uid != w->attr.st_uid 3164 || prev.st_uid != w->attr.st_uid
3106 || w->prev.st_gid != w->attr.st_gid 3165 || prev.st_gid != w->attr.st_gid
3107 || w->prev.st_rdev != w->attr.st_rdev 3166 || prev.st_rdev != w->attr.st_rdev
3108 || w->prev.st_size != w->attr.st_size 3167 || prev.st_size != w->attr.st_size
3109 || w->prev.st_atime != w->attr.st_atime 3168 || prev.st_atime != w->attr.st_atime
3110 || w->prev.st_mtime != w->attr.st_mtime 3169 || prev.st_mtime != w->attr.st_mtime
3111 || w->prev.st_ctime != w->attr.st_ctime 3170 || prev.st_ctime != w->attr.st_ctime
3112 ) { 3171 ) {
3172 /* we only update w->prev on actual differences */
3173 /* in case we test more often than invoke the callback, */
3174 /* to ensure that prev is always different to attr */
3175 w->prev = prev;
3176
3113 #if EV_USE_INOTIFY 3177 #if EV_USE_INOTIFY
3114 if (fs_fd >= 0) 3178 if (fs_fd >= 0)
3115 { 3179 {
3116 infy_del (EV_A_ w); 3180 infy_del (EV_A_ w);
3117 infy_add (EV_A_ w); 3181 infy_add (EV_A_ w);
3142 3206
3143 if (fs_fd >= 0) 3207 if (fs_fd >= 0)
3144 infy_add (EV_A_ w); 3208 infy_add (EV_A_ w);
3145 else 3209 else
3146#endif 3210#endif
3211 {
3147 ev_timer_again (EV_A_ &w->timer); 3212 ev_timer_again (EV_A_ &w->timer);
3213 ev_unref (EV_A);
3214 }
3148 3215
3149 ev_start (EV_A_ (W)w, 1); 3216 ev_start (EV_A_ (W)w, 1);
3150 3217
3151 EV_FREQUENT_CHECK; 3218 EV_FREQUENT_CHECK;
3152} 3219}
3161 EV_FREQUENT_CHECK; 3228 EV_FREQUENT_CHECK;
3162 3229
3163#if EV_USE_INOTIFY 3230#if EV_USE_INOTIFY
3164 infy_del (EV_A_ w); 3231 infy_del (EV_A_ w);
3165#endif 3232#endif
3233
3234 if (ev_is_active (&w->timer))
3235 {
3236 ev_ref (EV_A);
3166 ev_timer_stop (EV_A_ &w->timer); 3237 ev_timer_stop (EV_A_ &w->timer);
3238 }
3167 3239
3168 ev_stop (EV_A_ (W)w); 3240 ev_stop (EV_A_ (W)w);
3169 3241
3170 EV_FREQUENT_CHECK; 3242 EV_FREQUENT_CHECK;
3171} 3243}
3390 EV_FREQUENT_CHECK; 3462 EV_FREQUENT_CHECK;
3391 3463
3392 ev_io_stop (EV_A_ &w->io); 3464 ev_io_stop (EV_A_ &w->io);
3393 ev_prepare_stop (EV_A_ &w->prepare); 3465 ev_prepare_stop (EV_A_ &w->prepare);
3394 ev_fork_stop (EV_A_ &w->fork); 3466 ev_fork_stop (EV_A_ &w->fork);
3467
3468 ev_stop (EV_A_ (W)w);
3395 3469
3396 EV_FREQUENT_CHECK; 3470 EV_FREQUENT_CHECK;
3397} 3471}
3398#endif 3472#endif
3399 3473

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines