[ViewVC] Diff of: cvs/libev/ev.c

Comparing libev/ev.c (file contents):
Revision 1.421 by root, Wed Apr 18 06:06:04 2012 UTC vs.
Revision 1.428 by root, Tue May 8 15:44:09 2012 UTC

 # include <unistd.h>
 #else
 # include <io.h>
 # define WIN32_LEAN_AND_MEAN
 # include <windows.h>
+# include <winsock2.h>
 # ifndef EV_SELECT_IS_WINSOCKET
 #  define EV_SELECT_IS_WINSOCKET 1
 # endif
 # undef EV_AVOID_STDIO
 #endif
 #endif
 /* on linux, we can use a (slow) syscall to avoid a dependency on pthread, */
 /* which makes programs even slower. might work on other unices, too. */
 #if EV_USE_CLOCK_SYSCALL
-# include <syscall.h>
+# include <sys/syscall.h>
 # ifdef SYS_clock_gettime
 #  define clock_gettime(id, ts) syscall (SYS_clock_gettime, (id), (ts))
 #  undef EV_USE_MONOTONIC
 #  define EV_USE_MONOTONIC 1
 # else
       w_->pending = ++pendingcnt [pri];
       array_needsize (ANPENDING, pendings [pri], pendingmax [pri], w_->pending, EMPTY2);
       pendings [pri][w_->pending - 1].w      = w_;
       pendings [pri][w_->pending - 1].events = revents;
     }
+  pendingpri = NUMPRI - 1;
 }
 inline_speed void
 feed_reverse (EV_P_ W w)
 {
 }
 inline_speed void
 evpipe_write (EV_P_ EV_ATOMIC_T *flag)
 {
+  ECB_MEMORY_FENCE; /* push out the write before this function was called, acquire flag */
   if (expect_true (*flag))
     return;
   *flag = 1;
           write (evfd, &counter, sizeof (uint64_t));
         }
       else
 #endif
         {
-          /* win32 people keep sending patches that change this write() to send() */
+#ifdef _WIN32
-          /* and then run away. but send() is wrong, it wants a socket handle on win32 */
+          WSABUF buf;
-          /* so when you think this write should be a send instead, please find out */
+          DWORD sent;
-          /* where your send() is from - it's definitely not the microsoft send, and */
+          buf.buf = &buf;
-          /* tell me. thank you. */
+          buf.len = 1;
-          /* it might be that your problem is that your environment needs EV_USE_WSASOCKET */
+          WSASend (EV_FD_TO_WIN32_HANDLE (evpipe [1]), &buf, 1, &sent, 0, 0, 0);
-          /* check the ev documentation on how to use this flag */
+#else
           write (evpipe [1], &(evpipe [1]), 1);
+#endif
         }
       errno = old_errno;
     }
 }
           read (evfd, &counter, sizeof (uint64_t));
         }
       else
 #endif
         {
-          char dummy;
+          char dummy[4];
-          /* see discussion in evpipe_write when you think this read should be recv in win32 */
+#ifdef _WIN32
+          WSABUF buf;
+          DWORD recvd;
+          buf.buf = dummy;
+          buf.len = sizeof (dummy);
+          WSARecv (EV_FD_TO_WIN32_HANDLE (evpipe [0]), &buf, 1, &recvd, 0, 0, 0);
+#else
-          read (evpipe [0], &dummy, 1);
+          read (evpipe [0], &dummy, sizeof (dummy));
+#endif
         }
     }
   pipe_write_skipped = 0;
+  ECB_MEMORY_FENCE; /* push out skipped, acquire flags */
 #if EV_SIGNAL_ENABLE
   if (sig_pending)
     {
       sig_pending = 0;
+      ECB_MEMORY_FENCE_RELEASE;
       for (i = EV_NSIG - 1; i--; )
         if (expect_false (signals [i].pending))
           ev_feed_signal_event (EV_A_ i + 1);
     }
 #if EV_ASYNC_ENABLE
   if (async_pending)
     {
       async_pending = 0;
+      ECB_MEMORY_FENCE_RELEASE;
       for (i = asynccnt; i--; )
         if (asyncs [i]->sent)
           {
             asyncs [i]->sent = 0;
     }
 }
 /* free up a loop structure */
 void ecb_cold
-ev_loop_destroy (EV_P) EV_THROW
+ev_loop_destroy (EV_P)
 {
   int i;
 #if EV_MULTIPLICITY
   /* mimic free (0) */
 #if EV_FEATURE_API
 void ecb_cold
 ev_verify (EV_P) EV_THROW
 {
 #if EV_VERIFY
-  int i;
+  int i, j;
-  WL w;
+  WL w, w2;
   assert (activecnt >= -1);
   assert (fdchangemax >= fdchangecnt);
   for (i = 0; i < fdchangecnt; ++i)
     assert (("libev: negative fd in fdchanges", fdchanges [i] >= 0));
   assert (anfdmax >= 0);
-  for (i = 0; i < anfdmax; ++i)
+  for (i = j = 0; i < anfdmax; ++i)
-    for (w = anfds [i].head; w; w = w->next)
+    for (w = w2 = anfds [i].head; w; w = w->next)
       {
         verify_watcher (EV_A_ (W)w);
+        if (j++ & 1)
+          {
+            assert (("libev: io watcher list contains a loop", w != w2));
+            w2 = w2->next;
+          }
         assert (("libev: inactive fd watcher on anfd list", ev_active (w) == 1));
         assert (("libev: fd mismatch between watcher and anfd", ((ev_io *)w)->fd == i));
       }
   assert (timermax >= timercnt);
 }
 void noinline
 ev_invoke_pending (EV_P)
 {
-  int pri;
+  for (pendingpri = NUMPRI; pendingpri--; ) /* pendingpri is modified during the loop */
-  for (pri = NUMPRI; pri--; )
-    while (pendingcnt [pri])
+    while (pendingcnt [pendingpri])
       {
-        ANPENDING *p = pendings [pri] + --pendingcnt [pri];
+        ANPENDING *p = pendings [pendingpri] + --pendingcnt [pendingpri];
         p->w->pending = 0;
         EV_CB_INVOKE (p->w, p->events);
         EV_FREQUENT_CHECK;
       }
   EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, 1);
   array_needsize (ANFD, anfds, anfdmax, fd + 1, array_init_zero);
   wlist_add (&anfds[fd].head, (WL)w);
+  /* common bug, apparently */
+  assert (("libev: ev_io_start called with corrupted watcher", ((WL)w)->next != (WL)w));
   fd_change (EV_A_ fd, w->events & EV__IOFDSET | EV_ANFD_REIFY);
   w->events &= ~EV__IOFDSET;
   EV_FREQUENT_CHECK;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing libev/ev.c (file contents): Revision 1.421 by root, Wed Apr 18 06:06:04 2012 UTC vs. Revision 1.428 by root, Tue May 8 15:44:09 2012 UTC

Diff Legend

Comparing libev/ev.c (file contents):
Revision 1.421 by root, Wed Apr 18 06:06:04 2012 UTC vs.
Revision 1.428 by root, Tue May 8 15:44:09 2012 UTC