[ViewVC] Diff of: cvs/libev/ev.c

Comparing libev/ev.c (file contents):
Revision 1.424 by root, Tue May 1 22:01:40 2012 UTC vs.
Revision 1.436 by root, Tue May 29 20:44:39 2012 UTC

 # include <sys/wait.h>
 # include <unistd.h>
 #else
 # include <io.h>
 # define WIN32_LEAN_AND_MEAN
+# include <winsock2.h>
 # include <windows.h>
 # ifndef EV_SELECT_IS_WINSOCKET
 #  define EV_SELECT_IS_WINSOCKET 1
 # endif
 # undef EV_AVOID_STDIO
 /* some very old inotify.h headers don't have IN_DONT_FOLLOW */
 # ifndef IN_DONT_FOLLOW
 #  undef EV_USE_INOTIFY
 #  define EV_USE_INOTIFY 0
 # endif
-#endif
-#if EV_SELECT_IS_WINSOCKET
-# include <winsock.h>
 #endif
 #if EV_USE_EVENTFD
 /* our minimum requirement is glibc 2.7 which has the stub, but not the header */
 # include <stdint.h>
 #endif
 static void (*syserr_cb)(const char *msg) EV_THROW;
 void ecb_cold
-ev_set_syserr_cb (void (*cb)(const char *msg)) EV_THROW
+ev_set_syserr_cb (void (*cb)(const char *msg) EV_THROW) EV_THROW
 {
   syserr_cb = cb;
 }
 static void noinline ecb_cold
       abort ();
     }
 }
 static void *
-ev_realloc_emul (void *ptr, long size)
+ev_realloc_emul (void *ptr, long size) EV_THROW
 {
 #if __GLIBC__
   return realloc (ptr, size);
 #else
   /* some systems, notably openbsd and darwin, fail to properly
 }
 static void *(*alloc)(void *ptr, long size) EV_THROW = ev_realloc_emul;
 void ecb_cold
-ev_set_allocator (void *(*cb)(void *ptr, long size)) EV_THROW
+ev_set_allocator (void *(*cb)(void *ptr, long size) EV_THROW) EV_THROW
 {
   alloc = cb;
 }
 inline_speed void *
       w_->pending = ++pendingcnt [pri];
       array_needsize (ANPENDING, pendings [pri], pendingmax [pri], w_->pending, EMPTY2);
       pendings [pri][w_->pending - 1].w      = w_;
       pendings [pri][w_->pending - 1].events = revents;
     }
+  pendingpri = NUMPRI - 1;
 }
 inline_speed void
 feed_reverse (EV_P_ W w)
 {
   if (expect_true (*flag))
     return;
   *flag = 1;
   ECB_MEMORY_FENCE_RELEASE; /* make sure flag is visible before the wakeup */
   pipe_write_skipped = 1;
   ECB_MEMORY_FENCE; /* make sure pipe_write_skipped is visible before we check pipe_write_wanted */
   if (pipe_write_wanted)
     {
       int old_errno;
-      pipe_write_skipped = 0; /* just an optimisation, no fence needed */
+      pipe_write_skipped = 0;
+      ECB_MEMORY_FENCE_RELEASE;
       old_errno = errno; /* save errno because write will clobber it */
 #if EV_USE_EVENTFD
       if (evfd >= 0)
           write (evfd, &counter, sizeof (uint64_t));
         }
       else
 #endif
         {
-          /* win32 people keep sending patches that change this write() to send() */
+#ifdef _WIN32
-          /* and then run away. but send() is wrong, it wants a socket handle on win32 */
+          WSABUF buf;
-          /* so when you think this write should be a send instead, please find out */
+          DWORD sent;
-          /* where your send() is from - it's definitely not the microsoft send, and */
+          buf.buf = &buf;
-          /* tell me. thank you. */
+          buf.len = 1;
-          /* it might be that your problem is that your environment needs EV_USE_WSASOCKET */
+          WSASend (EV_FD_TO_WIN32_HANDLE (evpipe [1]), &buf, 1, &sent, 0, 0, 0);
-          /* check the ev documentation on how to use this flag */
+#else
           write (evpipe [1], &(evpipe [1]), 1);
+#endif
         }
       errno = old_errno;
     }
 }
           read (evfd, &counter, sizeof (uint64_t));
         }
       else
 #endif
         {
-          char dummy;
+          char dummy[4];
-          /* see discussion in evpipe_write when you think this read should be recv in win32 */
+#ifdef _WIN32
+          WSABUF buf;
+          DWORD recvd;
+          DWORD flags = 0;
+          buf.buf = dummy;
+          buf.len = sizeof (dummy);
+          WSARecv (EV_FD_TO_WIN32_HANDLE (evpipe [0]), &buf, 1, &recvd, &flags, 0, 0);
+#else
-          read (evpipe [0], &dummy, 1);
+          read (evpipe [0], &dummy, sizeof (dummy));
+#endif
         }
     }
   pipe_write_skipped = 0;
 #if EV_SIGNAL_ENABLE
   if (sig_pending)
     {
       sig_pending = 0;
-      ECB_MEMORY_FENCE_RELEASE;
+      ECB_MEMORY_FENCE;
       for (i = EV_NSIG - 1; i--; )
         if (expect_false (signals [i].pending))
           ev_feed_signal_event (EV_A_ i + 1);
     }
 #if EV_ASYNC_ENABLE
   if (async_pending)
     {
       async_pending = 0;
-      ECB_MEMORY_FENCE_RELEASE;
+      ECB_MEMORY_FENCE;
       for (i = asynccnt; i--; )
         if (asyncs [i]->sent)
           {
             asyncs [i]->sent = 0;
+            ECB_MEMORY_FENCE_RELEASE;
             ev_feed_event (EV_A_ asyncs [i], EV_ASYNC);
           }
     }
 #endif
 }
   if (expect_false (signals [signum].loop != EV_A))
     return;
 #endif
   signals [signum].pending = 0;
+  MEMORY_FENCE_RELEASE;
   for (w = signals [signum].head; w; w = w->next)
     ev_feed_event (EV_A_ (W)w, EV_SIGNAL);
 }
       EV_INVOKE_PENDING;
     }
 #endif
 #if EV_CHILD_ENABLE
-  if (ev_is_active (&childev))
+  if (ev_is_default_loop (EV_A) && ev_is_active (&childev))
     {
       ev_ref (EV_A); /* child watcher */
       ev_signal_stop (EV_A_ &childev);
     }
 #endif
 void ecb_cold
 ev_verify (EV_P) EV_THROW
 {
 #if EV_VERIFY
   int i;
-  WL w;
+  WL w, w2;
   assert (activecnt >= -1);
   assert (fdchangemax >= fdchangecnt);
   for (i = 0; i < fdchangecnt; ++i)
     assert (("libev: negative fd in fdchanges", fdchanges [i] >= 0));
   assert (anfdmax >= 0);
   for (i = 0; i < anfdmax; ++i)
+    {
+      int j = 0;
-    for (w = anfds [i].head; w; w = w->next)
+      for (w = w2 = anfds [i].head; w; w = w->next)
-      {
+        {
-        verify_watcher (EV_A_ (W)w);
+          verify_watcher (EV_A_ (W)w);
+          if (j++ & 1)
+            {
+              assert (("libev: io watcher list contains a loop", w != w2));
+              w2 = w2->next;
+            }
-        assert (("libev: inactive fd watcher on anfd list", ev_active (w) == 1));
+          assert (("libev: inactive fd watcher on anfd list", ev_active (w) == 1));
-        assert (("libev: fd mismatch between watcher and anfd", ((ev_io *)w)->fd == i));
+          assert (("libev: fd mismatch between watcher and anfd", ((ev_io *)w)->fd == i));
-      }
+        }
+    }
   assert (timermax >= timercnt);
   verify_heap (EV_A_ timers, timercnt);
 #if EV_PERIODIC_ENABLE
 }
 void noinline
 ev_invoke_pending (EV_P)
 {
-  int pri;
+  for (pendingpri = NUMPRI; pendingpri--; ) /* pendingpri is modified during the loop */
-  for (pri = NUMPRI; pri--; )
-    while (pendingcnt [pri])
+    while (pendingcnt [pendingpri])
       {
-        ANPENDING *p = pendings [pri] + --pendingcnt [pri];
+        ANPENDING *p = pendings [pendingpri] + --pendingcnt [pendingpri];
         p->w->pending = 0;
         EV_CB_INVOKE (p->w, p->events);
         EV_FREQUENT_CHECK;
       }
 {
   EV_FREQUENT_CHECK;
   while (periodiccnt && ANHE_at (periodics [HEAP0]) < ev_rt_now)
     {
-      int feed_count = 0;
       do
         {
           ev_periodic *w = (ev_periodic *)ANHE_w (periodics [HEAP0]);
           /*assert (("libev: inactive timer on periodic heap detected", ev_is_active (w)));*/
   EV_FREQUENT_CHECK;
   ev_start (EV_A_ (W)w, 1);
   array_needsize (ANFD, anfds, anfdmax, fd + 1, array_init_zero);
   wlist_add (&anfds[fd].head, (WL)w);
+  /* common bug, apparently */
+  assert (("libev: ev_io_start called with corrupted watcher", ((WL)w)->next != (WL)w));
   fd_change (EV_A_ fd, w->events & EV__IOFDSET | EV_ANFD_REIFY);
   w->events &= ~EV__IOFDSET;
   EV_FREQUENT_CHECK;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing libev/ev.c (file contents): Revision 1.424 by root, Tue May 1 22:01:40 2012 UTC vs. Revision 1.436 by root, Tue May 29 20:44:39 2012 UTC

Diff Legend

Comparing libev/ev.c (file contents):
Revision 1.424 by root, Tue May 1 22:01:40 2012 UTC vs.
Revision 1.436 by root, Tue May 29 20:44:39 2012 UTC