ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/libev/ev_iouring.c
(Generate patch)

Comparing libev/ev_iouring.c (file contents):
Revision 1.6 by root, Fri Dec 20 05:20:23 2019 UTC vs.
Revision 1.14 by root, Sat Dec 28 05:20:17 2019 UTC

… …
47 * without any syscalls. what's not to like? 47 * without any syscalls. what's not to like?
48 * d) ok, it's vastly more complex, but that's ok, really. 48 * d) ok, it's vastly more complex, but that's ok, really.
49 * e) why 3 mmaps instead of one? one would be more space-efficient, 49 * e) why 3 mmaps instead of one? one would be more space-efficient,
50 * and I can't see what benefit three would have (other than being 50 * and I can't see what benefit three would have (other than being
51 * somehow resizable/relocatable, but that's apparently not possible). 51 * somehow resizable/relocatable, but that's apparently not possible).
52 * (FIXME: newer kernels can use 2 mmaps only, need to look into this).
52 * f) hmm, it's practiclaly undebuggable (gdb can't access the memory, and 53 * f) hmm, it's practiclaly undebuggable (gdb can't access the memory, and
53 the bizarre way structure offsets are commuinicated makes it hard to 54 * the bizarre way structure offsets are communicated makes it hard to
54 * just print the ring buffer heads, even *iff* the memory were visible 55 * just print the ring buffer heads, even *iff* the memory were visible
55 * in gdb. but then, that's also ok, really. 56 * in gdb. but then, that's also ok, really.
56 * g) well, you cannot specify a timeout when waiting for events. no, 57 * g) well, you cannot specify a timeout when waiting for events. no,
57 * seriously, the interface doesn't support a timeout. never seen _that_ 58 * seriously, the interface doesn't support a timeout. never seen _that_
58 * before. sure, you can use a timerfd, but that's another syscall 59 * before. sure, you can use a timerfd, but that's another syscall
59 * you could have avoided. overall, this bizarre omission smells 60 * you could have avoided. overall, this bizarre omission smells
60 * like a µ-optimisation by the io_uring author for his personal 61 * like a µ-optimisation by the io_uring author for his personal
61 * applications, to the detriment of everybody else who just wants 62 * applications, to the detriment of everybody else who just wants
62 * an event loop. but, umm, ok, if that's all, it could be worse. 63 * an event loop. but, umm, ok, if that's all, it could be worse.
64 * (FIXME: jens mentioned timeout commands, need to investigate)
63 * h) there is a hardcoded limit of 4096 outstanding events. okay, 65 * h) there is a hardcoded limit of 4096 outstanding events. okay,
64 * at least there is no arbitrary low system-wide limit... 66 * at least there is no arbitrary low system-wide limit...
67 * (FIXME: apparently, this was increased to 32768 in later kernels(
65 * i) unlike linux aio, you *can* register more then the limit 68 * i) unlike linux aio, you *can* register more then the limit
66 * of fd events, and the kernel will "gracefully" signal an 69 * of fd events, and the kernel will "gracefully" signal an
67 * overflow, after which you could destroy and recreate the kernel 70 * overflow, after which you could destroy and recreate the kernel
68 * state, a bit bigger, or fall back to e.g. poll. thats not 71 * state, a bit bigger, or fall back to e.g. poll. thats not
69 * totally insane, but kind of questions the point a high 72 * totally insane, but kind of questions the point a high
70 * performance I/O framework when it doesn't really work 73 * performance I/O framework when it doesn't really work
71 * under stress. 74 * under stress.
75 * (FIXME: iouring should no longer drop events, need to investigate)
72 * j) but, oh my! is has exactly the same bugs as the linux aio backend, 76 * j) but, oh my! is has exactly the same bugs as the linux aio backend,
73 * where some undocumented poll combinations just fail. 77 * where some undocumented poll combinations just fail.
74 * so we need epoll AGAIN as a fallback. AGAIN! epoll!! and of course, 78 * so we need epoll AGAIN as a fallback. AGAIN! epoll!! and of course,
75 * this is completely undocumented, have I mantioned this already? 79 * this is completely undocumented, have I mantioned this already?
76 * k) overall, the *API* itself is, I dare to say, not a total trainwreck. 80 * k) overall, the *API* itself is, I dare to say, not a total trainwreck.
77 * the big isuess with it are the bugs requiring epoll, which might 81 * the big isuess with it are the bugs requiring epoll, which might
78 * or might not get fixed (do I hold my breath?). 82 * or might not get fixed (do I hold my breath?).
79 */ 83 */
80 84
85/* TODO: use internal TIMEOUT */
86/* TODO: take advantage of single mmap, NODROP etc. */
87/* TODO: resize cq/sq size independently */
88
81#include <sys/timerfd.h> 89#include <sys/timerfd.h>
82#include <sys/mman.h> 90#include <sys/mman.h>
83#include <poll.h> 91#include <poll.h>
92#include <stdint.h>
84 93
85#define IOURING_INIT_ENTRIES 32 94#define IOURING_INIT_ENTRIES 32
86 95
87/*****************************************************************************/ 96/*****************************************************************************/
88/* syscall wrapdadoop - this section has the raw api/abi definitions */ 97/* syscall wrapdadoop - this section has the raw api/abi definitions */
… …
96{ 105{
97 __u8 opcode; 106 __u8 opcode;
98 __u8 flags; 107 __u8 flags;
99 __u16 ioprio; 108 __u16 ioprio;
100 __s32 fd; 109 __s32 fd;
110 union {
101 __u64 off; 111 __u64 off;
112 __u64 addr2;
113 };
102 __u64 addr; 114 __u64 addr;
103 __u32 len; 115 __u32 len;
104 union { 116 union {
105 __kernel_rwf_t rw_flags; 117 __kernel_rwf_t rw_flags;
106 __u32 fsync_flags; 118 __u32 fsync_flags;
107 __u16 poll_events; 119 __u16 poll_events;
108 __u32 sync_range_flags; 120 __u32 sync_range_flags;
109 __u32 msg_flags; 121 __u32 msg_flags;
122 __u32 timeout_flags;
123 __u32 accept_flags;
124 __u32 cancel_flags;
125 __u32 open_flags;
126 __u32 statx_flags;
110 }; 127 };
111 __u64 user_data; 128 __u64 user_data;
112 union { 129 union {
113 __u16 buf_index; 130 __u16 buf_index;
114 __u64 __pad2[3]; 131 __u64 __pad2[3];
… …
151 __u32 sq_entries; 168 __u32 sq_entries;
152 __u32 cq_entries; 169 __u32 cq_entries;
153 __u32 flags; 170 __u32 flags;
154 __u32 sq_thread_cpu; 171 __u32 sq_thread_cpu;
155 __u32 sq_thread_idle; 172 __u32 sq_thread_idle;
173 __u32 features;
156 __u32 resv[5]; 174 __u32 resv[4];
157 struct io_sqring_offsets sq_off; 175 struct io_sqring_offsets sq_off;
158 struct io_cqring_offsets cq_off; 176 struct io_cqring_offsets cq_off;
159}; 177};
160 178
179#define IORING_SETUP_CQSIZE 0x00000008
180
161#define IORING_OP_POLL_ADD 6 181#define IORING_OP_POLL_ADD 6
162#define IORING_OP_POLL_REMOVE 7 182#define IORING_OP_POLL_REMOVE 7
183#define IORING_OP_TIMEOUT 11
184#define IORING_OP_TIMEOUT_REMOVE 12
185
186/* relative or absolute, reference clock is CLOCK_MONOTONIC */
187struct iouring_kernel_timespec
188{
189 int64_t tv_sec;
190 long long tv_nsec;
191};
192
193#define IORING_TIMEOUT_ABS 0x00000001
163 194
164#define IORING_ENTER_GETEVENTS 0x01 195#define IORING_ENTER_GETEVENTS 0x01
165 196
166#define IORING_OFF_SQ_RING 0x00000000ULL 197#define IORING_OFF_SQ_RING 0x00000000ULL
167#define IORING_OFF_CQ_RING 0x08000000ULL 198#define IORING_OFF_CQ_RING 0x08000000ULL
168#define IORING_OFF_SQES 0x10000000ULL 199#define IORING_OFF_SQES 0x10000000ULL
169 200
201#define IORING_FEAT_SINGLE_MMAP 0x00000001
202#define IORING_FEAT_NODROP 0x00000002
203#define IORING_FEAT_SUBMIT_STABLE 0x00000004
204
170inline_size 205inline_size
171int 206int
172evsys_io_uring_setup (unsigned entries, struct io_uring_params *params) 207evsys_io_uring_setup (unsigned entries, struct io_uring_params *params)
173{ 208{
174 return ev_syscall2 (SYS_io_uring_setup, entries, params); 209 return ev_syscall2 (SYS_io_uring_setup, entries, params);
… …
193 228
194/* the submit/completion queue entries */ 229/* the submit/completion queue entries */
195#define EV_SQES ((struct io_uring_sqe *) iouring_sqes) 230#define EV_SQES ((struct io_uring_sqe *) iouring_sqes)
196#define EV_CQES ((struct io_uring_cqe *)((char *)iouring_cq_ring + iouring_cq_cqes)) 231#define EV_CQES ((struct io_uring_cqe *)((char *)iouring_cq_ring + iouring_cq_cqes))
197 232
233/* TODO: this is not enough, we might have to reap events */
234/* TODO: but we can't, as that will re-arm events, causing */
235/* TODO: an endless loop in fd_reify */
236static int
237iouring_enter (EV_P_ ev_tstamp timeout)
238{
239 int res;
240
241 EV_RELEASE_CB;
242
243 res = evsys_io_uring_enter (iouring_fd, iouring_to_submit, 1,
244 timeout > EV_TS_CONST (0.) ? IORING_ENTER_GETEVENTS : 0, 0, 0);
245
246 assert (("libev: io_uring_enter did not consume all sqes", (res < 0 || res == iouring_to_submit)));
247
248 iouring_to_submit = 0;
249
250 EV_ACQUIRE_CB;
251
252 return res;
253}
254
198static 255static
199struct io_uring_sqe * 256struct io_uring_sqe *
200iouring_sqe_get (EV_P) 257iouring_sqe_get (EV_P)
201{ 258{
202 unsigned tail = EV_SQ_VAR (tail); 259 unsigned tail = EV_SQ_VAR (tail);
203 260
204 if (tail + 1 - EV_SQ_VAR (head) > EV_SQ_VAR (ring_entries)) 261 while (ecb_expect_false (tail + 1 - EV_SQ_VAR (head) > EV_SQ_VAR (ring_entries)))
205 { 262 {
206 /* queue full, flush */ 263 /* queue full, need to flush */
207 evsys_io_uring_enter (iouring_fd, iouring_to_submit, 0, 0, 0, 0);
208 iouring_to_submit = 0;
209 }
210 264
265 int res = iouring_enter (EV_A_ EV_TS_CONST (0.));
266
267 /* io_uring_enter might fail with EBUSY and won't submit anything */
268 /* unfortunately, we can't handle this at the moment */
269
270 if (res < 0 && errno == EBUSY)
271 //TODO
272 ev_syserr ("(libev) io_uring_enter could not clear sq");
273 else
274 break;
275
276 /* iouring_poll should have done ECB_MEMORY_FENCE_ACQUIRE */
277 }
278
211 assert (("libev: io_uring queue full after flush", tail + 1 - EV_SQ_VAR (head) <= EV_SQ_VAR (ring_entries))); 279 /*assert (("libev: io_uring queue full after flush", tail + 1 - EV_SQ_VAR (head) <= EV_SQ_VAR (ring_entries)));*/
212 280
213 return EV_SQES + (tail & EV_SQ_VAR (ring_mask)); 281 return EV_SQES + (tail & EV_SQ_VAR (ring_mask));
214} 282}
215 283
216inline_size 284inline_size
… …
236iouring_tfd_cb (EV_P_ struct ev_io *w, int revents) 304iouring_tfd_cb (EV_P_ struct ev_io *w, int revents)
237{ 305{
238 iouring_tfd_to = EV_TSTAMP_HUGE; 306 iouring_tfd_to = EV_TSTAMP_HUGE;
239} 307}
240 308
241static void
242iouring_epoll_cb (EV_P_ struct ev_io *w, int revents)
243{
244 epoll_poll (EV_A_ 0);
245}
246
247/* called for full and partial cleanup */ 309/* called for full and partial cleanup */
248ecb_cold 310ecb_cold
249static int 311static int
250iouring_internal_destroy (EV_P) 312iouring_internal_destroy (EV_P)
251{ 313{
… …
254 316
255 if (iouring_sq_ring != MAP_FAILED) munmap (iouring_sq_ring, iouring_sq_ring_size); 317 if (iouring_sq_ring != MAP_FAILED) munmap (iouring_sq_ring, iouring_sq_ring_size);
256 if (iouring_cq_ring != MAP_FAILED) munmap (iouring_cq_ring, iouring_cq_ring_size); 318 if (iouring_cq_ring != MAP_FAILED) munmap (iouring_cq_ring, iouring_cq_ring_size);
257 if (iouring_sqes != MAP_FAILED) munmap (iouring_sqes , iouring_sqes_size ); 319 if (iouring_sqes != MAP_FAILED) munmap (iouring_sqes , iouring_sqes_size );
258 320
259 if (ev_is_active (&iouring_epoll_w)) ev_ref (EV_A); ev_io_stop (EV_A_ &iouring_epoll_w); 321 if (ev_is_active (&iouring_tfd_w))
260 if (ev_is_active (&iouring_tfd_w )) ev_ref (EV_A); ev_io_stop (EV_A_ &iouring_tfd_w ); 322 {
323 ev_ref (EV_A);
324 ev_io_stop (EV_A_ &iouring_tfd_w);
325 }
261} 326}
262 327
263ecb_cold 328ecb_cold
264static int 329static int
265iouring_internal_init (EV_P) 330iouring_internal_init (EV_P)
… …
271 iouring_tfd = -1; 336 iouring_tfd = -1;
272 iouring_sq_ring = MAP_FAILED; 337 iouring_sq_ring = MAP_FAILED;
273 iouring_cq_ring = MAP_FAILED; 338 iouring_cq_ring = MAP_FAILED;
274 iouring_sqes = MAP_FAILED; 339 iouring_sqes = MAP_FAILED;
275 340
341 if (!have_monotonic) /* cannot really happen, but what if11 */
342 return -1;
343
276 for (;;) 344 for (;;)
277 { 345 {
278 iouring_fd = evsys_io_uring_setup (iouring_entries, &params); 346 iouring_fd = evsys_io_uring_setup (iouring_entries, &params);
279 347
280 if (iouring_fd >= 0) 348 if (iouring_fd >= 0)
281 break; /* yippie */ 349 break; /* yippie */
282 350
283 if (errno != EINVAL) 351 if (errno != EINVAL)
284 return -1; /* we failed */ 352 return -1; /* we failed */
353
354#if TODO
355 if ((~params.features) & (IORING_FEAT_NODROP | IORING_FEATURE_SINGLE_MMAP))
356 return -1; /* we require the above features */
357#endif
285 358
286 /* EINVAL: lots of possible reasons, but maybe 359 /* EINVAL: lots of possible reasons, but maybe
287 * it is because we hit the unqueryable hardcoded size limit 360 * it is because we hit the unqueryable hardcoded size limit
288 */ 361 */
289 362
… …
342 iouring_internal_destroy (EV_A); 415 iouring_internal_destroy (EV_A);
343 416
344 while (iouring_internal_init (EV_A) < 0) 417 while (iouring_internal_init (EV_A) < 0)
345 ev_syserr ("(libev) io_uring_setup"); 418 ev_syserr ("(libev) io_uring_setup");
346 419
347 /* forking epoll should also effectively unregister all fds from the backend */
348 epoll_fork (EV_A);
349 /* epoll_fork already did this. hopefully */
350 /*fd_rearm_all (EV_A);*/ 420 fd_rearm_all (EV_A);
351
352 ev_io_stop (EV_A_ &iouring_epoll_w);
353 ev_io_set (EV_A_ &iouring_epoll_w, backend_fd, EV_READ);
354 ev_io_start (EV_A_ &iouring_epoll_w);
355 421
356 ev_io_stop (EV_A_ &iouring_tfd_w); 422 ev_io_stop (EV_A_ &iouring_tfd_w);
357 ev_io_set (EV_A_ &iouring_tfd_w, iouring_tfd, EV_READ); 423 ev_io_set (EV_A_ &iouring_tfd_w, iouring_tfd, EV_READ);
358 ev_io_start (EV_A_ &iouring_tfd_w); 424 ev_io_start (EV_A_ &iouring_tfd_w);
359} 425}
… …
361/*****************************************************************************/ 427/*****************************************************************************/
362 428
363static void 429static void
364iouring_modify (EV_P_ int fd, int oev, int nev) 430iouring_modify (EV_P_ int fd, int oev, int nev)
365{ 431{
366 if (ecb_expect_false (anfds [fd].eflags))
367 {
368 /* we handed this fd over to epoll, so undo this first */
369 /* we do it manually because the optimisations on epoll_modify won't do us any good */
370 epoll_ctl (iouring_fd, EPOLL_CTL_DEL, fd, 0);
371 anfds [fd].eflags = 0;
372 oev = 0;
373 }
374
375 if (oev) 432 if (oev)
376 { 433 {
377 /* we assume the sqe's are all "properly" initialised */ 434 /* we assume the sqe's are all "properly" initialised */
378 struct io_uring_sqe *sqe = iouring_sqe_get (EV_A); 435 struct io_uring_sqe *sqe = iouring_sqe_get (EV_A);
379 sqe->opcode = IORING_OP_POLL_REMOVE; 436 sqe->opcode = IORING_OP_POLL_REMOVE;
380 sqe->fd = fd; 437 sqe->fd = fd;
381 sqe->user_data = -1; 438 /* Jens Axboe notified me that user_data is not what is documented, but is
439 * some kind of unique ID that has to match, otherwise the request cannot
440 * be removed. Since we don't *really* have that, we pass in the old
441 * generation counter - if that fails, too bad, it will hopefully be removed
442 * at close time and then be ignored. */
443 sqe->user_data = (uint32_t)fd | ((__u64)(uint32_t)anfds [fd].egen << 32);
382 iouring_sqe_submit (EV_A_ sqe); 444 iouring_sqe_submit (EV_A_ sqe);
383 445
384 /* increment generation counter to avoid handling old events */ 446 /* increment generation counter to avoid handling old events */
385 ++anfds [fd].egen; 447 ++anfds [fd].egen;
386 } 448 }
… …
427{ 489{
428 int fd = cqe->user_data & 0xffffffffU; 490 int fd = cqe->user_data & 0xffffffffU;
429 uint32_t gen = cqe->user_data >> 32; 491 uint32_t gen = cqe->user_data >> 32;
430 int res = cqe->res; 492 int res = cqe->res;
431 493
432 /* ignore fd removal events, if there are any. TODO: verify */
433 if (cqe->user_data == (__u64)-1)
434 abort ();//D
435
436 assert (("libev: io_uring fd must be in-bounds", fd >= 0 && fd < anfdmax)); 494 assert (("libev: io_uring fd must be in-bounds", fd >= 0 && fd < anfdmax));
437 495
438 /* documentation lies, of course. the result value is NOT like 496 /* documentation lies, of course. the result value is NOT like
439 * normal syscalls, but like linux raw syscalls, i.e. negative 497 * normal syscalls, but like linux raw syscalls, i.e. negative
440 * error numbers. fortunate, as otherwise there would be no way 498 * error numbers. fortunate, as otherwise there would be no way
441 * to get error codes at all. still, why not document this? 499 * to get error codes at all. still, why not document this?
442 */ 500 */
443 501
444 /* ignore event if generation doesn't match */ 502 /* ignore event if generation doesn't match */
503 /* other than skipping removal events, */
445 /* this should actually be very rare */ 504 /* this should actually be very rare */
446 if (ecb_expect_false (gen != (uint32_t)anfds [fd].egen)) 505 if (ecb_expect_false (gen != (uint32_t)anfds [fd].egen))
447 return; 506 return;
448 507
449 if (ecb_expect_false (res < 0)) 508 if (ecb_expect_false (res < 0))
450 { 509 {
451 if (res == -EINVAL) 510 /*TODO: EINVAL handling (was something failed with this fd)*/
452 { 511 /*TODO: EBUSY happens when?*/
453 /* we assume this error code means the fd/poll combination is buggy
454 * and fall back to epoll.
455 * this error code might also indicate a bug, but the kernel doesn't
456 * distinguish between those two conditions, so... sigh...
457 */
458 512
459 epoll_modify (EV_A_ fd, 0, anfds [fd].events);
460 }
461 else if (res == -EBADF) 513 if (res == -EBADF)
462 { 514 {
463 assert (("libev: event loop rejected bad fd", res != -EBADF)); 515 assert (("libev: event loop rejected bad fd", res != -EBADF));
464 fd_kill (EV_A_ fd); 516 fd_kill (EV_A_ fd);
465 } 517 }
466 else 518 else
… …
492iouring_overflow (EV_P) 544iouring_overflow (EV_P)
493{ 545{
494 /* we have two options, resize the queue (by tearing down 546 /* we have two options, resize the queue (by tearing down
495 * everything and recreating it, or living with it 547 * everything and recreating it, or living with it
496 * and polling. 548 * and polling.
497 * we implement this by resizing tghe queue, and, if that fails, 549 * we implement this by resizing the queue, and, if that fails,
498 * we just recreate the state on every failure, which 550 * we just recreate the state on every failure, which
499 * kind of is a very inefficient poll. 551 * kind of is a very inefficient poll.
500 * one danger is, due to the bios toward lower fds, 552 * one danger is, due to the bios toward lower fds,
501 * we will only really get events for those, so 553 * we will only really get events for those, so
502 * maybe we need a poll() fallback, after all. 554 * maybe we need a poll() fallback, after all.
… …
514 else 566 else
515 { 567 {
516 /* we hit the kernel limit, we should fall back to something else. 568 /* we hit the kernel limit, we should fall back to something else.
517 * we can either poll() a few times and hope for the best, 569 * we can either poll() a few times and hope for the best,
518 * poll always, or switch to epoll. 570 * poll always, or switch to epoll.
519 * since we use epoll anyways, go epoll. 571 * TODO: is this necessary with newer kernels?
520 */ 572 */
521 573
522 iouring_internal_destroy (EV_A); 574 iouring_internal_destroy (EV_A);
523 575
524 /* this should make it so that on return, we don'T call any uring functions */ 576 /* this should make it so that on return, we don't call any uring functions */
525 iouring_to_submit = 0; 577 iouring_to_submit = 0;
526 578
527 for (;;) 579 for (;;)
528 { 580 {
529 backend = epoll_init (EV_A_ 0); 581 backend = epoll_init (EV_A_ 0);
… …
579 iouring_tfd_update (EV_A_ timeout); 631 iouring_tfd_update (EV_A_ timeout);
580 632
581 /* only enter the kernel if we have something to submit, or we need to wait */ 633 /* only enter the kernel if we have something to submit, or we need to wait */
582 if (timeout || iouring_to_submit) 634 if (timeout || iouring_to_submit)
583 { 635 {
584 int res; 636 int res = iouring_enter (EV_A_ timeout);
585
586 EV_RELEASE_CB;
587
588 res = evsys_io_uring_enter (iouring_fd, iouring_to_submit, 1,
589 timeout > EV_TS_CONST (0.) ? IORING_ENTER_GETEVENTS : 0, 0, 0);
590 iouring_to_submit = 0;
591
592 EV_ACQUIRE_CB;
593 637
594 if (ecb_expect_false (res < 0)) 638 if (ecb_expect_false (res < 0))
595 if (errno == EINTR) 639 if (errno == EINTR)
596 /* ignore */; 640 /* ignore */;
641 else if (errno == EBUSY)
642 /* cq full, cannot submit - should be rare because we flush the cq first, so simply ignore */;
597 else 643 else
598 ev_syserr ("(libev) iouring setup"); 644 ev_syserr ("(libev) iouring setup");
599 else 645 else
600 iouring_handle_cq (EV_A); 646 iouring_handle_cq (EV_A);
601 } 647 }
… …
603 649
604inline_size 650inline_size
605int 651int
606iouring_init (EV_P_ int flags) 652iouring_init (EV_P_ int flags)
607{ 653{
608 if (!epoll_init (EV_A_ 0))
609 return 0;
610
611 iouring_entries = IOURING_INIT_ENTRIES; 654 iouring_entries = IOURING_INIT_ENTRIES;
612 iouring_max_entries = 0; 655 iouring_max_entries = 0;
613 656
614 if (iouring_internal_init (EV_A) < 0) 657 if (iouring_internal_init (EV_A) < 0)
615 { 658 {
616 iouring_internal_destroy (EV_A); 659 iouring_internal_destroy (EV_A);
617 return 0; 660 return 0;
618 } 661 }
619 662
620 ev_io_init (&iouring_epoll_w, iouring_epoll_cb, backend_fd, EV_READ);
621 ev_set_priority (&iouring_epoll_w, EV_MAXPRI);
622
623 ev_io_init (&iouring_tfd_w, iouring_tfd_cb, iouring_tfd, EV_READ); 663 ev_io_init (&iouring_tfd_w, iouring_tfd_cb, iouring_tfd, EV_READ);
624 ev_set_priority (&iouring_tfd_w, EV_MAXPRI); 664 ev_set_priority (&iouring_tfd_w, EV_MINPRI);
625
626 ev_io_start (EV_A_ &iouring_epoll_w);
627 ev_unref (EV_A); /* watcher should not keep loop alive */
628
629 ev_io_start (EV_A_ &iouring_tfd_w); 665 ev_io_start (EV_A_ &iouring_tfd_w);
630 ev_unref (EV_A); /* watcher should not keep loop alive */ 666 ev_unref (EV_A); /* watcher should not keep loop alive */
631 667
632 backend_modify = iouring_modify; 668 backend_modify = iouring_modify;
633 backend_poll = iouring_poll; 669 backend_poll = iouring_poll;
… …
638inline_size 674inline_size
639void 675void
640iouring_destroy (EV_P) 676iouring_destroy (EV_P)
641{ 677{
642 iouring_internal_destroy (EV_A); 678 iouring_internal_destroy (EV_A);
643 epoll_destroy (EV_A);
644} 679}
645 680

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines