ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/libev/ev_linuxaio.c
(Generate patch)

Comparing libev/ev_linuxaio.c (file contents):
Revision 1.14 by root, Sun Jun 23 23:49:56 2019 UTC vs.
Revision 1.20 by root, Mon Jun 24 20:33:24 2019 UTC

… …
53 * therefore the calculation below will use "exactly" 4kB for the ring buffer 53 * therefore the calculation below will use "exactly" 4kB for the ring buffer
54 */ 54 */
55#define EV_LINUXAIO_DEPTH (128 / 2 - 2 - 1) /* max. number of io events per batch */ 55#define EV_LINUXAIO_DEPTH (128 / 2 - 2 - 1) /* max. number of io events per batch */
56 56
57/*****************************************************************************/ 57/*****************************************************************************/
58/* syscall wrapdadoop */ 58/* syscall wrapdadoop - this section has the raw syscall definitions */
59 59
60#include <sys/syscall.h> /* no glibc wrappers */ 60#include <sys/syscall.h> /* no glibc wrappers */
61 61
62/* aio_abi.h is not versioned in any way, so we cannot test for its existance */ 62/* aio_abi.h is not versioned in any way, so we cannot test for its existance */
63#define IOCB_CMD_POLL 5 63#define IOCB_CMD_POLL 5
… …
80 struct io_event io_events[0]; 80 struct io_event io_events[0];
81}; 81};
82 82
83inline_size 83inline_size
84int 84int
85ev_io_setup (unsigned nr_events, aio_context_t *ctx_idp) 85evsys_io_setup (unsigned nr_events, aio_context_t *ctx_idp)
86{ 86{
87 return syscall (SYS_io_setup, nr_events, ctx_idp); 87 return syscall (SYS_io_setup, nr_events, ctx_idp);
88} 88}
89 89
90inline_size 90inline_size
91int 91int
92ev_io_destroy (aio_context_t ctx_id) 92evsys_io_destroy (aio_context_t ctx_id)
93{ 93{
94 return syscall (SYS_io_destroy, ctx_id); 94 return syscall (SYS_io_destroy, ctx_id);
95} 95}
96 96
97inline_size 97inline_size
98int 98int
99ev_io_submit (aio_context_t ctx_id, long nr, struct iocb *cbp[]) 99evsys_io_submit (aio_context_t ctx_id, long nr, struct iocb *cbp[])
100{ 100{
101 return syscall (SYS_io_submit, ctx_id, nr, cbp); 101 return syscall (SYS_io_submit, ctx_id, nr, cbp);
102} 102}
103 103
104inline_size 104inline_size
105int 105int
106ev_io_cancel (aio_context_t ctx_id, struct iocb *cbp, struct io_event *result) 106evsys_io_cancel (aio_context_t ctx_id, struct iocb *cbp, struct io_event *result)
107{ 107{
108 return syscall (SYS_io_cancel, ctx_id, cbp, result); 108 return syscall (SYS_io_cancel, ctx_id, cbp, result);
109} 109}
110 110
111inline_size 111inline_size
112int 112int
113ev_io_getevents (aio_context_t ctx_id, long min_nr, long nr, struct io_event *events, struct timespec *timeout) 113evsys_io_getevents (aio_context_t ctx_id, long min_nr, long nr, struct io_event *events, struct timespec *timeout)
114{ 114{
115 return syscall (SYS_io_getevents, ctx_id, min_nr, nr, events, timeout); 115 return syscall (SYS_io_getevents, ctx_id, min_nr, nr, events, timeout);
116} 116}
117 117
118/*****************************************************************************/ 118/*****************************************************************************/
… …
164 iocb->io.aio_reqprio = 0; 164 iocb->io.aio_reqprio = 0;
165 } 165 }
166#endif 166#endif
167 167
168 if (iocb->io.aio_buf) 168 if (iocb->io.aio_buf)
169 ev_io_cancel (linuxaio_ctx, &iocb->io, (struct io_event *)0); /* always returns an error relevant kernels */ 169 evsys_io_cancel (linuxaio_ctx, &iocb->io, (struct io_event *)0); /* always returns an error relevant kernels */
170 170
171 if (nev) 171 if (nev)
172 { 172 {
173 iocb->io.aio_data = fd; 173 iocb->io.aio_data = fd;
174 iocb->io.aio_fildes = fd; 174 iocb->io.aio_fildes = fd;
… …
182 array_needsize (struct iocb *, linuxaio_submits, linuxaio_submitmax, linuxaio_submitcnt, array_needsize_noinit); 182 array_needsize (struct iocb *, linuxaio_submits, linuxaio_submitmax, linuxaio_submitcnt, array_needsize_noinit);
183 linuxaio_submits [linuxaio_submitcnt - 1] = &iocb->io; 183 linuxaio_submits [linuxaio_submitcnt - 1] = &iocb->io;
184 } 184 }
185} 185}
186 186
187#if EPOLL_FALLBACK
188
189static void
190linuxaio_rearm_epoll (EV_P_ struct iocb *iocb, int op)
191{
192 struct epoll_event eev;
193
194 eev.events = EPOLLONESHOT;
195 if (iocb->aio_buf & POLLIN ) eev.events |= EPOLLIN ;
196 if (iocb->aio_buf & POLLOUT) eev.events |= EPOLLOUT;
197 eev.data.fd = iocb->aio_fildes;
198
199 if (epoll_ctl (backend_fd, op, iocb->aio_fildes, &eev) < 0)
200 ev_syserr ("(libeio) linuxaio epoll_ctl");
201}
202
203static void
204linuxaio_epoll_cb (EV_P_ struct ev_io *w, int revents)
205{
206 struct epoll_event events[16];
207
208 for (;;)
209 {
210 int idx;
211 int res = epoll_wait (backend_fd, events, sizeof (events) / sizeof (events [0]), 0);
212
213 if (expect_false (res < 0))
214 ev_syserr ("(libev) linuxaio epoll_wait");
215 else if (!res)
216 break;
217
218 for (idx = res; idx--; )
219 {
220 int fd = events [idx].data.fd;
221 uint32_t ev = events [idx].events;
222
223 assert (("libev: iocb fd must be in-bounds", fd >= 0 && fd < anfdmax));
224
225 linuxaio_rearm_epoll (EV_A_ &linuxaio_iocbps [fd]->io, EPOLL_CTL_MOD);
226
227 fd_event (EV_A_ fd,
228 (ev & (EPOLLOUT | EPOLLERR | EPOLLHUP) ? EV_WRITE : 0)
229 | (ev & (EPOLLIN | EPOLLERR | EPOLLHUP) ? EV_READ : 0));
230 }
231
232 if (res < sizeof (events) / sizeof (events [0]))
233 break;
234 }
235}
236
237#endif
238
187static void 239static void
188linuxaio_parse_events (EV_P_ struct io_event *ev, int nr) 240linuxaio_parse_events (EV_P_ struct io_event *ev, int nr)
189{ 241{
190 while (nr) 242 while (nr)
191 { 243 {
192 int fd = ev->data; 244 int fd = ev->data;
193 int res = ev->res; 245 int res = ev->res;
194 246
195 assert (("libev: iocb fd must be in-bounds", fd >= 0 && fd < anfdmax)); 247 assert (("libev: iocb fd must be in-bounds", fd >= 0 && fd < anfdmax));
196 248
197 /* linux aio is oneshot: rearm fd */ 249 /* linux aio is oneshot: rearm fd. TODO: this does more work than needed */
198 linuxaio_iocbps [fd]->io.aio_buf = 0; 250 linuxaio_iocbps [fd]->io.aio_buf = 0;
199 anfds [fd].events = 0; 251 anfds [fd].events = 0;
200 fd_change (EV_A_ fd, 0); 252 fd_change (EV_A_ fd, 0);
201 253
202 /* feed events, we do not expect or handle POLLNVAL */ 254 /* feed events, we do not expect or handle POLLNVAL */
203 if (ecb_expect_false (res & POLLNVAL)) 255 if (expect_false (res & POLLNVAL))
204 fd_kill (EV_A_ fd); 256 fd_kill (EV_A_ fd);
205 else 257 else
206 fd_event ( 258 fd_event (
207 EV_A_ 259 EV_A_
208 fd, 260 fd,
… …
229 281
230 if (head == tail) 282 if (head == tail)
231 return 0; 283 return 0;
232 284
233 /* bail out if the ring buffer doesn't match the expected layout */ 285 /* bail out if the ring buffer doesn't match the expected layout */
234 if (ecb_expect_false (ring->magic != AIO_RING_MAGIC) 286 if (expect_false (ring->magic != AIO_RING_MAGIC)
235 || ring->incompat_features != AIO_RING_INCOMPAT_FEATURES 287 || ring->incompat_features != AIO_RING_INCOMPAT_FEATURES
236 || ring->header_length != sizeof (struct aio_ring)) /* TODO: or use it to find io_event[0]? */ 288 || ring->header_length != sizeof (struct aio_ring)) /* TODO: or use it to find io_event[0]? */
237 return 0; 289 return 0;
238 290
239 /* make sure the events up to tail are visible */ 291 /* make sure the events up to tail are visible */
240 ECB_MEMORY_FENCE_ACQUIRE; 292 ECB_MEMORY_FENCE_ACQUIRE;
241 293
… …
246 { 298 {
247 linuxaio_parse_events (EV_A_ ring->io_events + head, ring->nr - head); 299 linuxaio_parse_events (EV_A_ ring->io_events + head, ring->nr - head);
248 linuxaio_parse_events (EV_A_ ring->io_events, tail); 300 linuxaio_parse_events (EV_A_ ring->io_events, tail);
249 } 301 }
250 302
303 /* TODO: we only need a compiler barrier here, not a read fence */
304 ECB_MEMORY_FENCE_RELEASE;
251 /* as an extension to C, we hope that the volatile will makethis atomic and once-only */ 305 /* as an extension to C, we hope that the volatile will make this atomic and once-only */
252 *(volatile unsigned *)&ring->head = tail; 306 *(volatile unsigned *)&ring->head = tail;
253 /* make sure kernel can see our new head value - probably not required */ 307 /* make sure kernel can see our new head value - probably not required */
254 ECB_MEMORY_FENCE_RELEASE; 308 ECB_MEMORY_FENCE_RELEASE;
255 309
256 return 1; 310 return 1;
… …
260inline_size 314inline_size
261void 315void
262linuxaio_get_events (EV_P_ ev_tstamp timeout) 316linuxaio_get_events (EV_P_ ev_tstamp timeout)
263{ 317{
264 struct timespec ts; 318 struct timespec ts;
265 struct io_event ioev; 319 struct io_event ioev[1];
266 int res; 320 int res;
267 321
268 if (linuxaio_get_events_from_ring (EV_A)) 322 if (linuxaio_get_events_from_ring (EV_A))
269 return; 323 return;
270 324
271 /* no events, so wait for at least one, then poll ring buffer again */ 325 /* no events, so wait for at least one, then poll ring buffer again */
272 /* this degrades to one event per loop iteration */ 326 /* this degrades to one event per loop iteration */
273 /* if the ring buffer changes layout, but so be it */ 327 /* if the ring buffer changes layout, but so be it */
274 328
329 EV_RELEASE_CB;
330
275 ts.tv_sec = (long)timeout; 331 ts.tv_sec = (long)timeout;
276 ts.tv_nsec = (long)((timeout - ts.tv_sec) * 1e9); 332 ts.tv_nsec = (long)((timeout - ts.tv_sec) * 1e9);
277 333
278 res = ev_io_getevents (linuxaio_ctx, 1, 1, &ioev, &ts); 334 res = evsys_io_getevents (linuxaio_ctx, 1, sizeof (ioev) / sizeof (ioev [0]), ioev, &ts);
335
336 EV_ACQUIRE_CB;
279 337
280 if (res < 0) 338 if (res < 0)
281 if (errno == EINTR) 339 if (errno == EINTR)
282 /* ignored */; 340 /* ignored */;
283 else 341 else
284 ev_syserr ("(libev) linuxaio io_getevents"); 342 ev_syserr ("(libev) linuxaio io_getevents");
285 else if (res) 343 else if (res)
286 { 344 {
287 /* at least one event received, handle it and any remaining ones in the ring buffer */ 345 /* at least one event received, handle it and any remaining ones in the ring buffer */
288 linuxaio_parse_events (EV_A_ &ioev, 1); 346 linuxaio_parse_events (EV_A_ ioev, res);
289 linuxaio_get_events_from_ring (EV_A); 347 linuxaio_get_events_from_ring (EV_A);
290 } 348 }
291} 349}
292
293#if EPOLL_FALLBACK
294static void
295linuxaio_rearm_epoll (EV_P_ struct iocb *iocb, int op)
296{
297 struct epoll_event eev;
298
299 eev.events = EPOLLONESHOT;
300 if (iocb->aio_buf & POLLIN ) eev.events |= EPOLLIN ;
301 if (iocb->aio_buf & POLLOUT) eev.events |= EPOLLOUT;
302 eev.data.fd = iocb->aio_fildes;
303
304 if (epoll_ctl (backend_fd, op, iocb->aio_fildes, &eev) < 0)
305 ev_syserr ("(libeio) linuxaio epoll_ctl");
306}
307#endif
308 350
309static void 351static void
310linuxaio_poll (EV_P_ ev_tstamp timeout) 352linuxaio_poll (EV_P_ ev_tstamp timeout)
311{ 353{
312 int submitted; 354 int submitted;
… …
316 /* io_submit might return less than the requested number of iocbs */ 358 /* io_submit might return less than the requested number of iocbs */
317 /* this is, afaics, only because of errors, but we go by the book and use a loop, */ 359 /* this is, afaics, only because of errors, but we go by the book and use a loop, */
318 /* which allows us to pinpoint the errornous iocb */ 360 /* which allows us to pinpoint the errornous iocb */
319 for (submitted = 0; submitted < linuxaio_submitcnt; ) 361 for (submitted = 0; submitted < linuxaio_submitcnt; )
320 { 362 {
363#if 0
364 int res;
365 if (linuxaio_submits[submitted]->aio_fildes == backend_fd)
366 res = evsys_io_submit (linuxaio_ctx, 1, linuxaio_submits + submitted);
367 else
368 { res = -1; errno = EINVAL; };
369#else
321 int res = ev_io_submit (linuxaio_ctx, linuxaio_submitcnt - submitted, linuxaio_submits + submitted); 370 int res = evsys_io_submit (linuxaio_ctx, linuxaio_submitcnt - submitted, linuxaio_submits + submitted);
371#endif
322 372
323 if (ecb_expect_false (res < 0)) 373 if (expect_false (res < 0))
324 if (errno == EAGAIN) 374 if (errno == EAGAIN)
325 { 375 {
326 /* This happens when the ring buffer is full, at least. I assume this means 376 /* This happens when the ring buffer is full, at least. I assume this means
327 * that the event was queued synchronously during io_submit, and thus 377 * that the event was queued synchronously during io_submit, and thus
328 * the buffer overflowed. 378 * the buffer overflowed.
329 * In this case, we just try in next loop iteration. 379 * In this case, we just try in next loop iteration.
330 * This should not result in a few fds taking priority, as the interface 380 * This should not result in a few fds taking priority, as the interface
331 * is one-shot, and we submit iocb's in a round-robin fashion. 381 * is one-shot, and we submit iocb's in a round-robin fashion.
382 * TODO: maybe make "submitted" persistent, so we don't have to memmove?
332 */ 383 */
384 if (ecb_expect_false (submitted))
385 {
333 memmove (linuxaio_submits, linuxaio_submits + submitted, (linuxaio_submitcnt - submitted) * sizeof (*linuxaio_submits)); 386 memmove (linuxaio_submits, linuxaio_submits + submitted, (linuxaio_submitcnt - submitted) * sizeof (*linuxaio_submits));
334 linuxaio_submitcnt -= submitted; 387 linuxaio_submitcnt -= submitted;
388 }
389
335 timeout = 0; 390 timeout = 0;
336 break; 391 break;
337 } 392 }
338#if EPOLL_FALLBACK 393#if EPOLL_FALLBACK
339 else if (errno == EINVAL) 394 else if (errno == EINVAL)
340 { 395 {
341 /* This hapΓΌpens for unsupported fds, officially, but in my testing, 396 /* This happens for unsupported fds, officially, but in my testing,
342 * also randomly happens for supported fds. We fall back to good old 397 * also randomly happens for supported fds. We fall back to good old
343 * poll() here, under the assumption that this is a very rare case. 398 * poll() here, under the assumption that this is a very rare case.
399 * See https://lore.kernel.org/patchwork/patch/1047453/ to see
400 * discussion about such a case (ttys) where polling for POLLIN
401 * fails but POLLIN|POLLOUT works.
344 */ 402 */
345 struct iocb *iocb = linuxaio_submits [submitted]; 403 struct iocb *iocb = linuxaio_submits [submitted];
346 res = 1; /* skip this iocb */ 404 res = 1; /* skip this iocb */
347 405
348 linuxaio_rearm_epoll (EV_A_ iocb, EPOLL_CTL_ADD); 406 linuxaio_rearm_epoll (EV_A_ iocb, EPOLL_CTL_ADD);
… …
360 /* second phase: fetch and parse events */ 418 /* second phase: fetch and parse events */
361 419
362 linuxaio_get_events (EV_A_ timeout); 420 linuxaio_get_events (EV_A_ timeout);
363} 421}
364 422
365#if EPOLL_FALLBACK
366
367static void
368linuxaio_epoll_cb (EV_P_ struct ev_io *w, int revents)
369{
370 struct epoll_event events[16];
371
372 for (;;)
373 {
374 int idx;
375 int res = epoll_wait (backend_fd, events, sizeof (events) / sizeof (events [0]), 0);
376
377 if (ecb_expect_false (res < 0))
378 ev_syserr ("(libev) linuxaio epoll_wait");
379 else if (!res)
380 break;
381
382 for (idx = res; idx--; )
383 {
384 int fd = events [idx].data.fd;
385 uint32_t ev = events [idx].events;
386
387 assert (("libev: iocb fd must be in-bounds", fd >= 0 && fd < anfdmax));
388
389 linuxaio_rearm_epoll (EV_A_ &linuxaio_iocbps [fd]->io, EPOLL_CTL_MOD);
390
391 fd_event (EV_A_ fd,
392 (ev & (EPOLLOUT | EPOLLERR | EPOLLHUP) ? EV_WRITE : 0)
393 | (ev & (EPOLLIN | EPOLLERR | EPOLLHUP) ? EV_READ : 0));
394 }
395
396 if (res < sizeof (events) / sizeof (events [0]))
397 break;
398 }
399}
400
401#endif
402
403inline_size 423inline_size
404int 424int
405linuxaio_init (EV_P_ int flags) 425linuxaio_init (EV_P_ int flags)
406{ 426{
407 /* would be great to have a nice test for IOCB_CMD_POLL instead */ 427 /* would be great to have a nice test for IOCB_CMD_POLL instead */
408 /* also: test some semi-common fd types, such as files and ttys in recommended_backends */ 428 /* also: test some semi-common fd types, such as files and ttys in recommended_backends */
409 if (ev_linux_version () < 0x041200) /* 4.18 introduced IOCB_CMD_POLL */ 429#if EPOLL_FALLBACK
430 /* 4.19 made epoll work */
431 if (ev_linux_version () < 0x041300)
410 return 0; 432 return 0;
433#else
434 /* 4.18 introduced IOCB_CMD_POLL */
435 if (ev_linux_version () < 0x041200)
436 return 0;
437#endif
411 438
412 linuxaio_ctx = 0; 439 linuxaio_ctx = 0;
413 if (ev_io_setup (EV_LINUXAIO_DEPTH, &linuxaio_ctx) < 0) 440 if (evsys_io_setup (EV_LINUXAIO_DEPTH, &linuxaio_ctx) < 0)
414 return 0; 441 return 0;
415 442
416#if EPOLL_FALLBACK 443#if EPOLL_FALLBACK
417 backend_fd = ev_epoll_create (); 444 backend_fd = ev_epoll_create ();
418 if (backend_fd < 0) 445 if (backend_fd < 0)
419 { 446 {
420 ev_io_destroy (linuxaio_ctx); 447 evsys_io_destroy (linuxaio_ctx);
421 return 0; 448 return 0;
422 } 449 }
423 450
424 ev_io_init (EV_A_ &linuxaio_epoll_w, linuxaio_epoll_cb, backend_fd, EV_READ); 451 ev_io_init (EV_A_ &linuxaio_epoll_w, linuxaio_epoll_cb, backend_fd, EV_READ);
452 ev_set_priority (&linuxaio_epoll_w, EV_MAXPRI);
425 ev_io_start (EV_A_ &linuxaio_epoll_w); 453 ev_io_start (EV_A_ &linuxaio_epoll_w);
426 ev_unref (EV_A); /* watcher should not keep loop alive */ 454 ev_unref (EV_A); /* watcher should not keep loop alive */
427#endif 455#endif
428 456
429 backend_modify = linuxaio_modify; 457 backend_modify = linuxaio_modify;
… …
457 /* this frees all iocbs, which is very heavy-handed */ 485 /* this frees all iocbs, which is very heavy-handed */
458 linuxaio_destroy (EV_A); 486 linuxaio_destroy (EV_A);
459 linuxaio_submitcnt = 0; /* all pointers were invalidated */ 487 linuxaio_submitcnt = 0; /* all pointers were invalidated */
460 488
461 linuxaio_ctx = 0; 489 linuxaio_ctx = 0;
462 while (ev_io_setup (EV_LINUXAIO_DEPTH, &linuxaio_ctx) < 0) 490 while (evsys_io_setup (EV_LINUXAIO_DEPTH, &linuxaio_ctx) < 0)
463 ev_syserr ("(libev) linuxaio io_setup"); 491 ev_syserr ("(libev) linuxaio io_setup");
464 492
465#if EPOLL_FALLBACK 493#if EPOLL_FALLBACK
466 while ((backend_fd = ev_epoll_create ()) < 0) 494 while ((backend_fd = ev_epoll_create ()) < 0)
467 ev_syserr ("(libev) linuxaio epoll_create"); 495 ev_syserr ("(libev) linuxaio epoll_create");

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines