ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/libev/ev_linuxaio.c
(Generate patch)

Comparing libev/ev_linuxaio.c (file contents):
Revision 1.31 by root, Tue Jun 25 18:00:42 2019 UTC vs.
Revision 1.53 by root, Fri Dec 27 16:12:55 2019 UTC

100 * not only is this totally undocumented, not even the source code 100 * not only is this totally undocumented, not even the source code
101 * can tell you what the future semantics of compat_features and 101 * can tell you what the future semantics of compat_features and
102 * incompat_features are, or what header_length actually is for. 102 * incompat_features are, or what header_length actually is for.
103 */ 103 */
104#define AIO_RING_MAGIC 0xa10a10a1 104#define AIO_RING_MAGIC 0xa10a10a1
105#define AIO_RING_INCOMPAT_FEATURES 0 105#define EV_AIO_RING_INCOMPAT_FEATURES 0
106struct aio_ring 106struct aio_ring
107{ 107{
108 unsigned id; /* kernel internal index number */ 108 unsigned id; /* kernel internal index number */
109 unsigned nr; /* number of io_events */ 109 unsigned nr; /* number of io_events */
110 unsigned head; /* Written to by userland or by kernel. */ 110 unsigned head; /* Written to by userland or by kernel. */
115 unsigned incompat_features; 115 unsigned incompat_features;
116 unsigned header_length; /* size of aio_ring */ 116 unsigned header_length; /* size of aio_ring */
117 117
118 struct io_event io_events[0]; 118 struct io_event io_events[0];
119}; 119};
120
121/*
122 * define some syscall wrappers for common architectures
123 * this is mostly for nice looks during debugging, not performance.
124 * our syscalls return < 0, not == -1, on error. which is good
125 * enough for linux aio.
126 * TODO: arm is also common nowadays, maybe even mips and x86
127 * TODO: after implementing this, it suddenly looks like overkill, but its hard to remove...
128 */
129#if __GNUC__ && __linux && ECB_AMD64
130
131 #define ev_syscall(nr,narg,arg1,arg2,arg3,arg4,arg5) \
132 ({ \
133 long res; \
134 register unsigned long r5 __asm__ ("r8" ); \
135 register unsigned long r4 __asm__ ("r10"); \
136 register unsigned long r3 __asm__ ("rdx"); \
137 register unsigned long r2 __asm__ ("rsi"); \
138 register unsigned long r1 __asm__ ("rdi"); \
139 if (narg >= 5) r5 = (unsigned long)(arg5); \
140 if (narg >= 4) r4 = (unsigned long)(arg4); \
141 if (narg >= 3) r3 = (unsigned long)(arg3); \
142 if (narg >= 2) r2 = (unsigned long)(arg2); \
143 if (narg >= 1) r1 = (unsigned long)(arg1); \
144 __asm__ __volatile__ ( \
145 "syscall\n\t" \
146 : "=a" (res) \
147 : "0" (nr), "r" (r1), "r" (r2), "r" (r3), "r" (r4), "r" (r5) \
148 : "cc", "r11", "cx", "memory"); \
149 errno = -res; \
150 res; \
151 })
152
153#endif
154
155#ifdef ev_syscall
156 #define ev_syscall0(nr) ev_syscall (nr, 0, 0, 0, 0, 0, 0
157 #define ev_syscall1(nr,arg1) ev_syscall (nr, 1, arg1, 0, 0, 0, 0)
158 #define ev_syscall2(nr,arg1,arg2) ev_syscall (nr, 2, arg1, arg2, 0, 0, 0)
159 #define ev_syscall3(nr,arg1,arg2,arg3) ev_syscall (nr, 3, arg1, arg2, arg3, 0, 0)
160 #define ev_syscall4(nr,arg1,arg2,arg3,arg4) ev_syscall (nr, 3, arg1, arg2, arg3, arg4, 0)
161 #define ev_syscall5(nr,arg1,arg2,arg3,arg4,arg5) ev_syscall (nr, 5, arg1, arg2, arg3, arg4, arg5)
162#else
163 #define ev_syscall0(nr) syscall (nr)
164 #define ev_syscall1(nr,arg1) syscall (nr, arg1)
165 #define ev_syscall2(nr,arg1,arg2) syscall (nr, arg1, arg2)
166 #define ev_syscall3(nr,arg1,arg2,arg3) syscall (nr, arg1, arg2, arg3)
167 #define ev_syscall4(nr,arg1,arg2,arg3,arg4) syscall (nr, arg1, arg2, arg3, arg4)
168 #define ev_syscall5(nr,arg1,arg2,arg3,arg4,arg5) syscall (nr, arg1, arg2, arg3, arg4, arg5)
169#endif
170 120
171inline_size 121inline_size
172int 122int
173evsys_io_setup (unsigned nr_events, aio_context_t *ctx_idp) 123evsys_io_setup (unsigned nr_events, aio_context_t *ctx_idp)
174{ 124{
262 * this is not well documented, so we better do it. 212 * this is not well documented, so we better do it.
263 */ 213 */
264 memset (iocb, 0, sizeof (*iocb)); 214 memset (iocb, 0, sizeof (*iocb));
265 215
266 iocb->io.aio_lio_opcode = IOCB_CMD_POLL; 216 iocb->io.aio_lio_opcode = IOCB_CMD_POLL;
267 iocb->io.aio_data = offset;
268 iocb->io.aio_fildes = offset; 217 iocb->io.aio_fildes = offset;
269 218
270 base [offset++] = iocb; 219 base [offset++] = iocb;
271 } 220 }
272} 221}
284static void 233static void
285linuxaio_modify (EV_P_ int fd, int oev, int nev) 234linuxaio_modify (EV_P_ int fd, int oev, int nev)
286{ 235{
287 array_needsize (ANIOCBP, linuxaio_iocbps, linuxaio_iocbpmax, fd + 1, linuxaio_array_needsize_iocbp); 236 array_needsize (ANIOCBP, linuxaio_iocbps, linuxaio_iocbpmax, fd + 1, linuxaio_array_needsize_iocbp);
288 ANIOCBP iocb = linuxaio_iocbps [fd]; 237 ANIOCBP iocb = linuxaio_iocbps [fd];
238 ANFD *anfd = &anfds [fd];
289 239
290 if (iocb->io.aio_reqprio < 0) 240 if (ecb_expect_false (iocb->io.aio_reqprio < 0))
291 { 241 {
292 /* we handed this fd over to epoll, so undo this first */ 242 /* we handed this fd over to epoll, so undo this first */
293 /* we do it manually because the optimisations on epoll_modfy won't do us any good */ 243 /* we do it manually because the optimisations on epoll_modify won't do us any good */
294 epoll_ctl (backend_fd, EPOLL_CTL_DEL, fd, 0); 244 epoll_ctl (backend_fd, EPOLL_CTL_DEL, fd, 0);
295 anfds [fd].emask = 0; 245 anfd->emask = 0;
296 iocb->io.aio_reqprio = 0; 246 iocb->io.aio_reqprio = 0;
297 } 247 }
298 248 else if (ecb_expect_false (iocb->io.aio_buf))
299 if (iocb->io.aio_buf) 249 {
300 /* io_cancel always returns some error on relevant kernels, but works */ 250 /* iocb active, so cancel it first before resubmit */
251 /* this assumes we only ever get one call per fd per loop iteration */
252 for (;;)
253 {
254 /* on all relevant kernels, io_cancel fails with EINPROGRESS on "success" */
301 evsys_io_cancel (linuxaio_ctx, &iocb->io, (struct io_event *)0); 255 if (ecb_expect_false (evsys_io_cancel (linuxaio_ctx, &iocb->io, (struct io_event *)0) == 0))
256 break;
257
258 if (ecb_expect_true (errno == EINPROGRESS))
259 break;
260
261 /* the EINPROGRESS test is for nicer error message. clumsy. */
262 if (errno != EINTR)
263 {
264 assert (("libev: linuxaio unexpected io_cancel failed", errno != EINTR && errno != EINPROGRESS));
265 break;
266 }
267 }
268
269 /* increment generation counter to avoid handling old events */
270 ++anfd->egen;
271 }
272
273 iocb->io.aio_buf = (nev & EV_READ ? POLLIN : 0)
274 | (nev & EV_WRITE ? POLLOUT : 0);
302 275
303 if (nev) 276 if (nev)
304 { 277 {
305 iocb->io.aio_buf = 278 iocb->io.aio_data = (uint32_t)fd | ((__u64)(uint32_t)anfd->egen << 32);
306 (nev & EV_READ ? POLLIN : 0)
307 | (nev & EV_WRITE ? POLLOUT : 0);
308 279
309 /* queue iocb up for io_submit */ 280 /* queue iocb up for io_submit */
310 /* this assumes we only ever get one call per fd per loop iteration */ 281 /* this assumes we only ever get one call per fd per loop iteration */
311 ++linuxaio_submitcnt; 282 ++linuxaio_submitcnt;
312 array_needsize (struct iocb *, linuxaio_submits, linuxaio_submitmax, linuxaio_submitcnt, array_needsize_noinit); 283 array_needsize (struct iocb *, linuxaio_submits, linuxaio_submitmax, linuxaio_submitcnt, array_needsize_noinit);
318linuxaio_epoll_cb (EV_P_ struct ev_io *w, int revents) 289linuxaio_epoll_cb (EV_P_ struct ev_io *w, int revents)
319{ 290{
320 epoll_poll (EV_A_ 0); 291 epoll_poll (EV_A_ 0);
321} 292}
322 293
323static void 294inline_speed
295void
324linuxaio_fd_rearm (EV_P_ int fd) 296linuxaio_fd_rearm (EV_P_ int fd)
325{ 297{
326 anfds [fd].events = 0; 298 anfds [fd].events = 0;
327 linuxaio_iocbps [fd]->io.aio_buf = 0; 299 linuxaio_iocbps [fd]->io.aio_buf = 0;
328 fd_change (EV_A_ fd, EV_ANFD_REIFY); 300 fd_change (EV_A_ fd, EV_ANFD_REIFY);
331static void 303static void
332linuxaio_parse_events (EV_P_ struct io_event *ev, int nr) 304linuxaio_parse_events (EV_P_ struct io_event *ev, int nr)
333{ 305{
334 while (nr) 306 while (nr)
335 { 307 {
336 int fd = ev->data; 308 int fd = ev->data & 0xffffffff;
309 uint32_t gen = ev->data >> 32;
337 int res = ev->res; 310 int res = ev->res;
338 311
339 assert (("libev: iocb fd must be in-bounds", fd >= 0 && fd < anfdmax)); 312 assert (("libev: iocb fd must be in-bounds", fd >= 0 && fd < anfdmax));
340 313
314 /* only accept events if generation counter matches */
315 if (ecb_expect_true (gen == (uint32_t)anfds [fd].egen))
316 {
341 /* feed events, we do not expect or handle POLLNVAL */ 317 /* feed events, we do not expect or handle POLLNVAL */
342 fd_event ( 318 fd_event (
343 EV_A_ 319 EV_A_
344 fd, 320 fd,
345 (res & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0) 321 (res & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0)
346 | (res & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0) 322 | (res & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0)
347 ); 323 );
348 324
349 /* linux aio is oneshot: rearm fd. TODO: this does more work than needed */ 325 /* linux aio is oneshot: rearm fd. TODO: this does more work than strictly needed */
350 linuxaio_fd_rearm (EV_A_ fd); 326 linuxaio_fd_rearm (EV_A_ fd);
327 }
351 328
352 --nr; 329 --nr;
353 ++ev; 330 ++ev;
354 } 331 }
355} 332}
357/* get any events from ring buffer, return true if any were handled */ 334/* get any events from ring buffer, return true if any were handled */
358static int 335static int
359linuxaio_get_events_from_ring (EV_P) 336linuxaio_get_events_from_ring (EV_P)
360{ 337{
361 struct aio_ring *ring = (struct aio_ring *)linuxaio_ctx; 338 struct aio_ring *ring = (struct aio_ring *)linuxaio_ctx;
339 unsigned head, tail;
362 340
363 /* the kernel reads and writes both of these variables, */ 341 /* the kernel reads and writes both of these variables, */
364 /* as a C extension, we assume that volatile use here */ 342 /* as a C extension, we assume that volatile use here */
365 /* both makes reads atomic and once-only */ 343 /* both makes reads atomic and once-only */
366 unsigned head = *(volatile unsigned *)&ring->head; 344 head = *(volatile unsigned *)&ring->head;
345 ECB_MEMORY_FENCE_ACQUIRE;
367 unsigned tail = *(volatile unsigned *)&ring->tail; 346 tail = *(volatile unsigned *)&ring->tail;
368 347
369 if (head == tail) 348 if (head == tail)
370 return 0; 349 return 0;
371 350
372 /* bail out if the ring buffer doesn't match the expected layout */
373 if (expect_false (ring->magic != AIO_RING_MAGIC)
374 || ring->incompat_features != AIO_RING_INCOMPAT_FEATURES
375 || ring->header_length != sizeof (struct aio_ring)) /* TODO: or use it to find io_event[0]? */
376 return 0;
377
378 /* make sure the events up to tail are visible */
379 ECB_MEMORY_FENCE_ACQUIRE;
380
381 /* parse all available events, but only once, to avoid starvation */ 351 /* parse all available events, but only once, to avoid starvation */
382 if (tail > head) /* normal case around */ 352 if (ecb_expect_true (tail > head)) /* normal case around */
383 linuxaio_parse_events (EV_A_ ring->io_events + head, tail - head); 353 linuxaio_parse_events (EV_A_ ring->io_events + head, tail - head);
384 else /* wrapped around */ 354 else /* wrapped around */
385 { 355 {
386 linuxaio_parse_events (EV_A_ ring->io_events + head, ring->nr - head); 356 linuxaio_parse_events (EV_A_ ring->io_events + head, ring->nr - head);
387 linuxaio_parse_events (EV_A_ ring->io_events, tail); 357 linuxaio_parse_events (EV_A_ ring->io_events, tail);
392 *(volatile unsigned *)&ring->head = tail; 362 *(volatile unsigned *)&ring->head = tail;
393 363
394 return 1; 364 return 1;
395} 365}
396 366
367inline_size
368int
369linuxaio_ringbuf_valid (EV_P)
370{
371 struct aio_ring *ring = (struct aio_ring *)linuxaio_ctx;
372
373 return ecb_expect_true (ring->magic == AIO_RING_MAGIC)
374 && ring->incompat_features == EV_AIO_RING_INCOMPAT_FEATURES
375 && ring->header_length == sizeof (struct aio_ring); /* TODO: or use it to find io_event[0]? */
376}
377
397/* read at least one event from kernel, or timeout */ 378/* read at least one event from kernel, or timeout */
398inline_size 379inline_size
399void 380void
400linuxaio_get_events (EV_P_ ev_tstamp timeout) 381linuxaio_get_events (EV_P_ ev_tstamp timeout)
401{ 382{
402 struct timespec ts; 383 struct timespec ts;
403 struct io_event ioev[1]; 384 struct io_event ioev[8]; /* 256 octet stack space */
404 int res; 385 int want = 1; /* how many events to request */
386 int ringbuf_valid = linuxaio_ringbuf_valid (EV_A);
405 387
388 if (ecb_expect_true (ringbuf_valid))
389 {
390 /* if the ring buffer has any events, we don't wait or call the kernel at all */
406 if (linuxaio_get_events_from_ring (EV_A)) 391 if (linuxaio_get_events_from_ring (EV_A))
407 return; 392 return;
408 393
409 /* no events, so wait for at least one, then poll ring buffer again */ 394 /* if the ring buffer is empty, and we don't have a timeout, then don't call the kernel */
410 /* this degrades to one event per loop iteration */ 395 if (!timeout)
411 /* if the ring buffer changes layout, but so be it */ 396 return;
397 }
398 else
399 /* no ringbuffer, request slightly larger batch */
400 want = sizeof (ioev) / sizeof (ioev [0]);
412 401
402 /* no events, so wait for some
403 * for fairness reasons, we do this in a loop, to fetch all events
404 */
405 for (;;)
406 {
407 int res;
408
413 EV_RELEASE_CB; 409 EV_RELEASE_CB;
414 410
415 ts.tv_sec = (long)timeout; 411 EV_TS_SET (ts, timeout);
416 ts.tv_nsec = (long)((timeout - ts.tv_sec) * 1e9); 412 res = evsys_io_getevents (linuxaio_ctx, 1, want, ioev, &ts);
417 413
418 res = evsys_io_getevents (linuxaio_ctx, 1, sizeof (ioev) / sizeof (ioev [0]), ioev, &ts);
419
420 EV_ACQUIRE_CB; 414 EV_ACQUIRE_CB;
421 415
422 if (res < 0) 416 if (res < 0)
423 if (errno == EINTR) 417 if (errno == EINTR)
424 /* ignored */; 418 /* ignored, retry */;
425 else 419 else
426 ev_syserr ("(libev) linuxaio io_getevents"); 420 ev_syserr ("(libev) linuxaio io_getevents");
427 else if (res) 421 else if (res)
428 { 422 {
429 /* at least one event available, handle it and any remaining ones in the ring buffer */ 423 /* at least one event available, handle them */
430 linuxaio_parse_events (EV_A_ ioev, res); 424 linuxaio_parse_events (EV_A_ ioev, res);
425
426 if (ecb_expect_true (ringbuf_valid))
427 {
428 /* if we have a ring buffer, handle any remaining events in it */
431 linuxaio_get_events_from_ring (EV_A); 429 linuxaio_get_events_from_ring (EV_A);
430
431 /* at this point, we should have handled all outstanding events */
432 break;
433 }
434 else if (res < want)
435 /* otherwise, if there were fewere events than we wanted, we assume there are no more */
436 break;
437 }
438 else
439 break; /* no events from the kernel, we are done */
440
441 timeout = EV_TS_CONST (0.); /* only wait in the first iteration */
432 } 442 }
433} 443}
434 444
435inline_size 445inline_size
436int 446int
452 /* which allows us to pinpoint the erroneous iocb */ 462 /* which allows us to pinpoint the erroneous iocb */
453 for (submitted = 0; submitted < linuxaio_submitcnt; ) 463 for (submitted = 0; submitted < linuxaio_submitcnt; )
454 { 464 {
455 int res = evsys_io_submit (linuxaio_ctx, linuxaio_submitcnt - submitted, linuxaio_submits + submitted); 465 int res = evsys_io_submit (linuxaio_ctx, linuxaio_submitcnt - submitted, linuxaio_submits + submitted);
456 466
457 if (expect_false (res < 0)) 467 if (ecb_expect_false (res < 0))
458 if (errno == EINVAL) 468 if (errno == EINVAL)
459 { 469 {
460 /* This happens for unsupported fds, officially, but in my testing, 470 /* This happens for unsupported fds, officially, but in my testing,
461 * also randomly happens for supported fds. We fall back to good old 471 * also randomly happens for supported fds. We fall back to good old
462 * poll() here, under the assumption that this is a very rare case. 472 * poll() here, under the assumption that this is a very rare case.
492 } 502 }
493 503
494 ++linuxaio_iteration; 504 ++linuxaio_iteration;
495 if (linuxaio_io_setup (EV_A) < 0) 505 if (linuxaio_io_setup (EV_A) < 0)
496 { 506 {
507 /* TODO: rearm all and recreate epoll backend from scratch */
508 /* TODO: might be more prudent? */
509
497 /* to bad, we can't get a new aio context, go 100% epoll */ 510 /* to bad, we can't get a new aio context, go 100% epoll */
498 linuxaio_free_iocbp (EV_A); 511 linuxaio_free_iocbp (EV_A);
499 ev_io_stop (EV_A_ &linuxaio_epoll_w); 512 ev_io_stop (EV_A_ &linuxaio_epoll_w);
500 ev_ref (EV_A); 513 ev_ref (EV_A);
501 linuxaio_ctx = 0; 514 linuxaio_ctx = 0;
515
516 backend = EVBACKEND_EPOLL;
502 backend_modify = epoll_modify; 517 backend_modify = epoll_modify;
503 backend_poll = epoll_poll; 518 backend_poll = epoll_poll;
504 } 519 }
505 520
506 timeout = 0; 521 timeout = EV_TS_CONST (0.);
507 /* it's easiest to handle this mess in another iteration */ 522 /* it's easiest to handle this mess in another iteration */
508 return; 523 return;
509 } 524 }
510 else if (errno == EBADF) 525 else if (errno == EBADF)
511 { 526 {
527 assert (("libev: event loop rejected bad fd", errno != EBADF));
512 fd_kill (EV_A_ linuxaio_submits [submitted]->aio_fildes); 528 fd_kill (EV_A_ linuxaio_submits [submitted]->aio_fildes);
513 529
514 res = 1; /* skip this iocb */ 530 res = 1; /* skip this iocb */
515 } 531 }
532 else if (errno == EINTR) /* not seen in reality, not documented */
533 res = 0; /* silently ignore and retry */
516 else 534 else
535 {
517 ev_syserr ("(libev) linuxaio io_submit"); 536 ev_syserr ("(libev) linuxaio io_submit");
537 res = 0;
538 }
518 539
519 submitted += res; 540 submitted += res;
520 } 541 }
521 542
522 linuxaio_submitcnt = 0; 543 linuxaio_submitcnt = 0;
545 { 566 {
546 epoll_destroy (EV_A); 567 epoll_destroy (EV_A);
547 return 0; 568 return 0;
548 } 569 }
549 570
550 ev_io_init (EV_A_ &linuxaio_epoll_w, linuxaio_epoll_cb, backend_fd, EV_READ); 571 ev_io_init (&linuxaio_epoll_w, linuxaio_epoll_cb, backend_fd, EV_READ);
551 ev_set_priority (&linuxaio_epoll_w, EV_MAXPRI); 572 ev_set_priority (&linuxaio_epoll_w, EV_MAXPRI);
552 ev_io_start (EV_A_ &linuxaio_epoll_w); 573 ev_io_start (EV_A_ &linuxaio_epoll_w);
553 ev_unref (EV_A); /* watcher should not keep loop alive */ 574 ev_unref (EV_A); /* watcher should not keep loop alive */
554 575
555 backend_modify = linuxaio_modify; 576 backend_modify = linuxaio_modify;
556 backend_poll = linuxaio_poll; 577 backend_poll = linuxaio_poll;
557 578
558 linuxaio_iocbpmax = 0; 579 linuxaio_iocbpmax = 0;
559 linuxaio_iocbps = 0; 580 linuxaio_iocbps = 0;
560 581
561 linuxaio_submits = 0; 582 linuxaio_submits = 0;
569void 590void
570linuxaio_destroy (EV_P) 591linuxaio_destroy (EV_P)
571{ 592{
572 epoll_destroy (EV_A); 593 epoll_destroy (EV_A);
573 linuxaio_free_iocbp (EV_A); 594 linuxaio_free_iocbp (EV_A);
574 evsys_io_destroy (linuxaio_ctx); 595 evsys_io_destroy (linuxaio_ctx); /* fails in child, aio context is destroyed */
575} 596}
576 597
577inline_size 598ecb_cold
578void 599static void
579linuxaio_fork (EV_P) 600linuxaio_fork (EV_P)
580{ 601{
581 /* this frees all iocbs, which is very heavy-handed */
582 linuxaio_destroy (EV_A);
583 linuxaio_submitcnt = 0; /* all pointers were invalidated */ 602 linuxaio_submitcnt = 0; /* all pointers were invalidated */
603 linuxaio_free_iocbp (EV_A); /* this frees all iocbs, which is very heavy-handed */
604 evsys_io_destroy (linuxaio_ctx); /* fails in child, aio context is destroyed */
584 605
585 linuxaio_iteration = 0; /* we start over in the child */ 606 linuxaio_iteration = 0; /* we start over in the child */
586 607
587 while (linuxaio_io_setup (EV_A) < 0) 608 while (linuxaio_io_setup (EV_A) < 0)
588 ev_syserr ("(libev) linuxaio io_setup"); 609 ev_syserr ("(libev) linuxaio io_setup");
589 610
611 /* forking epoll should also effectively unregister all fds from the backend */
590 epoll_fork (EV_A); 612 epoll_fork (EV_A);
613 /* epoll_fork already did this. hopefully */
614 /*fd_rearm_all (EV_A);*/
591 615
592 ev_io_stop (EV_A_ &linuxaio_epoll_w); 616 ev_io_stop (EV_A_ &linuxaio_epoll_w);
593 ev_io_set (EV_A_ &linuxaio_epoll_w, backend_fd, EV_READ); 617 ev_io_set (EV_A_ &linuxaio_epoll_w, backend_fd, EV_READ);
594 ev_io_start (EV_A_ &linuxaio_epoll_w); 618 ev_io_start (EV_A_ &linuxaio_epoll_w);
595
596 /* epoll_fork already did this. hopefully */
597 /*fd_rearm_all (EV_A);*/
598} 619}
599 620

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines