--- libev/ev_poll.c 2007/11/04 18:29:44 1.5 +++ libev/ev_poll.c 2007/11/23 05:13:49 1.16 @@ -42,26 +42,33 @@ poll_modify (EV_P_ int fd, int oev, int nev) { int idx; - array_needsize (pollidxs, pollidxmax, fd + 1, pollidx_init); + + if (oev == nev) + return; + + array_needsize (int, pollidxs, pollidxmax, fd + 1, pollidx_init); idx = pollidxs [fd]; if (idx < 0) /* need to allocate a new pollfd */ { - idx = pollcnt++; - array_needsize (polls, pollmax, pollcnt, ); + pollidxs [fd] = idx = pollcnt++; + array_needsize (struct pollfd, polls, pollmax, pollcnt, EMPTY2); polls [idx].fd = fd; } + assert (polls [idx].fd == fd); + if (nev) polls [idx].events = (nev & EV_READ ? POLLIN : 0) | (nev & EV_WRITE ? POLLOUT : 0); else /* remove pollfd */ { - if (idx < pollcnt--) + pollidxs [fd] = -1; + + if (idx < --pollcnt) { - pollidxs [fd] = -1; polls [idx] = polls [pollcnt]; pollidxs [polls [idx].fd] = idx; } @@ -71,45 +78,50 @@ static void poll_poll (EV_P_ ev_tstamp timeout) { - int res = poll (polls, pollcnt, ceil (timeout * 1000.)); - - if (res > 0) - { - int i; + int i; + int res = poll (polls, pollcnt, (int)ceil (timeout * 1000.)); - for (i = 0; i < pollcnt; ++i) - fd_event ( - EV_A_ - polls [i].fd, - (polls [i].revents & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0) - | (polls [i].revents & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0) - ); - } - else if (res < 0) + if (res < 0) { if (errno == EBADF) fd_ebadf (EV_A); - else if (errno == ENOMEM) + else if (errno == ENOMEM && !syserr_cb) fd_enomem (EV_A); + else if (errno != EINTR) + syserr ("(libev) poll"); + + return; } + + for (i = 0; i < pollcnt; ++i) + if (polls [i].revents & POLLNVAL) + fd_kill (EV_A_ polls [i].fd); + else + fd_event ( + EV_A_ + polls [i].fd, + (polls [i].revents & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0) + | (polls [i].revents & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0) + ); } static int poll_init (EV_P_ int flags) { - method_fudge = 1e-3; /* needed to compensate for select returning early, very conservative */ - method_modify = poll_modify; - method_poll = poll_poll; + backend_fudge = 1e-3; /* needed to compensate for select returning early, very conservative */ + backend_modify = poll_modify; + backend_poll = poll_poll; pollidxs = 0; pollidxmax = 0; polls = 0; pollmax = 0; pollcnt = 0; - return EVMETHOD_POLL; + return EVBACKEND_POLL; } static void poll_destroy (EV_P) { - free (pollidxs); - free (polls); + ev_free (pollidxs); + ev_free (polls); } +