--- libev/ev_poll.c 2008/04/10 06:48:12 1.23 +++ libev/ev_poll.c 2011/06/04 05:33:29 1.39 @@ -1,19 +1,19 @@ /* * libev poll fd activity backend * - * Copyright (c) 2007 Marc Alexander Lehmann + * Copyright (c) 2007,2008,2009,2010,2011 Marc Alexander Lehmann * All rights reserved. * * Redistribution and use in source and binary forms, with or without modifica- * tion, are permitted provided that the following conditions are met: - * + * * 1. Redistributions of source code must retain the above copyright notice, * this list of conditions and the following disclaimer. - * + * * 2. Redistributions in binary form must reproduce the above copyright * notice, this list of conditions and the following disclaimer in the * documentation and/or other materials provided with the distribution. - * + * * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MER- * CHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO @@ -42,6 +42,8 @@ void inline_size pollidx_init (int *base, int count) { + /* consider using memset (.., -1, ...), which is practically guaranteed + * to work on all systems implementing poll */ while (count--) *base++ = -1; } @@ -87,7 +89,11 @@ poll_poll (EV_P_ ev_tstamp timeout) { struct pollfd *p; - int res = poll (polls, pollcnt, (int)ceil (timeout * 1000.)); + int res; + + EV_RELEASE_CB; + res = poll (polls, pollcnt, timeout * 1e3); + EV_ACQUIRE_CB; if (expect_false (res < 0)) { @@ -96,32 +102,36 @@ else if (errno == ENOMEM && !syserr_cb) fd_enomem (EV_A); else if (errno != EINTR) - syserr ("(libev) poll"); + ev_syserr ("(libev) poll"); } - - for (p = polls; res; ++p) - if (expect_false (p->revents)) /* this expect is debatable */ + else + for (p = polls; res; ++p) { - --res; + assert (("libev: poll() returned illegal result, broken BSD kernel?", p < polls + pollcnt)); - if (expect_false (p->revents & POLLNVAL)) - fd_kill (EV_A_ p->fd); - else - fd_event ( - EV_A_ - p->fd, - (p->revents & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0) - | (p->revents & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0) - ); + if (expect_false (p->revents)) /* this expect is debatable */ + { + --res; + + if (expect_false (p->revents & POLLNVAL)) + fd_kill (EV_A_ p->fd); + else + fd_event ( + EV_A_ + p->fd, + (p->revents & (POLLOUT | POLLERR | POLLHUP) ? EV_WRITE : 0) + | (p->revents & (POLLIN | POLLERR | POLLHUP) ? EV_READ : 0) + ); + } } } int inline_size poll_init (EV_P_ int flags) { - backend_fudge = 0.; /* posix says this is zero */ - backend_modify = poll_modify; - backend_poll = poll_poll; + backend_mintime = 1e-3; + backend_modify = poll_modify; + backend_poll = poll_poll; pollidxs = 0; pollidxmax = 0; polls = 0; pollmax = 0; pollcnt = 0;