ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/libev/ev_port.c
(Generate patch)

Comparing libev/ev_port.c (file contents):
Revision 1.22 by root, Sat Oct 16 00:59:56 2010 UTC vs.
Revision 1.23 by root, Mon Jan 10 13:53:49 2011 UTC

33 * version of this file under the BSD license, indicate your decision 33 * version of this file under the BSD license, indicate your decision
34 * by deleting the provisions above and replace them with the notice 34 * by deleting the provisions above and replace them with the notice
35 * and other provisions required by the GPL. If you do not delete the 35 * and other provisions required by the GPL. If you do not delete the
36 * provisions above, a recipient may use your version of this file under 36 * provisions above, a recipient may use your version of this file under
37 * either the BSD or the GPL. 37 * either the BSD or the GPL.
38 */
39
40/* useful reading:
41 *
42 * http://bugs.opensolaris.org/view_bug.do?bug_id=6268715 (random results)
43 * http://bugs.opensolaris.org/view_bug.do?bug_id=6455223 (just totally broken)
44 * http://bugs.opensolaris.org/view_bug.do?bug_id=6873782 (manpage ETIME)
45 * http://bugs.opensolaris.org/view_bug.do?bug_id=6874410 (implementation ETIME)
46 * http://www.mail-archive.com/networking-discuss@opensolaris.org/msg11898.html ETIME vs. nget
47 * http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libc/port/gen/event_port.c (libc)
48 * http://cvs.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/fs/portfs/port.c#1325 (kernel)
38 */ 49 */
39 50
40#include <sys/types.h> 51#include <sys/types.h>
41#include <sys/time.h> 52#include <sys/time.h>
42#include <poll.h> 53#include <poll.h>
83{ 94{
84 int res, i; 95 int res, i;
85 struct timespec ts; 96 struct timespec ts;
86 uint_t nget = 1; 97 uint_t nget = 1;
87 98
99 /* we initialise this to something we will skip in the loop, as */
100 /* port_getn can return with nget unchanged, but no indication */
101 /* whether it was the original value or has been updated :/ */
102 port_events [0].portev_source = 0;
103
88 EV_RELEASE_CB; 104 EV_RELEASE_CB;
89 EV_TS_SET (ts, timeout); 105 EV_TS_SET (ts, timeout);
90 res = port_getn (backend_fd, port_events, port_eventmax, &nget, &ts); 106 res = port_getn (backend_fd, port_events, port_eventmax, &nget, &ts);
91 EV_ACQUIRE_CB; 107 EV_ACQUIRE_CB;
92 108
93 if (res == -1) 109 /* port_getn may or may not set nget on error */
94 { 110 /* so we rely on port_events [0].portev_source not being updated */
95 if (errno != EINTR && errno != ETIME) 111 if (res == -1 && errno != ETIME && errno != EINTR)
96 ev_syserr ("(libev) port_getn (see http://bugs.opensolaris.org/view_bug.do?bug_id=6268715, try LIBEV_FLAGS=3 env variable)"); 112 ev_syserr ("(libev) port_getn (see http://bugs.opensolaris.org/view_bug.do?bug_id=6268715, try LIBEV_FLAGS=3 env variable)");
97
98 return;
99 }
100 113
101 for (i = 0; i < nget; ++i) 114 for (i = 0; i < nget; ++i)
102 { 115 {
103 if (port_events [i].portev_source == PORT_SOURCE_FD) 116 if (port_events [i].portev_source == PORT_SOURCE_FD)
104 { 117 {
128{ 141{
129 /* Initialize the kernel queue */ 142 /* Initialize the kernel queue */
130 if ((backend_fd = port_create ()) < 0) 143 if ((backend_fd = port_create ()) < 0)
131 return 0; 144 return 0;
132 145
146 assert (("libev: PORT_SOURCE_FD must not be zero"), PORT_SOURCE_FD);
147
133 fcntl (backend_fd, F_SETFD, FD_CLOEXEC); /* not sure if necessary, hopefully doesn't hurt */ 148 fcntl (backend_fd, F_SETFD, FD_CLOEXEC); /* not sure if necessary, hopefully doesn't hurt */
134 149
135 backend_fudge = 1e-3; /* needed to compensate for port_getn returning early */ 150 backend_fudge = 1e-3; /* needed to compensate for port_getn returning early */
136 backend_modify = port_modify; 151 backend_modify = port_modify;
137 backend_poll = port_poll; 152 backend_poll = port_poll;

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines