[ViewVC] Diff of: cvs/liblzf/lzf

Comparing liblzf/lzf_c.c (file contents):
Revision 1.31 by root, Tue May 6 22:49:18 2008 UTC vs.
Revision 1.42 by root, Tue Jun 1 03:17:06 2010 UTC

 /*
- * Copyright (c) 2000-2007 Marc Alexander Lehmann <schmorp@schmorp.de>
+ * Copyright (c) 2000-2010 Marc Alexander Lehmann <schmorp@schmorp.de>
  *
  * Redistribution and use in source and binary forms, with or without modifica-
  * tion, are permitted provided that the following conditions are met:
  *
  *   1.  Redistributions of source code must retain the above copyright notice,
 #define HSIZE (1 << (HLOG))
 /*
  * don't play with this unless you benchmark!
- * decompression is not dependent on the hash function
+ * the data format is not dependent on the hash function.
- * the hashing function might seem strange, just believe me
+ * the hash function might seem strange, just believe me,
  * it works ;)
  */
 #ifndef FRST
 # define FRST(p) (((p[0]) << 8) | p[1])
 # define NEXT(v,p) (((v) << 8) | p[2])
 #define expect_true(expr)  expect ((expr) != 0, 1)
 /*
  * compressed format
  *
- * 000LLLLL <L+1>    ; literal
+ * 000LLLLL <L+1>    ; literal, L+1=1..33 octets
- * LLLooooo oooooooo ; backref L
+ * LLLooooo oooooooo ; backref L+1=1..7 octets, o+1=1..4096 offset
- * 111ooooo LLLLLLLL oooooooo ; backref L+7
+ * 111ooooo LLLLLLLL oooooooo ; backref L+8 octets, o+1=1..4096 offset
  *
  */
 unsigned int
 lzf_compress (const void *const in_data, unsigned int in_len,
               )
 {
 #if !LZF_STATE_ARG
   LZF_STATE htab;
 #endif
-  const u8 **hslot;
   const u8 *ip = (const u8 *)in_data;
         u8 *op = (u8 *)out_data;
   const u8 *in_end  = ip + in_len;
         u8 *out_end = op + out_len;
   const u8 *ref;
+  /* off requires a type wide enough to hold a general pointer difference.
+   * ISO C doesn't have that (size_t might not be enough and ptrdiff_t only
+   * works for differences within a single object). We also assume that no
+   * no bit pattern traps. Since the only platform that is both non-POSIX
+   * and fails to support both assumptions is windows 64 bit, we make a
+   * special workaround for it.
+   */
+#if defined (WIN32) && defined (_M_X64)
+  unsigned _int64 off; /* workaround for missing POSIX compliance */
+#else
+  unsigned long off;
+#endif
   unsigned int hval;
-#if WIN32
-  unsigned _int64 off; /* workaround for microsoft bug (they claim to support POSIX) */
-#else
-  unsigned long off;
-#endif
   int lit;
   if (!in_len || !out_len)
     return 0;
 #if INIT_HTAB
   memset (htab, 0, sizeof (htab));
-# if 0
-  for (hslot = htab; hslot < htab + HSIZE; hslot++)
-    *hslot++ = ip;
-# endif
 #endif
   lit = 0; op++; /* start run */
   hval = FRST (ip);
   while (ip < in_end - 2)
     {
+      LZF_HSLOT *hslot;
       hval = NEXT (hval, ip);
       hslot = htab + IDX (hval);
-      ref = *hslot; *hslot = ip;
+      ref = *hslot + LZF_HSLOT_BIAS; *hslot = ip - LZF_HSLOT_BIAS;
       if (1
 #if INIT_HTAB
           && ref < ip /* the next test will actually take care of this, but this is faster */
 #endif
           && (off = ip - ref - 1) < MAX_OFF
           && ip + 4 < in_end
           && ref > (u8 *)in_data
+          && ref[2] == ip[2]
 #if STRICT_ALIGN
-          && ref[0] == ip[0]
+          && (ref[1] << 8) | ref[0] == (ip[1] << 8) | ip[0]
-          && ref[1] == ip[1]
-          && ref[2] == ip[2]
 #else
           && *(u16 *)ref == *(u16 *)ip
-          && ref[2] == ip[2]
 #endif
         )
         {
           /* match found at *ref++ */
           unsigned int len = 2;
           unsigned int maxlen = in_end - ip - len;
           maxlen = maxlen > MAX_REF ? MAX_REF : maxlen;
+          if (expect_false (op + 3 + 1 >= out_end)) /* first a faster conservative test */
+            if (op - !lit + 3 + 1 >= out_end) /* second the exact but rare test */
+              return 0;
           op [- lit - 1] = lit - 1; /* stop run */
           op -= !lit; /* undo run if length is zero */
-          if (expect_false (op + 3 + 1 >= out_end))
-            return 0;
           for (;;)
             {
               if (expect_true (maxlen > 16))
                 {
               while (len < maxlen && ref[len] == ip[len]);
               break;
             }
-          len -= 2;
+          len -= 2; /* len is now #octets - 1 */
           ip++;
           if (len < 7)
             {
               *op++ = (off >> 8) + (len << 5);
               *op++ = (off >> 8) + (  7 << 5);
               *op++ = len - 7;
             }
           *op++ = off;
+          lit = 0; op++; /* start run */
+          ip += len + 1;
+          if (expect_false (ip >= in_end - 2))
+            break;
 #if ULTRA_FAST || VERY_FAST
-          ip += len;
-#if VERY_FAST && !ULTRA_FAST
           --ip;
+# if VERY_FAST && !ULTRA_FAST
+          --ip;
-#endif
+# endif
           hval = FRST (ip);
           hval = NEXT (hval, ip);
-          htab[IDX (hval)] = ip;
+          htab[IDX (hval)] = ip - LZF_HSLOT_BIAS;
           ip++;
-#if VERY_FAST && !ULTRA_FAST
+# if VERY_FAST && !ULTRA_FAST
           hval = NEXT (hval, ip);
-          htab[IDX (hval)] = ip;
+          htab[IDX (hval)] = ip - LZF_HSLOT_BIAS;
           ip++;
-#endif
+# endif
 #else
+          ip -= len + 1;
           do
             {
               hval = NEXT (hval, ip);
-              htab[IDX (hval)] = ip;
+              htab[IDX (hval)] = ip - LZF_HSLOT_BIAS;
               ip++;
             }
           while (len--);
 #endif
-          lit = 0; op++; /* start run */
         }
       else
         {
           /* one more literal byte we must copy */
           if (expect_false (op >= out_end))

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing liblzf/lzf_c.c (file contents): Revision 1.31 by root, Tue May 6 22:49:18 2008 UTC vs. Revision 1.42 by root, Tue Jun 1 03:17:06 2010 UTC

Diff Legend

Comparing liblzf/lzf_c.c (file contents):
Revision 1.31 by root, Tue May 6 22:49:18 2008 UTC vs.
Revision 1.42 by root, Tue Jun 1 03:17:06 2010 UTC