--- rxvt-unicode/src/background.C 2010/10/22 18:03:10 1.97 +++ rxvt-unicode/src/background.C 2010/11/01 14:29:33 1.107 @@ -731,7 +731,7 @@ if (!pixbuf) return false; -#if !XFT +#if !XRENDER if (background_flags) return false; #endif @@ -858,13 +858,13 @@ 0, 0); } -#if XFT +#if XRENDER if (background_flags) { Display *dpy = target->dpy; XRenderPictureAttributes pa; - XRenderPictFormat *src_format = XRenderFindVisualFormat (dpy, DefaultVisual (dpy, target->display->screen)); + XRenderPictFormat *src_format = XRenderFindVisualFormat (dpy, target->visual); Picture src = XRenderCreatePicture (dpy, root_pmap, src_format, 0, &pa); XRenderPictFormat *dst_format = XRenderFindVisualFormat (dpy, target->visual); @@ -911,45 +911,43 @@ bool bgPixmap_t::set_file (const char *file) { - assert (file); + if (!file || !*file) + return false; - if (*file) + if (const char *p = strchr (file, ';')) { - if (const char *p = strchr (file, ';')) - { - size_t len = p - file; - char *f = rxvt_temp_buf (len + 1); - memcpy (f, file, len); - f[len] = '\0'; - file = f; - } + size_t len = p - file; + char *f = rxvt_temp_buf (len + 1); + memcpy (f, file, len); + f[len] = '\0'; + file = f; + } # ifdef HAVE_AFTERIMAGE - if (!target->asimman) - target->asimman = create_generic_imageman (target->rs[Rs_path]); - ASImage *image = get_asimage (target->asimman, file, 0xFFFFFFFF, 100); - if (image) - { - if (original_asim) - safe_asimage_destroy (original_asim); - original_asim = image; - have_image = true; - return true; - } + if (!target->asimman) + target->asimman = create_generic_imageman (target->rs[Rs_path]); + ASImage *image = get_asimage (target->asimman, file, 0xFFFFFFFF, 100); + if (image) + { + if (original_asim) + safe_asimage_destroy (original_asim); + original_asim = image; + have_image = true; + return true; + } # endif # ifdef HAVE_PIXBUF - GdkPixbuf *image = gdk_pixbuf_new_from_file (file, NULL); - if (image) - { - if (pixbuf) - g_object_unref (pixbuf); - pixbuf = image; - have_image = true; - return true; - } -# endif + GdkPixbuf *image = gdk_pixbuf_new_from_file (file, NULL); + if (image) + { + if (pixbuf) + g_object_unref (pixbuf); + pixbuf = image; + have_image = true; + return true; } +# endif return false; } @@ -1002,8 +1000,8 @@ else flags |= blurNeeded; -#if XFT - XFilters *filters = XRenderQueryFilters (target->dpy, target->display->root); +#if XRENDER + XFilters *filters = XRenderQueryFilters (target->dpy, target->vt); if (filters) { for (int i = 0; i < filters->nfilter; i++) @@ -1052,7 +1050,7 @@ flags |= bgPixmap_t::tintServerSide; else { -#if XFT +#if XRENDER flags |= bgPixmap_t::tintServerSide; #endif } @@ -1109,7 +1107,7 @@ return false; } -#if XFT +#if XRENDER static void get_gaussian_kernel (int radius, int width, double *kernel, XFixed *params) { @@ -1136,7 +1134,7 @@ bgPixmap_t::blur_pixmap (Pixmap pixmap, Visual *visual, int width, int height) { bool ret = false; -#if XFT +#if XRENDER int size = max (h_blurRadius, v_blurRadius) * 2 + 1; double *kernel = (double *)malloc (size * sizeof (double)); XFixed *params = (XFixed *)malloc ((size + 2) * sizeof (XFixed)); @@ -1223,7 +1221,7 @@ } else { -# if XFT +# if XRENDER rgba c (rgba::MAX_CC,rgba::MAX_CC,rgba::MAX_CC); if (flags & tintSet) @@ -1286,8 +1284,8 @@ } /* make_transparency_pixmap() - * Builds a pixmap sized the same as terminal window, with depth same as the root window - * that pixmap contains tiled portion of the root pixmap that is supposed to be covered by + * Builds a pixmap of the same size as the terminal window that contains + * the tiled portion of the root pixmap that is supposed to be covered by * our window. */ unsigned long @@ -1301,9 +1299,9 @@ /* root dimensions may change from call to call - but Display structure should * be always up-to-date, so let's use it : */ - Window root = target->display->root; int screen = target->display->screen; Display *dpy = target->dpy; + int root_depth = DefaultDepth (dpy, screen); int root_width = DisplayWidth (dpy, screen); int root_height = DisplayHeight (dpy, screen); unsigned int root_pmap_width, root_pmap_height; @@ -1320,30 +1318,60 @@ || sx >= root_width || sy >= root_height) return 0; + // validate root pixmap and get its size if (root_pixmap != None) { - /* we want to validate the pixmap and get its size at the same time : */ - int junk; - unsigned int ujunk; - /* root pixmap may be bad - allow a error */ + Window wdummy; + int idummy; + unsigned int udummy; + target->allowedxerror = -1; - if (!XGetGeometry (dpy, root_pixmap, &root, &junk, &junk, &root_pmap_width, &root_pmap_height, &ujunk, &ujunk)) + if (!XGetGeometry (dpy, root_pixmap, &wdummy, &idummy, &idummy, &root_pmap_width, &root_pmap_height, &udummy, &udummy)) root_pixmap = None; target->allowedxerror = 0; } + Pixmap recoded_root_pmap = root_pixmap; + + if (root_pixmap != None && root_depth != target->depth) + { +#if XRENDER + XRenderPictureAttributes pa; + + XRenderPictFormat *src_format = XRenderFindVisualFormat (dpy, DefaultVisual (dpy, screen)); + Picture src = XRenderCreatePicture (dpy, root_pixmap, src_format, 0, &pa); + + recoded_root_pmap = XCreatePixmap (dpy, target->vt, root_pmap_width, root_pmap_height, target->depth); + XRenderPictFormat *dst_format = XRenderFindVisualFormat (dpy, target->visual); + Picture dst = XRenderCreatePicture (dpy, recoded_root_pmap, dst_format, 0, &pa); + + if (src && dst) + XRenderComposite (dpy, PictOpSrc, src, None, dst, 0, 0, 0, 0, 0, 0, root_pmap_width, root_pmap_height); + else + { + XFreePixmap (dpy, recoded_root_pmap); + root_pixmap = None; + } + + XRenderFreePicture (dpy, src); + XRenderFreePicture (dpy, dst); +#else + root_pixmap = None; +#endif + } + if (root_pixmap == None) return 0; - Pixmap tiled_root_pmap = XCreatePixmap (dpy, root, window_width, window_height, root_depth); + Pixmap tiled_root_pmap = XCreatePixmap (dpy, target->vt, window_width, window_height, target->depth); if (tiled_root_pmap == None) /* something really bad happened - abort */ return 0; /* straightforward pixmap copy */ - gcv.tile = root_pixmap; + gcv.tile = recoded_root_pmap; gcv.fill_style = FillTiled; while (sx < 0) sx += (int)root_width; @@ -1351,7 +1379,7 @@ gcv.ts_x_origin = -sx; gcv.ts_y_origin = -sy; - gc = XCreateGC (dpy, root, GCFillStyle | GCTile | GCTileStipXOrigin | GCTileStipYOrigin, &gcv); + gc = XCreateGC (dpy, target->vt, GCFillStyle | GCTile | GCTileStipXOrigin | GCTileStipYOrigin, &gcv); if (gc) { @@ -1364,14 +1392,16 @@ { if (!need_client_side_rendering ()) { - if (flags & (blurNeeded | blurServerSide)) + if ((flags & blurNeeded) + && (flags & blurServerSide)) { - if (blur_pixmap (tiled_root_pmap, DefaultVisual (dpy, screen), window_width, window_height)) + if (blur_pixmap (tiled_root_pmap, target->visual, window_width, window_height)) result |= transpPmapBlurred; } - if (flags & (tintNeeded | tintServerSide)) + if ((flags & tintNeeded) + && (flags & tintServerSide)) { - if (tint_pixmap (tiled_root_pmap, DefaultVisual (dpy, screen), window_width, window_height)) + if (tint_pixmap (tiled_root_pmap, target->visual, window_width, window_height)) result |= transpPmapTinted; } } /* server side rendering completed */ @@ -1382,26 +1412,23 @@ pixmap = tiled_root_pmap; pmap_width = window_width; pmap_height = window_height; - pmap_depth = root_depth; + pmap_depth = target->depth; } + if (recoded_root_pmap != root_pixmap) + XFreePixmap (dpy, recoded_root_pmap); + return result; } -bool +void bgPixmap_t::set_root_pixmap () { Pixmap new_root_pixmap = target->get_pixmap_property (XA_XROOTPMAP_ID); if (new_root_pixmap == None) new_root_pixmap = target->get_pixmap_property (XA_ESETROOT_PMAP_ID); - if (new_root_pixmap != root_pixmap) - { - root_pixmap = new_root_pixmap; - return true; - } - - return false; + root_pixmap = new_root_pixmap; } # endif /* ENABLE_TRANSPARENCY */ @@ -1425,8 +1452,7 @@ background_flags = make_transparency_pixmap (); if (background_flags == 0) return false; - else if ((background_flags & transpTransformations) == (flags & transpTransformations) - && pmap_depth == target->depth) + else if ((background_flags & transpTransformations) == (flags & transpTransformations)) flags = flags & ~isInvalid; } # endif @@ -1449,10 +1475,8 @@ if (result) { -# if !defined(HAVE_AFTERIMAGE) && !XFT +# if !defined(HAVE_AFTERIMAGE) && !XRENDER /* our own client-side tinting */ - /* ATTENTION: We ASSUME that XFT will let us do all the tinting necessary server-side. - This may need to be changed in need_client_side_rendering() logic is altered !!! */ if (!(background_flags & transpPmapTinted) && (flags & tintNeeded)) { rgba c (rgba::MAX_CC,rgba::MAX_CC,rgba::MAX_CC); @@ -1466,35 +1490,7 @@ if (gc) { - if (/*pmap_depth != target->depth &&*/ pixmap != None) - { - XFreePixmap (target->dpy, pixmap); - pixmap = None; - } - - if (pixmap == None) - { - pixmap = XCreatePixmap (target->dpy, target->vt, result->width, result->height, target->depth); - pmap_width = result->width; - pmap_height = result->height; - pmap_depth = target->depth; - } - - if (pmap_depth != result->depth) - { - /* Bad Match error will ensue ! stupid X !!!! */ - if (result->depth == 24 && pmap_depth == 32) - result->depth = 32; - else if (result->depth == 32 && pmap_depth == 24) - result->depth = 24; - else - { - /* TODO: implement image recoding */ - } - } - - if (pmap_depth == result->depth) - XPutImage (target->dpy, pixmap, gc, result, 0, 0, 0, 0, result->width, result->height); + XPutImage (target->dpy, pixmap, gc, result, 0, 0, 0, 0, result->width, result->height); XFreeGC (target->dpy, gc); flags = flags & ~isInvalid; @@ -1519,79 +1515,69 @@ return true; } -bool +void bgPixmap_t::set_target (rxvt_term *new_target) { - if (new_target) - if (target != new_target) - { - target = new_target; -# ifdef ENABLE_TRANSPARENCY - root_depth = DefaultDepthOfScreen (ScreenOfDisplay (target->dpy, target->display->screen)); -# endif - return true; - } - - return false; + target = new_target; } void bgPixmap_t::apply () { - if (target) + if (target == NULL) + return; + + if (pixmap != None) { - if (pixmap != None) - { - /* set target's background to pixmap */ + /* set target's background to pixmap */ # ifdef ENABLE_TRANSPARENCY - if (flags & isTransparent) - { - XSetWindowBackgroundPixmap (target->dpy, target->parent[0], pixmap); - XSetWindowBackgroundPixmap (target->dpy, target->vt, ParentRelative); - - if (target->scrollBar.win) - XSetWindowBackgroundPixmap (target->dpy, target->scrollBar.win, ParentRelative); - } - else -# endif - { - /* force old pixmap dereference in case it was transparent before :*/ - XSetWindowBackground (target->dpy, target->parent[0], target->pix_colors[Color_border]); - XSetWindowBackgroundPixmap (target->dpy, target->vt, pixmap); - /* do we also need to set scrollbar's background here ? */ + if (flags & isTransparent) + { + XSetWindowBackgroundPixmap (target->dpy, target->parent[0], pixmap); + XSetWindowBackgroundPixmap (target->dpy, target->vt, ParentRelative); - if (target->scrollBar.win) - XSetWindowBackground (target->dpy, target->scrollBar.win, target->pix_colors[Color_border]); - } + if (target->scrollBar.win) + XSetWindowBackgroundPixmap (target->dpy, target->scrollBar.win, ParentRelative); } else +# endif { - /* set target background to a pixel */ + /* force old pixmap dereference in case it was transparent before :*/ XSetWindowBackground (target->dpy, target->parent[0], target->pix_colors[Color_border]); - XSetWindowBackground (target->dpy, target->vt, target->pix_colors[Color_bg]); + XSetWindowBackgroundPixmap (target->dpy, target->vt, pixmap); /* do we also need to set scrollbar's background here ? */ + if (target->scrollBar.win) XSetWindowBackground (target->dpy, target->scrollBar.win, target->pix_colors[Color_border]); } + } + else + { + /* set target background to a pixel */ + XSetWindowBackground (target->dpy, target->parent[0], target->pix_colors[Color_border]); + XSetWindowBackground (target->dpy, target->vt, target->pix_colors[Color_bg]); + /* do we also need to set scrollbar's background here ? */ + if (target->scrollBar.win) + XSetWindowBackground (target->dpy, target->scrollBar.win, target->pix_colors[Color_border]); + } - /* don't want Expose on the parent or vt. It is better to use - scr_touch or we get a great deal of flicker otherwise: */ - XClearWindow (target->dpy, target->parent[0]); + /* don't want Expose on the parent or vt. It is better to use + scr_touch or we get a great deal of flicker otherwise: */ + XClearWindow (target->dpy, target->parent[0]); - if (target->scrollBar.state && target->scrollBar.win) - { - target->scrollBar.state = STATE_IDLE; - target->scrollBar.show (0); - } - - target->want_refresh = 1; - flags |= hasChanged; + if (target->scrollBar.state && target->scrollBar.win) + { + target->scrollBar.state = STATE_IDLE; + target->scrollBar.show (0); } + + target->want_refresh = 1; + flags |= hasChanged; } #endif /* HAVE_BG_PIXMAP */ -#if defined(ENABLE_TRANSPARENCY) && !defined(HAVE_AFTERIMAGE) && !XFT +#if defined(ENABLE_TRANSPARENCY) && !defined(HAVE_AFTERIMAGE) && !XRENDER /* taken from aterm-0.4.2 */ static void