ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/rxvt-unicode/src/keyboard.C
(Generate patch)

Comparing rxvt-unicode/src/keyboard.C (file contents):
Revision 1.7 by root, Sun Jan 16 23:55:42 2005 UTC vs.
Revision 1.39 by root, Mon Feb 21 07:41:01 2011 UTC

1/*----------------------------------------------------------------------*
2 * File: keyboard.C
3 *----------------------------------------------------------------------*
4 *
5 * All portions of code are copyright by their respective author/s.
6 * Copyright (c) 2005 WU Fengguang
7 * Copyright (c) 2005-2006 Marc Lehmann <schmorp@schmorp.de>
8 *
9 * This program is free software; you can redistribute it and/or modify
10 * it under the terms of the GNU General Public License as published by
11 * the Free Software Foundation; either version 2 of the License, or
12 * (at your option) any later version.
13 *
14 * This program is distributed in the hope that it will be useful,
15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17 * GNU General Public License for more details.
18 *
19 * You should have received a copy of the GNU General Public License
20 * along with this program; if not, write to the Free Software
21 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
22 *----------------------------------------------------------------------*/
23
1#include "../config.h" 24#include "../config.h"
2#include "rxvt.h" 25#include "rxvt.h"
3 26
4#ifdef KEYSYM_RESOURCE 27#ifdef KEYSYM_RESOURCE
5 28
6#include <cstring> 29#include <cstring>
7 30
31#include "rxvtperl.h"
8#include "keyboard.h" 32#include "keyboard.h"
9#include "command.h" 33#include "command.h"
10 34
11//////////////////////////////////////////////////////////////////////////////// 35/* an intro to the data structure:
12// default keycode translation map and keyevent handlers 36 *
13 37 * vector keymap[] is grouped.
14keysym_t keyboard_manager::stock_keymap[] = { 38 *
15 /* examples */ 39 * inside each group, elements are sorted by the criteria given by compare_priority().
16 /* keysym, state, range, handler, str */ 40 * the lookup of keysym is done in two steps:
17//{XK_ISO_Left_Tab, 0, 1, NORMAL, "\033[Z"}, 41 * 1) locate the group corresponds to the keysym;
18//{ 'a', 0, 26, RANGE_META8, "a" "%c"}, 42 * 2) do a linear search inside the group.
19//{ 'a', ControlMask, 26, RANGE_META8, "" "%c"}, 43 *
20//{ XK_Left, 0, 4, LIST, "DACBZ" "\033[Z"}, 44 * array hash[] effectively defines a map from a keysym to a group in keymap[].
21//{ XK_Left, ShiftMask, 4, LIST, "dacbZ" "\033[Z"}, 45 *
22//{ XK_Left, ControlMask, 4, LIST, "dacbZ" "\033OZ"}, 46 * each group has its address(the index of first group element in keymap[]),
23//{ XK_Tab, ControlMask, 1, NORMAL, "\033<C-Tab>"}, 47 * which is computed and stored in hash[].
24//{ XK_apostrophe, ControlMask, 1, NORMAL, "\033<C-'>"}, 48 * hash[] stores the addresses in the form of:
25//{ XK_slash, ControlMask, 1, NORMAL, "\033<C-/>"}, 49 * index: 0 I1 I2 I3 In
26//{ XK_semicolon, ControlMask, 1, NORMAL, "\033<C-;>"}, 50 * value: 0...0, A1...A1, A2...A2, A3...A3, ..., An...An
27//{ XK_grave, ControlMask, 1, NORMAL, "\033<C-`>"}, 51 * where
28//{ XK_comma, ControlMask, 1, NORMAL, "\033<C-\054>"}, 52 * A1 = 0;
29//{ XK_Return, ControlMask, 1, NORMAL, "\033<C-Return>"}, 53 * Ai+1 = N1 + N2 + ... + Ni.
30//{ XK_Return, ShiftMask, 1, NORMAL, "\033<S-Return>"}, 54 * it is computed from hash_bucket_size[]:
31//{ ' ', ShiftMask, 1, NORMAL, "\033<S-Space>"}, 55 * index: 0 I1 I2 I3 In
32//{ '.', ControlMask, 1, NORMAL, "\033<C-.>"}, 56 * value: 0...0, N1, 0...0, N2, 0...0, N3, ..., Nn, 0...0
33//{ '0', ControlMask, 10, RANGE, "0" "\033<C-%c>"}, 57 * 0...0, 0.......0, N1.....N1, N1+N2...N1+N2, ... (the computation of hash[])
34//{ '0', MetaMask|ControlMask, 10, RANGE, "0" "\033<M-C-%c>"}, 58 * or we can say
35//{ 'a', MetaMask|ControlMask, 26, RANGE, "a" "\033<M-C-%c>"}, 59 * hash_bucket_size[Ii] = Ni; hash_bucket_size[elsewhere] = 0,
36}; 60 * where
61 * set {I1, I2, ..., In} = { hashkey of keymap[0]->keysym, ..., keymap[keymap.size-1]->keysym }
62 * where hashkey of keymap[i]->keysym = keymap[i]->keysym & KEYSYM_HASH_MASK
63 * n(the number of groups) = the number of non-zero member of hash_bucket_size[];
64 * Ni(the size of group i) = hash_bucket_size[Ii].
65 */
37 66
38static void 67static void
39output_string (rxvt_term *rt, const char *str) 68output_string (rxvt_term *rt, const char *str)
40{ 69{
41 assert (rt && str); 70 if (strncmp (str, "command:", 8) == 0)
42 71 rt->cmd_write (str + 8, strlen (str) - 8);
43 if (strncmp (str, "proto:", 6) == 0) 72 else if (strncmp (str, "perl:", 5) == 0)
44 rt->cmd_write ((unsigned char *)str + 6, strlen (str) - 6); 73 HOOK_INVOKE((rt, HOOK_USER_COMMAND, DT_STR, str + 5, DT_END));
45 else 74 else
46 rt->tt_write ((unsigned char *)str, strlen (str)); 75 rt->tt_write (str, strlen (str));
47} 76}
48
49static void
50output_string_meta8 (rxvt_term *rt, unsigned int state, char *buf, int buflen)
51{
52 if (state & rt->ModMetaMask)
53 {
54#ifdef META8_OPTION
55 if (rt->meta_char == 0x80) /* set 8-bit on */
56 {
57 for (char *ch = buf; ch < buf + buflen; ch++)
58 *ch |= 0x80;
59 }
60 else if (rt->meta_char == C0_ESC) /* escape prefix */
61#endif
62 {
63 const unsigned char ch = C0_ESC;
64 rt->tt_write (&ch, 1);
65 }
66 }
67
68 rt->tt_write ((unsigned char *) buf, buflen);
69}
70
71static int
72format_keyrange_string (const char *str, int keysym_offset, char *buf, int bufsize)
73{
74 size_t len = snprintf (buf, bufsize, str + 1, keysym_offset + str [0]);
75
76 if (len >= (size_t)bufsize)
77 {
78 rxvt_warn ("format_keyrange_string: formatting failed, ignoring key.\n");
79 *buf = 0;
80 }
81
82 return len;
83}
84
85////////////////////////////////////////////////////////////////////////////////
86// return: #bits of '1'
87#if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ > 3)
88# define bitcount(n) (__extension__ ({ uint32_t n__ = (n); __builtin_popcount (n); }))
89#else
90static int
91bitcount (uint16_t n)
92{
93 int i;
94
95 for (i = 0; n; ++i, n &= n - 1)
96 ;
97
98 return i;
99}
100#endif
101 77
102// return: priority_of_a - priority_of_b 78// return: priority_of_a - priority_of_b
103static int 79static int
104compare_priority (keysym_t *a, keysym_t *b) 80compare_priority (keysym_t *a, keysym_t *b)
105{ 81{
106 assert (a && b);
107
108 // (the more '1's in state; the less range): the greater priority 82 // (the more '1's in state; the less range): the greater priority
109 int ca = bitcount (a->state /* & OtherModMask */); 83 int ca = rxvt_popcount (a->state /* & OtherModMask */);
110 int cb = bitcount (b->state /* & OtherModMask */); 84 int cb = rxvt_popcount (b->state /* & OtherModMask */);
111 85
112 if (ca != cb) 86 if (ca != cb)
113 return ca - cb; 87 return ca - cb;
114//else if (a->state != b->state) // this behavior is to be disscussed 88//else if (a->state != b->state) // this behavior is to be discussed
115// return b->state - a->state; 89// return b->state - a->state;
116 else 90 else
117 return b->range - a->range; 91 return b->range - a->range;
118} 92}
119 93
130} 104}
131 105
132void 106void
133keyboard_manager::clear () 107keyboard_manager::clear ()
134{ 108{
109 hash [0] = 2;
110
111 for (unsigned int i = 0; i < keymap.size (); ++i)
112 {
113 free ((void *)keymap [i]->str);
114 delete keymap [i];
115 keymap [i] = 0;
116 }
117
135 keymap.clear (); 118 keymap.clear ();
136 hash [0] = 2;
137
138 for (unsigned int i = 0; i < user_translations.size (); ++i)
139 {
140 free ((void *)user_translations [i]);
141 user_translations [i] = 0;
142 }
143
144 for (unsigned int i = 0; i < user_keymap.size (); ++i)
145 {
146 delete user_keymap [i];
147 user_keymap [i] = 0;
148 }
149
150 user_keymap.clear ();
151 user_translations.clear ();
152} 119}
153 120
154// a wrapper for register_keymap, 121// a wrapper for register_keymap,
155// so that outside codes don't have to know so much details. 122// so that outside codes don't have to know so much details.
156// 123//
157// the string 'trans' is copied to an internal managed buffer, 124// the string 'trans' is copied to an internal managed buffer,
158// so the caller can free memory of 'trans' at any time. 125// so the caller can free memory of 'trans' at any time.
159void 126void
160keyboard_manager::register_user_translation (KeySym keysym, unsigned int state, const char *trans) 127keyboard_manager::register_user_translation (KeySym keysym, unsigned int state, const char *trans)
161{ 128{
162 assert (trans);
163
164 keysym_t *key = new keysym_t; 129 keysym_t *key = new keysym_t;
165 wchar_t *wc = rxvt_mbstowcs (trans); 130 wchar_t *wc = rxvt_mbstowcs (trans);
166printf ("CONV <%s> %x %x %x %x\n", trans, (int)wc[0], (int)wc[1], (int)wc[2], (int)wc[3]);
167 const char *translation = rxvt_wcstoutf8 (wc); 131 char *translation = rxvt_wcstoutf8 (wc);
168 free (wc); 132 free (wc);
169 133
170 if (key && translation) 134 if (key && translation)
171 { 135 {
172 key->keysym = keysym; 136 key->keysym = keysym;
173 key->state = state; 137 key->state = state;
174 key->range = 1; 138 key->range = 1;
175 key->str = translation; 139 key->str = translation;
176 key->type = keysym_t::NORMAL; 140 key->type = keysym_t::STRING;
177 141
178 if (strncmp (translation, "list", 4) == 0 && translation [4]) 142 if (strncmp (translation, "list", 4) == 0 && translation [4])
179 { 143 {
180 char *middle = strchr (translation + 5, translation [4]); 144 char *middle = strchr (translation + 5, translation [4]);
181 char *suffix = strrchr (translation + 5, translation [4]); 145 char *suffix = strrchr (translation + 5, translation [4]);
182 146
183 if (suffix && middle && suffix > middle + 1) 147 if (suffix && middle && suffix > middle + 1)
184 { 148 {
185 key->type = keysym_t::LIST; 149 key->type = keysym_t::LIST;
186 key->range = suffix - middle - 1; 150 key->range = suffix - middle - 1;
187 151
188 strcpy (translation, translation + 4); 152 memmove (translation, translation + 4, strlen (translation + 4) + 1);
189 } 153 }
190 else 154 else
191 rxvt_warn ("cannot parse list-type keysym '%s', treating as normal keysym.\n", translation); 155 rxvt_warn ("cannot parse list-type keysym '%s', treating as normal keysym.\n", translation);
192 } 156 }
157 else if (strncmp (translation, "builtin:", 8) == 0)
158 key->type = keysym_t::BUILTIN;
193 159
194 user_keymap.push_back (key);
195 user_translations.push_back (translation);
196 register_keymap (key); 160 register_keymap (key);
197 } 161 }
198 else 162 else
199 { 163 {
200 delete key; 164 delete key;
204} 168}
205 169
206void 170void
207keyboard_manager::register_keymap (keysym_t *key) 171keyboard_manager::register_keymap (keysym_t *key)
208{ 172{
209 assert (key);
210 assert (key->range >= 1);
211
212 if (keymap.size () == keymap.capacity ()) 173 if (keymap.size () == keymap.capacity ())
213 keymap.reserve (keymap.size () * 2); 174 keymap.reserve (keymap.size () * 2);
214 175
215 keymap.push_back (key); 176 keymap.push_back (key);
216 hash[0] = 3; 177 hash[0] = 3;
217} 178}
218 179
219void 180void
220keyboard_manager::register_done () 181keyboard_manager::register_done ()
221{ 182{
222 unsigned int i, n = sizeof (stock_keymap) / sizeof (keysym_t);
223
224 if (keymap.back () != &stock_keymap[n - 1])
225 for (i = 0; i < n; ++i)
226 register_keymap (&stock_keymap[i]);
227
228 purge_duplicate_keymap ();
229
230 setup_hash (); 183 setup_hash ();
231} 184}
232 185
233bool 186bool
234keyboard_manager::dispatch (rxvt_term *term, KeySym keysym, unsigned int state) 187keyboard_manager::dispatch (rxvt_term *term, KeySym keysym, unsigned int state)
235{ 188{
236 assert (hash[0] == 0 && "register_done() need to be called"); 189 assert (hash[0] == 0 && "register_done() need to be called");
190
191 state &= OtherModMask; // mask out uninteresting modifiers
237 192
238 if (state & term->ModMetaMask) state |= MetaMask; 193 if (state & term->ModMetaMask) state |= MetaMask;
239 if (state & term->ModNumLockMask) state |= NumLockMask; 194 if (state & term->ModNumLockMask) state |= NumLockMask;
240 if (state & term->ModLevel3Mask) state |= Level3Mask; 195 if (state & term->ModLevel3Mask) state |= Level3Mask;
241 196
246 201
247 if (index >= 0) 202 if (index >= 0)
248 { 203 {
249 const keysym_t &key = *keymap [index]; 204 const keysym_t &key = *keymap [index];
250 205
251 int keysym_offset = keysym - key.keysym; 206 if (key.type != keysym_t::BUILTIN)
252
253 wchar_t *wc = rxvt_utf8towcs (key.str);
254
255 char *str = rxvt_wcstombs (wc);
256 // TODO: do translations, unescaping etc, here (allow \u escape etc.)
257 free (wc);
258
259 switch (key.type)
260 { 207 {
261 case keysym_t::NORMAL: 208 int keysym_offset = keysym - key.keysym;
262 output_string (term, str);
263 break;
264 209
265 case keysym_t::RANGE: 210 wchar_t *wc = rxvt_utf8towcs (key.str);
211 char *str = rxvt_wcstombs (wc);
212 // TODO: do (some) translations, unescaping etc, here (allow \u escape etc.)
213 free (wc);
214
215 switch (key.type)
266 { 216 {
217 case keysym_t::STRING:
218 output_string (term, str);
219 break;
220
221 case keysym_t::LIST:
222 {
267 char buf[STRING_MAX]; 223 char buf[STRING_MAX];
268 224
269 if (format_keyrange_string (str, keysym_offset, buf, sizeof (buf)) > 0) 225 char *prefix, *middle, *suffix;
226
227 prefix = str;
228 middle = strchr (prefix + 1, *prefix);
229 suffix = strrchr (middle + 1, *prefix);
230
231 memcpy (buf, prefix + 1, middle - prefix - 1);
232 buf [middle - prefix - 1] = middle [keysym_offset + 1];
233 strcpy (buf + (middle - prefix), suffix + 1);
234
270 output_string (term, buf); 235 output_string (term, buf);
236 }
237 break;
271 } 238 }
272 break;
273 239
274 case keysym_t::RANGE_META8: 240 free (str);
275 {
276 int len;
277 char buf[STRING_MAX];
278 241
279 len = format_keyrange_string (str, keysym_offset, buf, sizeof (buf)); 242 return true;
280 if (len > 0)
281 output_string_meta8 (term, state, buf, len);
282 }
283 break;
284
285 case keysym_t::LIST:
286 {
287 char buf[STRING_MAX];
288
289 char *prefix, *middle, *suffix;
290
291 prefix = str;
292 middle = strchr (prefix + 1, *prefix);
293 suffix = strrchr (middle + 1, *prefix);
294
295 memcpy (buf, prefix + 1, middle - prefix - 1);
296 buf [middle - prefix - 1] = middle [keysym_offset + 1];
297 strcpy (buf + (middle - prefix), suffix + 1);
298
299 output_string (term, buf);
300 }
301 break;
302 } 243 }
303
304 free (str);
305
306 return true;
307 }
308 else
309 { 244 }
310 // fprintf(stderr,"[%x:%x]",state,keysym); 245
311 return false; 246 return false;
312 }
313}
314
315// purge duplicate keymap entries
316void keyboard_manager::purge_duplicate_keymap ()
317{
318 for (unsigned int i = 0; i < keymap.size (); ++i)
319 {
320 for (unsigned int j = 0; j < i; ++j)
321 {
322 if (keymap [i] == keymap [j])
323 {
324 while (keymap [i] == keymap.back ())
325 keymap.pop_back ();
326
327 if (i < keymap.size ())
328 {
329 keymap[i] = keymap.back ();
330 keymap.pop_back ();
331 }
332 break;
333 }
334 }
335 }
336} 247}
337 248
338void 249void
339keyboard_manager::setup_hash () 250keyboard_manager::setup_hash ()
340{ 251{
341 unsigned int i, index, hashkey; 252 unsigned int i, index, hashkey;
342 vector <keysym_t *> sorted_keymap; 253 vector <keysym_t *> sorted_keymap;
343 uint16_t hash_budget_size[KEYSYM_HASH_BUDGETS]; // size of each budget 254 uint16_t hash_bucket_size[KEYSYM_HASH_BUCKETS]; // size of each bucket
344 uint16_t hash_budget_counter[KEYSYM_HASH_BUDGETS]; // #elements in each budget
345 255
346 memset (hash_budget_size, 0, sizeof (hash_budget_size)); 256 memset (hash_bucket_size, 0, sizeof (hash_bucket_size));
347 memset (hash_budget_counter, 0, sizeof (hash_budget_counter));
348 257
349 // count keysyms for corresponding hash budgets 258 // determine hash bucket size
350 for (i = 0; i < keymap.size (); ++i) 259 for (i = 0; i < keymap.size (); ++i)
260 for (int j = min (keymap [i]->range, KEYSYM_HASH_BUCKETS) - 1; j >= 0; --j)
351 { 261 {
352 assert (keymap [i]);
353 hashkey = (keymap [i]->keysym & KEYSYM_HASH_MASK); 262 hashkey = (keymap [i]->keysym + j) & KEYSYM_HASH_MASK;
354 ++hash_budget_size [hashkey]; 263 ++hash_bucket_size [hashkey];
355 } 264 }
356 265
357 // keysym A with range>1 is counted one more time for 266 // now we know the size of each bucket
358 // every keysym B lies in its range 267 // compute the index of each bucket
268 hash [0] = 0;
269 for (index = 0, i = 1; i < KEYSYM_HASH_BUCKETS; ++i)
270 {
271 index += hash_bucket_size [i - 1];
272 hash [i] = index;
273 }
274
275 // and allocate just enough space
276 sorted_keymap.insert (sorted_keymap.begin (), index + hash_bucket_size [i - 1], 0);
277
278 memset (hash_bucket_size, 0, sizeof (hash_bucket_size));
279
280 // fill in sorted_keymap
281 // it is sorted in each bucket
359 for (i = 0; i < keymap.size (); ++i) 282 for (i = 0; i < keymap.size (); ++i)
360 {
361 if (keymap[i]->range > 1)
362 {
363 for (int j = min (keymap [i]->range, KEYSYM_HASH_BUDGETS) - 1; j > 0; --j)
364 {
365 hashkey = ((keymap [i]->keysym + j) & KEYSYM_HASH_MASK);
366 if (hash_budget_size [hashkey])
367 ++hash_budget_size [hashkey];
368 }
369 }
370 }
371
372 // now we know the size of each budget
373 // compute the index of each budget
374 hash [0] = 0;
375 for (index = 0, i = 1; i < KEYSYM_HASH_BUDGETS; ++i)
376 {
377 index += hash_budget_size [i - 1];
378 hash[i] = (hash_budget_size [i] ? index : hash [i - 1]);
379 }
380
381 // and allocate just enough space
382 //sorted_keymap.reserve (hash[i - 1] + hash_budget_size[i - 1]);
383 sorted_keymap.insert (sorted_keymap.begin (), index + hash_budget_size [i - 1], 0);
384
385 // fill in sorted_keymap
386 // it is sorted in each budget
387 for (i = 0; i < keymap.size (); ++i)
388 {
389 for (int j = min (keymap [i]->range, KEYSYM_HASH_BUDGETS) - 1; j >= 0; --j) 283 for (int j = min (keymap [i]->range, KEYSYM_HASH_BUCKETS) - 1; j >= 0; --j)
390 { 284 {
391 hashkey = ((keymap [i]->keysym + j) & KEYSYM_HASH_MASK); 285 hashkey = (keymap [i]->keysym + j) & KEYSYM_HASH_MASK;
392 286
393 if (hash_budget_size [hashkey])
394 {
395 index = hash [hashkey] + hash_budget_counter [hashkey]; 287 index = hash [hashkey] + hash_bucket_size [hashkey];
396 288
397 while (index > hash [hashkey] 289 while (index > hash [hashkey]
398 && compare_priority (keymap [i], sorted_keymap [index - 1]) > 0) 290 && compare_priority (keymap [i], sorted_keymap [index - 1]) > 0)
399 { 291 {
400 sorted_keymap [index] = sorted_keymap [index - 1]; 292 sorted_keymap [index] = sorted_keymap [index - 1];
401 --index; 293 --index;
402 } 294 }
403 295
404 sorted_keymap [index] = keymap [i]; 296 sorted_keymap [index] = keymap [i];
405 ++hash_budget_counter [hashkey]; 297 ++hash_bucket_size [hashkey];
406 }
407 } 298 }
408 }
409 299
410 keymap.swap (sorted_keymap); 300 keymap.swap (sorted_keymap);
411 301
412#if defined (DEBUG_STRICT) || defined (DEBUG_KEYBOARD) 302#ifndef NDEBUG
413 // check for invariants 303 // check for invariants
414 for (i = 0; i < KEYSYM_HASH_BUDGETS; ++i) 304 for (i = 0; i < KEYSYM_HASH_BUCKETS; ++i)
415 { 305 {
416 index = hash[i]; 306 index = hash[i];
417 for (int j = 0; j < hash_budget_size [i]; ++j) 307 for (int j = 0; j < hash_bucket_size [i]; ++j)
418 { 308 {
419 if (keymap [index + j]->range == 1) 309 if (keymap [index + j]->range == 1)
420 assert (i == (keymap [index + j]->keysym & KEYSYM_HASH_MASK)); 310 assert (i == (keymap [index + j]->keysym & KEYSYM_HASH_MASK));
421 311
422 if (j) 312 if (j)
433 { 323 {
434 int index = find_keysym (a->keysym + j, a->state); 324 int index = find_keysym (a->keysym + j, a->state);
435 325
436 assert (index >= 0); 326 assert (index >= 0);
437 keysym_t *b = keymap [index]; 327 keysym_t *b = keymap [index];
438 assert (i == (signed) index || // the normally expected result 328 assert (i == index // the normally expected result
439 (a->keysym + j) >= b->keysym && (a->keysym + j) <= (b->keysym + b->range) && compare_priority (a, b) <= 0); // is effectively the same 329 || IN_RANGE_INC (a->keysym + j, b->keysym, b->keysym + b->range)
330 && compare_priority (a, b) <= 0); // is effectively the same or a closer match
440 } 331 }
441 } 332 }
442#endif 333#endif
443} 334}
444 335
445int 336int
446keyboard_manager::find_keysym (KeySym keysym, unsigned int state) 337keyboard_manager::find_keysym (KeySym keysym, unsigned int state)
447{ 338{
448 int hashkey = keysym & KEYSYM_HASH_MASK; 339 int hashkey = keysym & KEYSYM_HASH_MASK;
449 unsigned int index = hash [hashkey]; 340 unsigned int index = hash [hashkey];
341 unsigned int end = hashkey < KEYSYM_HASH_BUCKETS - 1
342 ? hash [hashkey + 1]
343 : keymap.size ();
450 344
451 for (; index < keymap.size (); ++index) 345 for (; index < end; ++index)
452 { 346 {
453 keysym_t *key = keymap [index]; 347 keysym_t *key = keymap [index];
454 assert (key);
455 348
456 if (key->keysym <= keysym && key->keysym + key->range > keysym 349 if (key->keysym <= keysym && keysym < key->keysym + key->range
457 // match only the specified bits in state and ignore others 350 // match only the specified bits in state and ignore others
458 && (key->state & state) == key->state) 351 && (key->state & state) == key->state)
459 return index; 352 return index;
460 else if (key->keysym > keysym && key->range == 1)
461 return -1;
462 } 353 }
463 354
464 return -1; 355 return -1;
465} 356}
466 357

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines