ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/rxvt-unicode/src/keyboard.C
(Generate patch)

Comparing rxvt-unicode/src/keyboard.C (file contents):
Revision 1.18 by root, Mon Jan 2 21:17:01 2006 UTC vs.
Revision 1.44 by sf-exg, Sun Nov 27 09:07:48 2011 UTC

1/*----------------------------------------------------------------------*
2 * File: keyboard.C
3 *----------------------------------------------------------------------*
4 *
5 * All portions of code are copyright by their respective author/s.
6 * Copyright (c) 2005 WU Fengguang
7 * Copyright (c) 2005-2006 Marc Lehmann <schmorp@schmorp.de>
8 *
9 * This program is free software; you can redistribute it and/or modify
10 * it under the terms of the GNU General Public License as published by
11 * the Free Software Foundation; either version 2 of the License, or
12 * (at your option) any later version.
13 *
14 * This program is distributed in the hope that it will be useful,
15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17 * GNU General Public License for more details.
18 *
19 * You should have received a copy of the GNU General Public License
20 * along with this program; if not, write to the Free Software
21 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
22 *----------------------------------------------------------------------*/
23
1#include "../config.h" 24#include "../config.h"
2#include "rxvt.h" 25#include "rxvt.h"
3 26
4#ifdef KEYSYM_RESOURCE 27#ifdef KEYSYM_RESOURCE
5 28
… …
26 * index: 0 I1 I2 I3 In 49 * index: 0 I1 I2 I3 In
27 * value: 0...0, A1...A1, A2...A2, A3...A3, ..., An...An 50 * value: 0...0, A1...A1, A2...A2, A3...A3, ..., An...An
28 * where 51 * where
29 * A1 = 0; 52 * A1 = 0;
30 * Ai+1 = N1 + N2 + ... + Ni. 53 * Ai+1 = N1 + N2 + ... + Ni.
31 * it is computed from hash_budget_size[]: 54 * it is computed from hash_bucket_size[]:
32 * index: 0 I1 I2 I3 In 55 * index: 0 I1 I2 I3 In
33 * value: 0...0, N1, 0...0, N2, 0...0, N3, ..., Nn, 0...0 56 * value: 0...0, N1, 0...0, N2, 0...0, N3, ..., Nn, 0...0
34 * 0...0, 0.......0, N1.....N1, N1+N2...N1+N2, ... (the compution of hash[]) 57 * 0...0, 0.......0, N1.....N1, N1+N2...N1+N2, ... (the computation of hash[])
35 * or we can say 58 * or we can say
36 * hash_budget_size[Ii] = Ni; hash_budget_size[elsewhere] = 0, 59 * hash_bucket_size[Ii] = Ni; hash_bucket_size[elsewhere] = 0,
37 * where 60 * where
38 * set {I1, I2, ..., In} = { hashkey of keymap[0]->keysym, ..., keymap[keymap.size-1]->keysym } 61 * set {I1, I2, ..., In} = { hashkey of keymap[0]->keysym, ..., keymap[keymap.size-1]->keysym }
39 * where hashkey of keymap[i]->keysym = keymap[i]->keysym & KEYSYM_HASH_MASK 62 * where hashkey of keymap[i]->keysym = keymap[i]->keysym & KEYSYM_HASH_MASK
40 * n(the number of groups) = the number of non-zero member of hash_budget_size[]; 63 * n(the number of groups) = the number of non-zero member of hash_bucket_size[];
41 * Ni(the size of group i) = hash_budget_size[Ii]. 64 * Ni(the size of group i) = hash_bucket_size[Ii].
42 */ 65 */
43
44#if STOCK_KEYMAP
45////////////////////////////////////////////////////////////////////////////////
46// default keycode translation map and keyevent handlers
47
48keysym_t keyboard_manager::stock_keymap[] = {
49 /* examples */
50 /* keysym, state, range, handler, str */
51//{XK_ISO_Left_Tab, 0, 1, keysym_t::NORMAL, "\033[Z"},
52//{ 'a', 0, 26, keysym_t::RANGE_META8, "a" "%c"},
53//{ 'a', ControlMask, 26, keysym_t::RANGE_META8, "" "%c"},
54//{ XK_Left, 0, 4, keysym_t::LIST, ".\033[.DACB."},
55//{ XK_Left, ShiftMask, 4, keysym_t::LIST, ".\033[.dacb."},
56//{ XK_Left, ControlMask, 4, keysym_t::LIST, ".\033O.dacb."},
57//{ XK_Tab, ControlMask, 1, keysym_t::NORMAL, "\033<C-Tab>"},
58//{ XK_apostrophe, ControlMask, 1, keysym_t::NORMAL, "\033<C-'>"},
59//{ XK_slash, ControlMask, 1, keysym_t::NORMAL, "\033<C-/>"},
60//{ XK_semicolon, ControlMask, 1, keysym_t::NORMAL, "\033<C-;>"},
61//{ XK_grave, ControlMask, 1, keysym_t::NORMAL, "\033<C-`>"},
62//{ XK_comma, ControlMask, 1, keysym_t::NORMAL, "\033<C-\054>"},
63//{ XK_Return, ControlMask, 1, keysym_t::NORMAL, "\033<C-Return>"},
64//{ XK_Return, ShiftMask, 1, keysym_t::NORMAL, "\033<S-Return>"},
65//{ ' ', ShiftMask, 1, keysym_t::NORMAL, "\033<S-Space>"},
66//{ '.', ControlMask, 1, keysym_t::NORMAL, "\033<C-.>"},
67//{ '0', ControlMask, 10, keysym_t::RANGE, "0" "\033<C-%c>"},
68//{ '0', MetaMask|ControlMask, 10, keysym_t::RANGE, "0" "\033<M-C-%c>"},
69//{ 'a', MetaMask|ControlMask, 26, keysym_t::RANGE, "a" "\033<M-C-%c>"},
70};
71#endif
72 66
73static void 67static void
74output_string (rxvt_term *rt, const char *str) 68output_string (rxvt_term *rt, const char *str)
75{ 69{
76 if (strncmp (str, "command:", 8) == 0) 70 if (strncmp (str, "command:", 8) == 0)
77 rt->cmd_write ((unsigned char *)str + 8, strlen (str) - 8); 71 rt->cmdbuf_append (str + 8, strlen (str) - 8);
78 else if (strncmp (str, "perl:", 5) == 0) 72 else if (strncmp (str, "perl:", 5) == 0)
79 PERL_INVOKE((rt, HOOK_KEYBOARD_COMMAND, DT_STRING, str + 5, DT_END)); 73 HOOK_INVOKE((rt, HOOK_USER_COMMAND, DT_STR, str + 5, DT_END));
80 else 74 else
81 rt->tt_write ((unsigned char *)str, strlen (str)); 75 rt->tt_write (str, strlen (str));
82} 76}
83
84static void
85output_string_meta8 (rxvt_term *rt, unsigned int state, char *buf, int buflen)
86{
87 if (state & rt->ModMetaMask)
88 {
89#ifdef META8_OPTION
90 if (rt->meta_char == 0x80) /* set 8-bit on */
91 {
92 for (char *ch = buf; ch < buf + buflen; ch++)
93 *ch |= 0x80;
94 }
95 else if (rt->meta_char == C0_ESC) /* escape prefix */
96#endif
97 {
98 const unsigned char ch = C0_ESC;
99 rt->tt_write (&ch, 1);
100 }
101 }
102
103 rt->tt_write ((unsigned char *) buf, buflen);
104}
105
106static int
107format_keyrange_string (const char *str, int keysym_offset, char *buf, int bufsize)
108{
109 size_t len = snprintf (buf, bufsize, str + 1, keysym_offset + str [0]);
110
111 if (len >= (size_t)bufsize)
112 {
113 rxvt_warn ("format_keyrange_string: formatting failed, ignoring key.\n");
114 *buf = 0;
115 }
116
117 return len;
118}
119
120////////////////////////////////////////////////////////////////////////////////
121// return: #bits of '1'
122#if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ > 3)
123# define bitcount(n) (__extension__ ({ uint32_t n__ = (n); __builtin_popcount (n__); }))
124#else
125static int
126bitcount (uint16_t n)
127{
128 int i;
129
130 for (i = 0; n; ++i, n &= n - 1)
131 ;
132
133 return i;
134}
135#endif
136 77
137// return: priority_of_a - priority_of_b 78// return: priority_of_a - priority_of_b
138static int 79static int
139compare_priority (keysym_t *a, keysym_t *b) 80compare_priority (keysym_t *a, keysym_t *b)
140{ 81{
141 // (the more '1's in state; the less range): the greater priority 82 // (the more '1's in state; the less range): the greater priority
142 int ca = bitcount (a->state /* & OtherModMask */); 83 int ca = ecb_popcount32 (a->state /* & OtherModMask */);
143 int cb = bitcount (b->state /* & OtherModMask */); 84 int cb = ecb_popcount32 (b->state /* & OtherModMask */);
144 85
145 if (ca != cb) 86 if (ca != cb)
146 return ca - cb; 87 return ca - cb;
147//else if (a->state != b->state) // this behavior is to be disscussed 88//else if (a->state != b->state) // this behavior is to be discussed
148// return b->state - a->state; 89// return b->state - a->state;
149 else 90 else
150 return b->range - a->range; 91 return 0;
151} 92}
152 93
153//////////////////////////////////////////////////////////////////////////////// 94////////////////////////////////////////////////////////////////////////////////
154keyboard_manager::keyboard_manager () 95keyboard_manager::keyboard_manager ()
155{ 96{
… …
163} 104}
164 105
165void 106void
166keyboard_manager::clear () 107keyboard_manager::clear ()
167{ 108{
109 hash [0] = 2;
110
111 for (unsigned int i = 0; i < keymap.size (); ++i)
112 {
113 free ((void *)keymap [i]->str);
114 delete keymap [i];
115 keymap [i] = 0;
116 }
117
168 keymap.clear (); 118 keymap.clear ();
169 hash [0] = 2;
170
171 for (unsigned int i = 0; i < user_translations.size (); ++i)
172 {
173 free ((void *)user_translations [i]);
174 user_translations [i] = 0;
175 }
176
177 for (unsigned int i = 0; i < user_keymap.size (); ++i)
178 {
179 delete user_keymap [i];
180 user_keymap [i] = 0;
181 }
182
183 user_keymap.clear ();
184 user_translations.clear ();
185} 119}
186 120
187// a wrapper for register_keymap, 121// a wrapper for register_translation that converts the input string
188// so that outside codes don't have to know so much details. 122// to utf-8 and expands 'list' syntax.
189//
190// the string 'trans' is copied to an internal managed buffer,
191// so the caller can free memory of 'trans' at any time.
192void 123void
193keyboard_manager::register_user_translation (KeySym keysym, unsigned int state, const char *trans) 124keyboard_manager::register_user_translation (KeySym keysym, unsigned int state, const char *trans)
194{ 125{
126 wchar_t *wc = rxvt_mbstowcs (trans);
127 char *translation = rxvt_wcstoutf8 (wc);
128 free (wc);
129
130 if (strncmp (translation, "list", 4) == 0 && translation [4]
131 && strlen (translation) < STRING_MAX)
132 {
133 char *prefix = translation + 4;
134 char *middle = strchr (prefix + 1, translation [4]);
135 char *suffix = strrchr (prefix + 1, translation [4]);
136
137 if (suffix && middle && suffix > middle + 1)
138 {
139 int range = suffix - middle - 1;
140 int prefix_len = middle - prefix - 1;
141 char buf[STRING_MAX];
142
143 memcpy (buf, prefix + 1, prefix_len);
144 strcpy (buf + prefix_len + 1, suffix + 1);
145
146 for (int i = 0; i < range; i++)
147 {
148 buf [prefix_len] = middle [i + 1];
149 register_translation (keysym + i, state, strdup (buf));
150 }
151
152 free (translation);
153 return;
154 }
155 else
156 rxvt_warn ("cannot parse list-type keysym '%s', processing as normal keysym.\n", translation);
157 }
158
159 register_translation (keysym, state, translation);
160}
161
162void
163keyboard_manager::register_translation (KeySym keysym, unsigned int state, char *translation)
164{
195 keysym_t *key = new keysym_t; 165 keysym_t *key = new keysym_t;
196 wchar_t *wc = rxvt_mbstowcs (trans);
197 const char *translation = rxvt_wcstoutf8 (wc);
198 free (wc);
199 166
200 if (key && translation) 167 if (key && translation)
201 { 168 {
202 key->keysym = keysym; 169 key->keysym = keysym;
203 key->state = state; 170 key->state = state;
204 key->range = 1;
205 key->str = translation; 171 key->str = translation;
206 key->type = keysym_t::NORMAL; 172 key->type = keysym_t::STRING;
207 173
208 if (strncmp (translation, "list", 4) == 0 && translation [4])
209 {
210 char *middle = strchr (translation + 5, translation [4]);
211 char *suffix = strrchr (translation + 5, translation [4]);
212
213 if (suffix && middle && suffix > middle + 1)
214 {
215 key->type = keysym_t::LIST;
216 key->range = suffix - middle - 1;
217
218 strcpy (translation, translation + 4);
219 }
220 else
221 rxvt_warn ("cannot parse list-type keysym '%s', treating as normal keysym.\n", translation);
222 }
223 else if (strncmp (translation, "builtin:", 8) == 0) 174 if (strncmp (translation, "builtin:", 8) == 0)
224 key->type = keysym_t::BUILTIN; 175 key->type = keysym_t::BUILTIN;
225 176
226 user_keymap.push_back (key);
227 user_translations.push_back (translation);
228 register_keymap (key); 177 register_keymap (key);
229 } 178 }
230 else 179 else
231 { 180 {
232 delete key; 181 delete key;
… …
246} 195}
247 196
248void 197void
249keyboard_manager::register_done () 198keyboard_manager::register_done ()
250{ 199{
251#if STOCK_KEYMAP
252 int n = sizeof (stock_keymap) / sizeof (keysym_t);
253
254 //TODO: shield against repeated calls and empty keymap
255 //if (keymap.back () != &stock_keymap[n - 1])
256 for (int i = 0; i < n; ++i)
257 register_keymap (&stock_keymap[i]);
258#endif
259
260 purge_duplicate_keymap ();
261
262 setup_hash (); 200 setup_hash ();
263} 201}
264 202
265bool 203bool
266keyboard_manager::dispatch (rxvt_term *term, KeySym keysym, unsigned int state) 204keyboard_manager::dispatch (rxvt_term *term, KeySym keysym, unsigned int state)
… …
282 { 220 {
283 const keysym_t &key = *keymap [index]; 221 const keysym_t &key = *keymap [index];
284 222
285 if (key.type != keysym_t::BUILTIN) 223 if (key.type != keysym_t::BUILTIN)
286 { 224 {
287 int keysym_offset = keysym - key.keysym;
288
289 wchar_t *wc = rxvt_utf8towcs (key.str); 225 wchar_t *wc = rxvt_utf8towcs (key.str);
290 char *str = rxvt_wcstombs (wc); 226 char *str = rxvt_wcstombs (wc);
291 // TODO: do (some) translations, unescaping etc, here (allow \u escape etc.) 227 // TODO: do (some) translations, unescaping etc, here (allow \u escape etc.)
292 free (wc); 228 free (wc);
293 229
294 switch (key.type)
295 {
296 case keysym_t::NORMAL:
297 output_string (term, str); 230 output_string (term, str);
298 break;
299
300 case keysym_t::RANGE:
301 {
302 char buf[STRING_MAX];
303
304 if (format_keyrange_string (str, keysym_offset, buf, sizeof (buf)) > 0)
305 output_string (term, buf);
306 }
307 break;
308
309 case keysym_t::RANGE_META8:
310 {
311 int len;
312 char buf[STRING_MAX];
313
314 len = format_keyrange_string (str, keysym_offset, buf, sizeof (buf));
315 if (len > 0)
316 output_string_meta8 (term, state, buf, len);
317 }
318 break;
319
320 case keysym_t::LIST:
321 {
322 char buf[STRING_MAX];
323
324 char *prefix, *middle, *suffix;
325
326 prefix = str;
327 middle = strchr (prefix + 1, *prefix);
328 suffix = strrchr (middle + 1, *prefix);
329
330 memcpy (buf, prefix + 1, middle - prefix - 1);
331 buf [middle - prefix - 1] = middle [keysym_offset + 1];
332 strcpy (buf + (middle - prefix), suffix + 1);
333
334 output_string (term, buf);
335 }
336 break;
337 }
338 231
339 free (str); 232 free (str);
340 233
341 return true; 234 return true;
342 } 235 }
343 } 236 }
344 237
345 return false; 238 return false;
346} 239}
347 240
348// purge duplicate keymap entries
349void keyboard_manager::purge_duplicate_keymap ()
350{
351 for (unsigned int i = 0; i < keymap.size (); ++i)
352 {
353 for (unsigned int j = 0; j < i; ++j)
354 {
355 if (keymap [i] == keymap [j])
356 {
357 while (keymap [i] == keymap.back ())
358 keymap.pop_back ();
359
360 if (i < keymap.size ())
361 {
362 keymap[i] = keymap.back ();
363 keymap.pop_back ();
364 }
365
366 break;
367 }
368 }
369 }
370}
371
372void 241void
373keyboard_manager::setup_hash () 242keyboard_manager::setup_hash ()
374{ 243{
375 unsigned int i, index, hashkey; 244 unsigned int i, index, hashkey;
376 vector <keysym_t *> sorted_keymap; 245 vector <keysym_t *> sorted_keymap;
377 uint16_t hash_budget_size[KEYSYM_HASH_BUDGETS]; // size of each budget 246 uint16_t hash_bucket_size[KEYSYM_HASH_BUCKETS]; // size of each bucket
378 uint16_t hash_budget_counter[KEYSYM_HASH_BUDGETS]; // #elements in each budget
379 247
380 memset (hash_budget_size, 0, sizeof (hash_budget_size)); 248 memset (hash_bucket_size, 0, sizeof (hash_bucket_size));
381 memset (hash_budget_counter, 0, sizeof (hash_budget_counter));
382 249
383 // determine hash bucket size 250 // determine hash bucket size
384 for (i = 0; i < keymap.size (); ++i) 251 for (i = 0; i < keymap.size (); ++i)
385 for (int j = min (keymap [i]->range, KEYSYM_HASH_BUDGETS) - 1; j >= 0; --j)
386 { 252 {
387 hashkey = (keymap [i]->keysym + j) & KEYSYM_HASH_MASK; 253 hashkey = keymap [i]->keysym & KEYSYM_HASH_MASK;
388 ++hash_budget_size [hashkey]; 254 ++hash_bucket_size [hashkey];
389 } 255 }
390 256
391 // now we know the size of each budget 257 // now we know the size of each bucket
392 // compute the index of each budget 258 // compute the index of each bucket
393 hash [0] = 0; 259 hash [0] = 0;
394 for (index = 0, i = 1; i < KEYSYM_HASH_BUDGETS; ++i) 260 for (index = 0, i = 1; i < KEYSYM_HASH_BUCKETS; ++i)
395 { 261 {
396 index += hash_budget_size [i - 1]; 262 index += hash_bucket_size [i - 1];
397 hash [i] = index; 263 hash [i] = index;
398 } 264 }
399 265
400 // and allocate just enough space 266 // and allocate just enough space
401 sorted_keymap.insert (sorted_keymap.begin (), index + hash_budget_size [i - 1], 0); 267 sorted_keymap.insert (sorted_keymap.begin (), index + hash_bucket_size [i - 1], 0);
268
269 memset (hash_bucket_size, 0, sizeof (hash_bucket_size));
402 270
403 // fill in sorted_keymap 271 // fill in sorted_keymap
404 // it is sorted in each budget 272 // it is sorted in each bucket
405 for (i = 0; i < keymap.size (); ++i) 273 for (i = 0; i < keymap.size (); ++i)
406 for (int j = min (keymap [i]->range, KEYSYM_HASH_BUDGETS) - 1; j >= 0; --j)
407 { 274 {
408 hashkey = (keymap [i]->keysym + j) & KEYSYM_HASH_MASK; 275 hashkey = keymap [i]->keysym & KEYSYM_HASH_MASK;
409 276
410 index = hash [hashkey] + hash_budget_counter [hashkey]; 277 index = hash [hashkey] + hash_bucket_size [hashkey];
411 278
412 while (index > hash [hashkey] 279 while (index > hash [hashkey]
413 && compare_priority (keymap [i], sorted_keymap [index - 1]) > 0) 280 && compare_priority (keymap [i], sorted_keymap [index - 1]) > 0)
414 { 281 {
415 sorted_keymap [index] = sorted_keymap [index - 1]; 282 sorted_keymap [index] = sorted_keymap [index - 1];
416 --index; 283 --index;
417 } 284 }
418 285
419 sorted_keymap [index] = keymap [i]; 286 sorted_keymap [index] = keymap [i];
420 ++hash_budget_counter [hashkey]; 287 ++hash_bucket_size [hashkey];
421 } 288 }
422 289
423 keymap.swap (sorted_keymap); 290 keymap.swap (sorted_keymap);
424 291
425#if defined (DEBUG_STRICT) || defined (DEBUG_KEYBOARD) 292#ifndef NDEBUG
426 // check for invariants 293 // check for invariants
427 for (i = 0; i < KEYSYM_HASH_BUDGETS; ++i) 294 for (i = 0; i < KEYSYM_HASH_BUCKETS; ++i)
428 { 295 {
429 index = hash[i]; 296 index = hash[i];
430 for (int j = 0; j < hash_budget_size [i]; ++j) 297 for (int j = 0; j < hash_bucket_size [i]; ++j)
431 { 298 {
432 if (keymap [index + j]->range == 1)
433 assert (i == (keymap [index + j]->keysym & KEYSYM_HASH_MASK)); 299 assert (i == (keymap [index + j]->keysym & KEYSYM_HASH_MASK));
434 300
435 if (j) 301 if (j)
436 assert (compare_priority (keymap [index + j - 1], 302 assert (compare_priority (keymap [index + j - 1],
437 keymap [index + j]) >= 0); 303 keymap [index + j]) >= 0);
438 } 304 }
… …
440 306
441 // this should be able to detect most possible bugs 307 // this should be able to detect most possible bugs
442 for (i = 0; i < sorted_keymap.size (); ++i) 308 for (i = 0; i < sorted_keymap.size (); ++i)
443 { 309 {
444 keysym_t *a = sorted_keymap[i]; 310 keysym_t *a = sorted_keymap[i];
445 for (int j = 0; j < a->range; ++j)
446 {
447 int index = find_keysym (a->keysym + j, a->state); 311 int index = find_keysym (a->keysym, a->state);
448 312
449 assert (index >= 0); 313 assert (index >= 0);
450 keysym_t *b = keymap [index]; 314 keysym_t *b = keymap [index];
451 assert (i == (signed) index || // the normally expected result 315 assert (i == index // the normally expected result
452 (a->keysym + j) >= b->keysym && (a->keysym + j) <= (b->keysym + b->range) && compare_priority (a, b) <= 0); // is effectively the same or a closer match 316 || a->keysym == b->keysym
453 } 317 && compare_priority (a, b) <= 0); // is effectively the same or a closer match
454 } 318 }
455#endif 319#endif
456} 320}
457 321
458int 322int
459keyboard_manager::find_keysym (KeySym keysym, unsigned int state) 323keyboard_manager::find_keysym (KeySym keysym, unsigned int state)
460{ 324{
461 int hashkey = keysym & KEYSYM_HASH_MASK; 325 int hashkey = keysym & KEYSYM_HASH_MASK;
462 unsigned int index = hash [hashkey]; 326 unsigned int index = hash [hashkey];
463 unsigned int end = hashkey < KEYSYM_HASH_BUDGETS - 1 327 unsigned int end = hashkey < KEYSYM_HASH_BUCKETS - 1
464 ? hash [hashkey + 1] 328 ? hash [hashkey + 1]
465 : keymap.size (); 329 : keymap.size ();
466 330
467 for (; index < end; ++index) 331 for (; index < end; ++index)
468 { 332 {
469 keysym_t *key = keymap [index]; 333 keysym_t *key = keymap [index];
470 334
471 if (key->keysym <= keysym && keysym < key->keysym + key->range 335 if (key->keysym == keysym
472 // match only the specified bits in state and ignore others 336 // match only the specified bits in state and ignore others
473 && (key->state & state) == key->state) 337 && (key->state & state) == key->state)
474 return index; 338 return index;
475 } 339 }
476 340

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines