[ViewVC] Diff of: cvs/rxvt-unicode/src/main.C

Comparing rxvt-unicode/src/main.C (file contents):
Revision 1.352 by sf-exg, Fri Feb 11 01:24:46 2011 UTC vs.
Revision 1.360 by sf-exg, Fri Aug 19 16:01:37 2011 UTC

  * Copyright (c) 1997      mj olesen <olesen@me.QueensU.CA>
  *                              - extensive modifications
  * Copyright (c) 1997,1998 Oezguer Kesim <kesim@math.fu-berlin.de>
  * Copyright (c) 1998-2001 Geoff Wing <gcw@pobox.com>
  *                              - extensive modifications
- * Copyright (c) 2003-2010 Marc Lehmann <pcg@goof.com>
+ * Copyright (c) 2003-2010 Marc Lehmann <schmorp@schmorp.de>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
       if (cc->c2 == c2) return c1;
       cc = (*this)[cc->c1];
     }
   // check to see whether this combination already exists otherwise
-  for (cc = v.end (); cc-- > v.begin (); )
+  for (cc = v.begin (); cc < v.end (); cc++)
     if (cc->c1 == c1 && cc->c2 == c2)
       return COMPOSE_LO + (cc - v.begin ());
   // allocate a new combination
   if (v.size () == COMPOSE_HI - COMPOSE_LO + 1)
       scrollBar.destroy ();
       if (gc)   XFreeGC (dpy, gc);
       delete drawable;
       // destroy all windows
-      if (parent[0])
+      if (parent)
-        XDestroyWindow (dpy, parent[0]);
+        XDestroyWindow (dpy, parent);
       for (int i = 0; i < TOTAL_COLORS; i++)
         if (ISSET_PIXCOLOR (i))
           {
             pix_colors_focused   [i].free (this);
   // TODO: manage env vars in child only(!)
   free (env_display);
   free (env_term);
   free (locale);
   free (v_buffer);
+  delete selection_req;
   delete envv;
   delete argv;
 #ifdef KEYSYM_RESOURCE
   if (recalc_y)
     szHint.y += DisplayHeight (dpy, display->screen) - szHint.height - 2 * ext_bwidth;
   ncol = width  / fwidth;
   nrow = height / fheight;
+  // When the size of the vt window is not a multiple of the cell
+  // size, i.e., when the wm does not honour our size hints, there are
+  // extra areas not covered by the terminal screen. Such gaps, when a
+  // bg pixmap is set, would have to be cleared manually to properly
+  // refresh the background. We take the simpler route and shrink the
+  // vt window so as to avoid creating gaps.
+  width  = ncol * fwidth;
+  height = nrow * fheight;
 }
 /*----------------------------------------------------------------------*/
 /*
  * Tell the teletype handler what size the window is.
     kill (-cmd_pid, SIGWINCH);
 #endif
 }
 /*----------------------------------------------------------------------*/
-/* set_fonts () - load and set the various fonts
+/* load and set the various fonts */
- *
- * init = 1   - initialize
- *
- * fontname == FONT_UP  - switch to bigger font
- * fontname == FONT_DN  - switch to smaller font
- */
 bool
 rxvt_term::set_fonts ()
 {
   rxvt_fontset *fs = new rxvt_fontset (this);
   rxvt_fontprop prop;
 #else
       fontset[style] = fontset[0];
 #endif
     }
-  if (parent[0])
+  if (parent)
     {
       resize_all_windows (0, 0, 0);
       scr_remap_chars ();
       scr_touch (true);
     }
 }
 void
 rxvt_term::set_string_property (Atom prop, const char *str, int len)
 {
-  XChangeProperty (dpy, parent[0],
+  XChangeProperty (dpy, parent,
                    prop, XA_STRING, 8, PropModeReplace,
                    (const unsigned char *)str, len >= 0 ? len : strlen (str));
 }
 void
 {
   XTextProperty ct;
   if (XmbTextListToTextProperty (dpy, (char **)&str, 1, XStdICCTextStyle, &ct) >= 0)
     {
-      XSetTextProperty (dpy, parent[0], &ct, prop);
+      XSetTextProperty (dpy, parent, &ct, prop);
       XFree (ct.value);
     }
 }
 void
 rxvt_term::set_utf8_property (Atom prop, const char *str, int len)
 {
   wchar_t *ws = rxvt_mbstowcs (str, len);
   char *s = rxvt_wcstoutf8 (ws);
-  XChangeProperty (dpy, parent[0],
+  XChangeProperty (dpy, parent,
                    prop, xa[XA_UTF8_STRING], 8, PropModeReplace,
                    (const unsigned char *)s, strlen (s));
   free (s);
   free (ws);
   // to avoid races between us and the wm, we clear the incremental size hints around the xresizewindow
   if (set_hint)
     {
       szHint.flags &= ~(PBaseSize | PResizeInc);
-      XSetWMNormalHints (dpy, parent[0], &szHint);
+      XSetWMNormalHints (dpy, parent, &szHint);
       szHint.flags |= PBaseSize | PResizeInc;
     }
   if (!ignoreparent)
     {
       int x, y, x1, y1;
       int dx, dy;
       unsigned int unused_w1, unused_h1, unused_b1, unused_d1;
       Window unused_cr;
-      XTranslateCoordinates (dpy, parent[0], display->root,
+      XTranslateCoordinates (dpy, parent, display->root,
                              0, 0, &x, &y, &unused_cr);
-      XGetGeometry (dpy, parent[0], &unused_cr, &x1, &y1,
+      XGetGeometry (dpy, parent, &unused_cr, &x1, &y1,
                     &unused_w1, &unused_h1, &unused_b1, &unused_d1);
       /*
        * if display->root isn't the parent window, a WM will probably have offset
        * our position for handles and decorations.  Counter it
        */
       if (y < y1)             /* top half */
         dy = 0;
       else if (y == y1)       /* exact center */
         dy /= 2;
-      XMoveResizeWindow (dpy, parent[0], x + dx, y + dy,
+      XMoveResizeWindow (dpy, parent, x + dx, y + dy,
                          szHint.width, szHint.height);
 #else
-      XResizeWindow (dpy, parent[0], szHint.width, szHint.height);
+      XResizeWindow (dpy, parent, szHint.width, szHint.height);
 #endif
     }
   if (set_hint)
-    XSetWMNormalHints (dpy, parent[0], &szHint);
+    XSetWMNormalHints (dpy, parent, &szHint);
   fix_screen = ncol != prev_ncol || nrow != prev_nrow;
   if (fix_screen || newwidth != old_width || newheight != old_height)
     {
   if (fix_screen || old_height == 0)
     scr_reset ();
 #ifdef USE_XIM
-  IMSetPosition ();
+  im_set_position ();
 #endif
 }
 /*
  * Set the width/height of the vt window in characters.  Units are pixels.
   status_rect.height  = fheight;
 }
 /* Checking whether input method is running. */
 bool
-rxvt_term::IMisRunning ()
+rxvt_term::im_is_running ()
 {
   Atom atom;
   Window win;
   char server[IMBUFSIZ];
   return false;
 }
 void
-rxvt_term::IMSendSpot ()
+rxvt_term::im_send_spot ()
 {
   XPoint nspot;
   XVaNestedList preedit_attr;
   if (!Input_Context
 /*
  * Try to open a XIM with the current modifiers, then see if we can
  * open a suitable preedit type
  */
 bool
-rxvt_term::IM_get_IC (const char *modifiers)
+rxvt_term::im_get_ic (const char *modifiers)
 {
   int i, j, found;
   XIM xim;
   XPoint spot;
   XRectangle rect, status_rect, needed_rect;
   unsigned long fg, bg;
   const char *p;
   char **s;
   XIMStyles *xim_styles;
-#ifdef ENABLE_XIM_ONTHESPOT
-  XIMCallback xcb[4];
-#endif
   set_environ (envv);
   if (! ((p = XSetLocaleModifiers (modifiers)) && *p))
     return false;
                                          NULL);
     }
 #if ENABLE_XIM_ONTHESPOT
   else if (input_style & XIMPreeditCallbacks)
     {
+      XIMCallback xcb[4];
       im_set_position (spot);
       xcb[0].client_data = (XPointer)this; xcb[0].callback = (XIMProc)xim_preedit_start;
       xcb[1].client_data = (XPointer)this; xcb[1].callback = (XIMProc)xim_preedit_done;
       xcb[2].client_data = (XPointer)this; xcb[2].callback = (XIMProc)xim_preedit_draw;
 #endif
   Input_Context = XCreateIC (xim,
                              XNInputStyle, input_style,
                              XNClientWindow, vt,
-                             XNFocusWindow, parent[0],
+                             XNFocusWindow, parent,
                              preedit_attr ? XNPreeditAttributes : NULL,
                              preedit_attr,
                              status_attr ? XNStatusAttributes : NULL,
                              status_attr, NULL);
   // unfortunately, only the focus window is used by XIM, hard to fix
   if (!XGetICValues (Input_Context, XNFilterEvents, &vt_emask_xim, NULL))
     vt_select_input ();
 #endif
-  IMSetPosition ();
+  im_set_position ();
   return true;
 }
 void
         {
           if (*s[i])
             {
               strcpy (buf, "@im=");
               strncat (buf, s[i], IMBUFSIZ - 5);
-              if (IM_get_IC (buf))
+              if (im_get_ic (buf))
                 {
                   found = true;
                   break;
                 }
             }
       if (found)
         goto done;
     }
   /* try with XMODIFIERS env. var. */
-  if (IM_get_IC (""))
+  if (im_get_ic (""))
     goto done;
   /* try with no modifiers base IF the user didn't specify an IM */
-  if (IM_get_IC ("@im=none"))
+  if (im_get_ic ("@im=none"))
     goto done;
 done:
 #if defined(HAVE_XSETLOCALE) || defined(HAVE_SETLOCALE)
   if (rs[Rs_imLocale])
     SET_LOCALE (locale);
 #endif
 }
 void
-rxvt_term::IMSetPosition ()
+rxvt_term::im_set_position ()
 {
   XRectangle preedit_rect, status_rect, *needed_rect;
   XVaNestedList preedit_attr, status_attr;
   if (!Input_Context
       || !focus
       || !(input_style & (XIMPreeditArea | XIMPreeditPosition))
-      || !IMisRunning ())
+      || !im_is_running ())
     return;
   if (input_style & XIMPreeditPosition)
     {
       im_set_size (preedit_rect);
 void
 rxvt_term::get_window_origin (int &x, int &y)
 {
   Window cr;
-  XTranslateCoordinates (dpy, parent[0], display->root, 0, 0, &x, &y, &cr);
+  XTranslateCoordinates (dpy, parent, display->root, 0, 0, &x, &y, &cr);
 }
 Pixmap
 rxvt_term::get_pixmap_property (Atom property)
 {

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing rxvt-unicode/src/main.C (file contents): Revision 1.352 by sf-exg, Fri Feb 11 01:24:46 2011 UTC vs. Revision 1.360 by sf-exg, Fri Aug 19 16:01:37 2011 UTC

Diff Legend

Comparing rxvt-unicode/src/main.C (file contents):
Revision 1.352 by sf-exg, Fri Feb 11 01:24:46 2011 UTC vs.
Revision 1.360 by sf-exg, Fri Aug 19 16:01:37 2011 UTC