ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/rxvt-unicode/src/main.C
(Generate patch)

Comparing rxvt-unicode/src/main.C (file contents):
Revision 1.132 by root, Thu Feb 3 07:18:30 2005 UTC vs.
Revision 1.134 by root, Fri Feb 4 11:41:23 2005 UTC

… …
181 if (!keyboard) 181 if (!keyboard)
182 rxvt_fatal ("out of memory, aborting.\n"); 182 rxvt_fatal ("out of memory, aborting.\n");
183#endif 183#endif
184} 184}
185 185
186rxvt_term::~rxvt_term () 186// clean up the most important stuff, do *not* call x or free mem etc.
187// for use before an emergency exit
188void rxvt_term::emergency_cleanup ()
187{ 189{
188 termlist.erase (find (termlist.begin (), termlist.end(), this));
189
190 if (cmd_pid) 190 if (cmd_pid)
191 kill (-cmd_pid, SIGHUP); 191 kill (-cmd_pid, SIGHUP);
192 192
193#ifdef UTMP_SUPPORT 193#ifdef UTMP_SUPPORT
194 privileged_utmp (RESTORE); 194 privileged_utmp (RESTORE);
195#endif 195#endif
196 196
197 pty.put (); 197 pty.put ();
198}
199
200rxvt_term::~rxvt_term ()
201{
202 termlist.erase (find (termlist.begin (), termlist.end(), this));
203
204 emergency_cleanup ();
198 205
199#if ENABLE_STYLES 206#if ENABLE_STYLES
200 for (int i = RS_styleCount; --i; ) 207 for (int i = RS_styleCount; --i; )
201 if (TermWin.fontset[i] != TermWin.fontset[0]) 208 if (TermWin.fontset[i] != TermWin.fontset[0])
202 delete TermWin.fontset[i]; 209 delete TermWin.fontset[i];
203#endif 210#endif
204 delete TermWin.fontset[0]; 211 delete TermWin.fontset[0];
205 212
206 if (display) 213 if (display)
207 { 214 {
215 dDisp;
216
208 selection_clear (); 217 selection_clear ();
209 218
210#ifdef USE_XIM 219#ifdef USE_XIM
211 im_destroy (); 220 im_destroy ();
212#endif 221#endif
213#ifdef MENUBAR 222#ifdef MENUBAR
214 if (menubarGC) XFreeGC (display->display, menubarGC); 223 if (menubarGC) XFreeGC (disp, menubarGC);
215#endif 224#endif
216#ifdef XTERM_SCROLLBAR 225#ifdef XTERM_SCROLLBAR
217 if (xscrollbarGC) XFreeGC (display->display, xscrollbarGC); 226 if (xscrollbarGC) XFreeGC (disp, xscrollbarGC);
218 if (ShadowGC) XFreeGC (display->display, ShadowGC); 227 if (ShadowGC) XFreeGC (disp, ShadowGC);
219#endif 228#endif
220#ifdef PLAIN_SCROLLBAR 229#ifdef PLAIN_SCROLLBAR
221 if (pscrollbarGC) XFreeGC (display->display, pscrollbarGC); 230 if (pscrollbarGC) XFreeGC (disp, pscrollbarGC);
222#endif 231#endif
223#ifdef NEXT_SCROLLBAR 232#ifdef NEXT_SCROLLBAR
224 if (blackGC) XFreeGC (display->display, blackGC); 233 if (blackGC) XFreeGC (disp, blackGC);
225 if (whiteGC) XFreeGC (display->display, whiteGC); 234 if (whiteGC) XFreeGC (disp, whiteGC);
226 if (grayGC) XFreeGC (display->display, grayGC); 235 if (grayGC) XFreeGC (disp, grayGC);
227 if (darkGC) XFreeGC (display->display, darkGC); 236 if (darkGC) XFreeGC (disp, darkGC);
228 if (stippleGC) XFreeGC (display->display, stippleGC); 237 if (stippleGC) XFreeGC (disp, stippleGC);
229 if (dimple) XFreePixmap (display->display, dimple); 238 if (dimple) XFreePixmap (disp, dimple);
230 if (upArrow) XFreePixmap (display->display, upArrow); 239 if (upArrow) XFreePixmap (disp, upArrow);
231 if (downArrow) XFreePixmap (display->display, downArrow); 240 if (downArrow) XFreePixmap (disp, downArrow);
232 if (upArrowHi) XFreePixmap (display->display, upArrowHi); 241 if (upArrowHi) XFreePixmap (disp, upArrowHi);
233 if (downArrowHi) XFreePixmap (display->display, downArrowHi); 242 if (downArrowHi) XFreePixmap (disp, downArrowHi);
234#endif 243#endif
235#if defined(MENUBAR) || defined(RXVT_SCROLLBAR) 244#if defined(MENUBAR) || defined(RXVT_SCROLLBAR)
236 if (topShadowGC) XFreeGC (display->display, topShadowGC); 245 if (topShadowGC) XFreeGC (disp, topShadowGC);
237 if (botShadowGC) XFreeGC (display->display, botShadowGC); 246 if (botShadowGC) XFreeGC (disp, botShadowGC);
238 if (scrollbarGC) XFreeGC (display->display, scrollbarGC); 247 if (scrollbarGC) XFreeGC (disp, scrollbarGC);
239#endif 248#endif
240 if (TermWin.gc) XFreeGC (display->display, TermWin.gc); 249 if (TermWin.gc) XFreeGC (disp, TermWin.gc);
241 250
242#if defined(MENUBAR) && (MENUBAR_MAX > 1) 251#if defined(MENUBAR) && (MENUBAR_MAX > 1)
243 delete menuBar.drawable; 252 delete menuBar.drawable;
244 //if (menuBar.win) 253 //if (menuBar.win)
245 // XDestroyWindow (display->display, menuBar.win); 254 // XDestroyWindow (disp, menuBar.win);
246#endif 255#endif
247 delete TermWin.drawable; 256 delete TermWin.drawable;
248 // destroy all windows 257 // destroy all windows
249 if (TermWin.parent[0]) 258 if (TermWin.parent[0])
250 XDestroyWindow (display->display, TermWin.parent[0]); 259 XDestroyWindow (disp, TermWin.parent[0]);
251 } 260 }
252 261
253 // TODO: free pixcolours, colours should become part of rxvt_display 262 // TODO: free pixcolours, colours should become part of rxvt_display
254 263
255 delete pix_colors_focused; 264 delete pix_colors_focused;
… …
261 270
262 scr_release (); 271 scr_release ();
263 272
264 /* clear all resources */ 273 /* clear all resources */
265 for (int i = 0; i < allocated.size (); i++) 274 for (int i = 0; i < allocated.size (); i++)
266 free (allocated[i]); 275 free (allocated [i]);
267 276
268 free (selection.text); 277 free (selection.text);
269 // TODO: manage env vars in child only(!) 278 // TODO: manage env vars in child only(!)
270 free (env_windowid); 279 free (env_windowid);
271 free (env_display); 280 free (env_display);
… …
277 286
278 delete envv; 287 delete envv;
279 delete argv; 288 delete argv;
280 289
281#ifdef KEYSYM_RESOURCE 290#ifdef KEYSYM_RESOURCE
282 delete keyboard; 291 delete keyboard;
283#endif 292#endif
284} 293}
285 294
286void 295void
287rxvt_term::destroy () 296rxvt_term::destroy ()
… …
340 349
341 delete this; 350 delete this;
342} 351}
343 352
344/*----------------------------------------------------------------------*/ 353/*----------------------------------------------------------------------*/
354/*
355 * Exit gracefully, clearing the utmp entry and restoring tty attributes
356 * TODO: if debugging, this should free up any known resources if we can
357 */
358static XErrorHandler old_xerror_handler;
359
360static void
361rxvt_emergency_cleanup ()
362{
363 for (rxvt_term **t = rxvt_term::termlist.begin (); t < rxvt_term::termlist.end (); t++)
364 (*t)->emergency_cleanup ();
365}
366
367int
368rxvt_xerror_handler (Display *display, XErrorEvent *event)
369{
370 if (GET_R->allowedxerror == -1)
371 GET_R->allowedxerror = event->error_code;
372 else
373 {
374 //TODO: GET_R is most likely not the terminal which caused the error
375 //TODO: maybe just output the error and continue?
376 old_xerror_handler (display, event);
377 GET_R->destroy ();
378 }
379
380 return 0;
381}
382
383int
384rxvt_xioerror_handler (Display *display)
385{
386 rxvt_warn ("X connection to '%s' broken, unable to recover, exiting.\n",
387 DisplayString (display));
388 rxvt_emergency_cleanup ();
389 _exit (EXIT_FAILURE);
390}
391
392/*
393 * Catch a fatal signal and tidy up before quitting
394 */
395void
396rxvt_term::sig_term (sig_watcher &w)
397{
398#ifdef DEBUG_CMD
399 rxvt_warn ("caught signal %d, exiting.\n", w.signum);
400#endif
401 rxvt_emergency_cleanup ();
402 signal (w.signum, SIG_DFL);
403 kill (getpid (), w.signum);
404}
405
406/*----------------------------------------------------------------------*/
345/* rxvt_init () */ 407/* rxvt_init () */
346bool 408bool
347rxvt_term::init (int argc, const char *const *argv) 409rxvt_term::init (int argc, const char *const *argv)
348{ 410{
349 SET_R (this); 411 SET_R (this);
… …
369 scrollBar.setIdle (); /* set existence for size calculations */ 431 scrollBar.setIdle (); /* set existence for size calculations */
370#endif 432#endif
371 433
372 create_windows (argc, argv); 434 create_windows (argc, argv);
373 435
436 dDisp;
437
374 init_xlocale (); 438 init_xlocale ();
375 439
376 scr_reset (); /* initialize screen */ 440 scr_reset (); /* initialize screen */
377 441
378#if 0 442#if 0
379 XSynchronize (display->display, True); 443 XSynchronize (disp, True);
380#endif 444#endif
381 445
382#ifdef HAVE_SCROLLBARS 446#ifdef HAVE_SCROLLBARS
383 if (options & Opt_scrollBar) 447 if (options & Opt_scrollBar)
384 resize_scrollbar (); /* create and map scrollbar */ 448 resize_scrollbar (); /* create and map scrollbar */
385#endif 449#endif
386#if (MENUBAR_MAX) 450#if (MENUBAR_MAX)
387 if (menubar_visible ()) 451 if (menubar_visible ())
388 XMapWindow (display->display, menuBar.win); 452 XMapWindow (disp, menuBar.win);
389#endif 453#endif
390#ifdef TRANSPARENT 454#ifdef TRANSPARENT
391 if (options & Opt_transparent) 455 if (options & Opt_transparent)
392 { 456 {
393 XSelectInput (display->display, display->root, PropertyChangeMask); 457 XSelectInput (disp, display->root, PropertyChangeMask);
394 check_our_parents (); 458 check_our_parents ();
395 rootwin_ev.start (display, display->root); 459 rootwin_ev.start (display, display->root);
396 } 460 }
397#endif 461#endif
398 462
399 XMapWindow (display->display, TermWin.vt); 463 XMapWindow (disp, TermWin.vt);
400 XMapWindow (display->display, TermWin.parent[0]); 464 XMapWindow (disp, TermWin.parent[0]);
401 465
402 set_colorfgbg (); 466 set_colorfgbg ();
403 467
404 init_command (cmd_argv); 468 init_command (cmd_argv);
405 469
… …
409 473
410 check_ev.start (); 474 check_ev.start ();
411 475
412 return true; 476 return true;
413} 477}
414
415static int (*old_xerror_handler) (Display *dpy, XErrorEvent *event);
416 478
417void 479void
418rxvt_init () 480rxvt_init ()
419{ 481{
420 /* 482 /*
… …
433 /* need to trap SIGURG for SVR4 (Unixware) rlogin */ 495 /* need to trap SIGURG for SVR4 (Unixware) rlogin */
434 /* signal (SIGURG, SIG_DFL); */ 496 /* signal (SIGURG, SIG_DFL); */
435 497
436 old_xerror_handler = XSetErrorHandler ((XErrorHandler) rxvt_xerror_handler); 498 old_xerror_handler = XSetErrorHandler ((XErrorHandler) rxvt_xerror_handler);
437 // TODO: handle this with exceptions and tolerate the memory loss 499 // TODO: handle this with exceptions and tolerate the memory loss
438 //XSetIOErrorHandler ((XErrorHandler) rxvt_xioerror_handler); 500 XSetIOErrorHandler (rxvt_xioerror_handler);
439} 501}
440 502
441/* ------------------------------------------------------------------------- * 503/* ------------------------------------------------------------------------- *
442 * SIGNAL HANDLING & EXIT HANDLER * 504 * SIGNAL HANDLING & EXIT HANDLER *
443 * ------------------------------------------------------------------------- */ 505 * ------------------------------------------------------------------------- */
… …
456 if (pid == (*t)->cmd_pid) 518 if (pid == (*t)->cmd_pid)
457 { 519 {
458 (*t)->destroy (); 520 (*t)->destroy ();
459 break; 521 break;
460 } 522 }
461}
462
463/*----------------------------------------------------------------------*/
464/*
465 * Exit gracefully, clearing the utmp entry and restoring tty attributes
466 * TODO: if debugging, this should free up any known resources if we can
467 */
468void
469rxvt_destroy_all ()
470{
471 // TODO: rxvtd should clean up all ressources
472 for (rxvt_term **t = rxvt_term::termlist.begin (); t < rxvt_term::termlist.end (); t++)
473 (*t)->destroy ();
474}
475
476/*
477 * Catch a fatal signal and tidy up before quitting
478 */
479void
480rxvt_term::sig_term (sig_watcher &w)
481{
482#ifdef DEBUG_CMD
483 rxvt_warn ("caught signal %d, exiting.\n", w.signum);
484#endif
485 rxvt_destroy_all ();
486 signal (w.signum, SIG_DFL);
487 kill (getpid (), w.signum);
488}
489
490/* INTPROTO */
491int
492rxvt_xerror_handler (Display *display, XErrorEvent *event)
493{
494 if (GET_R->allowedxerror == -1)
495 GET_R->allowedxerror = event->error_code;
496 else
497 {
498 old_xerror_handler (display, event);
499 GET_R->destroy ();
500 }
501
502 return 0;
503} 523}
504 524
505/* ------------------------------------------------------------------------- * 525/* ------------------------------------------------------------------------- *
506 * MEMORY ALLOCATION WRAPPERS * 526 * MEMORY ALLOCATION WRAPPERS *
507 * ------------------------------------------------------------------------- */ 527 * ------------------------------------------------------------------------- */
… …
620 * if width/height are non-zero then override calculated width/height 640 * if width/height are non-zero then override calculated width/height
621 */ 641 */
622void 642void
623rxvt_term::window_calc (unsigned int width, unsigned int height) 643rxvt_term::window_calc (unsigned int width, unsigned int height)
624{ 644{
625 short recalc_x, recalc_y; 645 short recalc_x, recalc_y;
626 int x, y, sb_w, mb_h, flags; 646 int x, y, sb_w, mb_h, flags;
627 unsigned int w, h; 647 unsigned int w, h;
628 unsigned int max_width, max_height; 648 unsigned int max_width, max_height;
649 dDisp;
629 650
630 D_SIZE ((stderr, "< Cols/Rows: %3d x %3d ; Width/Height: %4d x %4d", 651 D_SIZE ((stderr, "< Cols/Rows: %3d x %3d ; Width/Height: %4d x %4d",
631 TermWin.ncol, TermWin.nrow, szHint.width, 652 TermWin.ncol, TermWin.nrow, szHint.width,
632 szHint.height)); 653 szHint.height));
633 szHint.flags = PMinSize | PResizeInc | PBaseSize | PWinGravity; 654 szHint.flags = PMinSize | PResizeInc | PBaseSize | PWinGravity;
… …
731 752
732 if (scrollbar_visible () && (options & Opt_scrollBar_right)) 753 if (scrollbar_visible () && (options & Opt_scrollBar_right))
733 window_sb_x = szHint.width - sb_w; 754 window_sb_x = szHint.width - sb_w;
734 755
735 if (recalc_x) 756 if (recalc_x)
736 szHint.x += (DisplayWidth (display->display, DefaultScreen (display->display)) 757 szHint.x += (DisplayWidth (disp, display->screen)
737 - szHint.width - 2 * TermWin.ext_bwidth); 758 - szHint.width - 2 * TermWin.ext_bwidth);
738 if (recalc_y) 759 if (recalc_y)
739 szHint.y += (DisplayHeight (display->display, DefaultScreen (display->display)) 760 szHint.y += (DisplayHeight (disp, display->screen)
740 - szHint.height - 2 * TermWin.ext_bwidth); 761 - szHint.height - 2 * TermWin.ext_bwidth);
741 762
742 TermWin.ncol = TermWin.width / TermWin.fwidth; 763 TermWin.ncol = TermWin.width / TermWin.fwidth;
743 TermWin.nrow = TermWin.height / TermWin.fheight; 764 TermWin.nrow = TermWin.height / TermWin.fheight;
744 D_SIZE ((stderr, "> Cols/Rows: %3d x %3d ; Width/Height: %4d x %4d", 765 D_SIZE ((stderr, "> Cols/Rows: %3d x %3d ; Width/Height: %4d x %4d",
… …
909 930
910 /* handle color aliases */ 931 /* handle color aliases */
911 if (isdigit (*color)) 932 if (isdigit (*color))
912 { 933 {
913 i = atoi (color); 934 i = atoi (color);
935
914 if (i >= 8 && i <= 15) 936 if (i >= 8 && i <= 15)
915 { /* bright colors */ 937 { /* bright colors */
916 i -= 8; 938 i -= 8;
917# ifndef NO_BRIGHTCOLOR 939# ifndef NO_BRIGHTCOLOR
918 pix_colors_focused[idx] = pix_colors_focused[minBrightCOLOR + i]; 940 pix_colors_focused[idx] = pix_colors_focused[minBrightCOLOR + i];
919 SET_PIXCOLOR (idx); 941 SET_PIXCOLOR (idx);
920 goto Done; 942 goto Done;
921# endif 943# endif
922
923 } 944 }
945
924 if (i >= 0 && i <= 7) 946 if (i >= 0 && i <= 7)
925 { /* normal colors */ 947 { /* normal colors */
926 pix_colors_focused[idx] = pix_colors_focused[minCOLOR + i]; 948 pix_colors_focused[idx] = pix_colors_focused[minCOLOR + i];
927 SET_PIXCOLOR (idx); 949 SET_PIXCOLOR (idx);
928 goto Done; 950 goto Done;
929 } 951 }
930 } 952 }
931 953
932 if (!rXParseAllocColor (& xcol, color)) 954 if (!rXParseAllocColor (&xcol, color))
933 return; 955 return;
934 956
935 /* XStoreColor (display->display, display->cmap, XColor*); */ 957 /* XStoreColor (display->display, display->cmap, XColor*); */
936 958
937 /* 959 /*
… …
1040 * -------------------------------------------------------------------- */ 1062 * -------------------------------------------------------------------- */
1041void 1063void
1042rxvt_term::resize_all_windows (unsigned int width, unsigned int height, int ignoreparent) 1064rxvt_term::resize_all_windows (unsigned int width, unsigned int height, int ignoreparent)
1043{ 1065{
1044 int fix_screen; 1066 int fix_screen;
1045
1046#ifdef SMART_RESIZE 1067#ifdef SMART_RESIZE
1047 int old_width = szHint.width, old_height = szHint.height; 1068 int old_width = szHint.width, old_height = szHint.height;
1048#endif 1069#endif
1070 dDisp;
1049 1071
1050 window_calc (width, height); 1072 window_calc (width, height);
1051 XSetWMNormalHints (display->display, TermWin.parent[0], &szHint); 1073 XSetWMNormalHints (disp, TermWin.parent[0], &szHint);
1052 1074
1053 if (!ignoreparent) 1075 if (!ignoreparent)
1054 { 1076 {
1055#ifdef SMART_RESIZE 1077#ifdef SMART_RESIZE
1056 /* 1078 /*
… …
1060 int x, y, x1, y1; 1082 int x, y, x1, y1;
1061 int dx, dy; 1083 int dx, dy;
1062 unsigned int unused_w1, unused_h1, unused_b1, unused_d1; 1084 unsigned int unused_w1, unused_h1, unused_b1, unused_d1;
1063 Window unused_cr; 1085 Window unused_cr;
1064 1086
1065 XTranslateCoordinates (display->display, TermWin.parent[0], display->root, 1087 XTranslateCoordinates (disp, TermWin.parent[0], display->root,
1066 0, 0, &x, &y, &unused_cr); 1088 0, 0, &x, &y, &unused_cr);
1067 XGetGeometry (display->display, TermWin.parent[0], &unused_cr, &x1, &y1, 1089 XGetGeometry (disp, TermWin.parent[0], &unused_cr, &x1, &y1,
1068 &unused_w1, &unused_h1, &unused_b1, &unused_d1); 1090 &unused_w1, &unused_h1, &unused_b1, &unused_d1);
1069 /* 1091 /*
1070 * if display->root isn't the parent window, a WM will probably have offset 1092 * if display->root isn't the parent window, a WM will probably have offset
1071 * our position for handles and decorations. Counter it 1093 * our position for handles and decorations. Counter it
1072 */ 1094 */
… …
1074 { 1096 {
1075 x -= x1; 1097 x -= x1;
1076 y -= y1; 1098 y -= y1;
1077 } 1099 }
1078 1100
1079 x1 = (DisplayWidth (display->display, display->screen) - old_width) / 2; 1101 x1 = (DisplayWidth (disp, display->screen) - old_width) / 2;
1080 y1 = (DisplayHeight (display->display, display->screen) - old_height) / 2; 1102 y1 = (DisplayHeight (disp, display->screen) - old_height) / 2;
1081 dx = old_width - szHint.width; 1103 dx = old_width - szHint.width;
1082 dy = old_height - szHint.height; 1104 dy = old_height - szHint.height;
1083 1105
1084 /* Check position of the center of the window */ 1106 /* Check position of the center of the window */
1085 if (x < x1) /* left half */ 1107 if (x < x1) /* left half */
… …
1089 if (y < y1) /* top half */ 1111 if (y < y1) /* top half */
1090 dy = 0; 1112 dy = 0;
1091 else if (y == y1) /* exact center */ 1113 else if (y == y1) /* exact center */
1092 dy /= 2; 1114 dy /= 2;
1093 1115
1094 XMoveResizeWindow (display->display, TermWin.parent[0], x + dx, y + dy, 1116 XMoveResizeWindow (disp, TermWin.parent[0], x + dx, y + dy,
1095 szHint.width, szHint.height); 1117 szHint.width, szHint.height);
1096#else 1118#else
1097 XResizeWindow (display->display, TermWin.parent[0], szHint.width, szHint.height); 1119 XResizeWindow (disp, TermWin.parent[0], szHint.width, szHint.height);
1098#endif 1120#endif
1099 } 1121 }
1100 1122
1101 fix_screen = TermWin.ncol != prev_ncol || TermWin.nrow != prev_nrow; 1123 fix_screen = TermWin.ncol != prev_ncol || TermWin.nrow != prev_nrow;
1102 1124
1103 if (fix_screen || width != old_width || height != old_height) 1125 if (fix_screen || width != old_width || height != old_height)
1104 { 1126 {
1105 if (scrollbar_visible ()) 1127 if (scrollbar_visible ())
1106 { 1128 {
1107 XMoveResizeWindow (display->display, scrollBar.win, 1129 XMoveResizeWindow (disp, scrollBar.win,
1108 window_sb_x, 0, 1130 window_sb_x, 0,
1109 scrollbar_TotalWidth (), szHint.height); 1131 scrollbar_TotalWidth (), szHint.height);
1110 resize_scrollbar (); 1132 resize_scrollbar ();
1111 } 1133 }
1112 1134
1113 if (menubar_visible ()) 1135 if (menubar_visible ())
1114 XMoveResizeWindow (display->display, menuBar.win, 1136 XMoveResizeWindow (disp, menuBar.win,
1115 window_vt_x, 0, 1137 window_vt_x, 0,
1116 TermWin_TotalWidth (), menuBar_TotalHeight ()); 1138 TermWin_TotalWidth (), menuBar_TotalHeight ());
1117 1139
1118 XMoveResizeWindow (display->display, TermWin.vt, 1140 XMoveResizeWindow (disp, TermWin.vt,
1119 window_vt_x, window_vt_y, 1141 window_vt_x, window_vt_y,
1120 TermWin_TotalWidth (), TermWin_TotalHeight ()); 1142 TermWin_TotalWidth (), TermWin_TotalHeight ());
1121 1143
1122 scr_clear (); 1144 scr_clear ();
1123#ifdef XPM_BACKGROUND 1145#ifdef XPM_BACKGROUND

Diff Legend

– Removed lines
+ Added lines
< Changed lines
> Changed lines