ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/rxvt-unicode/src/main.C
(Generate patch)

Comparing rxvt-unicode/src/main.C (file contents):
Revision 1.368 by root, Wed Jan 18 12:26:59 2012 UTC vs.
Revision 1.394 by root, Sat Dec 13 10:07:30 2014 UTC

11 * Copyright (c) 1997 mj olesen <olesen@me.QueensU.CA> 11 * Copyright (c) 1997 mj olesen <olesen@me.QueensU.CA>
12 * - extensive modifications 12 * - extensive modifications
13 * Copyright (c) 1997,1998 Oezguer Kesim <kesim@math.fu-berlin.de> 13 * Copyright (c) 1997,1998 Oezguer Kesim <kesim@math.fu-berlin.de>
14 * Copyright (c) 1998-2001 Geoff Wing <gcw@pobox.com> 14 * Copyright (c) 1998-2001 Geoff Wing <gcw@pobox.com>
15 * - extensive modifications 15 * - extensive modifications
16 * Copyright (c) 2003-2010 Marc Lehmann <schmorp@schmorp.de> 16 * Copyright (c) 2003-2014 Marc Lehmann <schmorp@schmorp.de>
17 * 17 *
18 * This program is free software; you can redistribute it and/or modify 18 * This program is free software; you can redistribute it and/or modify
19 * it under the terms of the GNU General Public License as published by 19 * it under the terms of the GNU General Public License as published by
20 * the Free Software Foundation; either version 2 of the License, or 20 * the Free Software Foundation; either version 3 of the License, or
21 * (at your option) any later version. 21 * (at your option) any later version.
22 * 22 *
23 * This program is distributed in the hope that it will be useful, 23 * This program is distributed in the hope that it will be useful,
24 * but WITHOUT ANY WARRANTY; without even the implied warranty of 24 * but WITHOUT ANY WARRANTY; without even the implied warranty of
25 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 25 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
36#include "keyboard.h" 36#include "keyboard.h"
37#include "rxvtperl.h" 37#include "rxvtperl.h"
38 38
39#include <limits> 39#include <limits>
40 40
41#include <cassert> 41#include <assert.h>
42#include <csignal> 42#include <signal.h>
43#include <cstring> 43#include <string.h>
44 44
45#include <termios.h> 45#include <termios.h>
46 46
47#ifdef HAVE_XSETLOCALE 47#ifdef HAVE_XSETLOCALE
48# define X_LOCALE 48# define X_LOCALE
49# include <X11/Xlocale.h> 49# include <X11/Xlocale.h>
50#else 50#else
51# ifdef HAVE_SETLOCALE
52# include <clocale> 51# include <locale.h>
53# endif
54#endif 52#endif
55 53
56struct termios rxvt_term::def_tio; 54struct termios rxvt_term::def_tio;
57vector<rxvt_term *> rxvt_term::termlist; 55vector<rxvt_term *> rxvt_term::termlist;
58 56
170 sel_scroll_ev.set <rxvt_term, &rxvt_term::sel_scroll_cb> (this); 168 sel_scroll_ev.set <rxvt_term, &rxvt_term::sel_scroll_cb> (this);
171#endif 169#endif
172#if defined(MOUSE_WHEEL) && defined(MOUSE_SLIP_WHEELING) 170#if defined(MOUSE_WHEEL) && defined(MOUSE_SLIP_WHEELING)
173 slip_wheel_ev.set <rxvt_term, &rxvt_term::slip_wheel_cb> (this); 171 slip_wheel_ev.set <rxvt_term, &rxvt_term::slip_wheel_cb> (this);
174#endif 172#endif
175#if ENABLE_TRANSPARENCY || ENABLE_PERL 173#if BG_IMAGE_FROM_ROOT || ENABLE_PERL
176 rootwin_ev.set <rxvt_term, &rxvt_term::rootwin_cb> (this), 174 rootwin_ev.set <rxvt_term, &rxvt_term::rootwin_cb> (this),
177#endif 175#endif
178 scrollbar_ev.set <rxvt_term, &rxvt_term::x_cb> (this), 176 scrollbar_ev.set <rxvt_term, &rxvt_term::x_cb> (this),
179#ifdef USE_XIM 177#if USE_XIM
180 im_ev.set <rxvt_term, &rxvt_term::im_cb> (this), 178 im_ev.set <rxvt_term, &rxvt_term::im_cb> (this),
181#endif 179#endif
182#ifdef POINTER_BLANK 180#ifdef POINTER_BLANK
183 pointer_ev.set <rxvt_term, &rxvt_term::pointer_cb> (this); 181 pointer_ev.set <rxvt_term, &rxvt_term::pointer_cb> (this);
184#endif 182#endif
228 226
229#ifdef HAVE_BG_PIXMAP 227#ifdef HAVE_BG_PIXMAP
230 bg_destroy (); 228 bg_destroy ();
231#endif 229#endif
232 230
231#if HAVE_IMG
232 delete bg_img;
233#endif
234
233 if (display) 235 if (display)
234 { 236 {
235 selection_clear (); 237 selection_clear ();
236 selection_clear (true); 238 selection_clear (true);
237 239
238#ifdef USE_XIM 240#if USE_XIM
239 im_destroy (); 241 im_destroy ();
240#endif 242#endif
241 scrollBar.destroy (); 243 scrollBar.destroy ();
244
245 if (gc)
242 if (gc) XFreeGC (dpy, gc); 246 XFreeGC (dpy, gc);
243 247
244 delete drawable; 248 delete drawable;
249
245 // destroy all windows 250 // destroy all windows
246 if (parent) 251 if (parent)
247 XDestroyWindow (dpy, parent); 252 XDestroyWindow (dpy, parent);
248 253
249 for (int i = 0; i < TOTAL_COLORS; i++) 254 for (int i = 0; i < TOTAL_COLORS; i++)
272 free (locale); 277 free (locale);
273 free (v_buffer); 278 free (v_buffer);
274 279
275 delete selection_req; 280 delete selection_req;
276 281
282 if (env && memcmp (env, envv->begin (), envv->size () * sizeof (char *)))
283 rxvt_warn ("env has been modified, probably as a result of a lib calling setenv.\n");
284
285 delete env;
286
277 delete envv; 287 delete envv;
278 delete argv; 288 delete argv;
279 289
280#ifdef KEYSYM_RESOURCE 290#ifdef KEYSYM_RESOURCE
281 delete keyboard; 291 delete keyboard;
282#endif 292#endif
283#ifndef NO_RESOURCES 293#ifndef NO_RESOURCES
284 XrmDestroyDatabase (option_db); 294 XrmDestroyDatabase (option_db);
285#endif 295#endif
296
297 SET_R ((rxvt_term *)0);
286} 298}
287 299
288// child has exited, usually destroys 300// child has exited, usually destroys
289void 301void
290rxvt_term::child_cb (ev::child &w, int status) 302rxvt_term::child_cb (ev::child &w, int status)
313 { 325 {
314#if USE_XIM 326#if USE_XIM
315 im_ev.stop (display); 327 im_ev.stop (display);
316#endif 328#endif
317 scrollbar_ev.stop (display); 329 scrollbar_ev.stop (display);
318#if ENABLE_TRANSPARENCY || ENABLE_PERL 330#if BG_IMAGE_FROM_ROOT || ENABLE_PERL
319 rootwin_ev.stop (display); 331 rootwin_ev.stop (display);
320#endif 332#endif
321 termwin_ev.stop (display); 333 termwin_ev.stop (display);
322 vt_ev.stop (display); 334 vt_ev.stop (display);
323 } 335 }
364} 376}
365 377
366/*----------------------------------------------------------------------*/ 378/*----------------------------------------------------------------------*/
367/* 379/*
368 * Exit gracefully, clearing the utmp entry and restoring tty attributes 380 * Exit gracefully, clearing the utmp entry and restoring tty attributes
369 * TODO: if debugging, this should free up any known resources if we can
370 */ 381 */
371static XErrorHandler old_xerror_handler; 382static XErrorHandler old_xerror_handler;
372 383
373static void 384static void
374rxvt_emergency_cleanup () 385rxvt_emergency_cleanup ()
376 for (rxvt_term **t = rxvt_term::termlist.begin (); t < rxvt_term::termlist.end (); t++) 387 for (rxvt_term **t = rxvt_term::termlist.begin (); t < rxvt_term::termlist.end (); t++)
377 (*t)->emergency_cleanup (); 388 (*t)->emergency_cleanup ();
378} 389}
379 390
380#if !ENABLE_MINIMAL 391#if !ENABLE_MINIMAL
381static void 392static void ecb_cold
382print_x_error (Display *dpy, XErrorEvent *event) 393print_x_error (Display *dpy, XErrorEvent *event)
383{ 394{
384 char buffer[BUFSIZ]; 395 char buffer[BUFSIZ];
385 char mesg[BUFSIZ]; 396 char mesg[BUFSIZ];
386 char number[32]; 397 char number[32];
387 const char mtype[] = "XlibMessage"; 398
388 XGetErrorText(dpy, event->error_code, buffer, BUFSIZ);
389 XGetErrorDatabaseText(dpy, mtype, "XError", "X Error", mesg, BUFSIZ);
390 rxvt_warn ("An X Error occurred, trying to continue after report.\n"); 399 rxvt_warn ("An X Error occurred, trying to continue after report.\n");
400
401 XGetErrorDatabaseText (dpy, "XlibMessage", "ErrorSerial", "Error Serial #%d", mesg, BUFSIZ);
402 snprintf (buffer, BUFSIZ, "+ %s\n", mesg); rxvt_warn (buffer, event->serial);
403
404 XGetErrorText (dpy, event->error_code, buffer, BUFSIZ);
405 XGetErrorDatabaseText (dpy, "XlibMessage", "XError", "X Error", mesg, BUFSIZ);
391 rxvt_warn ("%s: %s\n", mesg, buffer); 406 rxvt_warn ("+ %s: %s\n", mesg, buffer);
407
392 XGetErrorDatabaseText(dpy, mtype, "MajorCode", "Request Major code %d", mesg, BUFSIZ); 408 XGetErrorDatabaseText (dpy, "XlibMessage", "MajorCode", "Request Major code %d", mesg, BUFSIZ);
393 rxvt_warn (strncat (mesg, "\n", BUFSIZ), event->request_code); 409 snprintf (buffer, BUFSIZ, "+ %s\n", mesg); rxvt_warn (buffer, event->request_code);
410
411 if (event->request_code >= 128)
412 {
413#if 0
414 /* XListExtensions and probably query extensions hangs when there are multiple queues errors */
415 int nexts;
416 char **exts = XListExtensions (dpy, &nexts);
417
418 while (nexts)
419 {
420 char *extname = exts [nexts - 1];
421 int major, first_event, first_error;
422
423 if (XQueryExtension (dpy, extname, &major, &first_event, &first_error) && major == event->request_code)
424 {
425 XGetErrorDatabaseText (dpy, "XlibMessage", "MinorCode", "Request Minor code %d", mesg, BUFSIZ);
426 rxvt_warn ("+ (which is extension %s minor code %d)\n", extname, event->minor_code);
427
428 snprintf (buffer, BUFSIZ, "%s.%d", extname, event->minor_code);
429 XGetErrorDatabaseText (dpy, "XRequest", buffer, "an unregistered minor code", buffer, BUFSIZ);
430 rxvt_warn ("+ (which is %s)\n", buffer);
431
432 break;
433 }
434
435 printf ("nextss %d %s\n", nexts, extname);//D
436 --nexts;
437 ++exts;
438 }
439#else
440 int nexts = 0;
441 char **exts = 0;
442#endif
443
444 if (!nexts)
445 {
446 rxvt_warn ("+ (which is an unknown extension)\n", buffer);
447
448 XGetErrorDatabaseText (dpy, "XlibMessage", "MinorCode", "Request Minor code %d", mesg, BUFSIZ);
449 snprintf (buffer, BUFSIZ, "+ %s\n", mesg); rxvt_warn (buffer, event->minor_code);
450
451#if 0
452 sprintf (number, "RENDER.%d", event->minor_code);
453 XGetErrorDatabaseText (dpy, "XRequest", number, "", buffer, BUFSIZ);
454 rxvt_warn ("+ (which is %s)\n", buffer);
455#endif
456 }
457
458 XFreeExtensionList (exts);
459 }
460 else
461 {
394 sprintf(number, "%d", event->request_code); 462 sprintf (number, "%d", event->request_code);
395 XGetErrorDatabaseText(dpy, "XRequest", number, "", buffer, BUFSIZ); 463 XGetErrorDatabaseText (dpy, "XRequest", number, "", buffer, BUFSIZ);
396 rxvt_warn ("(which is %s)\n", buffer); 464 rxvt_warn ("+ (which is %s)\n", buffer);
397 if (event->request_code >= 128) {
398 XGetErrorDatabaseText(dpy, mtype, "MinorCode", "Request Minor code %d",
399 mesg, BUFSIZ);
400 rxvt_warn (strncat (mesg, "\n", BUFSIZ), event->minor_code);
401 } 465 }
466
402 if ((event->error_code == BadWindow) || 467 if (event->error_code == BadWindow
403 (event->error_code == BadPixmap) || 468 || event->error_code == BadPixmap
404 (event->error_code == BadCursor) || 469 || event->error_code == BadCursor
405 (event->error_code == BadFont) || 470 || event->error_code == BadFont
406 (event->error_code == BadDrawable) || 471 || event->error_code == BadDrawable
407 (event->error_code == BadColor) || 472 || event->error_code == BadColor
408 (event->error_code == BadGC) || 473 || event->error_code == BadGC
409 (event->error_code == BadIDChoice) || 474 || event->error_code == BadIDChoice
410 (event->error_code == BadValue) || 475 || event->error_code == BadValue
411 (event->error_code == BadAtom)) { 476 || event->error_code == BadAtom)
477 {
412 if (event->error_code == BadValue) 478 if (event->error_code == BadValue)
413 XGetErrorDatabaseText(dpy, mtype, "Value", "Value 0x%x", 479 XGetErrorDatabaseText (dpy, "XlibMessage", "Value", "Value 0x%x", mesg, BUFSIZ);
414 mesg, BUFSIZ);
415 else if (event->error_code == BadAtom) 480 else if (event->error_code == BadAtom)
416 XGetErrorDatabaseText(dpy, mtype, "AtomID", "AtomID 0x%x", 481 XGetErrorDatabaseText (dpy, "XlibMessage", "AtomID", "AtomID 0x%x", mesg, BUFSIZ);
417 mesg, BUFSIZ);
418 else 482 else
419 XGetErrorDatabaseText(dpy, mtype, "ResourceID", "ResourceID 0x%x", 483 XGetErrorDatabaseText (dpy, "XlibMessage", "ResourceID", "ResourceID 0x%x", mesg, BUFSIZ);
420 mesg, BUFSIZ);
421 rxvt_warn (strncat (mesg, "\n", BUFSIZ), event->resourceid);
422 }
423 XGetErrorDatabaseText(dpy, mtype, "ErrorSerial", "Error Serial #%d",
424 mesg, BUFSIZ);
425 rxvt_warn (strncat (mesg, "\n", BUFSIZ), event->serial);
426}
427#endif
428 484
429int 485 snprintf (buffer, BUFSIZ, "+ %s\n", mesg); rxvt_warn (buffer, event->resourceid);
486 }
487}
488#endif
489
490int ecb_cold
430rxvt_xerror_handler (Display *display, XErrorEvent *event) 491rxvt_xerror_handler (Display *display, XErrorEvent *event)
431{ 492{
432 if (GET_R->allowedxerror == -1) 493 if (GET_R && GET_R->allowedxerror == -1)
433 GET_R->allowedxerror = event->error_code; 494 GET_R->allowedxerror = event->error_code;
434 else 495 else
435 { 496 {
436 // GET_R is most likely not the terminal which caused the error, 497 // GET_R is most likely not the terminal which caused the error,
437 // so just output the error and continue 498 // so just output the error and continue
443 } 504 }
444 505
445 return 0; 506 return 0;
446} 507}
447 508
448int 509int ecb_cold
449rxvt_xioerror_handler (Display *display) 510rxvt_xioerror_handler (Display *display)
450{ 511{
451 rxvt_warn ("X connection to '%s' broken, unable to recover, exiting.\n", 512 rxvt_warn ("X connection to '%s' broken, unable to recover, exiting.\n",
452 DisplayString (display)); 513 DisplayString (display));
453 rxvt_emergency_cleanup (); 514 rxvt_emergency_cleanup ();
573 old_xerror_handler = XSetErrorHandler ((XErrorHandler) rxvt_xerror_handler); 634 old_xerror_handler = XSetErrorHandler ((XErrorHandler) rxvt_xerror_handler);
574 // TODO: handle this with exceptions and tolerate the memory loss 635 // TODO: handle this with exceptions and tolerate the memory loss
575 XSetIOErrorHandler (rxvt_xioerror_handler); 636 XSetIOErrorHandler (rxvt_xioerror_handler);
576 637
577 XrmInitialize (); 638 XrmInitialize ();
639
640#if HAVE_PIXBUF
641 g_type_init ();
642#endif
578} 643}
579 644
580/*----------------------------------------------------------------------*/ 645/*----------------------------------------------------------------------*/
581/* 646/*
582 * window size/position calculations for XSizeHint and other storage. 647 * window size/position calculations for XSizeHint and other storage.
766 831
767 delete fontset[0]; 832 delete fontset[0];
768 fontset[0] = fs; 833 fontset[0] = fs;
769 834
770 prop = (*fs)[rxvt_fontset::firstFont]->properties (); 835 prop = (*fs)[rxvt_fontset::firstFont]->properties ();
771 prop.height += lineSpace; 836 prop.width = max (prop.width + letterSpace, 1);
772 prop.width += letterSpace;
773 837
774 fs->set_prop (prop, false); 838 fs->set_prop (prop, false);
775 839
776 fwidth = prop.width; 840 fwidth = prop.width;
777 fheight = prop.height; 841 fheight = prop.height + lineSpace;
778 fbase = prop.ascent; 842 fbase = prop.ascent;
779 843
780 for (int style = 1; style < 4; style++) 844 for (int style = 1; style < 4; style++)
781 { 845 {
782#if ENABLE_STYLES 846#if ENABLE_STYLES
964 1028
965 for (i = Color_Black; i <= Color_White; i++) 1029 for (i = Color_Black; i <= Color_White; i++)
966 if (pix_colors[Color_bg] == pix_colors[i]) 1030 if (pix_colors[Color_bg] == pix_colors[i])
967 { 1031 {
968 sprintf (bstr, "%d", i - Color_Black); 1032 sprintf (bstr, "%d", i - Color_Black);
969#ifdef BG_IMAGE_FROM_FILE 1033#if BG_IMAGE_FROM_FILE
970 xpmb = "default;"; 1034 xpmb = "default;";
971#endif 1035#endif
972 break; 1036 break;
973 } 1037 }
974 1038
1077 1141
1078 XMoveResizeWindow (dpy, vt, 1142 XMoveResizeWindow (dpy, vt,
1079 window_vt_x, window_vt_y, 1143 window_vt_x, window_vt_y,
1080 vt_width, vt_height); 1144 vt_width, vt_height);
1081 1145
1146 HOOK_INVOKE ((this, HOOK_SIZE_CHANGE, DT_INT, newwidth, DT_INT, newheight, DT_END));
1147
1082#ifdef HAVE_BG_PIXMAP 1148#ifdef HAVE_BG_PIXMAP
1083 if (bg_window_size_sensitive ()) 1149 if (bg_window_size_sensitive ())
1084 update_background (); 1150 update_background ();
1085#endif 1151#endif
1086 } 1152 }
1087 1153
1088 if (fix_screen || old_height == 0) 1154 if (fix_screen || old_height == 0)
1089 scr_reset (); 1155 scr_reset ();
1090 1156
1091#ifdef USE_XIM 1157#if USE_XIM
1092 im_set_position (); 1158 im_set_position ();
1093#endif 1159#endif
1094} 1160}
1095 1161
1096/* 1162/*
1121} 1187}
1122 1188
1123/* -------------------------------------------------------------------- * 1189/* -------------------------------------------------------------------- *
1124 * - X INPUT METHOD ROUTINES - * 1190 * - X INPUT METHOD ROUTINES - *
1125 * -------------------------------------------------------------------- */ 1191 * -------------------------------------------------------------------- */
1126#ifdef USE_XIM 1192#if USE_XIM
1127 1193
1128void 1194void
1129rxvt_term::im_set_color (unsigned long &fg, unsigned long &bg) 1195rxvt_term::im_set_color (unsigned long &fg, unsigned long &bg)
1130{ 1196{
1131 fg = pix_colors [Color_fg]; 1197 fg = pix_colors [Color_fg];
1311 unsigned long fg, bg; 1377 unsigned long fg, bg;
1312 const char *p; 1378 const char *p;
1313 char **s; 1379 char **s;
1314 XIMStyles *xim_styles; 1380 XIMStyles *xim_styles;
1315 1381
1316 set_environ (envv); 1382 set_environ (env);
1317 1383
1318 if (! ((p = XSetLocaleModifiers (modifiers)) && *p)) 1384 if (!((p = XSetLocaleModifiers (modifiers)) && *p))
1319 return false; 1385 return false;
1320 1386
1321 input_method = display->get_xim (locale, modifiers); 1387 input_method = display->get_xim (locale, modifiers);
1322 if (input_method == NULL) 1388 if (input_method == NULL)
1323 return false; 1389 return false;
1528 im_destroy (); 1594 im_destroy ();
1529 1595
1530 if (Input_Context) 1596 if (Input_Context)
1531 return; 1597 return;
1532 1598
1533#if defined(HAVE_XSETLOCALE) || defined(HAVE_SETLOCALE)
1534 if (rs[Rs_imLocale]) 1599 if (rs[Rs_imLocale])
1535 SET_LOCALE (rs[Rs_imLocale]); 1600 SET_LOCALE (rs[Rs_imLocale]);
1536#endif
1537 1601
1538 p = rs[Rs_inputMethod]; 1602 p = rs[Rs_inputMethod];
1539 if (p && *p) 1603 if (p && *p)
1540 { 1604 {
1541 bool found = false; 1605 bool found = false;
1568 1632
1569 /* try with no modifiers base IF the user didn't specify an IM */ 1633 /* try with no modifiers base IF the user didn't specify an IM */
1570 if (im_get_ic ("@im=none")) 1634 if (im_get_ic ("@im=none"))
1571 goto done; 1635 goto done;
1572 1636
1573done: ; 1637done:
1574#if defined(HAVE_XSETLOCALE) || defined(HAVE_SETLOCALE)
1575 if (rs[Rs_imLocale]) 1638 if (rs[Rs_imLocale])
1576 SET_LOCALE (locale); 1639 SET_LOCALE (locale);
1577#endif
1578} 1640}
1579 1641
1580void 1642void
1581rxvt_term::im_set_position () 1643rxvt_term::im_set_position ()
1582{ 1644{
1627{ 1689{
1628 Window cr; 1690 Window cr;
1629 XTranslateCoordinates (dpy, parent, display->root, 0, 0, &x, &y, &cr); 1691 XTranslateCoordinates (dpy, parent, display->root, 0, 0, &x, &y, &cr);
1630} 1692}
1631 1693
1632Pixmap
1633rxvt_term::get_pixmap_property (Atom property)
1634{
1635 Pixmap pixmap = None;
1636
1637 int aformat;
1638 unsigned long nitems, bytes_after;
1639 Atom atype;
1640 unsigned char *prop;
1641 int result = XGetWindowProperty (dpy, display->root, property,
1642 0L, 1L, False, XA_PIXMAP, &atype, &aformat,
1643 &nitems, &bytes_after, &prop);
1644 if (result == Success)
1645 {
1646 if (atype == XA_PIXMAP)
1647 pixmap = *(Pixmap *)prop;
1648 XFree (prop);
1649 }
1650
1651 return pixmap;
1652}
1653
1654#ifdef HAVE_BG_PIXMAP 1694#ifdef HAVE_BG_PIXMAP
1655 1695
1656void 1696void
1657rxvt_term::update_background () 1697rxvt_term::update_background ()
1658{ 1698{
1659 if (update_background_ev.is_active ()) 1699 if (update_background_ev.is_active ())
1660 return;
1661
1662 bg_invalidate ();
1663
1664 if (!mapped)
1665 return; 1700 return;
1666 1701
1667 ev_tstamp to_wait = 0.5 - (ev::now () - bg_valid_since); 1702 ev_tstamp to_wait = 0.5 - (ev::now () - bg_valid_since);
1668 1703
1669 if (to_wait <= 0.) 1704 if (to_wait <= 0.)

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines