--- rxvt-unicode/src/misc.C 2008/01/07 12:41:31 1.51 +++ rxvt-unicode/src/misc.C 2011/01/10 14:07:19 1.55 @@ -40,7 +40,10 @@ ssize_t l = wcrtomb (dst, *str++, mbs); if (l < 0) - *dst++ = '?'; + { + *dst++ = '?'; + wcrtomb (0, 0, mbs); // reset undefined state + } else dst += l; } @@ -164,12 +167,12 @@ return r; } -char * +const char * rxvt_basename (const char *str) NOTHROW { - char *base = strrchr (str, '/'); + const char *base = strrchr (str, '/'); - return (char *) (base ? base + 1 : str); + return base ? base + 1 : str; } /* @@ -262,21 +265,20 @@ } /* - * Split a comma-separated string into an array, stripping leading and + * Split a string into an array based on the given delimiter, stripping leading and * trailing spaces from each entry. Empty strings are properly returned */ char ** -rxvt_splitcommastring (const char *cs) NOTHROW +rxvt_strsplit (char delim, const char *str) NOTHROW { - int l, n, p; - const char *s, *t; - char **ret; + int l, n; + char *s, *t; + char **ret; - if ((s = cs) == NULL) - s = ""; + s = strdup (str ? str : ""); for (n = 1, t = s; *t; t++) - if (*t == ',') + if (*t == delim) n++; ret = (char **)malloc ((n + 1) * sizeof (char *)); @@ -284,11 +286,10 @@ for (l = 0, t = s; l < n; l++) { - for ( ; *t && *t != ','; t++) ; - p = t - s; - ret[l] = (char *)malloc (p + 1); - memcpy (ret[l], s, p); - ret[l][p] = '\0'; + for (; *t && *t != delim; t++) + ; + *t = '\0'; + ret[l] = s; rxvt_strtrim (ret[l]); s = ++t; } @@ -296,15 +297,6 @@ return ret; } -void -rxvt_freecommastring (char **cs) NOTHROW -{ - for (int i = 0; cs[i]; ++i) - free (cs[i]); - - free (cs); -} - void * rxvt_malloc (size_t size) {