--- rxvt-unicode/src/perl/matcher	2014/05/31 19:47:42	1.17
+++ rxvt-unicode/src/perl/matcher	2014/06/13 21:49:19	1.25
@@ -30,8 +30,8 @@
 The launcher can also be overridden on a per-pattern basis.
 
 It is possible to activate the most recently seen match or a list of matches
-from the keyboard.  Simply bind a keysym to "perl:matcher:last" or
-"perl:matcher:list" as seen in the example below.
+from the keyboard.  Simply bind a keysym to "matcher:last" or
+"matcher:list" as seen in the example below.
 
 Example: load and use the matcher extension with defaults.
 
@@ -40,8 +40,8 @@
 Example: use a custom configuration.
 
     URxvt.url-launcher:       sensible-browser
-    URxvt.keysym.C-Delete:    perl:matcher:last
-    URxvt.keysym.M-Delete:    perl:matcher:list
+    URxvt.keysym.C-Delete:    matcher:last
+    URxvt.keysym.M-Delete:    matcher:list
     URxvt.matcher.button:     1
     URxvt.matcher.pattern.1:  \\bwww\\.[\\w-]+\\.[\\w./?&@#-]*[\\w/-]
     URxvt.matcher.pattern.2:  \\B(/\\S+?):(\\d+)(?=:|$)
@@ -62,20 +62,18 @@
 sub on_key_press {
    my ($self, $event, $keysym, $octets) = @_;
 
-   if (! $self->{showing} ) {
-      return;
-   }
+   return unless $self->{overlay};
+
+   delete $self->{overlay};
 
    my $i = ($keysym == 96 ? 0 : $keysym - 48);
-   if (($i > scalar(@{$self->{urls}})) || ($i < 0)) {
-      $self->matchlist();
-      return;
+   if ($i >= 0 && $i < @{ $self->{matches} }) {
+      my @exec = @{ $self->{matches}[$i] };
+      shift @exec;
+      $self->exec_async (@exec);
    }
 
-   my @args = ($self->{urls}[ -$i-1 ]);
-   $self->matchlist();
-
-   $self->exec_async( $self->{launcher}, @args );
+   1
 }
 
 # backwards compat
@@ -96,59 +94,57 @@
    ()
 }
 
-sub matchlist {
-   my ($self) = @_;
-   if ( $self->{showing} ) {
-      $self->{url_overlay}->hide;
-      $self->{showing} = 0;
-      return;
-   }
-   @{$self->{urls}} = ();
-   my $line;
-   for (my $i = 0; $i < $self->nrow; $i ++) {
-      $line = $self->line($i);
-      next if ($line->beg != $i);
-      for my $url ($self->get_urls_from_line($line->t)) {
-         if (scalar(@{$self->{urls}}) == 10) {
-            shift @{$self->{urls}};
-         }
-         push @{$self->{urls}}, $url;
-      }
-   }
+sub on_action {
+   my ($self, $action) = @_;
 
-   if (! scalar(@{$self->{urls}})) {
-      return;
+   if ($action eq "list") {
+      $self->matchlist;
+   } elsif ($action eq "last") {
+      $self->most_recent;
    }
 
-   my $max = 0;
-   my $i = scalar( @{$self->{urls}} ) - 1 ;;
-
-   my @temp = ();
+   ()
+}
 
-   for my $url (@{$self->{urls}}) {
-      my $url = "$i-$url";
-      my $xpos = 0;
+sub matchlist {
+   my ($self) = @_;
 
-      if ($self->ncol + (length $url) >= $self->ncol) {
-         $url = substr( $url, 0, $self->ncol );
+   @{ $self->{matches} } = ();
+   my $row = $self->nrow - 1;
+   while ($row >= 0 && @{ $self->{matches} } < 10) {
+      my $line = $self->line ($row);
+      my @matches = $self->find_matches ($row);
+
+      for (sort { $b->[0] <=> $a->[0] } @matches) {
+         shift @$_;
+         push @{ $self->{matches} }, $_;
+         last if @{ $self->{matches} } == 10;
       }
 
-      push @temp, $url;
+      $row = $line->beg - 1;
+   }
 
-      if( length $url > $max ) {
-         $max = length $url;
-      }
+   return unless @{ $self->{matches} };
+
+   my $width = 0;
+
+   my $i = 0;
+   for my $match (@{ $self->{matches} }) {
+      my $text = $match->[0];
+      my $w = $self->strwidth ("$i-$text");
 
-      $i--;
+      $width = $w if $w > $width;
+      $i++;
    }
 
-   @temp = reverse @temp;
+   $width = $self->ncol - 2 if $width > $self->ncol - 2;
 
-   $self->{url_overlay} = $self->overlay(0, 0, $max, scalar( @temp ), urxvt::OVERLAY_RSTYLE, 2);
+   $self->{overlay} = $self->overlay (0, 0, $width, scalar (@{ $self->{matches} }), urxvt::OVERLAY_RSTYLE, 2);
    my $i = 0;
-   for my $url (@temp) {
-      $self->{url_overlay}->set( 0, $i, $url, [(urxvt::OVERLAY_RSTYLE) x length $url]);
-      $self->{showing} = 1;
+   for my $match (@{ $self->{matches} }) {
+      my $text = $match->[0];
+
+      $self->{overlay}->set (0, $i, "$i-$text");
       $i++;
    }
 
@@ -192,8 +188,7 @@
 
    $self->{launcher} = $self->my_resource ("launcher") || $self->x_resource("url-launcher") || "sensible-browser";
 
-   $self->{urls} = [];
-   $self->{showing} = 0;
+   $self->{matches} = [];
    $self->{button}  = 2;
    $self->{state}   = 0;
    if($self->{argv}[0] || $self->my_resource ("button")) {
@@ -228,17 +223,6 @@
    ()
 }
 
-sub get_urls_from_line {
-   my ($self, $line) = @_;
-   my @urls;
-   for my $matcher (@{$self->{matchers}}) {
-      while ($line =~ /$matcher->[0]/g) {
-         push @urls, substr( $line, $-[0], $+[0] - $-[0] );
-      }
-   }
-   return @urls;
-}
-
 sub on_line_update {
    my ($self, $row) = @_;
 
@@ -273,32 +257,49 @@
       ($event->{state} & $mask) == $self->{state});
 }
 
-sub command_for {
+sub find_matches {
    my ($self, $row, $col) = @_;
    my $line = $self->line ($row);
    my $text = $line->t;
+   my $off = $line->offset_of ($row, $col) if $col;
 
+   my @matches;
    for my $matcher (@{$self->{matchers}}) {
       my $launcher = $matcher->[1] || $self->{launcher};
-      while (($text =~ /$matcher->[0]/g)) {
-         my $match = $&;
+      while ($text =~ /$matcher->[0]/g) {
+         my $match = substr $text, $-[0], $+[0] - $-[0];
          my @begin = @-;
          my @end = @+;
-         if (!defined($col) || ($-[0] <= $col && $+[0] >= $col)) {
+         my @exec;
+
+         if (!defined($off) || ($-[0] <= $off && $+[0] >= $off)) {
             if ($launcher !~ /\$/) {
-               return ($launcher,$match);
+               @exec = ($launcher, $match);
             } else {
                # It'd be nice to just access a list like ($&,$1,$2...),
                # but alas, m//g behaves differently in list context.
-               my @exec = map { s/\$(\d+)|\$\{(\d+)\}/
-                  substr($text,$begin[$1||$2],$end[$1||$2]-$begin[$1||$2])
-                  /egx; $_ } split(/\s+/, $launcher);
-               return @exec;
+               @exec = map { s/\$(\d+)|\$\{(\d+)\}/
+                  substr $text, $begin[$1 || $2], $end[$1 || $2] - $begin[$1 || $2]
+                  /egx; $_ } split /\s+/, $launcher;
             }
+
+            push @matches, [ $begin[0], $match, @exec ];
          }
       }
    }
 
+   @matches;
+}
+
+sub command_for {
+   my ($self, $row, $col) = @_;
+
+   my @matches = $self->find_matches ($row, $col);
+   if (@matches) {
+      my @match = @{ $matches[0] };
+      return @match[2 .. $#match];
+   }
+
    ()
 }