[ViewVC] Diff of: cvs/rxvt-unicode/src/perl/matcher

Comparing rxvt-unicode/src/perl/matcher (file contents):
Revision 1.23 by sf-exg, Thu Jun 12 12:19:09 2014 UTC vs.
Revision 1.30 by sf-exg, Sat Jun 21 14:11:18 2014 UTC

 #:META:RESOURCE:%.launcher:string:default launcher command
 #:META:RESOURCE:%.button:string:the button, yeah
 #:META:RESOURCE:%.pattern.:string:extra pattern to match
 #:META:RESOURCE:%.launcher.:string:custom launcher for pattern
-#:META:RESOURCE:%.rend.:string:custom rednition for pattern
+#:META:RESOURCE:%.rend.:string:custom rendition for pattern
 =head1 NAME
 matcher - match strings in terminal output and change their rendition
          \([\w\-\@;\/?:&=%\$.+!*\x27,~#]*\)| # Allow a pair of matched parentheses
          [\w\-\@;\/?:&=%\$+*~]  # exclude some trailing characters (heuristic)
       )+
    }x;
-sub on_key_press {
+sub matchlist_key_press {
    my ($self, $event, $keysym, $octets) = @_;
-   return unless $self->{overlay};
    delete $self->{overlay};
+   $self->disable ("key_press");
    my $i = ($keysym == 96 ? 0 : $keysym - 48);
    if ($i >= 0 && $i < @{ $self->{matches} }) {
       my @exec = @{ $self->{matches}[$i] };
-      shift @exec;
-      $self->exec_async (@exec);
+      $self->exec_async (@exec[5 .. $#exec]);
    }
    1
 }
 }
 sub matchlist {
    my ($self) = @_;
-   @{ $self->{matches} } = ();
+   $self->{matches} = [];
    my $row = $self->nrow - 1;
    while ($row >= 0 && @{ $self->{matches} } < 10) {
       my $line = $self->line ($row);
-      my @matches = $self->find_matches ($row, 0);
+      my @matches = $self->find_matches ($row);
-      for (sort { $b->[0] <=> $a->[0] } @matches) {
+      for (sort { $b->[0] <=> $a->[0] or $b->[1] <=> $a->[1] } @matches) {
-         shift @$_;
          push @{ $self->{matches} }, $_;
          last if @{ $self->{matches} } == 10;
       }
       $row = $line->beg - 1;
    my $width = 0;
    my $i = 0;
    for my $match (@{ $self->{matches} }) {
-      my $text = $match->[0];
+      my $text = $match->[4];
       my $w = $self->strwidth ("$i-$text");
       $width = $w if $w > $width;
       $i++;
    }
    $width = $self->ncol - 2 if $width > $self->ncol - 2;
    $self->{overlay} = $self->overlay (0, 0, $width, scalar (@{ $self->{matches} }), urxvt::OVERLAY_RSTYLE, 2);
    my $i = 0;
    for my $match (@{ $self->{matches} }) {
-      my $text = $match->[0];
+      my $text = $match->[4];
       $self->{overlay}->set (0, $i, "$i-$text");
       $i++;
    }
+   $self->enable (key_press => \&matchlist_key_press);
 }
 sub most_recent {
    my ($self) = shift;
    my $row = $self->nrow;
 sub on_start {
    my ($self) = @_;
    $self->{launcher} = $self->my_resource ("launcher") || $self->x_resource("url-launcher") || "sensible-browser";
-   $self->{matches} = [];
    $self->{button}  = 2;
    $self->{state}   = 0;
    if($self->{argv}[0] || $self->my_resource ("button")) {
       my @mods = split '', $self->{argv}[0] || $self->my_resource ("button");
       for my $mod (@mods) {
    my ($self, $row) = @_;
    # fetch the line that has changed
    my $line = $self->line ($row);
    my $text = $line->t;
-   my $i = 0;
    # find all urls (if any)
    for my $matcher (@{$self->{matchers}}) {
       while ($text =~ /$matcher->[0]/g) {
          #print "$&\n";
          my $rend = $line->r;
          # mark all characters as underlined. we _must_ not toggle underline,
          # as we might get called on an already-marked url.
          &{$matcher->[2]}
-         for @{$rend}[ $-[0] .. $+[0] - 1];
+            for @{$rend}[$-[0] .. $+[0] - 1];
          $line->r ($rend);
       }
    }
 sub find_matches {
    my ($self, $row, $col) = @_;
    my $line = $self->line ($row);
    my $text = $line->t;
+   my $off = $line->offset_of ($row, $col) if defined $col;
    my @matches;
    for my $matcher (@{$self->{matchers}}) {
       my $launcher = $matcher->[1] || $self->{launcher};
       while ($text =~ /$matcher->[0]/g) {
          my $match = substr $text, $-[0], $+[0] - $-[0];
          my @begin = @-;
          my @end = @+;
          my @exec;
-         if (!defined($col) || ($-[0] <= $col && $+[0] >= $col)) {
+         if (!defined($off) || ($-[0] <= $off && $+[0] >= $off)) {
             if ($launcher !~ /\$/) {
                @exec = ($launcher, $match);
             } else {
                # It'd be nice to just access a list like ($&,$1,$2...),
                # but alas, m//g behaves differently in list context.
                @exec = map { s/\$(\d+)|\$\{(\d+)\}/
                   substr $text, $begin[$1 || $2], $end[$1 || $2] - $begin[$1 || $2]
                   /egx; $_ } split /\s+/, $launcher;
             }
-            push @matches, [ $begin[0], $match, @exec ];
+            push @matches, [ $line->coord_of ($begin[0]), $line->coord_of ($end[0]), $match, @exec ];
          }
       }
    }
    @matches;
    my ($self, $row, $col) = @_;
    my @matches = $self->find_matches ($row, $col);
    if (@matches) {
       my @match = @{ $matches[0] };
-      return @match[2 .. $#match];
+      return @match[5 .. $#match];
    }
    ()
 }

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing rxvt-unicode/src/perl/matcher (file contents): Revision 1.23 by sf-exg, Thu Jun 12 12:19:09 2014 UTC vs. Revision 1.30 by sf-exg, Sat Jun 21 14:11:18 2014 UTC

Diff Legend

Comparing rxvt-unicode/src/perl/matcher (file contents):
Revision 1.23 by sf-exg, Thu Jun 12 12:19:09 2014 UTC vs.
Revision 1.30 by sf-exg, Sat Jun 21 14:11:18 2014 UTC