--- rxvt-unicode/src/perl/option-popup	2006/01/09 00:34:36	1.7
+++ rxvt-unicode/src/perl/option-popup	2012/09/04 22:41:12	1.14
@@ -1,9 +1,39 @@
 #! perl
 
+=head1 NAME
+
+option-popup - option menu (enabled by default)
+
+=head1 DESCRIPTION
+
+Binds a popup menu to Ctrl-Button2 that lets you toggle (some) options at
+runtime.
+
+Other extensions can extend this popup menu by pushing a code reference
+onto C<< @{ $term->{option_popup_hook} } >>, which gets called whenever
+the popup is being displayed.
+
+Its sole argument is the popup menu, which can be modified.  It should
+either return nothing or a string, the initial boolean value and a code
+reference. The string will be used as button text and the code reference
+will be called when the toggle changes, with the new boolean value as
+first argument.
+
+The following will add an entry C<myoption> that changes
+C<< $self->{myoption} >>:
+
+   push @{ $self->{term}{option_popup_hook} }, sub {
+      ("my option" => $myoption, sub { $self->{myoption} = $_[0] })
+   };
+
+=cut
+
 sub on_start {
    my ($self) = @_;
 
    $self->grab_button (2, urxvt::ControlMask);
+
+   ()
 }
 
 sub on_button_press {
@@ -19,15 +49,29 @@
       my %unsafe = map +($_ => 1),
          qw(borderLess console iconic loginShell reverseVideo
             scrollBar scrollBar_floating scrollBar_right
-            secondaryScreen transparent utmpInhibit meta8);
+            secondaryScreen transparent utmpInhibit meta8
+            override_redirect);
 
       for my $name (sort keys %urxvt::OPTION) {
          next if $unsafe{$name};
 
          my $optval = $urxvt::OPTION{$name};
 
-         $popup->add_toggle ($name => sub { $self->option ($optval, $_[0]) },
-                             $self->option ($optval));
+         $popup->add_toggle ($name => $self->option ($optval),
+                             sub { $self->option ($optval, $_[0]) });
+      }
+
+      for my $hook (@{ $self->{term}{option_popup_hook} || [] }) {
+         if (my ($name, $value, $cb) = $hook->($popup)) {
+            $popup->add_toggle ($name => $value, sub { $cb->($_[0]) });
+         }
+      }
+
+      {
+         $popup->add_separator;
+         my $locale = $self->locale;
+         $locale =~ y/\x20-\x7e//cd;
+         $popup->add_title ("Locale: $locale");
       }
 
       $popup->show;