[ViewVC] Diff of: cvs/rxvt-unicode/src/rxvttoolkit.C

Comparing rxvt-unicode/src/rxvttoolkit.C (file contents):
Revision 1.58 by root, Wed Jul 5 19:22:15 2006 UTC vs.
Revision 1.102 by root, Tue Nov 4 11:03:29 2008 UTC

 /*----------------------------------------------------------------------*
  * File:	rxvttoolkit.C
  *----------------------------------------------------------------------*
  *
  * All portions of code are copyright by their respective author/s.
- * Copyright (c) 2003-2006 Marc Lehmann <pcg@goof.com>
+ * Copyright (c) 2003-2007 Marc Lehmann <pcg@goof.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 2 of the License, or
  * (at your option) any later version.
 #if ENABLE_EWMH
   "_NET_WM_PID",
   "_NET_WM_NAME",
   "_NET_WM_ICON_NAME",
   "_NET_WM_PING",
+  "_NET_WM_ICON",
 #endif
 #if USE_XIM
   "WM_LOCALE_NAME",
   "XIM_SERVERS",
 #endif
-#ifdef TRANSPARENT
+#ifdef ENABLE_TRANSPARENCY
   "_XROOTPMAP_ID",
   "ESETROOT_PMAP_ID",
 #endif
 #if ENABLE_XEMBED
   "_XEMBED",
   XIMCallback ximcallback;
   ximcallback.client_data = (XPointer)this;
   ximcallback.callback = im_destroy_cb;
-  XSetIMValues (xim, XNDestroyCallback, &ximcallback, 0);
+  XSetIMValues (xim, XNDestroyCallback, &ximcallback, (char *)0);
   return true;
 }
 rxvt_xim::~rxvt_xim ()
   visual  = DefaultVisualOfScreen   (screen);
   cmap    = DefaultColormapOfScreen (screen);
 }
 void
-rxvt_screen::set (rxvt_display *disp, int bitdepth)
+rxvt_screen::select_visual (int bitdepth)
 {
-  set (disp);
 #if XFT
   XVisualInfo vinfo;
   if (XMatchVisualInfo (dpy, display->screen, bitdepth, TrueColor, &vinfo))
     {
       depth  = bitdepth;
       visual = vinfo.visual;
-      cmap   = XCreateColormap (dpy, disp->root, visual, AllocNone);
+      cmap   = XCreateColormap (dpy, display->root, visual, AllocNone);
     }
 #endif
 }
 void
 /////////////////////////////////////////////////////////////////////////////
 rxvt_display::rxvt_display (const char *id)
 : refcounted (id)
-, x_ev (this, &rxvt_display::x_cb)
 , selection_owner (0)
 {
+  x_ev    .set<rxvt_display, &rxvt_display::x_cb    > (this);
+  flush_ev.set<rxvt_display, &rxvt_display::flush_cb> (this);
 }
 XrmDatabase
 rxvt_display::get_resources (bool refresh)
 {
-  char *homedir = (char *)getenv ("HOME");
+  char *homedir = getenv ("HOME");
   char fname[1024];
   /*
    * get resources using the X library function
    */
   char *displayResource, *xe;
   XrmDatabase rdb1, database = 0;
   // for ordering, see for example http://www.faqs.org/faqs/Xt-FAQ/ Subject: 20
+  // as opposed to "standard practise", we always read in ~/.Xdefaults
   // 6. System wide per application default file.
   /* Add in $XAPPLRESDIR/Rxvt only; not bothering with XUSERFILESEARCHPATH */
-  if ((xe = (char *)getenv ("XAPPLRESDIR")))
+  if ((xe = getenv ("XAPPLRESDIR")))
     {
       snprintf (fname, sizeof (fname), "%s/%s", xe, RESCLASS);
       if ((rdb1 = XrmGetFileDatabase (fname)))
         XrmMergeDatabases (rdb1, &database);
   // 5. User's per application default file.
   // none
   // 4. User's defaults file.
+  if (homedir)
+    {
+      snprintf (fname, sizeof (fname), "%s/.Xdefaults", homedir);
+      if ((rdb1 = XrmGetFileDatabase (fname)))
+        XrmMergeDatabases (rdb1, &database);
+    }
   /* Get any Xserver defaults */
   if (refresh)
     {
       // fucking xlib keeps a copy of the rm string
       Atom actual_type;
           && actual_format == 8)
          displayResource = val;
        else
          {
            displayResource = 0;
            if (val)
              XFree(val);
          }
 #if XLIB_ILLEGAL_ACCESS
   if (displayResource)
     {
       if ((rdb1 = XrmGetStringDatabase (displayResource)))
         XrmMergeDatabases (rdb1, &database);
     }
-  else if (homedir)
-    {
-      snprintf (fname, sizeof (fname), "%s/.Xdefaults", homedir);
-      if ((rdb1 = XrmGetFileDatabase (fname)))
-        XrmMergeDatabases (rdb1, &database);
-    }
 #if !XLIB_ILLEGAL_ACCESS
   if (refresh && displayResource)
     XFree (displayResource);
 #endif
       XFree (displayResource);
     }
   // 3. User's per host defaults file
   /* Add in XENVIRONMENT file */
-  if ((xe = (char *)getenv ("XENVIRONMENT"))
+  if ((xe = getenv ("XENVIRONMENT"))
       && (rdb1 = XrmGetFileDatabase (xe)))
     XrmMergeDatabases (rdb1, &database);
   else if (homedir)
     {
       struct utsname un;
 #endif
   int fd = XConnectionNumber (dpy);
   // try to detect wether we have a local connection.
-  // assume unix domains socket == local, everything else not
+  // assume unix domain socket == local, everything else not
   // TODO: might want to check for inet/127.0.0.1
   is_local = 0;
   sockaddr_un sa;
   socklen_t sl = sizeof (sa);
   if (!getsockname (fd, (sockaddr *)&sa, &sl))
-    is_local = sa.sun_family == AF_LOCAL;
+    is_local = sa.sun_family == AF_UNIX;
+  flush_ev.start ();
-  x_ev.start (fd, EVENT_READ);
+  x_ev.start (fd, ev::READ);
   fcntl (fd, F_SETFD, FD_CLOEXEC);
   XSelectInput (dpy, root, PropertyChangeMask);
   flush ();
 #ifdef POINTER_BLANK
   XFreeCursor (dpy, blank_cursor);
 #endif
   x_ev.stop ();
+  flush_ev.stop ();
 #ifdef USE_XIM
   xims.clear ();
 #endif
   XCloseDisplay (dpy);
 }
   XFree (atoms);
 }
 #endif
-void rxvt_display::x_cb (io_watcher &w, short revents)
+void rxvt_display::x_cb (ev::io &w, int revents)
 {
+  flush_ev.start ();
+}
+void rxvt_display::flush_cb (ev::prepare &w, int revents)
+{
+  while (XEventsQueued (dpy, QueuedAfterFlush))
-  do
+    do
-    {
+      {
-      XEvent xev;
+        XEvent xev;
-      XNextEvent (dpy, &xev);
+        XNextEvent (dpy, &xev);
 #ifdef USE_XIM
-      if (!XFilterEvent (&xev, None))
+        if (!XFilterEvent (&xev, None))
-        {
+          {
-          if (xev.type == PropertyNotify
+            if (xev.type == PropertyNotify
-              && xev.xany.window == root
+                && xev.xany.window == root
-              && xev.xproperty.atom == xa[XA_XIM_SERVERS])
+                && xev.xproperty.atom == xa[XA_XIM_SERVERS])
-            im_change_check ();
+              im_change_check ();
 #endif
+            if (xev.type == MappingNotify)
+              XRefreshKeyboardMapping (&xev.xmapping);
-          for (int i = xw.size (); i--; )
+            for (int i = xw.size (); i--; )
-            {
+              {
-              if (!xw[i])
+                if (!xw[i])
-                xw.erase_unordered (i);
+                  xw.erase_unordered (i);
-              else if (xw[i]->window == xev.xany.window)
+                else if (xw[i]->window == xev.xany.window)
-                xw[i]->call (xev);
+                  xw[i]->call (xev);
-            }
+              }
 #ifdef USE_XIM
-        }
+          }
 #endif
-    }
+      }
-  while (XEventsQueued (dpy, QueuedAlready));
+    while (XEventsQueued (dpy, QueuedAlready));
-  XFlush (dpy);
+  w.stop ();
-}
-void rxvt_display::flush ()
-{
-  if (XEventsQueued (dpy, QueuedAlready))
-    x_cb (x_ev, EVENT_READ);
-  XFlush (dpy);
 }
 void rxvt_display::reg (xevent_watcher *w)
 {
+  if (!w->active)
+    {
-  xw.push_back (w);
+      xw.push_back (w);
-  w->active = xw.size ();
+      w->active = xw.size ();
+    }
 }
 void rxvt_display::unreg (xevent_watcher *w)
 {
   if (w->active)
+    {
-    xw[w->active - 1] = 0;
+      xw[w->active - 1] = 0;
+      w->active = 0;
+    }
 }
 void rxvt_display::set_selection_owner (rxvt_term *owner)
 {
   if (selection_owner && selection_owner != owner)
+    {
+      rxvt_term *owner = selection_owner;
-    selection_owner->selection_clear ();
+      owner->selection_clear ();
+      owner->flush ();
+    }
   selection_owner = owner;
 }
 #ifdef USE_XIM
 static unsigned int
 insert_component (unsigned int value, unsigned int mask, unsigned int shift)
 {
   return (value * (mask + 1) >> 16) << shift;
 }
 bool
 rxvt_color::alloc (rxvt_screen *screen, const rgba &color)
 {
+  //TODO: only supports 24 bit
+  int alpha = color.a >= 0xff00 ? 0xffff : color.a;
 #if XFT
   XRenderPictFormat *format;
   // FUCKING Xft gets it wrong, of course, so work around it.
   // Transparency users should eat shit and die, and then
     {
       // the fun lies in doing everything manually...
       c.color.red   = color.r;
       c.color.green = color.g;
       c.color.blue  = color.b;
-      c.color.alpha = color.a;
+      c.color.alpha = alpha;
       c.pixel = insert_component (color.r, format->direct.redMask  , format->direct.red  )
               | insert_component (color.g, format->direct.greenMask, format->direct.green)
               | insert_component (color.b, format->direct.blueMask , format->direct.blue )
-              | insert_component (color.a, format->direct.alphaMask, format->direct.alpha);
+              | insert_component (alpha  , format->direct.alphaMask, format->direct.alpha);
       return true;
     }
   else
     {
       XRenderColor d;
       d.red   = color.r;
       d.green = color.g;
       d.blue  = color.b;
-      d.alpha = color.a;
+      d.alpha = alpha;
       return XftColorAllocValue (screen->dpy, screen->visual, screen->cmap, &d, &c);
     }
 #else
   c.red   = color.r;
   c.green = color.g;
   c.blue  = color.b;
   if (screen->visual->c_class == TrueColor)
     {
-      c.pixel = (color.r * (screen->visual->red_mask   >> ctz (screen->visual->red_mask  ))
+      c.pixel = (color.r >> (16 - popcount (screen->visual->red_mask  )) << ctz (screen->visual->red_mask  ))
-                         / rgba::MAX_CC) << ctz (screen->visual->red_mask  )
+              | (color.g >> (16 - popcount (screen->visual->green_mask)) << ctz (screen->visual->green_mask))
-              | (color.g * (screen->visual->green_mask >> ctz (screen->visual->green_mask))
-                         / rgba::MAX_CC) << ctz (screen->visual->green_mask)
-              | (color.b * (screen->visual->blue_mask  >> ctz (screen->visual->blue_mask ))
+              | (color.b >> (16 - popcount (screen->visual->blue_mask )) << ctz (screen->visual->blue_mask ));
-                         / rgba::MAX_CC) << ctz (screen->visual->blue_mask );
       return true;
     }
   else if (XAllocColor (screen->dpy, screen->cmap, &c))
     return true;
 {
   rgba c;
   char eos;
   int skip;
+  c.a = rgba::MAX_CC;
   // parse the nonstandard "[alphapercent]" prefix
   if (1 <= sscanf (name, "[%hd]%n", &c.a, &skip))
     {
       c.a = lerp<int, int, int> (0, rgba::MAX_CC, c.a);
       name += skip;
     }
-  else
-    c.a = rgba::MAX_CC;
   // parse the non-standard "rgba:rrrr/gggg/bbbb/aaaa" format
   if (strlen (name) != 4+5*4 || 4 != sscanf (name, "rgba:%4hx/%4hx/%4hx/%4hx%c", &c.r, &c.g, &c.b, &c.a, &eos))
     {
-      XColor xc, xc_exact;
+      XColor xc;
       if (XParseColor (screen->dpy, screen->cmap, name, &xc))
         {
           c.r = xc.red;
           c.g = xc.green;
     {
       XColor *colors = new XColor [screen->visual->map_entries];
       for (int i = 0; i < cmap_size; i++)
         colors [i].pixel = i;
       // many kilobytes transfer per colour, but pseudocolor isn't worth
       // many extra optimisations.
       XQueryColors (screen->dpy, screen->cmap, colors, cmap_size);
       int diff = 0x7fffffffUL;
             }
         }
       //rxvt_warn ("could not allocate %04x %04x %04x, getting %04x %04x %04x instead (%d)\n",
       //    color.r, color.g, color.b, best->red, best->green, best->blue, diff);
       got = alloc (screen, rgba (best->red, best->green, best->blue));
-      delete colors;
+      delete [] colors;
     }
 #endif
   return got;
 }
   color.green = c.g;
   color.blue  = c.b;
   color.pixel = (Pixel)*this;
 }
 void
 rxvt_color::free (rxvt_screen *screen)
 {
   if (screen->visual->c_class == TrueColor)
     return; // nothing to do
       lerp (c.a, to.a, percent)
     )
   );
 }
+#if TRACE_PIXMAPS
+# undef XCreatePixmap
+# undef XFreePixmap
+Pixmap trace_XCreatePixmap (const char *file, int line, Display *dpy, Window r, unsigned int w, unsigned int h, unsigned int d)
+{
+  Pixmap res = XCreatePixmap (dpy, r, w, h, d);
+  fprintf (stderr, "%s:%d: XCreatePixmap (%p,%lX,%u,%u,%u) returned %lX\n", file, line, dpy, r, w, h, d, res);
+  return res;
+}
+void trace_XFreePixmap (const char *file, int line, Display *dpy, Pixmap p)
+{
+  fprintf (stderr, "%s:%d: XFreePixmap (%p,%lX)\n", file, line, dpy, p);
+  XFreePixmap (dpy,p);
+}
+#endif

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing rxvt-unicode/src/rxvttoolkit.C (file contents): Revision 1.58 by root, Wed Jul 5 19:22:15 2006 UTC vs. Revision 1.102 by root, Tue Nov 4 11:03:29 2008 UTC

Diff Legend

Comparing rxvt-unicode/src/rxvttoolkit.C (file contents):
Revision 1.58 by root, Wed Jul 5 19:22:15 2006 UTC vs.
Revision 1.102 by root, Tue Nov 4 11:03:29 2008 UTC