ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/rxvt-unicode/src/rxvttoolkit.C
(Generate patch)

Comparing rxvt-unicode/src/rxvttoolkit.C (file contents):
Revision 1.65 by sasha, Fri Jun 8 20:04:12 2007 UTC vs.
Revision 1.111 by sf-exg, Sat Dec 18 18:17:39 2010 UTC

1/*----------------------------------------------------------------------* 1/*----------------------------------------------------------------------*
2 * File: rxvttoolkit.C 2 * File: rxvttoolkit.C
3 *----------------------------------------------------------------------* 3 *----------------------------------------------------------------------*
4 * 4 *
5 * All portions of code are copyright by their respective author/s. 5 * All portions of code are copyright by their respective author/s.
6 * Copyright (c) 2003-2006 Marc Lehmann <pcg@goof.com> 6 * Copyright (c) 2003-2007 Marc Lehmann <pcg@goof.com>
7 * 7 *
8 * This program is free software; you can redistribute it and/or modify 8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by 9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or 10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version. 11 * (at your option) any later version.
33 33
34#if XFT 34#if XFT
35# include <X11/extensions/Xrender.h> 35# include <X11/extensions/Xrender.h>
36#endif 36#endif
37 37
38const char *const xa_names[] = 38static const char *const xa_names[] =
39{ 39{
40 "TEXT", 40 "TEXT",
41 "COMPOUND_TEXT", 41 "COMPOUND_TEXT",
42 "UTF8_STRING", 42 "UTF8_STRING",
43 "MULTIPLE", 43 "MULTIPLE",
59#if ENABLE_EWMH 59#if ENABLE_EWMH
60 "_NET_WM_PID", 60 "_NET_WM_PID",
61 "_NET_WM_NAME", 61 "_NET_WM_NAME",
62 "_NET_WM_ICON_NAME", 62 "_NET_WM_ICON_NAME",
63 "_NET_WM_PING", 63 "_NET_WM_PING",
64 "_NET_WM_ICON",
64#endif 65#endif
65#if USE_XIM 66#if USE_XIM
66 "WM_LOCALE_NAME", 67 "WM_LOCALE_NAME",
67 "XIM_SERVERS", 68 "XIM_SERVERS",
68#endif 69#endif
69#ifdef TRANSPARENT 70#ifdef ENABLE_TRANSPARENCY
70 "_XROOTPMAP_ID", 71 "_XROOTPMAP_ID",
71 "ESETROOT_PMAP_ID", 72 "ESETROOT_PMAP_ID",
72#endif 73#endif
73#if ENABLE_XEMBED 74#if ENABLE_XEMBED
74 "_XEMBED", 75 "_XEMBED",
183 184
184 XIMCallback ximcallback; 185 XIMCallback ximcallback;
185 ximcallback.client_data = (XPointer)this; 186 ximcallback.client_data = (XPointer)this;
186 ximcallback.callback = im_destroy_cb; 187 ximcallback.callback = im_destroy_cb;
187 188
188 XSetIMValues (xim, XNDestroyCallback, &ximcallback, 0); 189 XSetIMValues (xim, XNDestroyCallback, &ximcallback, (char *)0);
189 190
190 return true; 191 return true;
191} 192}
192 193
193rxvt_xim::~rxvt_xim () 194rxvt_xim::~rxvt_xim ()
295 296
296///////////////////////////////////////////////////////////////////////////// 297/////////////////////////////////////////////////////////////////////////////
297 298
298rxvt_display::rxvt_display (const char *id) 299rxvt_display::rxvt_display (const char *id)
299: refcounted (id) 300: refcounted (id)
300, x_ev (this, &rxvt_display::x_cb)
301, selection_owner (0) 301, selection_owner (0)
302, clipboard_owner (0)
302{ 303{
304 x_ev .set<rxvt_display, &rxvt_display::x_cb > (this);
305 flush_ev.set<rxvt_display, &rxvt_display::flush_cb> (this);
303} 306}
304 307
305XrmDatabase 308XrmDatabase
306rxvt_display::get_resources (bool refresh) 309rxvt_display::get_resources (bool refresh)
307{ 310{
308 char *homedir = (char *)getenv ("HOME"); 311 char *homedir = getenv ("HOME");
309 char fname[1024]; 312 char fname[1024];
310 313
311 /* 314 /*
312 * get resources using the X library function 315 * get resources using the X library function
313 */ 316 */
318 // as opposed to "standard practise", we always read in ~/.Xdefaults 321 // as opposed to "standard practise", we always read in ~/.Xdefaults
319 322
320 // 6. System wide per application default file. 323 // 6. System wide per application default file.
321 324
322 /* Add in $XAPPLRESDIR/Rxvt only; not bothering with XUSERFILESEARCHPATH */ 325 /* Add in $XAPPLRESDIR/Rxvt only; not bothering with XUSERFILESEARCHPATH */
323 if ((xe = (char *)getenv ("XAPPLRESDIR"))) 326 if ((xe = getenv ("XAPPLRESDIR")))
324 { 327 {
325 snprintf (fname, sizeof (fname), "%s/%s", xe, RESCLASS); 328 snprintf (fname, sizeof (fname), "%s/%s", xe, RESCLASS);
326 329
327 if ((rdb1 = XrmGetFileDatabase (fname))) 330 if ((rdb1 = XrmGetFileDatabase (fname)))
328 XrmMergeDatabases (rdb1, &database); 331 XrmMergeDatabases (rdb1, &database);
359 XA_STRING, &actual_type, &actual_format, 362 XA_STRING, &actual_type, &actual_format,
360 &nitems, &nremaining, 363 &nitems, &nremaining,
361 (unsigned char **)&val) == Success 364 (unsigned char **)&val) == Success
362 && actual_type == XA_STRING 365 && actual_type == XA_STRING
363 && actual_format == 8) 366 && actual_format == 8)
364 displayResource = val; 367 displayResource = val;
365 else 368 else
366 { 369 {
367 displayResource = 0; 370 displayResource = 0;
368 371
369 if (val) 372 if (val)
370 XFree(val); 373 XFree (val);
371 } 374 }
372 375
373#if XLIB_ILLEGAL_ACCESS 376#if XLIB_ILLEGAL_ACCESS
374 dpy->xdefaults = displayResource; 377 dpy->xdefaults = displayResource;
375#endif 378#endif
376 } 379 }
400 XFree (displayResource); 403 XFree (displayResource);
401 } 404 }
402 405
403 // 3. User's per host defaults file 406 // 3. User's per host defaults file
404 /* Add in XENVIRONMENT file */ 407 /* Add in XENVIRONMENT file */
405 if ((xe = (char *)getenv ("XENVIRONMENT")) 408 if ((xe = getenv ("XENVIRONMENT"))
406 && (rdb1 = XrmGetFileDatabase (xe))) 409 && (rdb1 = XrmGetFileDatabase (xe)))
407 XrmMergeDatabases (rdb1, &database); 410 XrmMergeDatabases (rdb1, &database);
408 else if (homedir) 411 else if (homedir)
409 { 412 {
410 struct utsname un; 413 struct utsname un;
424bool rxvt_display::ref_init () 427bool rxvt_display::ref_init ()
425{ 428{
426#ifdef LOCAL_X_IS_UNIX 429#ifdef LOCAL_X_IS_UNIX
427 if (id[0] == ':') 430 if (id[0] == ':')
428 { 431 {
429 val = rxvt_malloc (5 + strlen (id) + 1); 432 if (!(val = rxvt_temp_buf<char> (5 + strlen (id) + 1)))
433 return false;
430 strcpy (val, "unix/"); 434 strcpy (val, "unix/");
431 strcat (val, id); 435 strcat (val, id);
432 dpy = XOpenDisplay (val); 436 dpy = XOpenDisplay (val);
433 free (val);
434 } 437 }
435 else 438 else
436#endif 439#endif
437 dpy = 0; 440 dpy = 0;
438 441
443 return false; 446 return false;
444 447
445 screen = DefaultScreen (dpy); 448 screen = DefaultScreen (dpy);
446 root = DefaultRootWindow (dpy); 449 root = DefaultRootWindow (dpy);
447 450
448#ifdef HAVE_AFTERIMAGE 451 assert (ARRAY_LENGTH(xa_names) == NUM_XA);
449 ::dpy = dpy; /* init global var from libAfter... */
450 asv = create_asvisual_for_id( dpy, screen, DefaultDepth(dpy,screen), XVisualIDFromVisual(DefaultVisual(dpy,screen)), None, NULL );
451#endif
452
453 assert (sizeof (xa_names) / sizeof (char *) == NUM_XA);
454 XInternAtoms (dpy, (char **)xa_names, NUM_XA, False, xa); 452 XInternAtoms (dpy, (char **)xa_names, NUM_XA, False, xa);
455 453
456 XrmSetDatabase (dpy, get_resources (false)); 454 XrmSetDatabase (dpy, get_resources (false));
457 455
458#ifdef POINTER_BLANK 456#ifdef POINTER_BLANK
466 XUnloadFont (dpy, f); 464 XUnloadFont (dpy, f);
467#endif 465#endif
468 466
469 int fd = XConnectionNumber (dpy); 467 int fd = XConnectionNumber (dpy);
470 468
471 // try to detect wether we have a local connection. 469 // try to detect whether we have a local connection.
472 // assume unix domains socket == local, everything else not 470 // assume unix domain socket == local, everything else not
473 // TODO: might want to check for inet/127.0.0.1 471 // TODO: might want to check for inet/127.0.0.1
474 is_local = 0; 472 is_local = 0;
475 sockaddr_un sa; 473 sockaddr_un sa;
476 socklen_t sl = sizeof (sa); 474 socklen_t sl = sizeof (sa);
477 475
478 if (!getsockname (fd, (sockaddr *)&sa, &sl)) 476 if (!getsockname (fd, (sockaddr *)&sa, &sl))
479 is_local = sa.sun_family == AF_LOCAL; 477 is_local = sa.sun_family == AF_UNIX;
480 478
479 flush_ev.start ();
481 x_ev.start (fd, EVENT_READ); 480 x_ev.start (fd, ev::READ);
482 fcntl (fd, F_SETFD, FD_CLOEXEC); 481 fcntl (fd, F_SETFD, FD_CLOEXEC);
483 482
484 XSelectInput (dpy, root, PropertyChangeMask); 483 XSelectInput (dpy, root, PropertyChangeMask);
485 484
486 flush (); 485 flush ();
489} 488}
490 489
491void 490void
492rxvt_display::ref_next () 491rxvt_display::ref_next ()
493{ 492{
494 // TODO: somehow check wether the database files/resources changed 493 // TODO: somehow check whether the database files/resources changed
495 // before affording re-loading/parsing 494 // before affording re-loading/parsing
496 XrmDestroyDatabase (XrmGetDatabase (dpy)); 495 XrmDestroyDatabase (XrmGetDatabase (dpy));
497 XrmSetDatabase (dpy, get_resources (true)); 496 XrmSetDatabase (dpy, get_resources (true));
498} 497}
499 498
504 503
505#ifdef POINTER_BLANK 504#ifdef POINTER_BLANK
506 XFreeCursor (dpy, blank_cursor); 505 XFreeCursor (dpy, blank_cursor);
507#endif 506#endif
508 x_ev.stop (); 507 x_ev.stop ();
508 flush_ev.stop ();
509#ifdef USE_XIM 509#ifdef USE_XIM
510 xims.clear (); 510 xims.clear ();
511#endif 511#endif
512 XCloseDisplay (dpy); 512 XCloseDisplay (dpy);
513} 513}
528 unsigned long nitems, bytes_after; 528 unsigned long nitems, bytes_after;
529 529
530 if (XGetWindowProperty (dpy, root, xa[XA_XIM_SERVERS], 0L, 1000000L, 530 if (XGetWindowProperty (dpy, root, xa[XA_XIM_SERVERS], 0L, 1000000L,
531 False, XA_ATOM, &actual_type, &actual_format, 531 False, XA_ATOM, &actual_type, &actual_format,
532 &nitems, &bytes_after, (unsigned char **)&atoms) 532 &nitems, &bytes_after, (unsigned char **)&atoms)
533 != Success ) 533 != Success)
534 return; 534 return;
535 535
536 if (actual_type == XA_ATOM && actual_format == 32) 536 if (actual_type == XA_ATOM && actual_format == 32)
537 for (int i = 0; i < nitems; i++) 537 for (int i = 0; i < nitems; i++)
538 if (XGetSelectionOwner (dpy, atoms[i])) 538 if (XGetSelectionOwner (dpy, atoms[i]))
539 { 539 {
540 im_change_cb (); 540 im_change_cb ();
541 break; 541 break;
543 543
544 XFree (atoms); 544 XFree (atoms);
545} 545}
546#endif 546#endif
547 547
548void rxvt_display::x_cb (io_watcher &w, short revents) 548void rxvt_display::x_cb (ev::io &w, int revents)
549{ 549{
550 flush_ev.start ();
551}
552
553void rxvt_display::flush_cb (ev::prepare &w, int revents)
554{
555 while (XEventsQueued (dpy, QueuedAfterFlush))
550 do 556 do
551 { 557 {
552 XEvent xev; 558 XEvent xev;
553 XNextEvent (dpy, &xev); 559 XNextEvent (dpy, &xev);
554 560
555#ifdef USE_XIM 561#ifdef USE_XIM
556 if (!XFilterEvent (&xev, None)) 562 if (!XFilterEvent (&xev, None))
557 { 563 {
558 if (xev.type == PropertyNotify 564 if (xev.type == PropertyNotify
559 && xev.xany.window == root 565 && xev.xany.window == root
560 && xev.xproperty.atom == xa[XA_XIM_SERVERS]) 566 && xev.xproperty.atom == xa[XA_XIM_SERVERS])
561 im_change_check (); 567 im_change_check ();
562#endif 568#endif
569 if (xev.type == MappingNotify)
570 XRefreshKeyboardMapping (&xev.xmapping);
571
563 for (int i = xw.size (); i--; ) 572 for (int i = xw.size (); i--; )
564 { 573 {
565 if (!xw[i]) 574 if (!xw[i])
566 xw.erase_unordered (i); 575 xw.erase_unordered (i);
567 else if (xw[i]->window == xev.xany.window) 576 else if (xw[i]->window == xev.xany.window)
568 xw[i]->call (xev); 577 xw[i]->call (xev);
569 } 578 }
570#ifdef USE_XIM 579#ifdef USE_XIM
571 } 580 }
572#endif 581#endif
573 } 582 }
574 while (XEventsQueued (dpy, QueuedAlready)); 583 while (XEventsQueued (dpy, QueuedAlready));
575 584
576 XFlush (dpy); 585 w.stop ();
577}
578
579void rxvt_display::flush ()
580{
581 if (XEventsQueued (dpy, QueuedAlready))
582 x_cb (x_ev, EVENT_READ);
583
584 XFlush (dpy);
585} 586}
586 587
587void rxvt_display::reg (xevent_watcher *w) 588void rxvt_display::reg (xevent_watcher *w)
588{ 589{
589 if (!w->active) 590 if (!w->active)
600 xw[w->active - 1] = 0; 601 xw[w->active - 1] = 0;
601 w->active = 0; 602 w->active = 0;
602 } 603 }
603} 604}
604 605
605void rxvt_display::set_selection_owner (rxvt_term *owner) 606void rxvt_display::set_selection_owner (rxvt_term *owner, bool clipboard)
606{ 607{
608 rxvt_term * &cur_owner = !clipboard ? selection_owner : clipboard_owner;
609
607 if (selection_owner && selection_owner != owner) 610 if (cur_owner && cur_owner != owner)
608 selection_owner->selection_clear (); 611 {
612 rxvt_term *term = cur_owner;
613 term->selection_clear (clipboard);
614 term->flush ();
615 }
609 616
610 selection_owner = owner; 617 cur_owner = owner;
611} 618}
612 619
613#ifdef USE_XIM 620#ifdef USE_XIM
614 621
615void rxvt_display::reg (im_watcher *w) 622void rxvt_display::reg (im_watcher *w)
628 int l, m; 635 int l, m;
629 636
630 l = strlen (locale); 637 l = strlen (locale);
631 m = strlen (modifiers); 638 m = strlen (modifiers);
632 639
633 if (!(id = (char *)malloc (l + m + 2))) 640 if (!(id = rxvt_temp_buf<char> (l + m + 2)))
634 return 0; 641 return 0;
635 642
636 memcpy (id, locale, l); id[l] = '\n'; 643 memcpy (id, locale, l); id[l] = '\n';
637 memcpy (id + l + 1, modifiers, m); id[l + m + 1] = 0; 644 memcpy (id + l + 1, modifiers, m); id[l + m + 1] = 0;
638 645
639 rxvt_xim *xim = xims.get (id); 646 rxvt_xim *xim = xims.get (id);
640
641 free (id);
642 647
643 return xim; 648 return xim;
644} 649}
645 650
646void rxvt_display::put_xim (rxvt_xim *xim) 651void rxvt_display::put_xim (rxvt_xim *xim)
668static unsigned int 673static unsigned int
669insert_component (unsigned int value, unsigned int mask, unsigned int shift) 674insert_component (unsigned int value, unsigned int mask, unsigned int shift)
670{ 675{
671 return (value * (mask + 1) >> 16) << shift; 676 return (value * (mask + 1) >> 16) << shift;
672} 677}
673 678
674bool 679bool
675rxvt_color::alloc (rxvt_screen *screen, const rgba &color) 680rxvt_color::alloc (rxvt_screen *screen, const rgba &color)
676{ 681{
682 //TODO: only supports 24 bit
683 int alpha = color.a >= 0xff00 ? 0xffff : color.a;
684
677#if XFT 685#if XFT
678 XRenderPictFormat *format; 686 XRenderPictFormat *format;
679 687
680 // FUCKING Xft gets it wrong, of course, so work around it. 688 // FUCKING Xft gets it wrong, of course, so work around it.
681 // Transparency users should eat shit and die, and then 689 // Transparency users should eat shit and die, and then
685 { 693 {
686 // the fun lies in doing everything manually... 694 // the fun lies in doing everything manually...
687 c.color.red = color.r; 695 c.color.red = color.r;
688 c.color.green = color.g; 696 c.color.green = color.g;
689 c.color.blue = color.b; 697 c.color.blue = color.b;
690 c.color.alpha = color.a; 698 c.color.alpha = alpha;
691 699
692 c.pixel = insert_component (color.r, format->direct.redMask , format->direct.red ) 700 c.pixel = insert_component (color.r, format->direct.redMask , format->direct.red )
693 | insert_component (color.g, format->direct.greenMask, format->direct.green) 701 | insert_component (color.g, format->direct.greenMask, format->direct.green)
694 | insert_component (color.b, format->direct.blueMask , format->direct.blue ) 702 | insert_component (color.b, format->direct.blueMask , format->direct.blue )
695 | insert_component (color.a, format->direct.alphaMask, format->direct.alpha); 703 | insert_component (alpha , format->direct.alphaMask, format->direct.alpha);
696 704
697 return true; 705 return true;
698 } 706 }
699 else 707 else
700 { 708 {
701 XRenderColor d; 709 XRenderColor d;
702 710
703 d.red = color.r; 711 d.red = color.r;
704 d.green = color.g; 712 d.green = color.g;
705 d.blue = color.b; 713 d.blue = color.b;
706 d.alpha = color.a; 714 d.alpha = alpha;
707 715
708 return XftColorAllocValue (screen->dpy, screen->visual, screen->cmap, &d, &c); 716 return XftColorAllocValue (screen->dpy, screen->visual, screen->cmap, &d, &c);
709 } 717 }
710#else 718#else
711 c.red = color.r; 719 c.red = color.r;
712 c.green = color.g; 720 c.green = color.g;
713 c.blue = color.b; 721 c.blue = color.b;
714 722
715 if (screen->visual->c_class == TrueColor) 723 if (screen->visual->c_class == TrueColor)
716 { 724 {
717 c.pixel = (color.r >> (16 - popcount (screen->visual->red_mask )) << ctz (screen->visual->red_mask )) 725 c.pixel = (color.r >> (16 - rxvt_popcount (screen->visual->red_mask )) << rxvt_ctz (screen->visual->red_mask ))
718 | (color.g >> (16 - popcount (screen->visual->green_mask)) << ctz (screen->visual->green_mask)) 726 | (color.g >> (16 - rxvt_popcount (screen->visual->green_mask)) << rxvt_ctz (screen->visual->green_mask))
719 | (color.b >> (16 - popcount (screen->visual->blue_mask )) << ctz (screen->visual->blue_mask )); 727 | (color.b >> (16 - rxvt_popcount (screen->visual->blue_mask )) << rxvt_ctz (screen->visual->blue_mask ));
720 728
721 return true; 729 return true;
722 } 730 }
723 else if (XAllocColor (screen->dpy, screen->cmap, &c)) 731 else if (XAllocColor (screen->dpy, screen->cmap, &c))
724 return true; 732 return true;
736{ 744{
737 rgba c; 745 rgba c;
738 char eos; 746 char eos;
739 int skip; 747 int skip;
740 748
749 c.a = rgba::MAX_CC;
750
741 // parse the nonstandard "[alphapercent]" prefix 751 // parse the nonstandard "[alphapercent]" prefix
742 if (1 <= sscanf (name, "[%hd]%n", &c.a, &skip)) 752 if (1 <= sscanf (name, "[%hd]%n", &c.a, &skip))
743 { 753 {
744 c.a = lerp<int, int, int> (0, rgba::MAX_CC, c.a); 754 c.a = lerp<int, int, int> (0, rgba::MAX_CC, c.a);
745 name += skip; 755 name += skip;
746 } 756 }
747 else
748 c.a = rgba::MAX_CC;
749 757
750 // parse the non-standard "rgba:rrrr/gggg/bbbb/aaaa" format 758 // parse the non-standard "rgba:rrrr/gggg/bbbb/aaaa" format
751 if (strlen (name) != 4+5*4 || 4 != sscanf (name, "rgba:%4hx/%4hx/%4hx/%4hx%c", &c.r, &c.g, &c.b, &c.a, &eos)) 759 if (strlen (name) != 4+5*4 || 4 != sscanf (name, "rgba:%4hx/%4hx/%4hx/%4hx%c", &c.r, &c.g, &c.b, &c.a, &eos))
752 { 760 {
753 XColor xc, xc_exact; 761 XColor xc;
754 762
755 if (XParseColor (screen->dpy, screen->cmap, name, &xc)) 763 if (XParseColor (screen->dpy, screen->cmap, name, &xc))
756 { 764 {
757 c.r = xc.red; 765 c.r = xc.red;
758 c.g = xc.green; 766 c.g = xc.green;
785 { 793 {
786 XColor *colors = new XColor [screen->visual->map_entries]; 794 XColor *colors = new XColor [screen->visual->map_entries];
787 795
788 for (int i = 0; i < cmap_size; i++) 796 for (int i = 0; i < cmap_size; i++)
789 colors [i].pixel = i; 797 colors [i].pixel = i;
790 798
791 // many kilobytes transfer per colour, but pseudocolor isn't worth 799 // many kilobytes transfer per colour, but pseudocolor isn't worth
792 // many extra optimisations. 800 // many extra optimisations.
793 XQueryColors (screen->dpy, screen->cmap, colors, cmap_size); 801 XQueryColors (screen->dpy, screen->cmap, colors, cmap_size);
794 802
795 int diff = 0x7fffffffUL; 803 int diff = 0x7fffffffUL;
808 } 816 }
809 } 817 }
810 818
811 //rxvt_warn ("could not allocate %04x %04x %04x, getting %04x %04x %04x instead (%d)\n", 819 //rxvt_warn ("could not allocate %04x %04x %04x, getting %04x %04x %04x instead (%d)\n",
812 // color.r, color.g, color.b, best->red, best->green, best->blue, diff); 820 // color.r, color.g, color.b, best->red, best->green, best->blue, diff);
813 821
814 got = alloc (screen, rgba (best->red, best->green, best->blue)); 822 got = alloc (screen, rgba (best->red, best->green, best->blue));
815 823
816 delete [] colors; 824 delete [] colors;
817 } 825 }
818#endif 826#endif
846 color.green = c.g; 854 color.green = c.g;
847 color.blue = c.b; 855 color.blue = c.b;
848 color.pixel = (Pixel)*this; 856 color.pixel = (Pixel)*this;
849} 857}
850 858
851void 859void
852rxvt_color::free (rxvt_screen *screen) 860rxvt_color::free (rxvt_screen *screen)
853{ 861{
854 if (screen->visual->c_class == TrueColor) 862 if (screen->visual->c_class == TrueColor)
855 return; // nothing to do 863 return; // nothing to do
856 864

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines