--- rxvt-unicode/src/screen.C 2010/10/14 23:12:11 1.349 +++ rxvt-unicode/src/screen.C 2010/10/15 21:13:44 1.353 @@ -146,6 +146,8 @@ rend_t rend = l.r[col] & ~RS_baseattrMask; rend = SET_FONT (rend, FONTSET (rend)->find_font (' ')); + l.touch (); + // found start, nuke do { l.t[col] = ' '; @@ -900,14 +902,6 @@ # endif #endif - // nuke the character at this position, if required - if (expect_false ( - line->t[screen.cur.col] == NOCHAR - || (screen.cur.col < ncol - 1 - && line->t[screen.cur.col + 1] == NOCHAR) - )) - scr_kill_char (*line, screen.cur.col); - rend_t rend = SET_FONT (rstyle, FONTSET (rstyle)->find_font (c)); // if the character doesn't fit into the remaining columns... @@ -924,6 +918,13 @@ screen.cur.col = ncol - width; } + // nuke the character at this position, if required + // due to wonderful coincidents everywehere else in this loop + // we never have to check for overwriting a wide char itself, + // only it's tail. + if (expect_false (line->t[screen.cur.col] == NOCHAR)) + scr_kill_char (*line, screen.cur.col); + line->touch (); do @@ -938,7 +939,8 @@ line->l = ncol; if (screen.flags & Screen_Autowrap) screen.flags |= Screen_WrapNext; - break; + + goto end_of_line; } c = NOCHAR; @@ -946,16 +948,14 @@ while (expect_false (--width > 0)); // pad with spaces when overwriting wide character with smaller one - if (expect_false (!width)) + for (int c = screen.cur.col; expect_false (c < ncol && line->t[c] == NOCHAR); c++) { - line->touch (); - - for (int c = screen.cur.col; c < ncol && line->t[c] == NOCHAR; c++) - { - line->t[c] = ' '; - line->r[c] = rend; - } + line->t[c] = ' '; + line->r[c] = rend; } + +end_of_line: + ; } #if ENABLE_COMBINING else // width == 0 @@ -1028,10 +1028,8 @@ #endif } } -#ifdef TERMCAP_HAS_BW else if (screen.flags & Screen_WrapNext) screen.flags &= ~Screen_WrapNext; -#endif else scr_gotorc (0, -1, RELATIVE); }