[ViewVC] Diff of: cvs/rxvt-unicode/src/screen.C

Comparing rxvt-unicode/src/screen.C (file contents):
Revision 1.438 by sf-exg, Mon Mar 25 15:41:07 2013 UTC vs.
Revision 1.450 by mikachu, Sat Dec 6 09:20:13 2014 UTC

  * Copyright (c) 1997-2001 Geoff Wing <gcw@pobox.com>
  * Copyright (c) 2003-2007 Marc Lehmann <schmorp@schmorp.de>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
       // finally move the view window, if desired
       if (option (Opt_scrollWithBuffer)
           && view_start != 0
           && view_start != -saveLines)
-        scr_page (UP, count);
+        scr_page (count);
       if (SHOULD_INVOKE (HOOK_SCROLL_BACK))
         HOOK_INVOKE ((this, HOOK_SCROLL_BACK, DT_INT, count, DT_INT, top_row, DT_END));
     }
   else
  * direction should be UP or DN
  */
 void
 rxvt_term::scr_index (enum page_dirn direction) NOTHROW
 {
-  int dirn;
   want_refresh = 1;
   ZERO_SCROLLBACK ();
-  dirn = ((direction == UP) ? 1 : -1);
   screen.flags &= ~Screen_WrapNext;
   if ((screen.cur.row == screen.bscroll && direction == UP)
       || (screen.cur.row == screen.tscroll && direction == DN))
-    scr_scroll_text (screen.tscroll, screen.bscroll, dirn);
+    scr_scroll_text (screen.tscroll, screen.bscroll, direction);
   else
-    screen.cur.row += dirn;
+    screen.cur.row += direction;
   clamp_it (screen.cur.row, 0, nrow - 1);
   selection_check (0);
 }
  * the top of the screen
  */
 void
 rxvt_term::scr_move_to (int y, int len) NOTHROW
 {
-  scr_changeview ((top_row - nrow) * (len - y) / len + (nrow - 1));
+  // lerp (y, 0, len, top_row, nrow - 1)
+  scr_changeview (top_row + (nrow - 1 - top_row) * y / len);
 }
 /* ------------------------------------------------------------------------- */
 /*
  * Page the screen up/down nlines
  * direction should be UP or DN
  */
 bool
-rxvt_term::scr_page (enum page_dirn direction, int nlines) NOTHROW
+rxvt_term::scr_page (int nlines) NOTHROW
 {
-  int new_view_start =
-    direction == UP ? view_start - nlines
-                    : view_start + nlines;
-  return scr_changeview (new_view_start);
+  return scr_changeview (view_start - nlines);
 }
 bool
 rxvt_term::scr_changeview (int new_view_start) NOTHROW
 {
   /*
    * C: set the cursor character (s)
    */
   {
-    bool setoldcursor;
 #ifdef CURSOR_BLINK
     if (hidden_cursor)
       showcursor = 0;
 #endif
           ccol2 = bgcolor_of (rstyle);
 #else
           ccol2 = Color_bg;
 #endif
-        if (focus)
+        if (focus && cursor_type != 2)
           {
             rend_t rend = cur_rend;
-            if (option (Opt_cursorUnderline))
+            if (cursor_type == 1)
               rend ^= RS_Uline;
             else
               {
                 rend ^= RS_RVid;
                 rend = SET_FGCOLOR (rend, ccol1);
             scr_set_char_rend (ROW(screen.cur.row), cur_col, rend);
           }
       }
     /* make sure no outline cursor is left around */
-    setoldcursor = 0;
     if (ocrow != -1)
       {
         if (screen.cur.row - view_start != ocrow
-            || screen.cur.col != oldcursor.col)
+            || screen.cur.col != oldcursor.col || !showcursor)
           {
             if (ocrow < nrow
                 && oldcursor.col < ncol)
               drawn_buf[ocrow].r[oldcursor.col] ^= (RS_RVid | RS_Uline);
-            if (focus || !showcursor)
-              oldcursor.row = -1;
-            else
-              setoldcursor = 1;
           }
       }
-    else if (!focus)
-      setoldcursor = 1;
-    if (setoldcursor)
+    // save the current cursor coordinates if the cursor is visible
+    // and either the window is unfocused or the cursor style is
+    // vertical bar, so as to clear the outline cursor in the next
+    // refresh if the cursor moves or becomes invisible
+    if (showcursor && (!focus || cursor_type == 2) && screen.cur.row - view_start < nrow)
       {
-        if (screen.cur.row - view_start >= nrow)
-          oldcursor.row = -1;
-        else
-          {
-            oldcursor.row = screen.cur.row - view_start;
+        oldcursor.row = screen.cur.row - view_start;
-            oldcursor.col = screen.cur.col;
+        oldcursor.col = screen.cur.col;
-          }
       }
+    else
+      oldcursor.row = -1;
   }
 #ifndef NO_SLOW_LINK_SUPPORT
   /*
    * D: CopyArea pass - very useful for slower links
       int ypixel = (int)Row2Pixel (row);
       for (col = 0; col < ncol; col++)
         {
           /* compare new text with old - if exactly the same then continue */
-          if (stp[col] == dtp[col]    /* Must match characters to skip. */
+          if (stp[col] == dtp[col] && RS_SAME (srp[col], drp[col]))
-              && (RS_SAME (srp[col], drp[col])    /* Either rendition the same or   */
-                  || (stp[col] == ' ' /* space w/ no background change  */
-                      && GET_BGATTR (srp[col]) == GET_BGATTR (drp[col]))))
             continue;
           // redraw one or more characters
           // seek to the beginning of wide characters
    * G: cleanup cursor and display outline cursor if necessary
    */
   if (showcursor)
     {
       if (focus)
+        {
+          if (cursor_type != 2)
-        scr_set_char_rend (ROW(screen.cur.row), cur_col, cur_rend);
+            scr_set_char_rend (ROW(screen.cur.row), cur_col, cur_rend);
+          else if (oldcursor.row >= 0)
+            {
+              XSetForeground (dpy, gc, pix_colors[ccol1]);
+              XFillRectangle (dpy, vt, gc,
+                              Col2Pixel (cur_col),
+                              Row2Pixel (oldcursor.row),
+                              1,
+                              Height2Pixel (1));
+            }
+        }
       else if (oldcursor.row >= 0)
         {
           XSetForeground (dpy, gc, pix_colors[ccol1]);
           XDrawRectangle (dpy, vt, gc,
       XSetWindowBackground (dpy, vt, pix_colors[Color_bg]);
     }
   XClearWindow (dpy, parent);
-  if (scrollBar.win)
+  if (scrollBar.state)
     {
       if (transparent)
         XSetWindowBackgroundPixmap (dpy, scrollBar.win, ParentRelative);
       else
         XSetWindowBackground (dpy, scrollBar.win, pix_colors[scrollBar.color ()]);
 void
 rxvt_term::selection_changed () NOTHROW
 {
   line_t &r1 = ROW (selection.beg.row);
-  while (selection.beg.col >    0 && r1.t [selection.beg.col] == NOCHAR)
+  while (selection.beg.col < r1.l && r1.t [selection.beg.col] == NOCHAR)
-    --selection.beg.col;
+    ++selection.beg.col;
   line_t &r2 = ROW (selection.end.row);
   while (selection.end.col < r2.l && r2.t [selection.end.col] == NOCHAR)
     ++selection.end.col;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing rxvt-unicode/src/screen.C (file contents): Revision 1.438 by sf-exg, Mon Mar 25 15:41:07 2013 UTC vs. Revision 1.450 by mikachu, Sat Dec 6 09:20:13 2014 UTC

Diff Legend

Comparing rxvt-unicode/src/screen.C (file contents):
Revision 1.438 by sf-exg, Mon Mar 25 15:41:07 2013 UTC vs.
Revision 1.450 by mikachu, Sat Dec 6 09:20:13 2014 UTC