--- rxvt-unicode/src/screen.C 2014/12/06 09:36:12 1.451 +++ rxvt-unicode/src/screen.C 2015/09/30 12:57:04 1.455 @@ -1013,8 +1013,8 @@ && ROW(screen.cur.row - 1).is_longer ()) { linep = &ROW(screen.cur.row - 1); - tp = line->t + ncol - 1; - rp = line->r + ncol - 1; + tp = linep->t + ncol - 1; + rp = linep->r + ncol - 1; } else continue; @@ -2120,40 +2120,27 @@ ccol2 = Color_bg; #endif - if (focus && cursor_type != 2) + if (focus && cursor_type == 0) { rend_t rend = cur_rend; - if (cursor_type == 1) - rend ^= RS_Uline; - else - { - rend ^= RS_RVid; - rend = SET_FGCOLOR (rend, ccol1); - rend = SET_BGCOLOR (rend, ccol2); - } + rend ^= RS_RVid; + rend = SET_FGCOLOR (rend, ccol1); + rend = SET_BGCOLOR (rend, ccol2); scr_set_char_rend (ROW(screen.cur.row), cur_col, rend); } } /* make sure no outline cursor is left around */ - if (ocrow != -1) - { - if (screen.cur.row - view_start != ocrow - || screen.cur.col != oldcursor.col || !showcursor) - { - if (ocrow < nrow - && oldcursor.col < ncol) - drawn_buf[ocrow].r[oldcursor.col] ^= (RS_RVid | RS_Uline); - } - } + if (ocrow != -1 && ocrow < nrow && oldcursor.col < ncol) + drawn_buf[ocrow].r[oldcursor.col] ^= (RS_RVid | RS_Uline); // save the current cursor coordinates if the cursor is visible // and either the window is unfocused or the cursor style is - // vertical bar, so as to clear the outline cursor in the next - // refresh if the cursor moves or becomes invisible - if (showcursor && (!focus || cursor_type == 2) && screen.cur.row - view_start < nrow) + // underline or vertical bar, so as to clear the outline cursor in + // the next refresh if the cursor moves or becomes invisible + if (showcursor && (!focus || cursor_type != 0) && screen.cur.row - view_start < nrow) { oldcursor.row = screen.cur.row - view_start; oldcursor.col = screen.cur.col; @@ -2457,16 +2444,23 @@ { if (focus) { - if (cursor_type != 2) + if (cursor_type == 0) scr_set_char_rend (ROW(screen.cur.row), cur_col, cur_rend); else if (oldcursor.row >= 0) { XSetForeground (dpy, gc, pix_colors[ccol1]); - XFillRectangle (dpy, vt, gc, - Col2Pixel (cur_col), - Row2Pixel (oldcursor.row), - 1, - Height2Pixel (1)); + if (cursor_type == 1) + XFillRectangle (dpy, vt, gc, + Col2Pixel (cur_col), + Row2Pixel (oldcursor.row + 1) - 2, + Width2Pixel (1), + 2); + else + XFillRectangle (dpy, vt, gc, + Col2Pixel (cur_col), + Row2Pixel (oldcursor.row), + 2, + Height2Pixel (1)); } } else if (oldcursor.row >= 0) @@ -2522,7 +2516,7 @@ } void ecb_cold -rxvt_term::scr_recolour (bool refresh) NOTHROW +rxvt_term::scr_recolor (bool refresh) NOTHROW { bool transparent = false;