--- rxvt-unicode/src/scrollbar.C 2006/01/24 19:40:12 1.33 +++ rxvt-unicode/src/scrollbar.C 2008/01/02 08:24:39 1.46 @@ -1,4 +1,4 @@ -/*--------------------------------*-C-*---------------------------------* +/*----------------------------------------------------------------------* * File: scrollbar.C *----------------------------------------------------------------------* * @@ -6,7 +6,7 @@ * Copyright (c) 1998 Alfredo K. Kojima * - N*XTstep like scrollbars * Copyright (c) 1999-2001 Geoff Wing - * Copyright (c) 2004 Marc Lehmann + * Copyright (c) 2004-2006 Marc Lehmann * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -34,7 +34,7 @@ int rxvt_term::scrollbar_mapping (int map) { - int change = 0; + int change = 0; #ifdef HAVE_SCROLLBARS if (map) @@ -46,17 +46,18 @@ if (scrollBar.win) { - XMapWindow (display->display, scrollBar.win); + XMapWindow (dpy, scrollBar.win); change = 1; } } else { scrollBar.state = 0; - XUnmapWindow (display->display, scrollBar.win); + XUnmapWindow (dpy, scrollBar.win); change = 1; } #endif + return change; } @@ -71,9 +72,9 @@ #define R_SCROLLBEG_NEXT 0 #define R_SCROLLEND_NEXT szHint.height - (SB_BUTTON_TOTAL_HEIGHT + \ SB_PADDING) -#define R_SCROLLBEG_RXVT (scrollBar.width + 1) + sb_shadow +#define R_SCROLLBEG_RXVT (scrollBar.width + 1) + scrollBar.shadow #define R_SCROLLEND_RXVT szHint.height - R_SCROLLBEG_RXVT - \ - (2 * sb_shadow) + (2 * scrollBar.shadow) #if defined(PLAIN_SCROLLBAR) if (scrollBar.style == R_SB_PLAIN) @@ -111,7 +112,7 @@ if (!scrollBar.win) { /* create the scrollbar window */ - scrollBar.win = XCreateSimpleWindow (display->display, + scrollBar.win = XCreateSimpleWindow (dpy, parent[0], window_sb_x, 0, scrollbar_TotalWidth (), @@ -119,9 +120,9 @@ 0, pix_colors[Color_fg], pix_colors[Color_border]); - XDefineCursor (display->display, scrollBar.win, leftptr_cursor); + XDefineCursor (dpy, scrollBar.win, leftptr_cursor); - XSelectInput (display->display, scrollBar.win, + XSelectInput (dpy, scrollBar.win, ExposureMask | ButtonPressMask | ButtonReleaseMask | Button1MotionMask | Button2MotionMask | Button3MotionMask); @@ -133,7 +134,7 @@ scrollbar_show (1); if (delayed_init) - XMapWindow (display->display, scrollBar.win); + XMapWindow (dpy, scrollBar.win); #endif } @@ -158,21 +159,21 @@ adj = (((bot - top) * scrollbar_size ()) % len) > 0 ? 1 : 0; scrollBar.top = (scrollBar.beg + (top * scrollbar_size ()) / len); - scrollbar_len = ((bot - top) * scrollbar_size ()) / len + + scrollBar.len = ((bot - top) * scrollbar_size ()) / len + scrollbar_minheight () + adj; - scrollBar.bot = (scrollBar.top + scrollbar_len); + scrollBar.bot = (scrollBar.top + scrollBar.len); /* no change */ - if (scrollBar.top == last_top - && scrollBar.bot == last_bot - && (scrollBar.state == last_state || !scrollbar_isUpDn ())) + if (scrollBar.top == scrollBar.last_top + && scrollBar.bot == scrollBar.last_bot + && (scrollBar.state == scrollBar.last_state || !scrollbar_isUpDn ())) return 0; } - ret = (this->*scrollBar.update) (update, last_top, last_bot, scrollbar_len); + ret = (this->*scrollBar.update) (update, scrollBar.last_top, scrollBar.last_bot, scrollBar.len); - last_top = scrollBar.top; - last_bot = scrollBar.bot; - last_state = scrollBar.state; + scrollBar.last_top = scrollBar.top; + scrollBar.last_bot = scrollBar.bot; + scrollBar.last_state = scrollBar.state; #endif return ret; @@ -229,21 +230,22 @@ width = min (i, SB_WIDTH_MAXIMUM); # ifdef RXVT_SCROLLBAR - if (! OPTION (Opt_scrollBar_floating) && style == R_SB_RXVT) - sb_shadow = 2; + if (! option (Opt_scrollBar_floating) && style == R_SB_RXVT) + scrollBar.shadow = SHADOW_WIDTH; # endif scrollBar.style = style; scrollBar.width = width; - /* scrollbar_align = R_SB_ALIGN_CENTRE; */ + /* scrollBar.align = R_SB_ALIGN_CENTRE; */ if (scrollalign) { if (strncasecmp (scrollalign, "top", 3) == 0) - scrollbar_align = R_SB_ALIGN_TOP; + scrollBar.align = R_SB_ALIGN_TOP; else if (strncasecmp (scrollalign, "bottom", 6) == 0) - scrollbar_align = R_SB_ALIGN_BOTTOM; + scrollBar.align = R_SB_ALIGN_BOTTOM; } + scrollBar.last_bot = scrollBar.last_state = -1; #endif }