common-sense/sense.pm

=head1 NAME

common::sense - save a tree AND a kitten, use common::sense!

=head1 SYNOPSIS

 use common::sense;

 # roughly the same as, with much lower memory usage:
 #
 # use strict qw(vars subs);
 # use feature qw(say state switch);
 # no warnings;
 # use warnings qw(FATAL closed threads internal debugging pack substr malloc
 #                 unopened portable prototype inplace io pipe unpack regexp
 #                 deprecated exiting glob digit printf utf8 layer
 #                 reserved parenthesis taint closure semicolon);
 # no warnings qw(exec newline);

=head1 DESCRIPTION

This module implements some sane defaults for Perl programs, as defined by
two typical (or not so typical - use your common sense) specimens of Perl
coders.

=over 4

=item use strict qw(subs vars)

Using C<use strict> is definitely common sense, but C<use strict
'refs'> definitely overshoots its usefulness. After almost two
decades of Perl hacking, we decided that it does more harm than being
useful. Specifically, constructs like these:

   @{ $var->[0] }

Must be written like this (or similarly), when C<use strict 'refs'> is in
scope, and C<$var> can legally be C<undef>:

   @{ $var->[0] || [] }

This is annoying, and doesn't shield against obvious mistakes such as
using C<"">, so one would even have to write (at least for the time
being):

   @{ defined $var->[0] ? $var->[0] :  [] }

... which nobody with a bit of common sense would consider
writing.

Curiously enough, sometimes perl is not so strict, as this works even with
C<use strict> in scope:

   for (@{ $var->[0] }) { ...

If that isn't hypocrisy! And all that from a mere program!


=item use feature qw(say state given)

We found it annoying that we always have to enable extra features. If
something breaks because it didn't anticipate future changes, so be
it. 5.10 broke almost all our XS modules and nobody cared either (or at
least I know of nobody who really complained about gratuitous changes -
as opposed to bugs).

Few modules that are not actively maintained work with newer versions of
Perl, regardless of use feature or not, so a new major perl release means
changes to many modules - new keywords are just the tip of the iceberg.

If your code isn't alive, it's dead, Jim - be an active maintainer.


=item no warnings, but a lot of new errors

Ah, the dreaded warnings. Even worse, the horribly dreaded C<-w>
switch: Even though we don't care if other people use warnings (and
certainly there are useful ones), a lot of warnings simply go against the
spirit of Perl.

Most prominently, the warnings related to C<undef>. There is nothing wrong
with C<undef>: it has well-defined semantics, it is useful, and spitting
out warnings you never asked for is just evil.

The result was that every one of our modules did C<no warnings> in the
past, to avoid somebody accidentally using and forcing his bad standards
on our code. Of course, this switched off all warnings, even the useful
ones. Not a good situation. Really, the C<-w> switch should only enable
warnings for the main program only.

Funnily enough, L<perllexwarn> explicitly mentions C<-w> (and not in a
favourable way, calling it outright "wrong"), but standard utilities, such
as L<prove>, or MakeMaker when running C<make test>, still enable them
blindly.

For version 2 of common::sense, we finally sat down a few hours and went
through I<every single warning message>, identifiying - according to
common sense - all the useful ones.

This resulted in the rather impressive list in the SYNOPSIS. When we
weren't sure, we didn't include the warning, so the list might grow in
the future (we might have made a mistake, too, so the list might shrink
as well).

Note the presence of C<FATAL> in the list: we do not think that the
conditions caught by these warnings are worthy of a warning, we I<insist>
that they are worthy of I<stopping> your program, I<instantly>. They are
I<bugs>!

Therefore we consider C<common::sense> to be much stricter than C<use
warnings>, which is good if you are into strict things (we are not,
actually, but these things tend to be subjective).

After deciding on the list, we ran the module against all of our code that
uses C<common::sense> (that is almost all of our code), and found only one
occurence where one of them caused a problem: one of elmex's (unreleased)
modules contained:

   $fmt =~ s/([^\s\[]*)\[( [^\]]* )\]/\x0$1\x1$2\x0/xgo;

We quickly agreed that indeed the code should be changed, even though it
happened to do the right thing when the warning was switched off.


=item mucho reduced memory usage

Just using all those pragmas mentioned in the SYNOPSIS together wastes
<blink>I<< B<776> kilobytes >></blink> of precious memory in my perl, for
I<every single perl process using our code>, which on our machines, is a
lot. In comparison, this module only uses I<< B<four> >> kilobytes (I even
had to write it out so it looks like more) of memory on the same platform.

The money/time/effort/electricity invested in these gigabytes (probably
petabytes globally!) of wasted memory could easily save 42 trees, and a
kitten!

Unfortunately, until everybods applies more common sense, there will still
often be modules that pull in the monster pragmas. But one can hope...

=cut

package common::sense;

our $VERSION = '2.0';

# paste this into pelr to find bitmask

# no warnings;
# use warnings qw(FATAL closed threads internal debugging pack substr malloc unopened portable prototype
#                 inplace io pipe unpack regexp deprecated exiting glob digit printf
#                 utf8 layer reserved parenthesis taint closure semicolon);
# no warnings qw(exec newline);
# BEGIN { warn join "", map "\\x$_", unpack "(H2)*", ${^WARNING_BITS}; exit 0 };

# overload should be included

sub import {
   # verified with perl 5.8.0, 5.10.0
   ${^WARNING_BITS} = "\xfc\x3f\xf3\x00\x0f\xf3\xcf\xc0\xf3\xfc\x33\x03";

   # use strict vars subs
   $^H |= 0x00000600;

   # use feature
   $^H{feature_switch} =
   $^H{feature_say}    =
   $^H{feature_state}  = 1;
}

1;

=back

=head1 THERE IS NO 'no common::sense'!!!! !!!! !!

This module doesn't offer an unimport. First of all, it wastes even more
memory, second, and more importantly, who with even a bit of common sense
would want no common sense?

=head1 STABILITY AND FUTURE VERSIONS

Future versions might change just about everything in this module. We
might test our modules and upload new ones working with newer versions of
this module, and leave you standing in the rain because we didn't tell
you. In fact, we did so when switching from 1.0 to 2.0, which enabled gobs
of warnings, and made them FATAL on top.

Maybe we will load some nifty modules that try to emulate C<say> or so
with perls older than 5.10 (this module, of course, should work with older
perl versions - supporting 5.8 for example is just common sense at this
time. Maybe not in the future, but of course you can trust our common
sense to be consistent with, uhm, our opinion).

=head1 WHAT OTHER PEOPLE HAD TO SAY ABOUT THIS MODULE

apeiron

   "... wow"
   "I hope common::sense is a joke."

crab

   "i wonder how it would be if joerg schilling wrote perl modules."

H.Merijn Brand

   "Just one more reason to drop JSON::XS from my distribution list"

Pista Palo

   "Something in short supply these days..."

Steffen Schwigon

   "This module is quite for sure *not* just a repetition of all the other
   'use strict, use warnings'-approaches, and it's also not the opposite.
   [...] And for its chosen middle-way it's also not the worst name ever.
   And everything is documented."

BKB

   "[Deleted - thanks to Steffen Schwigon for pointing out this review was
   in error.]"

Somni

   "the arrogance of the guy"
   "I swear he tacked somenoe else's name onto the module
   just so he could use the royal 'we' in the documentation"

dngor

   "Heh.  '"<elmex at ta-sa.org>"'  The quotes are semantic
   distancing from that e-mail address."

Jerad Pierce

   "Awful name (not a proper pragma), and the SYNOPSIS doesn't tell you
   anything either. Nor is it clear what features have to do with "common
   sense" or discipline."

acme

   "THERE IS NO 'no common::sense'!!!! !!!! !!"

apeiron (meta-comment about us commenting^Wquoting his comment)

   How about quoting this: get a clue, you fucktarded amoeba.

=head1 AUTHOR

 Marc Lehmann <schmorp@schmorp.de>
 http://home.schmorp.de/

 Robin Redeker, "<elmex at ta-sa.org>".

=cut

Revision:	1.16
Committed:	Tue Sep 1 19:10:02 2009 UTC (14 years, 8 months ago) by root
Branch:	MAIN
CVS Tags:	rel-2_0
Changes since 1.15:	+17 -17 lines
Log Message:	2.0
#	User	Rev	Content
1	root	1.1	=head1 NAME
2
3			common::sense - save a tree AND a kitten, use common::sense!
4
5			=head1 SYNOPSIS
6
7			use common::sense;
8
9			# roughly the same as, with much lower memory usage:
10			#
11			# use strict qw(vars subs);
12			# use feature qw(say state switch);
13			# no warnings;
14	root	1.15	# use warnings qw(FATAL closed threads internal debugging pack substr malloc
15			# unopened portable prototype inplace io pipe unpack regexp
16	root	1.16	# deprecated exiting glob digit printf utf8 layer
17	root	1.15	# reserved parenthesis taint closure semicolon);
18			# no warnings qw(exec newline);
19	root	1.1
20			=head1 DESCRIPTION
21
22			This module implements some sane defaults for Perl programs, as defined by
23	root	1.16	two typical (or not so typical - use your common sense) specimens of Perl
24			coders.
25	root	1.1
26			=over 4
27
28			=item use strict qw(subs vars)
29
30			Using C<use strict> is definitely common sense, but C<use strict
31	root	1.11	'refs'> definitely overshoots its usefulness. After almost two
32	root	1.1	decades of Perl hacking, we decided that it does more harm than being
33			useful. Specifically, constructs like these:
34
35			@{ $var->[0] }
36
37	root	1.4	Must be written like this (or similarly), when C<use strict 'refs'> is in
38			scope, and C<$var> can legally be C<undef>:
39	root	1.1
40			@{ $var->[0] \|\| [] }
41
42			This is annoying, and doesn't shield against obvious mistakes such as
43	root	1.11	using C<"">, so one would even have to write (at least for the time
44			being):
45	root	1.1
46			@{ defined $var->[0] ? $var->[0] : [] }
47
48			... which nobody with a bit of common sense would consider
49	root	1.11	writing.
50
51			Curiously enough, sometimes perl is not so strict, as this works even with
52			C<use strict> in scope:
53	root	1.1
54			for (@{ $var->[0] }) { ...
55
56	root	1.15	If that isn't hypocrisy! And all that from a mere program!
57
58	root	1.1
59			=item use feature qw(say state given)
60
61			We found it annoying that we always have to enable extra features. If
62			something breaks because it didn't anticipate future changes, so be
63	root	1.11	it. 5.10 broke almost all our XS modules and nobody cared either (or at
64	root	1.15	least I know of nobody who really complained about gratuitous changes -
65			as opposed to bugs).
66	root	1.11
67			Few modules that are not actively maintained work with newer versions of
68			Perl, regardless of use feature or not, so a new major perl release means
69			changes to many modules - new keywords are just the tip of the iceberg.
70
71	root	1.15	If your code isn't alive, it's dead, Jim - be an active maintainer.
72
73
74	root	1.16	=item no warnings, but a lot of new errors
75	root	1.15
76			Ah, the dreaded warnings. Even worse, the horribly dreaded C<-w>
77			switch: Even though we don't care if other people use warnings (and
78			certainly there are useful ones), a lot of warnings simply go against the
79			spirit of Perl.
80
81			Most prominently, the warnings related to C<undef>. There is nothing wrong
82			with C<undef>: it has well-defined semantics, it is useful, and spitting
83			out warnings you never asked for is just evil.
84
85	root	1.16	The result was that every one of our modules did C<no warnings> in the
86			past, to avoid somebody accidentally using and forcing his bad standards
87			on our code. Of course, this switched off all warnings, even the useful
88			ones. Not a good situation. Really, the C<-w> switch should only enable
89			warnings for the main program only.
90	root	1.15
91			Funnily enough, L<perllexwarn> explicitly mentions C<-w> (and not in a
92			favourable way, calling it outright "wrong"), but standard utilities, such
93			as L<prove>, or MakeMaker when running C<make test>, still enable them
94			blindly.
95
96	root	1.16	For version 2 of common::sense, we finally sat down a few hours and went
97			through I<every single warning message>, identifiying - according to
98			common sense - all the useful ones.
99	root	1.15
100			This resulted in the rather impressive list in the SYNOPSIS. When we
101			weren't sure, we didn't include the warning, so the list might grow in
102			the future (we might have made a mistake, too, so the list might shrink
103	root	1.16	as well).
104	root	1.15
105			Note the presence of C<FATAL> in the list: we do not think that the
106			conditions caught by these warnings are worthy of a warning, we I<insist>
107	root	1.16	that they are worthy of I<stopping> your program, I<instantly>. They are
108			I<bugs>!
109	root	1.15
110			Therefore we consider C<common::sense> to be much stricter than C<use
111			warnings>, which is good if you are into strict things (we are not,
112			actually, but these things tend to be subjective).
113
114			After deciding on the list, we ran the module against all of our code that
115			uses C<common::sense> (that is almost all of our code), and found only one
116			occurence where one of them caused a problem: one of elmex's (unreleased)
117			modules contained:
118
119			$fmt =~ s/([^\s\[])\[( [^\]] )\]/\x0$1\x1$2\x0/xgo;
120
121			We quickly agreed that indeed the code should be changed, even though it
122			happened to do the right thing when the warning was switched off.
123
124	root	1.11
125			=item mucho reduced memory usage
126
127			Just using all those pragmas mentioned in the SYNOPSIS together wastes
128			<blink>I<< B<776> kilobytes >></blink> of precious memory in my perl, for
129			I<every single perl process using our code>, which on our machines, is a
130			lot. In comparison, this module only uses I<< B<four> >> kilobytes (I even
131			had to write it out so it looks like more) of memory on the same platform.
132	root	1.1
133			The money/time/effort/electricity invested in these gigabytes (probably
134			petabytes globally!) of wasted memory could easily save 42 trees, and a
135			kitten!
136
137	root	1.11	Unfortunately, until everybods applies more common sense, there will still
138			often be modules that pull in the monster pragmas. But one can hope...
139
140	root	1.1	=cut
141
142	root	1.2	package common::sense;
143	root	1.1
144	root	1.15	our $VERSION = '2.0';
145
146			# paste this into pelr to find bitmask
147	root	1.1
148	root	1.13	# no warnings;
149			# use warnings qw(FATAL closed threads internal debugging pack substr malloc unopened portable prototype
150	root	1.16	# inplace io pipe unpack regexp deprecated exiting glob digit printf
151	root	1.14	# utf8 layer reserved parenthesis taint closure semicolon);
152			# no warnings qw(exec newline);
153			# BEGIN { warn join "", map "\\x$_", unpack "(H2)*", ${^WARNING_BITS}; exit 0 };
154	root	1.13
155			# overload should be included
156
157	root	1.2	sub import {
158	root	1.13	# verified with perl 5.8.0, 5.10.0
159	root	1.16	${^WARNING_BITS} = "\xfc\x3f\xf3\x00\x0f\xf3\xcf\xc0\xf3\xfc\x33\x03";
160	root	1.3
161			# use strict vars subs
162			$^H \|= 0x00000600;
163
164			# use feature
165			$^H{feature_switch} =
166			$^H{feature_say} =
167			$^H{feature_state} = 1;
168	root	1.1	}
169
170			1;
171
172			=back
173
174	root	1.5	=head1 THERE IS NO 'no common::sense'!!!! !!!! !!
175	root	1.4
176			This module doesn't offer an unimport. First of all, it wastes even more
177			memory, second, and more importantly, who with even a bit of common sense
178			would want no common sense?
179
180	root	1.5	=head1 STABILITY AND FUTURE VERSIONS
181
182			Future versions might change just about everything in this module. We
183			might test our modules and upload new ones working with newer versions of
184			this module, and leave you standing in the rain because we didn't tell
185	root	1.15	you. In fact, we did so when switching from 1.0 to 2.0, which enabled gobs
186			of warnings, and made them FATAL on top.
187	root	1.5
188	root	1.15	Maybe we will load some nifty modules that try to emulate C<say> or so
189			with perls older than 5.10 (this module, of course, should work with older
190			perl versions - supporting 5.8 for example is just common sense at this
191			time. Maybe not in the future, but of course you can trust our common
192			sense to be consistent with, uhm, our opinion).
193	root	1.11
194			=head1 WHAT OTHER PEOPLE HAD TO SAY ABOUT THIS MODULE
195
196			apeiron
197
198			"... wow"
199			"I hope common::sense is a joke."
200
201			crab
202	root	1.5
203	root	1.11	"i wonder how it would be if joerg schilling wrote perl modules."
204	root	1.7
205	root	1.11	H.Merijn Brand
206
207			"Just one more reason to drop JSON::XS from my distribution list"
208	root	1.7
209			Pista Palo
210
211			"Something in short supply these days..."
212
213			Steffen Schwigon
214
215			"This module is quite for sure not just a repetition of all the other
216			'use strict, use warnings'-approaches, and it's also not the opposite.
217			[...] And for its chosen middle-way it's also not the worst name ever.
218			And everything is documented."
219
220			BKB
221
222			"[Deleted - thanks to Steffen Schwigon for pointing out this review was
223			in error.]"
224
225			Somni
226
227			"the arrogance of the guy"
228			"I swear he tacked somenoe else's name onto the module
229			just so he could use the royal 'we' in the documentation"
230
231			dngor
232
233			"Heh. '"<elmex at ta-sa.org>"' The quotes are semantic
234			distancing from that e-mail address."
235
236			Jerad Pierce
237
238			"Awful name (not a proper pragma), and the SYNOPSIS doesn't tell you
239			anything either. Nor is it clear what features have to do with "common
240			sense" or discipline."
241
242			acme
243
244			"THERE IS NO 'no common::sense'!!!! !!!! !!"
245
246	root	1.15	apeiron (meta-comment about us commenting^Wquoting his comment)
247	root	1.12
248			How about quoting this: get a clue, you fucktarded amoeba.
249
250	root	1.1	=head1 AUTHOR
251
252			Marc Lehmann <schmorp@schmorp.de>
253			http://home.schmorp.de/
254
255	root	1.4	Robin Redeker, "<elmex at ta-sa.org>".
256
257	root	1.1	=cut
258