ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/deliantra/server/common/object.C
(Generate patch)

Comparing deliantra/server/common/object.C (file contents):
Revision 1.64 by root, Tue Dec 12 21:39:56 2006 UTC vs.
Revision 1.112 by root, Mon Jan 8 14:11:04 2007 UTC

1/* 1/*
2 CrossFire, A Multiplayer game for X-windows 2 CrossFire, A Multiplayer game for X-windows
3 3
4 Copyright (C) 2005, 2006, 2007 Marc Lehmann & Crossfire+ Development Team
4 Copyright (C) 2001 Mark Wedel & Crossfire Development Team 5 Copyright (C) 2001 Mark Wedel & Crossfire Development Team
5 Copyright (C) 1992 Frank Tore Johansen 6 Copyright (C) 1992 Frank Tore Johansen
6 7
7 This program is free software; you can redistribute it and/or modify 8 This program is free software; you can redistribute it and/or modify
8 it under the terms of the GNU General Public License as published by 9 it under the terms of the GNU General Public License as published by
30#include <sys/uio.h> 31#include <sys/uio.h>
31#include <object.h> 32#include <object.h>
32#include <funcpoint.h> 33#include <funcpoint.h>
33#include <loader.h> 34#include <loader.h>
34 35
36#include <bitset>
37
35int nrofallocobjects = 0; 38int nrofallocobjects = 0;
36static UUID uuid; 39static UUID uuid;
37const uint64 UUID_SKIP = 1<<19; 40const uint64 UUID_SKIP = 1<<19;
38 41
39object *active_objects; /* List of active objects that need to be processed */ 42objectvec objects;
43activevec actives;
40 44
41short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1, 45short freearr_x[SIZEOFFREE] = { 0, 0, 1, 1, 1, 0, -1, -1, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, -2, -2, -2, -1,
42 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1 46 0, 1, 2, 3, 3, 3, 3, 3, 3, 3, 2, 1, 0, -1, -2, -3, -3, -3, -3, -3, -3, -3, -2, -1
43}; 47};
44short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2, 48short freearr_y[SIZEOFFREE] = { 0, -1, -1, 0, 1, 1, 1, 0, -1, -2, -2, -2, -1, 0, 1, 2, 2, 2, 2, 2, 1, 0, -1, -2, -2,
139 * objects with lists are rare, and lists stay short. If not, use a 143 * objects with lists are rare, and lists stay short. If not, use a
140 * different structure or at least keep the lists sorted... 144 * different structure or at least keep the lists sorted...
141 */ 145 */
142 146
143 /* For each field in wants, */ 147 /* For each field in wants, */
144 for (wants_field = wants->key_values; wants_field != NULL; wants_field = wants_field->next) 148 for (wants_field = wants->key_values; wants_field; wants_field = wants_field->next)
145 { 149 {
146 key_value *has_field; 150 key_value *has_field;
147 151
148 /* Look for a field in has with the same key. */ 152 /* Look for a field in has with the same key. */
149 has_field = get_ob_key_link (has, wants_field->key); 153 has_field = get_ob_key_link (has, wants_field->key);
183 * 187 *
184 * Note that this function appears a lot longer than the macro it 188 * Note that this function appears a lot longer than the macro it
185 * replaces - this is mostly for clarity - a decent compiler should hopefully 189 * replaces - this is mostly for clarity - a decent compiler should hopefully
186 * reduce this to the same efficiency. 190 * reduce this to the same efficiency.
187 * 191 *
188 * Check nrof variable *before* calling CAN_MERGE() 192 * Check nrof variable *before* calling can_merge()
189 * 193 *
190 * Improvements made with merge: Better checking on potion, and also 194 * Improvements made with merge: Better checking on potion, and also
191 * check weight 195 * check weight
192 */ 196 */
193
194bool object::can_merge (object *ob1, object *ob2) 197bool object::can_merge_slow (object *ob1, object *ob2)
195{ 198{
196 /* A couple quicksanity checks */ 199 /* A couple quicksanity checks */
197 if ((ob1 == ob2) || (ob1->type != ob2->type)) 200 if (ob1 == ob2
201 || ob1->type != ob2->type
202 || ob1->speed != ob2->speed
203 || ob1->value != ob2->value
204 || ob1->name != ob2->name)
198 return 0; 205 return 0;
199 206
200 if (ob1->speed != ob2->speed) 207 //TODO: this ain't working well, use nicer and correct overflow check
201 return 0;
202
203 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that 208 /* Do not merge objects if nrof would overflow. We use 1UL<<31 since that
204 * value could not be stored in a sint32 (which unfortunately sometimes is 209 * value could not be stored in a sint32 (which unfortunately sometimes is
205 * used to store nrof). 210 * used to store nrof).
206 */ 211 */
207 if (ob1->nrof + ob2->nrof >= 1UL << 31) 212 if (ob1->nrof + ob2->nrof >= 1UL << 31)
217 SET_FLAG (ob1, FLAG_BEEN_APPLIED); 222 SET_FLAG (ob1, FLAG_BEEN_APPLIED);
218 223
219 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED)) 224 if (QUERY_FLAG (ob2, FLAG_IDENTIFIED))
220 SET_FLAG (ob2, FLAG_BEEN_APPLIED); 225 SET_FLAG (ob2, FLAG_BEEN_APPLIED);
221 226
222 227 if ((ob1->flag ^ ob2->flag).reset (FLAG_INV_LOCKED).reset (FLAG_CLIENT_SENT).any ()
223 /* the 0x400000 on flags2 is FLAG_INV_LOCK. I don't think something 228 || ob1->arch != ob2->arch
224 * being locked in inventory should prevent merging.
225 * 0x4 in flags3 is CLIENT_SENT
226 */
227 if ((ob1->arch != ob2->arch) ||
228 (ob1->flags[0] != ob2->flags[0]) ||
229 (ob1->flags[1] != ob2->flags[1]) ||
230 ((ob1->flags[2] & ~0x400000) != (ob2->flags[2] & ~0x400000)) ||
231 ((ob1->flags[3] & ~0x4) != (ob2->flags[3] & ~0x4)) ||
232 (ob1->name != ob2->name) || 229 || ob1->name != ob2->name
233 (ob1->title != ob2->title) || 230 || ob1->title != ob2->title
234 (ob1->msg != ob2->msg) || 231 || ob1->msg != ob2->msg
235 (ob1->weight != ob2->weight) || 232 || ob1->weight != ob2->weight
236 (memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist)) != 0) || 233 || memcmp (&ob1->resist, &ob2->resist, sizeof (ob1->resist))
237 (memcmp (&ob1->stats, &ob2->stats, sizeof (ob1->stats)) != 0) || 234 || memcmp (&ob1->stats , &ob2->stats , sizeof (ob1->stats) )
238 (ob1->attacktype != ob2->attacktype) || 235 || ob1->attacktype != ob2->attacktype
239 (ob1->magic != ob2->magic) || 236 || ob1->magic != ob2->magic
240 (ob1->slaying != ob2->slaying) || 237 || ob1->slaying != ob2->slaying
241 (ob1->skill != ob2->skill) || 238 || ob1->skill != ob2->skill
242 (ob1->value != ob2->value) || 239 || ob1->value != ob2->value
243 (ob1->animation_id != ob2->animation_id) || 240 || ob1->animation_id != ob2->animation_id
244 (ob1->client_type != ob2->client_type) || 241 || ob1->client_type != ob2->client_type
245 (ob1->materialname != ob2->materialname) || 242 || ob1->materialname != ob2->materialname
246 (ob1->lore != ob2->lore) || 243 || ob1->lore != ob2->lore
247 (ob1->subtype != ob2->subtype) || 244 || ob1->subtype != ob2->subtype
248 (ob1->move_type != ob2->move_type) || 245 || ob1->move_type != ob2->move_type
249 (ob1->move_block != ob2->move_block) || 246 || ob1->move_block != ob2->move_block
250 (ob1->move_allow != ob2->move_allow) || 247 || ob1->move_allow != ob2->move_allow
251 (ob1->move_on != ob2->move_on) || 248 || ob1->move_on != ob2->move_on
252 (ob1->move_off != ob2->move_off) || (ob1->move_slow != ob2->move_slow) || (ob1->move_slow_penalty != ob2->move_slow_penalty)) 249 || ob1->move_off != ob2->move_off
250 || ob1->move_slow != ob2->move_slow
251 || ob1->move_slow_penalty != ob2->move_slow_penalty)
253 return 0; 252 return 0;
254 253
255 /* This is really a spellbook check - really, we should 254 /* This is really a spellbook check - really, we should
256 * check all objects in the inventory. 255 * check all objects in the inventory.
257 */ 256 */
260 /* if one object has inventory but the other doesn't, not equiv */ 259 /* if one object has inventory but the other doesn't, not equiv */
261 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv)) 260 if ((ob1->inv && !ob2->inv) || (ob2->inv && !ob1->inv))
262 return 0; 261 return 0;
263 262
264 /* Now check to see if the two inventory objects could merge */ 263 /* Now check to see if the two inventory objects could merge */
265 if (!CAN_MERGE (ob1->inv, ob2->inv)) 264 if (!object::can_merge (ob1->inv, ob2->inv))
266 return 0; 265 return 0;
267 266
268 /* inventory ok - still need to check rest of this object to see 267 /* inventory ok - still need to check rest of this object to see
269 * if it is valid. 268 * if it is valid.
270 */ 269 */
279 278
280 /* Note sure why the following is the case - either the object has to 279 /* Note sure why the following is the case - either the object has to
281 * be animated or have a very low speed. Is this an attempted monster 280 * be animated or have a very low speed. Is this an attempted monster
282 * check? 281 * check?
283 */ 282 */
284 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && FABS ((ob1)->speed) > MIN_ACTIVE_SPEED) 283 if (!QUERY_FLAG (ob1, FLAG_ANIMATE) && ob1->has_active_speed ())
285 return 0; 284 return 0;
286 285
287 switch (ob1->type) 286 switch (ob1->type)
288 { 287 {
289 case SCROLL: 288 case SCROLL:
354 op = op->env; 353 op = op->env;
355 return op; 354 return op;
356} 355}
357 356
358/* 357/*
359 * Eneq(@csd.uu.se): Since we can have items buried in a character we need
360 * a better check. We basically keeping traversing up until we can't
361 * or find a player.
362 */
363
364object *
365is_player_inv (object *op)
366{
367 for (; op != NULL && op->type != PLAYER; op = op->env)
368 if (op->env == op)
369 op->env = NULL;
370 return op;
371}
372
373/*
374 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump. 358 * Used by: Crossedit: dump. Server DM commands: dumpbelow, dump.
375 * Some error messages. 359 * Some error messages.
376 * The result of the dump is stored in the static global errmsg array. 360 * The result of the dump is stored in the static global errmsg array.
377 */ 361 */
378 362
381{ 365{
382 if (!op) 366 if (!op)
383 return strdup ("[NULLOBJ]"); 367 return strdup ("[NULLOBJ]");
384 368
385 object_freezer freezer; 369 object_freezer freezer;
386 save_object (freezer, op, 3); 370 save_object (freezer, op, 1);
387 return freezer.as_string (); 371 return freezer.as_string ();
388} 372}
389 373
390/* 374/*
391 * get_nearest_part(multi-object, object 2) returns the part of the 375 * get_nearest_part(multi-object, object 2) returns the part of the
408} 392}
409 393
410/* 394/*
411 * Returns the object which has the count-variable equal to the argument. 395 * Returns the object which has the count-variable equal to the argument.
412 */ 396 */
413
414object * 397object *
415find_object (tag_t i) 398find_object (tag_t i)
416{ 399{
417 for (object *op = object::first; op; op = op->next) 400 for_all_objects (op)
418 if (op->count == i) 401 if (op->count == i)
419 return op; 402 return op;
420 403
421 return 0; 404 return 0;
422} 405}
423 406
424/* 407/*
425 * Returns the first object which has a name equal to the argument. 408 * Returns the first object which has a name equal to the argument.
426 * Used only by the patch command, but not all that useful. 409 * Used only by the patch command, but not all that useful.
427 * Enables features like "patch <name-of-other-player> food 999" 410 * Enables features like "patch <name-of-other-player> food 999"
428 */ 411 */
429
430object * 412object *
431find_object_name (const char *str) 413find_object_name (const char *str)
432{ 414{
433 shstr_cmp str_ (str); 415 shstr_cmp str_ (str);
434 object *op; 416 object *op;
435 417
436 for (op = object::first; op != NULL; op = op->next) 418 for_all_objects (op)
437 if (op->name == str_) 419 if (op->name == str_)
438 break; 420 break;
439 421
440 return op; 422 return op;
441} 423}
484 } 466 }
485 467
486 op->key_values = 0; 468 op->key_values = 0;
487} 469}
488 470
489void object::clear ()
490{
491 attachable_base::clear ();
492
493 free_key_values (this);
494
495 owner = 0;
496 name = 0;
497 name_pl = 0;
498 title = 0;
499 race = 0;
500 slaying = 0;
501 skill = 0;
502 msg = 0;
503 lore = 0;
504 custom_name = 0;
505 materialname = 0;
506 contr = 0;
507 below = 0;
508 above = 0;
509 inv = 0;
510 container = 0;
511 env = 0;
512 more = 0;
513 head = 0;
514 map = 0;
515 active_next = 0;
516 active_prev = 0;
517
518 memset (static_cast<object_pod *>(this), 0, sizeof (object_pod));
519
520 SET_FLAG (this, FLAG_REMOVED);
521
522 /* What is not cleared is next, prev, and count */
523
524 expmul = 1.0;
525 face = blank_face;
526
527 if (settings.casting_time)
528 casting_time = -1;
529}
530
531/* 471/*
532 * copy_to first frees everything allocated by the dst object, 472 * copy_to first frees everything allocated by the dst object,
533 * and then copies the contents of itself into the second 473 * and then copies the contents of itself into the second
534 * object, allocating what needs to be allocated. Basically, any 474 * object, allocating what needs to be allocated. Basically, any
535 * data that is malloc'd needs to be re-malloc/copied. Otherwise, 475 * data that is malloc'd needs to be re-malloc/copied. Otherwise,
541{ 481{
542 bool is_freed = QUERY_FLAG (dst, FLAG_FREED); 482 bool is_freed = QUERY_FLAG (dst, FLAG_FREED);
543 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED); 483 bool is_removed = QUERY_FLAG (dst, FLAG_REMOVED);
544 484
545 *(object_copy *)dst = *this; 485 *(object_copy *)dst = *this;
546 *(object_pod *)dst = *this;
547
548 if (self || cb)
549 INVOKE_OBJECT (CLONE, this, ARG_OBJECT (dst));
550 486
551 if (is_freed) 487 if (is_freed)
552 SET_FLAG (dst, FLAG_FREED); 488 SET_FLAG (dst, FLAG_FREED);
553 489
554 if (is_removed) 490 if (is_removed)
585 tail = new_link; 521 tail = new_link;
586 } 522 }
587 } 523 }
588 } 524 }
589 525
590 update_ob_speed (dst); 526 dst->set_speed (dst->speed);
527}
528
529object *
530object::clone ()
531{
532 object *neu = create ();
533 copy_to (neu);
534 return neu;
591} 535}
592 536
593/* 537/*
594 * If an object with the IS_TURNABLE() flag needs to be turned due 538 * If an object with the IS_TURNABLE() flag needs to be turned due
595 * to the closest player being on the other side, this function can 539 * to the closest player being on the other side, this function can
596 * be called to update the face variable, _and_ how it looks on the map. 540 * be called to update the face variable, _and_ how it looks on the map.
597 */ 541 */
598
599void 542void
600update_turn_face (object *op) 543update_turn_face (object *op)
601{ 544{
602 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || op->arch == NULL) 545 if (!QUERY_FLAG (op, FLAG_IS_TURNABLE) || !op->arch)
603 return; 546 return;
547
604 SET_ANIMATION (op, op->direction); 548 SET_ANIMATION (op, op->direction);
605 update_object (op, UP_OBJ_FACE); 549 update_object (op, UP_OBJ_FACE);
606} 550}
607 551
608/* 552/*
609 * Updates the speed of an object. If the speed changes from 0 to another 553 * Updates the speed of an object. If the speed changes from 0 to another
610 * value, or vice versa, then add/remove the object from the active list. 554 * value, or vice versa, then add/remove the object from the active list.
611 * This function needs to be called whenever the speed of an object changes. 555 * This function needs to be called whenever the speed of an object changes.
612 */ 556 */
613void 557void
614update_ob_speed (object *op) 558object::set_speed (float speed)
615{ 559{
616 extern int arch_init; 560 if (flag [FLAG_FREED] && speed)
617
618 /* No reason putting the archetypes objects on the speed list,
619 * since they never really need to be updated.
620 */
621
622 if (QUERY_FLAG (op, FLAG_FREED) && op->speed)
623 { 561 {
624 LOG (llevError, "Object %s is freed but has speed.\n", &op->name); 562 LOG (llevError, "Object %s is freed but has speed.\n", &name);
625#ifdef MANY_CORES
626 abort ();
627#else
628 op->speed = 0; 563 speed = 0;
629#endif
630 }
631
632 if (arch_init)
633 return;
634
635 if (FABS (op->speed) > MIN_ACTIVE_SPEED)
636 { 564 }
637 /* If already on active list, don't do anything */
638 if (op->active_next || op->active_prev || op == active_objects)
639 return;
640 565
641 /* process_events() expects us to insert the object at the beginning 566 this->speed = speed;
642 * of the list. */
643 op->active_next = active_objects;
644 567
645 if (op->active_next != NULL) 568 if (has_active_speed ())
646 op->active_next->active_prev = op; 569 activate ();
647
648 active_objects = op;
649 }
650 else 570 else
651 { 571 deactivate ();
652 /* If not on the active list, nothing needs to be done */
653 if (!op->active_next && !op->active_prev && op != active_objects)
654 return;
655
656 if (op->active_prev == NULL)
657 {
658 active_objects = op->active_next;
659
660 if (op->active_next != NULL)
661 op->active_next->active_prev = NULL;
662 }
663 else
664 {
665 op->active_prev->active_next = op->active_next;
666
667 if (op->active_next)
668 op->active_next->active_prev = op->active_prev;
669 }
670
671 op->active_next = NULL;
672 op->active_prev = NULL;
673 }
674} 572}
675 573
676/* This function removes object 'op' from the list of active
677 * objects.
678 * This should only be used for style maps or other such
679 * reference maps where you don't want an object that isn't
680 * in play chewing up cpu time getting processed.
681 * The reverse of this is to call update_ob_speed, which
682 * will do the right thing based on the speed of the object.
683 */
684void
685remove_from_active_list (object *op)
686{
687 /* If not on the active list, nothing needs to be done */
688 if (!op->active_next && !op->active_prev && op != active_objects)
689 return;
690
691 if (op->active_prev == NULL)
692 {
693 active_objects = op->active_next;
694 if (op->active_next != NULL)
695 op->active_next->active_prev = NULL;
696 }
697 else
698 {
699 op->active_prev->active_next = op->active_next;
700 if (op->active_next)
701 op->active_next->active_prev = op->active_prev;
702 }
703 op->active_next = NULL;
704 op->active_prev = NULL;
705}
706
707/* 574/*
708 * update_object() updates the array which represents the map. 575 * update_object() updates the the map.
709 * It takes into account invisible objects (and represent squares covered 576 * It takes into account invisible objects (and represent squares covered
710 * by invisible objects by whatever is below them (unless it's another 577 * by invisible objects by whatever is below them (unless it's another
711 * invisible object, etc...) 578 * invisible object, etc...)
712 * If the object being updated is beneath a player, the look-window 579 * If the object being updated is beneath a player, the look-window
713 * of that player is updated (this might be a suboptimal way of 580 * of that player is updated (this might be a suboptimal way of
714 * updating that window, though, since update_object() is called _often_) 581 * updating that window, though, since update_object() is called _often_)
715 * 582 *
716 * action is a hint of what the caller believes need to be done. 583 * action is a hint of what the caller believes need to be done.
717 * For example, if the only thing that has changed is the face (due to
718 * an animation), we don't need to call update_position until that actually
719 * comes into view of a player. OTOH, many other things, like addition/removal
720 * of walls or living creatures may need us to update the flags now.
721 * current action are: 584 * current action are:
722 * UP_OBJ_INSERT: op was inserted 585 * UP_OBJ_INSERT: op was inserted
723 * UP_OBJ_REMOVE: op was removed 586 * UP_OBJ_REMOVE: op was removed
724 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update 587 * UP_OBJ_CHANGE: object has somehow changed. In this case, we always update
725 * as that is easier than trying to look at what may have changed. 588 * as that is easier than trying to look at what may have changed.
726 * UP_OBJ_FACE: only the objects face has changed. 589 * UP_OBJ_FACE: only the objects face has changed.
727 */ 590 */
728
729void 591void
730update_object (object *op, int action) 592update_object (object *op, int action)
731{ 593{
732 int update_now = 0, flags;
733 MoveType move_on, move_off, move_block, move_slow; 594 MoveType move_on, move_off, move_block, move_slow;
734 595
735 if (op == NULL) 596 if (op == NULL)
736 { 597 {
737 /* this should never happen */ 598 /* this should never happen */
738 LOG (llevDebug, "update_object() called for NULL object.\n"); 599 LOG (llevDebug, "update_object() called for NULL object.\n");
739 return; 600 return;
740 } 601 }
741 602
742 if (op->env != NULL) 603 if (op->env)
743 { 604 {
744 /* Animation is currently handled by client, so nothing 605 /* Animation is currently handled by client, so nothing
745 * to do in this case. 606 * to do in this case.
746 */ 607 */
747 return; 608 return;
752 */ 613 */
753 if (!op->map || op->map->in_memory == MAP_SAVING) 614 if (!op->map || op->map->in_memory == MAP_SAVING)
754 return; 615 return;
755 616
756 /* make sure the object is within map boundaries */ 617 /* make sure the object is within map boundaries */
757 if (op->x < 0 || op->x >= MAP_WIDTH (op->map) || op->y < 0 || op->y >= MAP_HEIGHT (op->map)) 618 if (op->x < 0 || op->x >= op->map->width || op->y < 0 || op->y >= op->map->height)
758 { 619 {
759 LOG (llevError, "update_object() called for object out of map!\n"); 620 LOG (llevError, "update_object() called for object out of map!\n");
760#ifdef MANY_CORES 621#ifdef MANY_CORES
761 abort (); 622 abort ();
762#endif 623#endif
763 return; 624 return;
764 } 625 }
765 626
766 flags = GET_MAP_FLAGS (op->map, op->x, op->y); 627 mapspace &m = op->ms ();
767 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NEED_UPDATE);
768 move_slow = GET_MAP_MOVE_SLOW (op->map, op->x, op->y);
769 move_on = GET_MAP_MOVE_ON (op->map, op->x, op->y);
770 move_block = GET_MAP_MOVE_BLOCK (op->map, op->x, op->y);
771 move_off = GET_MAP_MOVE_OFF (op->map, op->x, op->y);
772 628
629 if (!(m.flags_ & P_UPTODATE))
630 /* nop */;
773 if (action == UP_OBJ_INSERT) 631 else if (action == UP_OBJ_INSERT)
774 { 632 {
633 // this is likely overkill, TODO: revisit (schmorp)
775 if (QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(flags & P_BLOCKSVIEW)) 634 if ((QUERY_FLAG (op, FLAG_BLOCKSVIEW) && !(m.flags_ & P_BLOCKSVIEW))
776 update_now = 1;
777
778 if (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(flags & P_NO_MAGIC)) 635 || (QUERY_FLAG (op, FLAG_NO_MAGIC) && !(m.flags_ & P_NO_MAGIC))
779 update_now = 1; 636 || (op->type == PLAYER && !(m.flags_ & P_PLAYER))
780 637 || (op->type == SAFE_GROUND && !(m.flags_ & P_SAFE))
638 || (QUERY_FLAG (op, FLAG_ALIVE) && !(m.flags_ & P_IS_ALIVE))
781 if (QUERY_FLAG (op, FLAG_DAMNED) && !(flags & P_NO_CLERIC)) 639 || (QUERY_FLAG (op, FLAG_DAMNED) && !(m.flags_ & P_NO_CLERIC))
782 update_now = 1;
783
784 if (QUERY_FLAG (op, FLAG_ALIVE) && !(flags & P_IS_ALIVE))
785 update_now = 1;
786
787 if (op->type == SAFE_GROUND && !(flags & P_SAFE))
788 update_now = 1;
789
790 if ((move_on | op->move_on) != move_on) 640 || (m.move_on | op->move_on ) != m.move_on
791 update_now = 1;
792
793 if ((move_off | op->move_off) != move_off) 641 || (m.move_off | op->move_off ) != m.move_off
794 update_now = 1; 642 || (m.move_slow | op->move_slow) != m.move_slow
795
796 /* This isn't perfect, but I don't expect a lot of objects to 643 /* This isn't perfect, but I don't expect a lot of objects to
797 * to have move_allow right now. 644 * to have move_allow right now.
798 */ 645 */
799 if (((move_block | op->move_block) & ~op->move_allow) != move_block) 646 || ((m.move_block | op->move_block) & ~op->move_allow) != m.move_block
800 update_now = 1; 647 || 1) // the above is not strong enough a test to skip updating. los maybe? TODO (Schmorp)
801 648 m.flags_ = 0;
802 if ((move_slow | op->move_slow) != move_slow)
803 update_now = 1;
804 } 649 }
805
806 /* if the object is being removed, we can't make intelligent 650 /* if the object is being removed, we can't make intelligent
807 * decisions, because remove_ob can't really pass the object 651 * decisions, because remove_ob can't really pass the object
808 * that is being removed. 652 * that is being removed.
809 */ 653 */
810 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE) 654 else if (action == UP_OBJ_CHANGE || action == UP_OBJ_REMOVE)
811 update_now = 1; 655 m.flags_ = 0;
812 else if (action == UP_OBJ_FACE) 656 else if (action == UP_OBJ_FACE)
813 /* Nothing to do for that case */ ; 657 /* Nothing to do for that case */ ;
814 else 658 else
815 LOG (llevError, "update_object called with invalid action: %d\n", action); 659 LOG (llevError, "update_object called with invalid action: %d\n", action);
816 660
817 if (update_now)
818 {
819 SET_MAP_FLAGS (op->map, op->x, op->y, flags | P_NO_ERROR | P_NEED_UPDATE);
820 update_position (op->map, op->x, op->y);
821 }
822
823 if (op->more != NULL) 661 if (op->more)
824 update_object (op->more, action); 662 update_object (op->more, action);
825} 663}
826 664
827object::vector object::mortals;
828object::vector object::objects; // not yet used
829object *object::first; 665object *object::first;
830
831void object::free_mortals ()
832{
833 for (AUTODECL (i, mortals.begin ()); i != mortals.end ();)
834 if ((*i)->refcnt)
835 ++i; // further delay freeing
836 else
837 {
838 delete *i;
839 mortals.erase (i);
840 }
841}
842 666
843object::object () 667object::object ()
844{ 668{
845 SET_FLAG (this, FLAG_REMOVED); 669 SET_FLAG (this, FLAG_REMOVED);
846 670
851object::~object () 675object::~object ()
852{ 676{
853 free_key_values (this); 677 free_key_values (this);
854} 678}
855 679
680static int object_count;
681
856void object::link () 682void object::link ()
857{ 683{
858 count = ++ob_count; 684 assert (!index);//D
859 uuid = gen_uuid (); 685 uuid = gen_uuid ();
686 count = ++object_count;
860 687
861 prev = 0; 688 refcnt_inc ();
862 next = object::first; 689 objects.insert (this);
863
864 if (object::first)
865 object::first->prev = this;
866
867 object::first = this;
868} 690}
869 691
870void object::unlink () 692void object::unlink ()
871{ 693{
872 if (this == object::first) 694 assert (index);//D
873 object::first = next; 695 objects.erase (this);
696 refcnt_dec ();
697}
874 698
875 /* Remove this object from the list of used objects */ 699void
876 if (prev) prev->next = next; 700object::activate ()
877 if (next) next->prev = prev; 701{
702 /* If already on active list, don't do anything */
703 if (active)
704 return;
878 705
879 prev = 0; 706 if (has_active_speed ())
880 next = 0; 707 actives.insert (this);
708}
709
710void
711object::activate_recursive ()
712{
713 activate ();
714
715 for (object *op = inv; op; op = op->below)
716 op->activate_recursive ();
717}
718
719/* This function removes object 'op' from the list of active
720 * objects.
721 * This should only be used for style maps or other such
722 * reference maps where you don't want an object that isn't
723 * in play chewing up cpu time getting processed.
724 * The reverse of this is to call update_ob_speed, which
725 * will do the right thing based on the speed of the object.
726 */
727void
728object::deactivate ()
729{
730 /* If not on the active list, nothing needs to be done */
731 if (!active)
732 return;
733
734 actives.erase (this);
735}
736
737void
738object::deactivate_recursive ()
739{
740 for (object *op = inv; op; op = op->below)
741 op->deactivate_recursive ();
742
743 deactivate ();
744}
745
746void
747object::set_flag_inv (int flag, int value)
748{
749 for (object *op = inv; op; op = op->below)
750 {
751 op->flag [flag] = value;
752 op->set_flag_inv (flag, value);
753 }
754}
755
756/*
757 * Remove and free all objects in the inventory of the given object.
758 * object.c ?
759 */
760void
761object::destroy_inv (bool drop_to_ground)
762{
763 // need to check first, because the checks below might segfault
764 // as we might be on an invalid mapspace and crossfire code
765 // is too buggy to ensure that the inventory is empty.
766 // corollary: if you create arrows etc. with stuff in tis inventory,
767 // cf will crash below with off-map x and y
768 if (!inv)
769 return;
770
771 /* Only if the space blocks everything do we not process -
772 * if some form of movement is allowed, let objects
773 * drop on that space.
774 */
775 if (!drop_to_ground
776 || !map
777 || map->in_memory != MAP_IN_MEMORY
778 || ms ().move_block == MOVE_ALL)
779 {
780 while (inv)
781 {
782 inv->destroy_inv (drop_to_ground);
783 inv->destroy ();
784 }
785 }
786 else
787 { /* Put objects in inventory onto this space */
788 while (inv)
789 {
790 object *op = inv;
791
792 if (op->flag [FLAG_STARTEQUIP]
793 || op->flag [FLAG_NO_DROP]
794 || op->type == RUNE
795 || op->type == TRAP
796 || op->flag [FLAG_IS_A_TEMPLATE]
797 || op->flag [FLAG_DESTROY_ON_DEATH])
798 op->destroy ();
799 else
800 map->insert (op, x, y);
801 }
802 }
881} 803}
882 804
883object *object::create () 805object *object::create ()
884{ 806{
885 object *op = new object; 807 object *op = new object;
886 op->link (); 808 op->link ();
887 return op; 809 return op;
888} 810}
889 811
890/* 812void
891 * free_object() frees everything allocated by an object, removes 813object::do_destroy ()
892 * it from the list of used objects, and puts it on the list of
893 * free objects. The IS_FREED() flag is set in the object.
894 * The object must have been removed by remove_ob() first for
895 * this function to succeed.
896 *
897 * If destroy_inventory is set, free inventory as well. Else drop items in
898 * inventory to the ground.
899 */
900void object::destroy (bool destroy_inventory)
901{ 814{
902 if (QUERY_FLAG (this, FLAG_FREED)) 815 attachable::do_destroy ();
903 return;
904 816
905 if (QUERY_FLAG (this, FLAG_FRIENDLY)) 817 if (flag [FLAG_IS_LINKED])
818 remove_button_link (this);
819
820 if (flag [FLAG_FRIENDLY])
906 remove_friendly_object (this); 821 remove_friendly_object (this);
907 822
908 if (!QUERY_FLAG (this, FLAG_REMOVED)) 823 if (!flag [FLAG_REMOVED])
909 remove (); 824 remove ();
910 825
911 SET_FLAG (this, FLAG_FREED); 826 destroy_inv (true);
912 827
913 if (more) 828 deactivate ();
914 { 829 unlink ();
915 more->destroy (destroy_inventory);
916 more = 0;
917 }
918 830
919 if (inv) 831 flag [FLAG_FREED] = 1;
920 {
921 /* Only if the space blocks everything do we not process -
922 * if some form of movement is allowed, let objects
923 * drop on that space.
924 */
925 if (destroy_inventory || !map || map->in_memory != MAP_IN_MEMORY || GET_MAP_MOVE_BLOCK (map, x, y) == MOVE_ALL)
926 {
927 object *op = inv;
928
929 while (op)
930 {
931 object *tmp = op->below;
932 op->destroy (destroy_inventory);
933 op = tmp;
934 }
935 }
936 else
937 { /* Put objects in inventory onto this space */
938 object *op = inv;
939
940 while (op)
941 {
942 object *tmp = op->below;
943
944 op->remove ();
945
946 if (QUERY_FLAG (op, FLAG_STARTEQUIP)
947 || QUERY_FLAG (op, FLAG_NO_DROP) || op->type == RUNE || op->type == TRAP || QUERY_FLAG (op, FLAG_IS_A_TEMPLATE))
948 op->destroy ();
949 else
950 {
951 op->x = x;
952 op->y = y;
953 insert_ob_in_map (op, map, 0, 0); /* Insert in same map as the envir */
954 }
955
956 op = tmp;
957 }
958 }
959 }
960 832
961 // hack to ensure that freed objects still have a valid map 833 // hack to ensure that freed objects still have a valid map
962 { 834 {
963 static maptile *freed_map; // freed objects are moved here to avoid crashes 835 static maptile *freed_map; // freed objects are moved here to avoid crashes
964 836
968 840
969 freed_map->name = "/internal/freed_objects_map"; 841 freed_map->name = "/internal/freed_objects_map";
970 freed_map->width = 3; 842 freed_map->width = 3;
971 freed_map->height = 3; 843 freed_map->height = 3;
972 844
973 freed_map->allocate (); 845 freed_map->alloc ();
846 freed_map->in_memory = MAP_IN_MEMORY;
974 } 847 }
975 848
976 map = freed_map; 849 map = freed_map;
977 x = 1; 850 x = 1;
978 y = 1; 851 y = 1;
979 } 852 }
980 853
854 head = 0;
855
856 if (more)
857 {
858 more->destroy ();
859 more = 0;
860 }
861
981 // clear those pointers that likely might have circular references to us 862 // clear those pointers that likely might have circular references to us
982 owner = 0; 863 owner = 0;
983 enemy = 0; 864 enemy = 0;
984 attacked_by = 0; 865 attacked_by = 0;
866}
985 867
986 // only relevant for players(?), but make sure of it anyways 868void
987 contr = 0; 869object::destroy (bool destroy_inventory)
870{
871 if (destroyed ())
872 return;
988 873
989 /* Remove object from the active list */ 874 if (destroy_inventory)
990 speed = 0; 875 destroy_inv (false);
991 update_ob_speed (this);
992 876
993 unlink (); 877 attachable::destroy ();
994
995 mortals.push_back (this);
996} 878}
997 879
998/* 880/*
999 * sub_weight() recursively (outwards) subtracts a number from the 881 * sub_weight() recursively (outwards) subtracts a number from the
1000 * weight of an object (and what is carried by it's environment(s)). 882 * weight of an object (and what is carried by it's environment(s)).
1024object::remove () 906object::remove ()
1025{ 907{
1026 object *tmp, *last = 0; 908 object *tmp, *last = 0;
1027 object *otmp; 909 object *otmp;
1028 910
1029 int check_walk_off;
1030
1031 if (QUERY_FLAG (this, FLAG_REMOVED)) 911 if (QUERY_FLAG (this, FLAG_REMOVED))
1032 return; 912 return;
1033 913
1034 SET_FLAG (this, FLAG_REMOVED); 914 SET_FLAG (this, FLAG_REMOVED);
915 INVOKE_OBJECT (REMOVE, this);
1035 916
1036 if (more) 917 if (more)
1037 more->remove (); 918 more->remove ();
1038 919
1039 /* 920 /*
1049 930
1050 /* NO_FIX_PLAYER is set when a great many changes are being 931 /* NO_FIX_PLAYER is set when a great many changes are being
1051 * made to players inventory. If set, avoiding the call 932 * made to players inventory. If set, avoiding the call
1052 * to save cpu time. 933 * to save cpu time.
1053 */ 934 */
1054 if ((otmp = is_player_inv (env)) != NULL && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 935 if ((otmp = in_player ()) && otmp->contr && !QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1055 fix_player (otmp); 936 otmp->update_stats ();
1056 937
1057 if (above != NULL) 938 if (above)
1058 above->below = below; 939 above->below = below;
1059 else 940 else
1060 env->inv = below; 941 env->inv = below;
1061 942
1062 if (below != NULL) 943 if (below)
1063 below->above = above; 944 below->above = above;
1064 945
1065 /* we set up values so that it could be inserted into 946 /* we set up values so that it could be inserted into
1066 * the map, but we don't actually do that - it is up 947 * the map, but we don't actually do that - it is up
1067 * to the caller to decide what we want to do. 948 * to the caller to decide what we want to do.
1071 above = 0, below = 0; 952 above = 0, below = 0;
1072 env = 0; 953 env = 0;
1073 } 954 }
1074 else if (map) 955 else if (map)
1075 { 956 {
1076 /* Re did the following section of code - it looks like it had 957 if (type == PLAYER)
1077 * lots of logic for things we no longer care about
1078 */ 958 {
959 --map->players;
960 map->touch ();
961 }
962
963 map->dirty = true;
1079 964
1080 /* link the object above us */ 965 /* link the object above us */
1081 if (above) 966 if (above)
1082 above->below = below; 967 above->below = below;
1083 else 968 else
1084 SET_MAP_TOP (map, x, y, below); /* we were top, set new top */ 969 map->at (x, y).top = below; /* we were top, set new top */
1085 970
1086 /* Relink the object below us, if there is one */ 971 /* Relink the object below us, if there is one */
1087 if (below) 972 if (below)
1088 below->above = above; 973 below->above = above;
1089 else 974 else
1101 dump = dump_object (GET_MAP_OB (map, x, y)); 986 dump = dump_object (GET_MAP_OB (map, x, y));
1102 LOG (llevError, "%s\n", dump); 987 LOG (llevError, "%s\n", dump);
1103 free (dump); 988 free (dump);
1104 } 989 }
1105 990
1106 SET_MAP_OB (map, x, y, above); /* goes on above it. */ 991 map->at (x, y).bot = above; /* goes on above it. */
1107 } 992 }
1108 993
1109 above = 0; 994 above = 0;
1110 below = 0; 995 below = 0;
1111 996
1112 if (map->in_memory == MAP_SAVING) 997 if (map->in_memory == MAP_SAVING)
1113 return; 998 return;
1114 999
1115 check_walk_off = !QUERY_FLAG (this, FLAG_NO_APPLY); 1000 int check_walk_off = !flag [FLAG_NO_APPLY];
1116 1001
1117 for (tmp = GET_MAP_OB (map, x, y); tmp; tmp = tmp->above) 1002 for (tmp = map->at (x, y).bot; tmp; tmp = tmp->above)
1118 { 1003 {
1119 /* No point updating the players look faces if he is the object 1004 /* No point updating the players look faces if he is the object
1120 * being removed. 1005 * being removed.
1121 */ 1006 */
1122 1007
1126 * removed (most likely destroyed), update the player view 1011 * removed (most likely destroyed), update the player view
1127 * appropriately. 1012 * appropriately.
1128 */ 1013 */
1129 if (tmp->container == this) 1014 if (tmp->container == this)
1130 { 1015 {
1131 CLEAR_FLAG (this, FLAG_APPLIED); 1016 flag [FLAG_APPLIED] = 0;
1132 tmp->container = 0; 1017 tmp->container = 0;
1133 } 1018 }
1134 1019
1135 tmp->contr->socket.update_look = 1; 1020 if (tmp->contr->ns)
1021 tmp->contr->ns->floorbox_update ();
1136 } 1022 }
1137 1023
1138 /* See if player moving off should effect something */ 1024 /* See if object moving off should effect something */
1139 if (check_walk_off 1025 if (check_walk_off
1140 && ((move_type & tmp->move_off) 1026 && ((move_type & tmp->move_off)
1141 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0)) 1027 && (move_type & ~tmp->move_off & ~tmp->move_block) == 0))
1142 { 1028 {
1143 move_apply (tmp, this, 0); 1029 move_apply (tmp, this, 0);
1145 if (destroyed ()) 1031 if (destroyed ())
1146 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ()); 1032 LOG (llevError, "BUG: remove_ob(): name %s, destroyed leaving object\n", tmp->debug_desc ());
1147 } 1033 }
1148 1034
1149 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */ 1035 /* Eneq(@csd.uu.se): Fixed this to skip tmp->above=tmp */
1150 1036 //TODO: why is this horrible hacka fix? get rid of this code=bug! (schmorp)
1151 if (tmp->above == tmp) 1037 if (tmp->above == tmp)
1152 tmp->above = 0; 1038 tmp->above = 0;
1153 1039
1154 last = tmp; 1040 last = tmp;
1155 } 1041 }
1156 1042
1157 /* last == NULL of there are no objects on this space */ 1043 /* last == NULL if there are no objects on this space */
1044 //TODO: this makes little sense, why only update the topmost object?
1158 if (!last) 1045 if (!last)
1159 { 1046 map->at (x, y).flags_ = 0;
1160 /* set P_NEED_UPDATE, otherwise update_position will complain. In theory,
1161 * we could preserve the flags (GET_MAP_FLAGS), but update_position figures
1162 * those out anyways, and if there are any flags set right now, they won't
1163 * be correct anyways.
1164 */
1165 SET_MAP_FLAGS (map, x, y, P_NEED_UPDATE);
1166 update_position (map, x, y);
1167 }
1168 else 1047 else
1169 update_object (last, UP_OBJ_REMOVE); 1048 update_object (last, UP_OBJ_REMOVE);
1170 1049
1171 if (QUERY_FLAG (this, FLAG_BLOCKSVIEW) || glow_radius) 1050 if (flag [FLAG_BLOCKSVIEW] || glow_radius)
1172 update_all_los (map, x, y); 1051 update_all_los (map, x, y);
1173 } 1052 }
1174} 1053}
1175 1054
1176/* 1055/*
1185merge_ob (object *op, object *top) 1064merge_ob (object *op, object *top)
1186{ 1065{
1187 if (!op->nrof) 1066 if (!op->nrof)
1188 return 0; 1067 return 0;
1189 1068
1190 if (top == NULL) 1069 if (top)
1191 for (top = op; top != NULL && top->above != NULL; top = top->above); 1070 for (top = op; top && top->above; top = top->above)
1071 ;
1192 1072
1193 for (; top != NULL; top = top->below) 1073 for (; top; top = top->below)
1194 { 1074 {
1195 if (top == op) 1075 if (top == op)
1196 continue; 1076 continue;
1197 if (CAN_MERGE (op, top)) 1077
1078 if (object::can_merge (op, top))
1198 { 1079 {
1199 top->nrof += op->nrof; 1080 top->nrof += op->nrof;
1200 1081
1201/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/ 1082/* CLEAR_FLAG(top,FLAG_STARTEQUIP);*/
1202 op->weight = 0; /* Don't want any adjustements now */ 1083 op->weight = 0; /* Don't want any adjustements now */
1213 * job preparing multi-part monsters 1094 * job preparing multi-part monsters
1214 */ 1095 */
1215object * 1096object *
1216insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y) 1097insert_ob_in_map_at (object *op, maptile *m, object *originator, int flag, int x, int y)
1217{ 1098{
1218 object *tmp;
1219
1220 if (op->head)
1221 op = op->head;
1222
1223 for (tmp = op; tmp; tmp = tmp->more) 1099 for (object *tmp = op->head_ (); tmp; tmp = tmp->more)
1224 { 1100 {
1225 tmp->x = x + tmp->arch->clone.x; 1101 tmp->x = x + tmp->arch->clone.x;
1226 tmp->y = y + tmp->arch->clone.y; 1102 tmp->y = y + tmp->arch->clone.y;
1227 } 1103 }
1228 1104
1247 * Return value: 1123 * Return value:
1248 * new object if 'op' was merged with other object 1124 * new object if 'op' was merged with other object
1249 * NULL if 'op' was destroyed 1125 * NULL if 'op' was destroyed
1250 * just 'op' otherwise 1126 * just 'op' otherwise
1251 */ 1127 */
1252
1253object * 1128object *
1254insert_ob_in_map (object *op, maptile *m, object *originator, int flag) 1129insert_ob_in_map (object *op, maptile *m, object *originator, int flag)
1255{ 1130{
1256 object *tmp, *top, *floor = NULL; 1131 object *tmp, *top, *floor = NULL;
1257 sint16 x, y; 1132 sint16 x, y;
1260 { 1135 {
1261 LOG (llevError, "Trying to insert freed object!\n"); 1136 LOG (llevError, "Trying to insert freed object!\n");
1262 return NULL; 1137 return NULL;
1263 } 1138 }
1264 1139
1265 if (m == NULL) 1140 if (!m)
1266 { 1141 {
1267 char *dump = dump_object (op); 1142 char *dump = dump_object (op);
1268 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump); 1143 LOG (llevError, "Trying to insert in null-map!\n%s\n", dump);
1269 free (dump); 1144 free (dump);
1270 return op; 1145 return op;
1291 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump); 1166 LOG (llevError, "Trying to insert (map) inserted object.\n%s\n", dump);
1292 free (dump); 1167 free (dump);
1293 return op; 1168 return op;
1294 } 1169 }
1295 1170
1296 if (op->more != NULL) 1171 if (op->more)
1297 { 1172 {
1298 /* The part may be on a different map. */ 1173 /* The part may be on a different map. */
1299 1174
1300 object *more = op->more; 1175 object *more = op->more;
1301 1176
1302 /* We really need the caller to normalize coordinates - if 1177 /* We really need the caller to normalise coordinates - if
1303 * we set the map, that doesn't work if the location is within 1178 * we set the map, that doesn't work if the location is within
1304 * a map and this is straddling an edge. So only if coordinate 1179 * a map and this is straddling an edge. So only if coordinate
1305 * is clear wrong do we normalize it. 1180 * is clear wrong do we normalise it.
1306 */ 1181 */
1307 if (OUT_OF_REAL_MAP (more->map, more->x, more->y)) 1182 if (OUT_OF_REAL_MAP (more->map, more->x, more->y))
1308 more->map = get_map_from_coord (m, &more->x, &more->y); 1183 more->map = get_map_from_coord (m, &more->x, &more->y);
1309 else if (!more->map) 1184 else if (!more->map)
1310 { 1185 {
1317 if (insert_ob_in_map (more, more->map, originator, flag) == NULL) 1192 if (insert_ob_in_map (more, more->map, originator, flag) == NULL)
1318 { 1193 {
1319 if (!op->head) 1194 if (!op->head)
1320 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n"); 1195 LOG (llevError, "BUG: insert_ob_in_map(): inserting op->more killed op\n");
1321 1196
1322 return NULL; 1197 return 0;
1323 } 1198 }
1324 } 1199 }
1325 1200
1326 CLEAR_FLAG (op, FLAG_REMOVED); 1201 CLEAR_FLAG (op, FLAG_REMOVED);
1327 1202
1334 y = op->y; 1209 y = op->y;
1335 1210
1336 /* this has to be done after we translate the coordinates. 1211 /* this has to be done after we translate the coordinates.
1337 */ 1212 */
1338 if (op->nrof && !(flag & INS_NO_MERGE)) 1213 if (op->nrof && !(flag & INS_NO_MERGE))
1339 for (tmp = GET_MAP_OB (op->map, x, y); tmp != NULL; tmp = tmp->above) 1214 for (tmp = GET_MAP_OB (op->map, x, y); tmp; tmp = tmp->above)
1340 if (CAN_MERGE (op, tmp)) 1215 if (object::can_merge (op, tmp))
1341 { 1216 {
1342 op->nrof += tmp->nrof; 1217 op->nrof += tmp->nrof;
1343 tmp->destroy (); 1218 tmp->destroy ();
1344 } 1219 }
1345 1220
1361 op->below = originator->below; 1236 op->below = originator->below;
1362 1237
1363 if (op->below) 1238 if (op->below)
1364 op->below->above = op; 1239 op->below->above = op;
1365 else 1240 else
1366 SET_MAP_OB (op->map, op->x, op->y, op); 1241 op->ms ().bot = op;
1367 1242
1368 /* since *below* originator, no need to update top */ 1243 /* since *below* originator, no need to update top */
1369 originator->below = op; 1244 originator->below = op;
1370 } 1245 }
1371 else 1246 else
1372 { 1247 {
1373 /* If there are other objects, then */ 1248 /* If there are other objects, then */
1374 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL)) 1249 if ((!(flag & INS_MAP_LOAD)) && ((top = GET_MAP_OB (op->map, op->x, op->y)) != NULL))
1375 { 1250 {
1376 object *last = NULL; 1251 object *last = 0;
1377 1252
1378 /* 1253 /*
1379 * If there are multiple objects on this space, we do some trickier handling. 1254 * If there are multiple objects on this space, we do some trickier handling.
1380 * We've already dealt with merging if appropriate. 1255 * We've already dealt with merging if appropriate.
1381 * Generally, we want to put the new object on top. But if 1256 * Generally, we want to put the new object on top. But if
1385 * once we get to them. This reduces the need to traverse over all of 1260 * once we get to them. This reduces the need to traverse over all of
1386 * them when adding another one - this saves quite a bit of cpu time 1261 * them when adding another one - this saves quite a bit of cpu time
1387 * when lots of spells are cast in one area. Currently, it is presumed 1262 * when lots of spells are cast in one area. Currently, it is presumed
1388 * that flying non pickable objects are spell objects. 1263 * that flying non pickable objects are spell objects.
1389 */ 1264 */
1390
1391 while (top != NULL) 1265 while (top)
1392 { 1266 {
1393 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR)) 1267 if (QUERY_FLAG (top, FLAG_IS_FLOOR) || QUERY_FLAG (top, FLAG_OVERLAY_FLOOR))
1394 floor = top; 1268 floor = top;
1395 1269
1396 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR)) 1270 if (QUERY_FLAG (top, FLAG_NO_PICK) && (top->move_type & (MOVE_FLY_LOW | MOVE_FLY_HIGH)) && !QUERY_FLAG (top, FLAG_IS_FLOOR))
1417 * If INS_ON_TOP is used, don't do this processing 1291 * If INS_ON_TOP is used, don't do this processing
1418 * Need to find the object that in fact blocks view, otherwise 1292 * Need to find the object that in fact blocks view, otherwise
1419 * stacking is a bit odd. 1293 * stacking is a bit odd.
1420 */ 1294 */
1421 if (!(flag & INS_ON_TOP) && 1295 if (!(flag & INS_ON_TOP) &&
1422 (get_map_flags (op->map, NULL, op->x, op->y, NULL, NULL) & P_BLOCKSVIEW) && (op->face && !op->face->visibility)) 1296 (get_map_flags (op->map, 0, op->x, op->y, 0, 0) & P_BLOCKSVIEW) && (op->face && !op->face->visibility))
1423 { 1297 {
1424 for (last = top; last != floor; last = last->below) 1298 for (last = top; last != floor; last = last->below)
1425 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT)) 1299 if (QUERY_FLAG (last, FLAG_BLOCKSVIEW) && (last->type != EXIT))
1426 break; 1300 break;
1427 /* Check to see if we found the object that blocks view, 1301 /* Check to see if we found the object that blocks view,
1449 op->above = GET_MAP_OB (op->map, op->x, op->y); 1323 op->above = GET_MAP_OB (op->map, op->x, op->y);
1450 1324
1451 if (op->above) 1325 if (op->above)
1452 op->above->below = op; 1326 op->above->below = op;
1453 1327
1454 op->below = NULL; 1328 op->below = 0;
1455 SET_MAP_OB (op->map, op->x, op->y, op); 1329 op->ms ().bot = op;
1456 } 1330 }
1457 else 1331 else
1458 { /* get inserted into the stack above top */ 1332 { /* get inserted into the stack above top */
1459 op->above = top->above; 1333 op->above = top->above;
1460 1334
1463 1337
1464 op->below = top; 1338 op->below = top;
1465 top->above = op; 1339 top->above = op;
1466 } 1340 }
1467 1341
1468 if (op->above == NULL) 1342 if (!op->above)
1469 SET_MAP_TOP (op->map, op->x, op->y, op); 1343 op->ms ().top = op;
1470 } /* else not INS_BELOW_ORIGINATOR */ 1344 } /* else not INS_BELOW_ORIGINATOR */
1471 1345
1472 if (op->type == PLAYER) 1346 if (op->type == PLAYER)
1347 {
1473 op->contr->do_los = 1; 1348 op->contr->do_los = 1;
1349 ++op->map->players;
1350 op->map->touch ();
1351 }
1352
1353 op->map->dirty = true;
1474 1354
1475 /* If we have a floor, we know the player, if any, will be above 1355 /* If we have a floor, we know the player, if any, will be above
1476 * it, so save a few ticks and start from there. 1356 * it, so save a few ticks and start from there.
1477 */ 1357 */
1478 if (!(flag & INS_MAP_LOAD)) 1358 if (!(flag & INS_MAP_LOAD))
1479 for (tmp = floor ? floor : GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1359 if (object *pl = op->ms ().player ())
1480 if (tmp->type == PLAYER) 1360 if (pl->contr->ns)
1481 tmp->contr->socket.update_look = 1; 1361 pl->contr->ns->floorbox_update ();
1482 1362
1483 /* If this object glows, it may affect lighting conditions that are 1363 /* If this object glows, it may affect lighting conditions that are
1484 * visible to others on this map. But update_all_los is really 1364 * visible to others on this map. But update_all_los is really
1485 * an inefficient way to do this, as it means los for all players 1365 * an inefficient way to do this, as it means los for all players
1486 * on the map will get recalculated. The players could very well 1366 * on the map will get recalculated. The players could very well
1487 * be far away from this change and not affected in any way - 1367 * be far away from this change and not affected in any way -
1488 * this should get redone to only look for players within range, 1368 * this should get redone to only look for players within range,
1489 * or just updating the P_NEED_UPDATE for spaces within this area 1369 * or just updating the P_UPTODATE for spaces within this area
1490 * of effect may be sufficient. 1370 * of effect may be sufficient.
1491 */ 1371 */
1492 if (MAP_DARKNESS (op->map) && (op->glow_radius != 0)) 1372 if (op->map->darkness && (op->glow_radius != 0))
1493 update_all_los (op->map, op->x, op->y); 1373 update_all_los (op->map, op->x, op->y);
1494 1374
1495 /* updates flags (blocked, alive, no magic, etc) for this map space */ 1375 /* updates flags (blocked, alive, no magic, etc) for this map space */
1496 update_object (op, UP_OBJ_INSERT); 1376 update_object (op, UP_OBJ_INSERT);
1497 1377
1378 INVOKE_OBJECT (INSERT, op);
1379
1498 /* Don't know if moving this to the end will break anything. However, 1380 /* Don't know if moving this to the end will break anything. However,
1499 * we want to have update_look set above before calling this. 1381 * we want to have floorbox_update called before calling this.
1500 * 1382 *
1501 * check_move_on() must be after this because code called from 1383 * check_move_on() must be after this because code called from
1502 * check_move_on() depends on correct map flags (so functions like 1384 * check_move_on() depends on correct map flags (so functions like
1503 * blocked() and wall() work properly), and these flags are updated by 1385 * blocked() and wall() work properly), and these flags are updated by
1504 * update_object(). 1386 * update_object().
1506 1388
1507 /* if this is not the head or flag has been passed, don't check walk on status */ 1389 /* if this is not the head or flag has been passed, don't check walk on status */
1508 if (!(flag & INS_NO_WALK_ON) && !op->head) 1390 if (!(flag & INS_NO_WALK_ON) && !op->head)
1509 { 1391 {
1510 if (check_move_on (op, originator)) 1392 if (check_move_on (op, originator))
1511 return NULL; 1393 return 0;
1512 1394
1513 /* If we are a multi part object, lets work our way through the check 1395 /* If we are a multi part object, lets work our way through the check
1514 * walk on's. 1396 * walk on's.
1515 */ 1397 */
1516 for (tmp = op->more; tmp != NULL; tmp = tmp->more) 1398 for (tmp = op->more; tmp != NULL; tmp = tmp->more)
1517 if (check_move_on (tmp, originator)) 1399 if (check_move_on (tmp, originator))
1518 return NULL; 1400 return 0;
1519 } 1401 }
1520 1402
1521 return op; 1403 return op;
1522} 1404}
1523 1405
1524/* this function inserts an object in the map, but if it 1406/* this function inserts an object in the map, but if it
1525 * finds an object of its own type, it'll remove that one first. 1407 * finds an object of its own type, it'll remove that one first.
1526 * op is the object to insert it under: supplies x and the map. 1408 * op is the object to insert it under: supplies x and the map.
1527 */ 1409 */
1528void 1410void
1529replace_insert_ob_in_map (const char *arch_string, object *op) 1411replace_insert_ob_in_map (const char *arch_string, object *op)
1530{ 1412{
1531 object * 1413 object *tmp, *tmp1;
1532 tmp;
1533 object *
1534 tmp1;
1535 1414
1536 /* first search for itself and remove any old instances */ 1415 /* first search for itself and remove any old instances */
1537 1416
1538 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL; tmp = tmp->above) 1417 for (tmp = op->ms ().bot; tmp; tmp = tmp->above)
1539 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */ 1418 if (!strcmp (tmp->arch->name, arch_string)) /* same archetype */
1540 tmp->destroy (); 1419 tmp->destroy ();
1541 1420
1542 tmp1 = arch_to_object (archetype::find (arch_string)); 1421 tmp1 = arch_to_object (archetype::find (arch_string));
1543 1422
1544 tmp1->x = op->x; 1423 tmp1->x = op->x;
1545 tmp1->y = op->y; 1424 tmp1->y = op->y;
1546 insert_ob_in_map (tmp1, op->map, op, 0); 1425 insert_ob_in_map (tmp1, op->map, op, 0);
1426}
1427
1428object *
1429object::insert_at (object *where, object *originator, int flags)
1430{
1431 where->map->insert (this, where->x, where->y, originator, flags);
1547} 1432}
1548 1433
1549/* 1434/*
1550 * get_split_ob(ob,nr) splits up ob into two parts. The part which 1435 * get_split_ob(ob,nr) splits up ob into two parts. The part which
1551 * is returned contains nr objects, and the remaining parts contains 1436 * is returned contains nr objects, and the remaining parts contains
1552 * the rest (or is removed and freed if that number is 0). 1437 * the rest (or is removed and freed if that number is 0).
1553 * On failure, NULL is returned, and the reason put into the 1438 * On failure, NULL is returned, and the reason put into the
1554 * global static errmsg array. 1439 * global static errmsg array.
1555 */ 1440 */
1556
1557object * 1441object *
1558get_split_ob (object *orig_ob, uint32 nr) 1442get_split_ob (object *orig_ob, uint32 nr)
1559{ 1443{
1560 object *newob; 1444 object *newob;
1561 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0); 1445 int is_removed = (QUERY_FLAG (orig_ob, FLAG_REMOVED) != 0);
1597 1481
1598object * 1482object *
1599decrease_ob_nr (object *op, uint32 i) 1483decrease_ob_nr (object *op, uint32 i)
1600{ 1484{
1601 object *tmp; 1485 object *tmp;
1602 player *pl;
1603 1486
1604 if (i == 0) /* objects with op->nrof require this check */ 1487 if (i == 0) /* objects with op->nrof require this check */
1605 return op; 1488 return op;
1606 1489
1607 if (i > op->nrof) 1490 if (i > op->nrof)
1608 i = op->nrof; 1491 i = op->nrof;
1609 1492
1610 if (QUERY_FLAG (op, FLAG_REMOVED)) 1493 if (QUERY_FLAG (op, FLAG_REMOVED))
1611 op->nrof -= i; 1494 op->nrof -= i;
1612 else if (op->env != NULL) 1495 else if (op->env)
1613 { 1496 {
1614 /* is this object in the players inventory, or sub container 1497 /* is this object in the players inventory, or sub container
1615 * therein? 1498 * therein?
1616 */ 1499 */
1617 tmp = is_player_inv (op->env); 1500 tmp = op->in_player ();
1618 /* nope. Is this a container the player has opened? 1501 /* nope. Is this a container the player has opened?
1619 * If so, set tmp to that player. 1502 * If so, set tmp to that player.
1620 * IMO, searching through all the players will mostly 1503 * IMO, searching through all the players will mostly
1621 * likely be quicker than following op->env to the map, 1504 * likely be quicker than following op->env to the map,
1622 * and then searching the map for a player. 1505 * and then searching the map for a player.
1623 */ 1506 */
1624 if (!tmp) 1507 if (!tmp)
1625 { 1508 for_all_players (pl)
1626 for (pl = first_player; pl; pl = pl->next)
1627 if (pl->ob->container == op->env) 1509 if (pl->ob->container == op->env)
1510 {
1511 tmp = pl->ob;
1628 break; 1512 break;
1629 if (pl)
1630 tmp = pl->ob;
1631 else
1632 tmp = NULL;
1633 } 1513 }
1634 1514
1635 if (i < op->nrof) 1515 if (i < op->nrof)
1636 { 1516 {
1637 sub_weight (op->env, op->weight * i); 1517 sub_weight (op->env, op->weight * i);
1638 op->nrof -= i; 1518 op->nrof -= i;
1639 if (tmp) 1519 if (tmp)
1640 {
1641 esrv_send_item (tmp, op); 1520 esrv_send_item (tmp, op);
1642 }
1643 } 1521 }
1644 else 1522 else
1645 { 1523 {
1646 op->remove (); 1524 op->remove ();
1647 op->nrof = 0; 1525 op->nrof = 0;
1648 if (tmp) 1526 if (tmp)
1649 {
1650 esrv_del_item (tmp->contr, op->count); 1527 esrv_del_item (tmp->contr, op->count);
1651 }
1652 } 1528 }
1653 } 1529 }
1654 else 1530 else
1655 { 1531 {
1656 object *above = op->above; 1532 object *above = op->above;
1662 op->remove (); 1538 op->remove ();
1663 op->nrof = 0; 1539 op->nrof = 0;
1664 } 1540 }
1665 1541
1666 /* Since we just removed op, op->above is null */ 1542 /* Since we just removed op, op->above is null */
1667 for (tmp = above; tmp != NULL; tmp = tmp->above) 1543 for (tmp = above; tmp; tmp = tmp->above)
1668 if (tmp->type == PLAYER) 1544 if (tmp->type == PLAYER)
1669 { 1545 {
1670 if (op->nrof) 1546 if (op->nrof)
1671 esrv_send_item (tmp, op); 1547 esrv_send_item (tmp, op);
1672 else 1548 else
1677 if (op->nrof) 1553 if (op->nrof)
1678 return op; 1554 return op;
1679 else 1555 else
1680 { 1556 {
1681 op->destroy (); 1557 op->destroy ();
1682 return NULL; 1558 return 0;
1683 } 1559 }
1684} 1560}
1685 1561
1686/* 1562/*
1687 * add_weight(object, weight) adds the specified weight to an object, 1563 * add_weight(object, weight) adds the specified weight to an object,
1747 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL); 1623 CLEAR_FLAG (op, FLAG_OBJ_ORIGINAL);
1748 CLEAR_FLAG (op, FLAG_REMOVED); 1624 CLEAR_FLAG (op, FLAG_REMOVED);
1749 if (op->nrof) 1625 if (op->nrof)
1750 { 1626 {
1751 for (tmp = inv; tmp != NULL; tmp = tmp->below) 1627 for (tmp = inv; tmp != NULL; tmp = tmp->below)
1752 if (CAN_MERGE (tmp, op)) 1628 if (object::can_merge (tmp, op))
1753 { 1629 {
1754 /* return the original object and remove inserted object 1630 /* return the original object and remove inserted object
1755 (client needs the original object) */ 1631 (client needs the original object) */
1756 tmp->nrof += op->nrof; 1632 tmp->nrof += op->nrof;
1757 /* Weight handling gets pretty funky. Since we are adding to 1633 /* Weight handling gets pretty funky. Since we are adding to
1775 add_weight (this, op->weight * op->nrof); 1651 add_weight (this, op->weight * op->nrof);
1776 } 1652 }
1777 else 1653 else
1778 add_weight (this, (op->weight + op->carrying)); 1654 add_weight (this, (op->weight + op->carrying));
1779 1655
1780 otmp = is_player_inv (this); 1656 otmp = this->in_player ();
1781 if (otmp && otmp->contr) 1657 if (otmp && otmp->contr)
1782 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER)) 1658 if (!QUERY_FLAG (otmp, FLAG_NO_FIX_PLAYER))
1783 fix_player (otmp); 1659 otmp->update_stats ();
1784 1660
1785 op->map = NULL; 1661 op->map = 0;
1786 op->env = this; 1662 op->env = this;
1787 op->above = NULL; 1663 op->above = 0;
1788 op->below = NULL; 1664 op->below = 0;
1789 op->x = 0, op->y = 0; 1665 op->x = 0, op->y = 0;
1790 1666
1791 /* reset the light list and los of the players on the map */ 1667 /* reset the light list and los of the players on the map */
1792 if ((op->glow_radius != 0) && map) 1668 if ((op->glow_radius != 0) && map)
1793 { 1669 {
1794#ifdef DEBUG_LIGHTS 1670#ifdef DEBUG_LIGHTS
1795 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name); 1671 LOG (llevDebug, " insert_ob_in_ob(): got %s to insert in map/op\n", op->name);
1796#endif /* DEBUG_LIGHTS */ 1672#endif /* DEBUG_LIGHTS */
1797 if (MAP_DARKNESS (map)) 1673 if (map->darkness)
1798 update_all_los (map, x, y); 1674 update_all_los (map, x, y);
1799 } 1675 }
1800 1676
1801 /* Client has no idea of ordering so lets not bother ordering it here. 1677 /* Client has no idea of ordering so lets not bother ordering it here.
1802 * It sure simplifies this function... 1678 * It sure simplifies this function...
1807 { 1683 {
1808 op->below = inv; 1684 op->below = inv;
1809 op->below->above = op; 1685 op->below->above = op;
1810 inv = op; 1686 inv = op;
1811 } 1687 }
1688
1689 INVOKE_OBJECT (INSERT, this);
1812 1690
1813 return op; 1691 return op;
1814} 1692}
1815 1693
1816/* 1694/*
1831 * 1709 *
1832 * MSW 2001-07-08: Check all objects on space, not just those below 1710 * MSW 2001-07-08: Check all objects on space, not just those below
1833 * object being inserted. insert_ob_in_map may not put new objects 1711 * object being inserted. insert_ob_in_map may not put new objects
1834 * on top. 1712 * on top.
1835 */ 1713 */
1836
1837int 1714int
1838check_move_on (object *op, object *originator) 1715check_move_on (object *op, object *originator)
1839{ 1716{
1840 object *tmp; 1717 object *tmp;
1841 maptile *m = op->map; 1718 maptile *m = op->map;
1868 1745
1869 /* The objects have to be checked from top to bottom. 1746 /* The objects have to be checked from top to bottom.
1870 * Hence, we first go to the top: 1747 * Hence, we first go to the top:
1871 */ 1748 */
1872 1749
1873 for (tmp = GET_MAP_OB (op->map, op->x, op->y); tmp != NULL && tmp->above != NULL; tmp = tmp->above) 1750 for (tmp = op->ms ().bot; tmp && tmp->above; tmp = tmp->above)
1874 { 1751 {
1875 /* Trim the search when we find the first other spell effect 1752 /* Trim the search when we find the first other spell effect
1876 * this helps performance so that if a space has 50 spell objects, 1753 * this helps performance so that if a space has 50 spell objects,
1877 * we don't need to check all of them. 1754 * we don't need to check all of them.
1878 */ 1755 */
1933/* 1810/*
1934 * present_arch(arch, map, x, y) searches for any objects with 1811 * present_arch(arch, map, x, y) searches for any objects with
1935 * a matching archetype at the given map and coordinates. 1812 * a matching archetype at the given map and coordinates.
1936 * The first matching object is returned, or NULL if none. 1813 * The first matching object is returned, or NULL if none.
1937 */ 1814 */
1938
1939object * 1815object *
1940present_arch (const archetype *at, maptile *m, int x, int y) 1816present_arch (const archetype *at, maptile *m, int x, int y)
1941{ 1817{
1942 object *
1943 tmp;
1944
1945 if (m == NULL || out_of_map (m, x, y)) 1818 if (!m || out_of_map (m, x, y))
1946 { 1819 {
1947 LOG (llevError, "Present_arch called outside map.\n"); 1820 LOG (llevError, "Present_arch called outside map.\n");
1948 return NULL; 1821 return NULL;
1949 } 1822 }
1950 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1823
1824 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1951 if (tmp->arch == at) 1825 if (tmp->arch == at)
1952 return tmp; 1826 return tmp;
1827
1953 return NULL; 1828 return NULL;
1954} 1829}
1955 1830
1956/* 1831/*
1957 * present(type, map, x, y) searches for any objects with 1832 * present(type, map, x, y) searches for any objects with
1958 * a matching type variable at the given map and coordinates. 1833 * a matching type variable at the given map and coordinates.
1959 * The first matching object is returned, or NULL if none. 1834 * The first matching object is returned, or NULL if none.
1960 */ 1835 */
1961
1962object * 1836object *
1963present (unsigned char type, maptile *m, int x, int y) 1837present (unsigned char type, maptile *m, int x, int y)
1964{ 1838{
1965 object *
1966 tmp;
1967
1968 if (out_of_map (m, x, y)) 1839 if (out_of_map (m, x, y))
1969 { 1840 {
1970 LOG (llevError, "Present called outside map.\n"); 1841 LOG (llevError, "Present called outside map.\n");
1971 return NULL; 1842 return NULL;
1972 } 1843 }
1973 for (tmp = GET_MAP_OB (m, x, y); tmp != NULL; tmp = tmp->above) 1844
1845 for (object *tmp = m->at (x, y).bot; tmp; tmp = tmp->above)
1974 if (tmp->type == type) 1846 if (tmp->type == type)
1975 return tmp; 1847 return tmp;
1848
1976 return NULL; 1849 return NULL;
1977} 1850}
1978 1851
1979/* 1852/*
1980 * present_in_ob(type, object) searches for any objects with 1853 * present_in_ob(type, object) searches for any objects with
1981 * a matching type variable in the inventory of the given object. 1854 * a matching type variable in the inventory of the given object.
1982 * The first matching object is returned, or NULL if none. 1855 * The first matching object is returned, or NULL if none.
1983 */ 1856 */
1984
1985object * 1857object *
1986present_in_ob (unsigned char type, const object *op) 1858present_in_ob (unsigned char type, const object *op)
1987{ 1859{
1988 object *
1989 tmp;
1990
1991 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1860 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
1992 if (tmp->type == type) 1861 if (tmp->type == type)
1993 return tmp; 1862 return tmp;
1863
1994 return NULL; 1864 return NULL;
1995} 1865}
1996 1866
1997/* 1867/*
1998 * present_in_ob (type, str, object) searches for any objects with 1868 * present_in_ob (type, str, object) searches for any objects with
2006 * str is the string to match against. Note that we match against 1876 * str is the string to match against. Note that we match against
2007 * the object name, not the archetype name. this is so that the 1877 * the object name, not the archetype name. this is so that the
2008 * spell code can use one object type (force), but change it's name 1878 * spell code can use one object type (force), but change it's name
2009 * to be unique. 1879 * to be unique.
2010 */ 1880 */
2011
2012object * 1881object *
2013present_in_ob_by_name (int type, const char *str, const object *op) 1882present_in_ob_by_name (int type, const char *str, const object *op)
2014{ 1883{
2015 object *
2016 tmp;
2017
2018 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1884 for (object *tmp = op->inv; tmp; tmp = tmp->below)
2019 {
2020 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name))) 1885 if ((type == -1 || tmp->type == type) && (!strcmp (str, tmp->name)))
2021 return tmp; 1886 return tmp;
2022 } 1887
2023 return NULL; 1888 return 0;
2024} 1889}
2025 1890
2026/* 1891/*
2027 * present_arch_in_ob(archetype, object) searches for any objects with 1892 * present_arch_in_ob(archetype, object) searches for any objects with
2028 * a matching archetype in the inventory of the given object. 1893 * a matching archetype in the inventory of the given object.
2029 * The first matching object is returned, or NULL if none. 1894 * The first matching object is returned, or NULL if none.
2030 */ 1895 */
2031
2032object * 1896object *
2033present_arch_in_ob (const archetype *at, const object *op) 1897present_arch_in_ob (const archetype *at, const object *op)
2034{ 1898{
2035 object *
2036 tmp;
2037
2038 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1899 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2039 if (tmp->arch == at) 1900 if (tmp->arch == at)
2040 return tmp; 1901 return tmp;
1902
2041 return NULL; 1903 return NULL;
2042} 1904}
2043 1905
2044/* 1906/*
2045 * activate recursively a flag on an object inventory 1907 * activate recursively a flag on an object inventory
2046 */ 1908 */
2047void 1909void
2048flag_inv (object *op, int flag) 1910flag_inv (object *op, int flag)
2049{ 1911{
2050 object *
2051 tmp;
2052
2053 if (op->inv) 1912 if (op->inv)
2054 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1913 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2055 { 1914 {
2056 SET_FLAG (tmp, flag); 1915 SET_FLAG (tmp, flag);
2057 flag_inv (tmp, flag); 1916 flag_inv (tmp, flag);
2058 } 1917 }
2059} /* 1918}
1919
1920/*
2060 * desactivate recursively a flag on an object inventory 1921 * deactivate recursively a flag on an object inventory
2061 */ 1922 */
2062void 1923void
2063unflag_inv (object *op, int flag) 1924unflag_inv (object *op, int flag)
2064{ 1925{
2065 object *
2066 tmp;
2067
2068 if (op->inv) 1926 if (op->inv)
2069 for (tmp = op->inv; tmp != NULL; tmp = tmp->below) 1927 for (object *tmp = op->inv; tmp != NULL; tmp = tmp->below)
2070 { 1928 {
2071 CLEAR_FLAG (tmp, flag); 1929 CLEAR_FLAG (tmp, flag);
2072 unflag_inv (tmp, flag); 1930 unflag_inv (tmp, flag);
2073 } 1931 }
2074} 1932}
2077 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in 1935 * set_cheat(object) sets the cheat flag (WAS_WIZ) in the object and in
2078 * all it's inventory (recursively). 1936 * all it's inventory (recursively).
2079 * If checksums are used, a player will get set_cheat called for 1937 * If checksums are used, a player will get set_cheat called for
2080 * him/her-self and all object carried by a call to this function. 1938 * him/her-self and all object carried by a call to this function.
2081 */ 1939 */
2082
2083void 1940void
2084set_cheat (object *op) 1941set_cheat (object *op)
2085{ 1942{
2086 SET_FLAG (op, FLAG_WAS_WIZ); 1943 SET_FLAG (op, FLAG_WAS_WIZ);
2087 flag_inv (op, FLAG_WAS_WIZ); 1944 flag_inv (op, FLAG_WAS_WIZ);
2106 * because arch_blocked (now ob_blocked) needs to know the movement type 1963 * because arch_blocked (now ob_blocked) needs to know the movement type
2107 * to know if the space in question will block the object. We can't use 1964 * to know if the space in question will block the object. We can't use
2108 * the archetype because that isn't correct if the monster has been 1965 * the archetype because that isn't correct if the monster has been
2109 * customized, changed states, etc. 1966 * customized, changed states, etc.
2110 */ 1967 */
2111
2112int 1968int
2113find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop) 1969find_free_spot (const object *ob, maptile *m, int x, int y, int start, int stop)
2114{ 1970{
2115 int
2116 i,
2117 index = 0, flag; 1971 int index = 0, flag;
2118 static int
2119 altern[SIZEOFFREE]; 1972 int altern[SIZEOFFREE];
2120 1973
2121 for (i = start; i < stop; i++) 1974 for (int i = start; i < stop; i++)
2122 { 1975 {
2123 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]); 1976 flag = ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]);
2124 if (!flag) 1977 if (!flag)
2125 altern[index++] = i; 1978 altern [index++] = i;
2126 1979
2127 /* Basically, if we find a wall on a space, we cut down the search size. 1980 /* Basically, if we find a wall on a space, we cut down the search size.
2128 * In this way, we won't return spaces that are on another side of a wall. 1981 * In this way, we won't return spaces that are on another side of a wall.
2129 * This mostly work, but it cuts down the search size in all directions - 1982 * This mostly work, but it cuts down the search size in all directions -
2130 * if the space being examined only has a wall to the north and empty 1983 * if the space being examined only has a wall to the north and empty
2131 * spaces in all the other directions, this will reduce the search space 1984 * spaces in all the other directions, this will reduce the search space
2132 * to only the spaces immediately surrounding the target area, and 1985 * to only the spaces immediately surrounding the target area, and
2133 * won't look 2 spaces south of the target space. 1986 * won't look 2 spaces south of the target space.
2134 */ 1987 */
2135 else if ((flag & AB_NO_PASS) && maxfree[i] < stop) 1988 else if ((flag & P_NO_PASS) && maxfree[i] < stop)
2136 stop = maxfree[i]; 1989 stop = maxfree[i];
2137 } 1990 }
1991
2138 if (!index) 1992 if (!index)
2139 return -1; 1993 return -1;
1994
2140 return altern[RANDOM () % index]; 1995 return altern[RANDOM () % index];
2141} 1996}
2142 1997
2143/* 1998/*
2144 * find_first_free_spot(archetype, maptile, x, y) works like 1999 * find_first_free_spot(archetype, maptile, x, y) works like
2145 * find_free_spot(), but it will search max number of squares. 2000 * find_free_spot(), but it will search max number of squares.
2146 * But it will return the first available spot, not a random choice. 2001 * But it will return the first available spot, not a random choice.
2147 * Changed 0.93.2: Have it return -1 if there is no free spot available. 2002 * Changed 0.93.2: Have it return -1 if there is no free spot available.
2148 */ 2003 */
2149
2150int 2004int
2151find_first_free_spot (const object *ob, maptile *m, int x, int y) 2005find_first_free_spot (const object *ob, maptile *m, int x, int y)
2152{ 2006{
2153 int
2154 i;
2155
2156 for (i = 0; i < SIZEOFFREE; i++) 2007 for (int i = 0; i < SIZEOFFREE; i++)
2157 {
2158 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i])) 2008 if (!ob_blocked (ob, m, x + freearr_x[i], y + freearr_y[i]))
2159 return i; 2009 return i;
2160 } 2010
2161 return -1; 2011 return -1;
2162} 2012}
2163 2013
2164/* 2014/*
2165 * The function permute(arr, begin, end) randomly reorders the array 2015 * The function permute(arr, begin, end) randomly reorders the array
2166 * arr[begin..end-1]. 2016 * arr[begin..end-1].
2017 * now uses a fisher-yates shuffle, old permute was broken
2167 */ 2018 */
2168static void 2019static void
2169permute (int *arr, int begin, int end) 2020permute (int *arr, int begin, int end)
2170{ 2021{
2171 int 2022 arr += begin;
2172 i,
2173 j,
2174 tmp,
2175 len;
2176
2177 len = end - begin; 2023 end -= begin;
2178 for (i = begin; i < end; i++)
2179 {
2180 j = begin + RANDOM () % len;
2181 2024
2182 tmp = arr[i]; 2025 while (--end)
2183 arr[i] = arr[j]; 2026 swap (arr [end], arr [RANDOM () % (end + 1)]);
2184 arr[j] = tmp;
2185 }
2186} 2027}
2187 2028
2188/* new function to make monster searching more efficient, and effective! 2029/* new function to make monster searching more efficient, and effective!
2189 * This basically returns a randomized array (in the passed pointer) of 2030 * This basically returns a randomized array (in the passed pointer) of
2190 * the spaces to find monsters. In this way, it won't always look for 2031 * the spaces to find monsters. In this way, it won't always look for
2193 * the 3x3 area will be searched, just not in a predictable order. 2034 * the 3x3 area will be searched, just not in a predictable order.
2194 */ 2035 */
2195void 2036void
2196get_search_arr (int *search_arr) 2037get_search_arr (int *search_arr)
2197{ 2038{
2198 int 2039 int i;
2199 i;
2200 2040
2201 for (i = 0; i < SIZEOFFREE; i++) 2041 for (i = 0; i < SIZEOFFREE; i++)
2202 {
2203 search_arr[i] = i; 2042 search_arr[i] = i;
2204 }
2205 2043
2206 permute (search_arr, 1, SIZEOFFREE1 + 1); 2044 permute (search_arr, 1, SIZEOFFREE1 + 1);
2207 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1); 2045 permute (search_arr, SIZEOFFREE1 + 1, SIZEOFFREE2 + 1);
2208 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE); 2046 permute (search_arr, SIZEOFFREE2 + 1, SIZEOFFREE);
2209} 2047}
2218 * Perhaps incorrectly, but I'm making the assumption that exclude 2056 * Perhaps incorrectly, but I'm making the assumption that exclude
2219 * is actually want is going to try and move there. We need this info 2057 * is actually want is going to try and move there. We need this info
2220 * because we have to know what movement the thing looking to move 2058 * because we have to know what movement the thing looking to move
2221 * there is capable of. 2059 * there is capable of.
2222 */ 2060 */
2223
2224int 2061int
2225find_dir (maptile *m, int x, int y, object *exclude) 2062find_dir (maptile *m, int x, int y, object *exclude)
2226{ 2063{
2227 int
2228 i,
2229 max = SIZEOFFREE, mflags; 2064 int i, max = SIZEOFFREE, mflags;
2230 2065
2231 sint16 nx, ny; 2066 sint16 nx, ny;
2232 object * 2067 object *tmp;
2233 tmp;
2234 maptile * 2068 maptile *mp;
2235 mp;
2236 2069
2237 MoveType blocked, move_type; 2070 MoveType blocked, move_type;
2238 2071
2239 if (exclude && exclude->head) 2072 if (exclude && exclude->head)
2240 { 2073 {
2252 mp = m; 2085 mp = m;
2253 nx = x + freearr_x[i]; 2086 nx = x + freearr_x[i];
2254 ny = y + freearr_y[i]; 2087 ny = y + freearr_y[i];
2255 2088
2256 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny); 2089 mflags = get_map_flags (m, &mp, nx, ny, &nx, &ny);
2090
2257 if (mflags & P_OUT_OF_MAP) 2091 if (mflags & P_OUT_OF_MAP)
2258 {
2259 max = maxfree[i]; 2092 max = maxfree[i];
2260 }
2261 else 2093 else
2262 { 2094 {
2263 blocked = GET_MAP_MOVE_BLOCK (mp, nx, ny); 2095 mapspace &ms = mp->at (nx, ny);
2096
2097 blocked = ms.move_block;
2264 2098
2265 if ((move_type & blocked) == move_type) 2099 if ((move_type & blocked) == move_type)
2266 {
2267 max = maxfree[i]; 2100 max = maxfree[i];
2268 }
2269 else if (mflags & P_IS_ALIVE) 2101 else if (mflags & P_IS_ALIVE)
2270 { 2102 {
2271 for (tmp = GET_MAP_OB (mp, nx, ny); tmp != NULL; tmp = tmp->above) 2103 for (tmp = ms.bot; tmp; tmp = tmp->above)
2272 { 2104 if ((tmp->flag [FLAG_MONSTER] || tmp->type == PLAYER)
2273 if ((QUERY_FLAG (tmp, FLAG_MONSTER) || tmp->type == PLAYER) && (tmp != exclude || (tmp->head && tmp->head != exclude))) 2105 && (tmp != exclude || (tmp->head && tmp->head != exclude)))
2274 {
2275 break; 2106 break;
2276 } 2107
2277 }
2278 if (tmp) 2108 if (tmp)
2279 {
2280 return freedir[i]; 2109 return freedir[i];
2281 }
2282 } 2110 }
2283 } 2111 }
2284 } 2112 }
2113
2285 return 0; 2114 return 0;
2286} 2115}
2287 2116
2288/* 2117/*
2289 * distance(object 1, object 2) will return the square of the 2118 * distance(object 1, object 2) will return the square of the
2290 * distance between the two given objects. 2119 * distance between the two given objects.
2291 */ 2120 */
2292
2293int 2121int
2294distance (const object *ob1, const object *ob2) 2122distance (const object *ob1, const object *ob2)
2295{ 2123{
2296 int
2297 i;
2298
2299 i = (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y); 2124 return (ob1->x - ob2->x) * (ob1->x - ob2->x) + (ob1->y - ob2->y) * (ob1->y - ob2->y);
2300 return i;
2301} 2125}
2302 2126
2303/* 2127/*
2304 * find_dir_2(delta-x,delta-y) will return a direction in which 2128 * find_dir_2(delta-x,delta-y) will return a direction in which
2305 * an object which has subtracted the x and y coordinates of another 2129 * an object which has subtracted the x and y coordinates of another
2306 * object, needs to travel toward it. 2130 * object, needs to travel toward it.
2307 */ 2131 */
2308
2309int 2132int
2310find_dir_2 (int x, int y) 2133find_dir_2 (int x, int y)
2311{ 2134{
2312 int 2135 int q;
2313 q;
2314 2136
2315 if (y) 2137 if (y)
2316 q = x * 100 / y; 2138 q = x * 100 / y;
2317 else if (x) 2139 else if (x)
2318 q = -300 * x; 2140 q = -300 * x;
2353int 2175int
2354absdir (int d) 2176absdir (int d)
2355{ 2177{
2356 while (d < 1) 2178 while (d < 1)
2357 d += 8; 2179 d += 8;
2180
2358 while (d > 8) 2181 while (d > 8)
2359 d -= 8; 2182 d -= 8;
2183
2360 return d; 2184 return d;
2361} 2185}
2362 2186
2363/* 2187/*
2364 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is 2188 * dirdiff(dir1, dir2) returns how many 45-degrees differences there is
2366 */ 2190 */
2367 2191
2368int 2192int
2369dirdiff (int dir1, int dir2) 2193dirdiff (int dir1, int dir2)
2370{ 2194{
2371 int 2195 int d;
2372 d;
2373 2196
2374 d = abs (dir1 - dir2); 2197 d = abs (dir1 - dir2);
2375 if (d > 4) 2198 if (d > 4)
2376 d = 8 - d; 2199 d = 8 - d;
2200
2377 return d; 2201 return d;
2378} 2202}
2379 2203
2380/* peterm: 2204/* peterm:
2381 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster. 2205 * do LOS stuff for ball lightning. Go after the closest VISIBLE monster.
2384 * This basically means that if direction is 15, then it could either go 2208 * This basically means that if direction is 15, then it could either go
2385 * direction 4, 14, or 16 to get back to where we are. 2209 * direction 4, 14, or 16 to get back to where we are.
2386 * Moved from spell_util.c to object.c with the other related direction 2210 * Moved from spell_util.c to object.c with the other related direction
2387 * functions. 2211 * functions.
2388 */ 2212 */
2389
2390int
2391 reduction_dir[SIZEOFFREE][3] = { 2213int reduction_dir[SIZEOFFREE][3] = {
2392 {0, 0, 0}, /* 0 */ 2214 {0, 0, 0}, /* 0 */
2393 {0, 0, 0}, /* 1 */ 2215 {0, 0, 0}, /* 1 */
2394 {0, 0, 0}, /* 2 */ 2216 {0, 0, 0}, /* 2 */
2395 {0, 0, 0}, /* 3 */ 2217 {0, 0, 0}, /* 3 */
2396 {0, 0, 0}, /* 4 */ 2218 {0, 0, 0}, /* 4 */
2444 * find a path to that monster that we found. If not, 2266 * find a path to that monster that we found. If not,
2445 * we don't bother going toward it. Returns 1 if we 2267 * we don't bother going toward it. Returns 1 if we
2446 * can see a direct way to get it 2268 * can see a direct way to get it
2447 * Modified to be map tile aware -.MSW 2269 * Modified to be map tile aware -.MSW
2448 */ 2270 */
2449
2450
2451int 2271int
2452can_see_monsterP (maptile *m, int x, int y, int dir) 2272can_see_monsterP (maptile *m, int x, int y, int dir)
2453{ 2273{
2454 sint16 dx, dy; 2274 sint16 dx, dy;
2455 int
2456 mflags; 2275 int mflags;
2457 2276
2458 if (dir < 0) 2277 if (dir < 0)
2459 return 0; /* exit condition: invalid direction */ 2278 return 0; /* exit condition: invalid direction */
2460 2279
2461 dx = x + freearr_x[dir]; 2280 dx = x + freearr_x[dir];
2474 return 0; 2293 return 0;
2475 2294
2476 /* yes, can see. */ 2295 /* yes, can see. */
2477 if (dir < 9) 2296 if (dir < 9)
2478 return 1; 2297 return 1;
2298
2479 return can_see_monsterP (m, x, y, reduction_dir[dir][0]) | 2299 return can_see_monsterP (m, x, y, reduction_dir[dir][0])
2480 can_see_monsterP (m, x, y, reduction_dir[dir][1]) | can_see_monsterP (m, x, y, reduction_dir[dir][2]); 2300 | can_see_monsterP (m, x, y, reduction_dir[dir][1])
2301 | can_see_monsterP (m, x, y, reduction_dir[dir][2]);
2481} 2302}
2482
2483
2484 2303
2485/* 2304/*
2486 * can_pick(picker, item): finds out if an object is possible to be 2305 * can_pick(picker, item): finds out if an object is possible to be
2487 * picked up by the picker. Returnes 1 if it can be 2306 * picked up by the picker. Returnes 1 if it can be
2488 * picked up, otherwise 0. 2307 * picked up, otherwise 0.
2499 return /*QUERY_FLAG(who,FLAG_WIZ)|| */ 2318 return /*QUERY_FLAG(who,FLAG_WIZ)|| */
2500 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) && 2319 (item->weight > 0 && !QUERY_FLAG (item, FLAG_NO_PICK) &&
2501 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3)); 2320 !QUERY_FLAG (item, FLAG_ALIVE) && !item->invisible && (who->type == PLAYER || item->weight < who->weight / 3));
2502} 2321}
2503 2322
2504
2505/* 2323/*
2506 * create clone from object to another 2324 * create clone from object to another
2507 */ 2325 */
2508object * 2326object *
2509object_create_clone (object *asrc) 2327object_create_clone (object *asrc)
2518 src = src->head; 2336 src = src->head;
2519 2337
2520 prev = 0; 2338 prev = 0;
2521 for (part = src; part; part = part->more) 2339 for (part = src; part; part = part->more)
2522 { 2340 {
2523 tmp = object::create (); 2341 tmp = part->clone ();
2524 part->copy_to (tmp);
2525 tmp->x -= src->x; 2342 tmp->x -= src->x;
2526 tmp->y -= src->y; 2343 tmp->y -= src->y;
2527 2344
2528 if (!part->head) 2345 if (!part->head)
2529 { 2346 {
2530 dst = tmp; 2347 dst = tmp;
2531 tmp->head = 0; 2348 tmp->head = 0;
2532 } 2349 }
2533 else 2350 else
2534 {
2535 tmp->head = dst; 2351 tmp->head = dst;
2536 }
2537 2352
2538 tmp->more = 0; 2353 tmp->more = 0;
2539 2354
2540 if (prev) 2355 if (prev)
2541 prev->more = tmp; 2356 prev->more = tmp;
2553/* Basically, we save the content of the string to a temp file, then call */ 2368/* Basically, we save the content of the string to a temp file, then call */
2554/* load_object on it. I admit it is a highly inefficient way to make things, */ 2369/* load_object on it. I admit it is a highly inefficient way to make things, */
2555/* but it was simple to make and allows reusing the load_object function. */ 2370/* but it was simple to make and allows reusing the load_object function. */
2556/* Remember not to use load_object_str in a time-critical situation. */ 2371/* Remember not to use load_object_str in a time-critical situation. */
2557/* Also remember that multiparts objects are not supported for now. */ 2372/* Also remember that multiparts objects are not supported for now. */
2558
2559object * 2373object *
2560load_object_str (const char *obstr) 2374load_object_str (const char *obstr)
2561{ 2375{
2562 object *op; 2376 object *op;
2563 char filename[MAX_BUF]; 2377 char filename[MAX_BUF];
2593 * returns NULL if no match. 2407 * returns NULL if no match.
2594 */ 2408 */
2595object * 2409object *
2596find_obj_by_type_subtype (const object *who, int type, int subtype) 2410find_obj_by_type_subtype (const object *who, int type, int subtype)
2597{ 2411{
2598 object *tmp;
2599
2600 for (tmp = who->inv; tmp; tmp = tmp->below) 2412 for (object *tmp = who->inv; tmp; tmp = tmp->below)
2601 if (tmp->type == type && tmp->subtype == subtype) 2413 if (tmp->type == type && tmp->subtype == subtype)
2602 return tmp; 2414 return tmp;
2603 2415
2604 return NULL; 2416 return 0;
2605} 2417}
2606 2418
2607/* If ob has a field named key, return the link from the list, 2419/* If ob has a field named key, return the link from the list,
2608 * otherwise return NULL. 2420 * otherwise return NULL.
2609 * 2421 *
2611 * do the desired thing. 2423 * do the desired thing.
2612 */ 2424 */
2613key_value * 2425key_value *
2614get_ob_key_link (const object *ob, const char *key) 2426get_ob_key_link (const object *ob, const char *key)
2615{ 2427{
2616 key_value *link;
2617
2618 for (link = ob->key_values; link != NULL; link = link->next) 2428 for (key_value *link = ob->key_values; link; link = link->next)
2619 if (link->key == key) 2429 if (link->key == key)
2620 return link; 2430 return link;
2621 2431
2622 return NULL; 2432 return 0;
2623} 2433}
2624 2434
2625/* 2435/*
2626 * Returns the value of op has an extra_field for key, or NULL. 2436 * Returns the value of op has an extra_field for key, or NULL.
2627 * 2437 *
2667 * Returns TRUE on success. 2477 * Returns TRUE on success.
2668 */ 2478 */
2669int 2479int
2670set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key) 2480set_ob_key_value_s (object *op, const shstr & canonical_key, const char *value, int add_key)
2671{ 2481{
2672 key_value *
2673 field = NULL, *last = NULL; 2482 key_value *field = NULL, *last = NULL;
2674 2483
2675 for (field = op->key_values; field != NULL; field = field->next) 2484 for (field = op->key_values; field != NULL; field = field->next)
2676 { 2485 {
2677 if (field->key != canonical_key) 2486 if (field->key != canonical_key)
2678 { 2487 {
2706 /* IF we get here, key doesn't exist */ 2515 /* IF we get here, key doesn't exist */
2707 2516
2708 /* No field, we'll have to add it. */ 2517 /* No field, we'll have to add it. */
2709 2518
2710 if (!add_key) 2519 if (!add_key)
2711 {
2712 return FALSE; 2520 return FALSE;
2713 } 2521
2714 /* There isn't any good reason to store a null 2522 /* There isn't any good reason to store a null
2715 * value in the key/value list. If the archetype has 2523 * value in the key/value list. If the archetype has
2716 * this key, then we should also have it, so shouldn't 2524 * this key, then we should also have it, so shouldn't
2717 * be here. If user wants to store empty strings, 2525 * be here. If user wants to store empty strings,
2718 * should pass in "" 2526 * should pass in ""
2767 } 2575 }
2768 else 2576 else
2769 item = item->env; 2577 item = item->env;
2770} 2578}
2771 2579
2580
2581const char *
2582object::flag_desc (char *desc, int len) const
2583{
2584 char *p = desc;
2585 bool first = true;
2586
2587 *p = 0;
2588
2589 for (int i = 0; i < NUM_FLAGS; i++)
2590 {
2591 if (len <= 10) // magic constant!
2592 {
2593 snprintf (p, len, ",...");
2594 break;
2595 }
2596
2597 if (flag [i])
2598 {
2599 int cnt = snprintf (p, len, "%s%d", first ? "" : ",", i);
2600 len -= cnt;
2601 p += cnt;
2602 first = false;
2603 }
2604 }
2605
2606 return desc;
2607}
2608
2772// return a suitable string describing an objetc in enough detail to find it 2609// return a suitable string describing an object in enough detail to find it
2773const char * 2610const char *
2774object::debug_desc (char *info) const 2611object::debug_desc (char *info) const
2775{ 2612{
2613 char flagdesc[512];
2776 char info2[256 * 3]; 2614 char info2[256 * 4];
2777 char *p = info; 2615 char *p = info;
2778 2616
2779 p += snprintf (p, 256, "%d=\"%s%s%s\"", 2617 p += snprintf (p, 512, "{cnt:%d,uuid:<1,%" PRIx64 ">,name:\"%s%s%s\",flags:[%s],type:%d}",
2780 count, 2618 count, uuid.seq,
2781 &name, 2619 &name,
2782 title ? " " : "", 2620 title ? "\",title:" : "",
2783 title ? (const char *)title : ""); 2621 title ? (const char *)title : "",
2622 flag_desc (flagdesc, 512), type);
2784 2623
2785 if (env) 2624 if (env)
2786 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2)); 2625 p += snprintf (p, 256, "(in %s)", env->debug_desc (info2));
2787 2626
2788 if (map) 2627 if (map)
2789 p += snprintf (p, 256, "(on %s@%d+%d)", map->path, x, y); 2628 p += snprintf (p, 256, "(on %s@%d+%d)", &map->path, x, y);
2790 2629
2791 return info; 2630 return info;
2792} 2631}
2793 2632
2794const char * 2633const char *
2795object::debug_desc () const 2634object::debug_desc () const
2796{ 2635{
2797 static char info[256 * 3]; 2636 static char info[256 * 4];
2798 return debug_desc (info); 2637 return debug_desc (info);
2799} 2638}
2800 2639

Diff Legend

Removed lines
+ Added lines
< Changed lines
> Changed lines