[ViewVC] Diff of: cvs/deliantra/server/lib/cf.pm

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.342 by root, Sun Aug 26 15:31:02 2007 UTC vs.
Revision 1.347 by root, Thu Aug 30 05:16:09 2007 UTC

 use Coro::Semaphore;
 use Coro::AIO;
 use Coro::Storable;
 use Coro::Util ();
-use JSON::XS 1.4 ();
+use JSON::XS ();
 use BDB ();
 use Data::Dumper;
 use Digest::MD5;
 use Fcntl;
 use YAML::Syck ();
 Wait until the given lock is available and then acquires it and returns
 a Coro::guard object. If the guard object gets destroyed (goes out of scope,
 for example when the coroutine gets canceled), the lock is automatically
 returned.
+Locks are *not* recursive, locking from the same coro twice results in a
+deadlocked coro.
 Lock names should begin with a unique identifier (for example, cf::map::find
 uses map_find and cf::map::load uses map_load).
 =item $locked = cf::lock_active $string
       if (1) {
          $md5 =
             join "\x00",
                $processversion,
                map {
-                  Coro::cede;
+                  cf::cede_to_tick;
                   ($src->[$_], Digest::MD5::md5_hex $data[$_])
                } 0.. $#$src;
          my $dbmd5 = db_get cache => "$id/md5";
    aio_mkdir playerdir $pl, 0770;
    $pl->{last_save} = $cf::RUNTIME;
    $pl->save_pl ($path);
-   Coro::cede;
+   cf::cede_to_tick;
 }
 sub new($) {
    my ($login) = @_;
    local $self->{deny_reset} = 1; # loading can take a long time
    my $path = $self->{path};
    {
+      my $guard1 = cf::lock_acquire "map_data:$path";
-      my $guard = cf::lock_acquire "map_load:$path";
+      my $guard2 = cf::lock_acquire "map_load:$path";
       return if $self->in_memory != cf::MAP_SWAPPED;
       $self->in_memory (cf::MAP_LOADING);
       $self->alloc;
       $self->pre_load;
-      Coro::cede;
+      cf::cede_to_tick;
       $self->_load_objects ($self->{load_path}, 1)
          or return;
       $self->set_object_flag (cf::FLAG_OBJ_ORIGINAL, 1)
             $self->clear_unique_items;
             $self->_load_objects ($uniq, 0);
          }
       }
-      Coro::cede;
+      cf::cede_to_tick;
       # now do the right thing for maps
       $self->link_multipart_objects;
       $self->difficulty ($self->estimate_difficulty)
          unless $self->difficulty;
-      Coro::cede;
+      cf::cede_to_tick;
       unless ($self->{deny_activate}) {
          $self->decay_objects;
          $self->fix_auto_apply;
          $self->update_buttons;
-         Coro::cede;
+         cf::cede_to_tick;
          $self->set_darkness_map;
-         Coro::cede;
+         cf::cede_to_tick;
          $self->activate;
       }
       $self->{last_save} = $cf::RUNTIME;
       $self->last_access ($cf::RUNTIME);
 }
 sub save {
    my ($self) = @_;
-   my $lock = cf::lock_acquire "map_data:" . $self->path;
+   my $lock = cf::lock_acquire "map_data:$self->{path}";
    $self->{last_save} = $cf::RUNTIME;
    return unless $self->dirty;
    my ($self) = @_;
    # save first because save cedes
    $self->save;
-   my $lock = cf::lock_acquire "map_data:" . $self->path;
+   my $lock = cf::lock_acquire "map_data:$self->{path}";
    return if $self->players;
    return if $self->in_memory != cf::MAP_IN_MEMORY;
    return if $self->{deny_save};
 =cut
 sub cf::client::ext_msg($$@) {
    my ($self, $type, @msg) = @_;
-   my $extcmd = $self->extcmd;
-   if ($extcmd == 2) {
+   if ($self->extcmd == 2) {
       $self->send_packet ("ext " . $self->{json_coder}->encode ([$type, @msg]));
-   } elsif ($extcmd == 1) { # TODO: remove
+   } elsif ($self->extcmd == 1) { # TODO: remove
       push @msg, msgtype => "event_$type";
       $self->send_packet ("ext " . $self->{json_coder}->encode ({@msg}));
    }
 }
 sub cf::client::ext_reply($$@) {
    my ($self, $id, @msg) = @_;
    if ($self->extcmd == 2) {
       $self->send_packet ("ext " . $self->{json_coder}->encode (["reply-$id", @msg]));
-   } elsif ($self->ns->extcmd == 1) {
+   } elsif ($self->extcmd == 1) {
       #TODO: version 1, remove
       unshift @msg, msgtype => "reply", msgid => $id;
       $self->send_packet ("ext " . $self->{json_coder}->encode ({@msg}));
    }
 }
 # the server's init and main functions
 sub load_facedata($) {
    my ($path) = @_;
-   my $enc = JSON::XS->new->utf8->canonical;
+   my $enc = JSON::XS->new->utf8->canonical->relaxed;
    warn "loading facedata from $path\n";
    my $facedata;
    0 < aio_load $path, $facedata
 sub init {
    reload_resources;
 }
-sub cfg_load {
+sub reload_config {
    open my $fh, "<:utf8", "$CONFDIR/config"
       or return;
    local $/;
    *CFG = YAML::Syck::Load <$fh>;
       (async {
          Event::one_event;
       })->prio (Coro::PRIO_MAX);
    };
-   cfg_load;
+   reload_config;
    db_init;
    load_extensions;
    $TICK_WATCHER->start;
    Event::loop;
       warn "reloading cf.pm";
       require cf;
       cf::_connect_to_perl; # nominally unnecessary, but cannot hurt
       warn "loading config and database again";
-      cf::cfg_load;
+      cf::reload_config;
       warn "loading extensions";
       cf::load_extensions;
       warn "reattaching attachments to objects/players";

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/lib/cf.pm (file contents): Revision 1.342 by root, Sun Aug 26 15:31:02 2007 UTC vs. Revision 1.347 by root, Thu Aug 30 05:16:09 2007 UTC

Diff Legend

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.342 by root, Sun Aug 26 15:31:02 2007 UTC vs.
Revision 1.347 by root, Thu Aug 30 05:16:09 2007 UTC