[ViewVC] Diff of: cvs/deliantra/server/lib/cf.pm

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.405 by root, Mon Dec 17 08:03:22 2007 UTC vs.
Revision 1.445 by root, Wed Sep 10 18:18:10 2008 UTC

+#
+# This file is part of Deliantra, the Roguelike Realtime MMORPG.
+#
+# Copyright (©) 2006,2007,2008 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
+#
+# Deliantra is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+# The authors can be reached via e-mail to <support@deliantra.net>
+#
 package cf;
+use 5.10.0;
 use utf8;
-use strict;
+use strict "vars", "subs";
 use Symbol;
 use List::Util;
 use Socket;
-use EV 1.86;
+use EV;
 use Opcode;
 use Safe;
 use Safe::Hole;
 use Storable ();
-use Coro 4.32 ();
+use Coro ();
 use Coro::State;
 use Coro::Handle;
 use Coro::EV;
+use Coro::AnyEvent;
 use Coro::Timer;
 use Coro::Signal;
 use Coro::Semaphore;
+use Coro::AnyEvent;
 use Coro::AIO;
-use Coro::BDB;
+use Coro::BDB 1.6;
 use Coro::Storable;
 use Coro::Util ();
 use JSON::XS 2.01 ();
 use BDB ();
 use Data::Dumper;
 use Digest::MD5;
 use Fcntl;
-use YAML::Syck ();
+use YAML ();
-use IO::AIO 2.51 ();
+use IO::AIO ();
 use Time::HiRes;
 use Compress::LZF;
 use Digest::MD5 ();
+AnyEvent::detect;
 # configure various modules to our taste
 #
 $Storable::canonical = 1; # reduce rsync transfers
 Coro::State::cctx_stacksize 256000; # 1-2MB stack, for deep recursions in maze generator
 Compress::LZF::sfreeze_cr { }; # prime Compress::LZF so it does not use require later
-# work around bug in YAML::Syck - bad news for perl6, will it be as broken wrt. unicode?
-$YAML::Syck::ImplicitUnicode = 1;
 $Coro::main->prio (Coro::PRIO_MAX); # run main coroutine ("the server") with very high priority
 sub WF_AUTOCANCEL () { 1 } # automatically cancel this watcher on reload
 our %COMMAND      = ();
 our %EXT_MAP      = (); # pluggable maps
 our $RELOAD; # number of reloads so far
 our @EVENT;
-our $CONFDIR   = confdir;
+our $CONFDIR     = confdir;
-our $DATADIR   = datadir;
+our $DATADIR     = datadir;
-our $LIBDIR    = "$DATADIR/ext";
+our $LIBDIR      = "$DATADIR/ext";
-our $PODDIR    = "$DATADIR/pod";
+our $PODDIR      = "$DATADIR/pod";
-our $MAPDIR    = "$DATADIR/" . mapdir;
+our $MAPDIR      = "$DATADIR/" . mapdir;
-our $LOCALDIR  = localdir;
+our $LOCALDIR    = localdir;
-our $TMPDIR    = "$LOCALDIR/" . tmpdir;
+our $TMPDIR      = "$LOCALDIR/" . tmpdir;
-our $UNIQUEDIR = "$LOCALDIR/" . uniquedir;
+our $UNIQUEDIR   = "$LOCALDIR/" . uniquedir;
-our $PLAYERDIR = "$LOCALDIR/" . playerdir;
+our $PLAYERDIR   = "$LOCALDIR/" . playerdir;
-our $RANDOMDIR = "$LOCALDIR/random";
+our $RANDOMDIR   = "$LOCALDIR/random";
-our $BDBDIR    = "$LOCALDIR/db";
+our $BDBDIR      = "$LOCALDIR/db";
+our $PIDFILE     = "$LOCALDIR/pid";
+our $RUNTIMEFILE = "$LOCALDIR/runtime";
 our %RESOURCE;
 our $TICK = MAX_TIME * 1e-6; # this is a CONSTANT(!)
-our $TICK_WATCHER;
-our $AIO_POLL_WATCHER;
 our $NEXT_RUNTIME_WRITE; # when should the runtime file be written
 our $NEXT_TICK;
 our $USE_FSYNC = 1; # use fsync to write maps - default off
-our $BDB_POLL_WATCHER;
 our $BDB_DEADLOCK_WATCHER;
 our $BDB_CHECKPOINT_WATCHER;
 our $BDB_TRICKLE_WATCHER;
 our $DB_ENV;
 # used to convert map paths into valid unix filenames by replacing / by ∕
 our $PATH_SEP = "∕"; # U+2215, chosen purely for visual reasons
 our $LOAD;       # a number between 0 (idle) and 1 (too many objects)
 our $LOADAVG;    # same thing, but with alpha-smoothing
+our $JITTER;     # average jitter
-our $tick_start; # for load detecting purposes
+our $TICK_START; # for load detecting purposes
 binmode STDOUT;
 binmode STDERR;
 # read virtual server time, if available
-unless ($RUNTIME || !-e "$LOCALDIR/runtime") {
+unless ($RUNTIME || !-e $RUNTIMEFILE) {
-   open my $fh, "<", "$LOCALDIR/runtime"
+   open my $fh, "<", $RUNTIMEFILE
-      or die "unable to read runtime file: $!";
+      or die "unable to read $RUNTIMEFILE file: $!";
    $RUNTIME = <$fh> + 0.;
 }
 mkdir $_
    for $LOCALDIR, $TMPDIR, $UNIQUEDIR, $PLAYERDIR, $RANDOMDIR, $BDBDIR;
       $msg =~ s/([\x00-\x08\x0b-\x1f])/sprintf "\\x%02x", ord $1/ge;
       LOG llevError, $msg;
    };
 }
+$Coro::State::DIEHOOK = sub {
+   return unless $^S eq 0; # "eq", not "=="
+   if ($Coro::current == $Coro::main) {#d#
+      warn "DIEHOOK called in main context, Coro bug?\n";#d#
+      return;#d#
+   }#d#
+   # kill coroutine otherwise
+   warn Carp::longmess $_[0];
+   Coro::terminate
+};
+$SIG{__DIE__} = sub { }; #d#?
 @safe::cf::global::ISA         = @cf::global::ISA         = 'cf::attachable';
 @safe::cf::object::ISA         = @cf::object::ISA         = 'cf::attachable';
 @safe::cf::player::ISA         = @cf::player::ISA         = 'cf::attachable';
 @safe::cf::client::ISA         = @cf::client::ISA         = 'cf::attachable';
 for my $pkg (qw(
    cf::global cf::attachable
    cf::object cf::object::player
    cf::client cf::player
    cf::arch cf::living
+   cf::map cf::mapspace
-   cf::map cf::party cf::region
+   cf::party cf::region
 )) {
-   no strict 'refs';
    @{"safe::$pkg\::wrap::ISA"} = @{"$pkg\::wrap::ISA"} = $pkg;
 }
 $EV::DIED = sub {
    warn "error in event callback: @_";
    ! ! $LOCK{$key}
 }
 sub freeze_mainloop {
-   return unless $TICK_WATCHER->is_active;
+   tick_inhibit_inc;
-   my $guard = Coro::guard {
+   Coro::guard \&tick_inhibit_dec;
-      $TICK_WATCHER->start;
-   };
-   $TICK_WATCHER->stop;
-   $guard
 }
 =item cf::periodic $interval, $cb
 Like EV::periodic, but randomly selects a starting point so that the actions
       }
    }
 };
 sub get_slot($;$$) {
+   return if tick_inhibit || $Coro::current == $Coro::main;
    my ($time, $pri, $name) = @_;
    $time = $TICK * .6 if $time > $TICK * .6;
    my $sig = new Coro::Signal;
       # this is the main coro, too bad, we have to block
       # till the operation succeeds, freezing the server :/
       LOG llevError, Carp::longmess "sync job";#d#
-      # TODO: use suspend/resume instead
-      # (but this is cancel-safe)
       my $freeze_guard = freeze_mainloop;
       my $busy = 1;
       my @res;
          } else {
             EV::loop EV::LOOP_ONESHOT;
          }
       }
-      $time = EV::time - $time;
+      my $time = EV::time - $time;
-      LOG llevError | logBacktrace, Carp::longmess "long sync job"
-         if $time > $TICK * 0.5 && $TICK_WATCHER->is_active;
-      $tick_start += $time; # do not account sync jobs to server load
+      $TICK_START += $time; # do not account sync jobs to server load
       wantarray ? @res : $res[0]
    } else {
       # we are in another coroutine, how wonderful, everything just works
       reset_signals;
       &$cb
    }, @args;
    wantarray ? @res : $res[-1]
+}
+=item $coin = coin_from_name $name
+=cut
+our %coin_alias = (
+   "silver"        => "silvercoin",
+   "silvercoin"    => "silvercoin",
+   "silvercoins"   => "silvercoin",
+   "gold"          => "goldcoin",
+   "goldcoin"      => "goldcoin",
+   "goldcoins"     => "goldcoin",
+   "platinum"      => "platinacoin",
+   "platinumcoin"  => "platinacoin",
+   "platinumcoins" => "platinacoin",
+   "platina"       => "platinacoin",
+   "platinacoin"   => "platinacoin",
+   "platinacoins"  => "platinacoin",
+   "royalty"       => "royalty",
+   "royalties"     => "royalty",
+);
+sub coin_from_name($) {
+   $coin_alias{$_[0]}
+      ? cf::arch::find $coin_alias{$_[0]}
+      : undef
 }
 =item $value = cf::db_get $family => $key
 Returns a single value from the environment database.
    }
    0
 }
-=item $bool = cf::global::invoke (EVENT_CLASS_XXX, ...)
+=item $bool = cf::global->invoke (EVENT_CLASS_XXX, ...)
 =item $bool = $attachable->invoke (EVENT_CLASS_XXX, ...)
 Generate an object-specific event with the given arguments.
 sub reattach {
    # basically do the same as instantiate, without calling instantiate
    my ($obj) = @_;
+   # no longer needed after getting rid of delete_package?
-   bless $obj, ref $obj; # re-bless in case extensions have been reloaded
+   #bless $obj, ref $obj; # re-bless in case extensions have been reloaded
    my $registry = $obj->registry;
    @$registry = ();
          utf8::decode (my $decname = $filename);
          warn sprintf "saving %s (%d,%d)\n",
             $decname, length $$rdata, scalar @$objs;
          if (my $fh = aio_open "$filename~", O_WRONLY | O_CREAT, 0600) {
-            chmod SAVE_MODE, $fh;
+            aio_chmod $fh, SAVE_MODE;
             aio_write $fh, 0, (length $$rdata), $$rdata, 0;
             aio_fsync $fh if $cf::USE_FSYNC;
-            close $fh;
+            aio_close $fh;
             if (@$objs) {
                if (my $fh = aio_open "$filename.pst~", O_WRONLY | O_CREAT, 0600) {
-                  chmod SAVE_MODE, $fh;
+                  aio_chmod $fh, SAVE_MODE;
                   my $data = Coro::Storable::nfreeze { version => 1, objs => $objs };
                   aio_write $fh, 0, (length $data), $data, 0;
                   aio_fsync $fh if $cf::USE_FSYNC;
-                  close $fh;
+                  aio_close $fh;
                   aio_rename "$filename.pst~", "$filename.pst";
                }
             } else {
                aio_unlink "$filename.pst";
             }
          $ext{meta} = { map { (split /=/, $_, 2)[0, 1] } split /\s+/, $1 }
             if $source =~ /\A#!.*?perl.*?#\s*(.*)$/m;
          $ext{source} =
-            "package $pkg; use strict; use utf8;\n"
+            "package $pkg; use 5.10.0; use strict 'vars', 'subs'; use utf8;\n"
             . "#line 1 \"$path\"\n{\n"
             . $source
             . "\n};\n1";
          $todo{$base} = \%ext;
                my $msg = $@ ? "$v->{path}: $@\n"
                             : "$v->{base}: extension inactive.\n";
                if (exists $v->{meta}{mandatory}) {
                   warn $msg;
-                  warn "mandatory extension failed to load, exiting.\n";
+                  cf::cleanup "mandatory extension failed to load, exiting.";
-                  exit 1;
                }
                warn $msg;
             }
          my $f = new_from_file cf::object::thawer path $login
             or return;
          my $pl = cf::player::load_pl $f
             or return;
          local $cf::PLAYER_LOADING{$login} = $pl;
          $f->resolve_delayed_derefs;
          $cf::PLAYER{$login} = $pl
       }
    }
    return if $pl->{deny_save};
    aio_mkdir playerdir $pl, 0770;
    $pl->{last_save} = $cf::RUNTIME;
+   cf::get_slot 0.01;
    $pl->save_pl ($path);
    cf::cede_to_tick;
 }
    my ($pl) = @_;
    my $name = $pl->ob->name;
    $pl->{deny_save} = 1;
-   $pl->password ("*"); # this should lock out the player until we nuked the dir
+   $pl->password ("*"); # this should lock out the player until we have nuked the dir
    $pl->invoke (cf::EVENT_PLAYER_LOGOUT, 1) if $pl->active;
    $pl->deactivate;
+   my $killer = cf::arch::get "killer_quit"; $pl->killer ($killer); $killer->destroy;
+   $pl->ob->check_score;
    $pl->invoke (cf::EVENT_PLAYER_QUIT);
    $pl->ns->destroy if $pl->ns;
    my $path = playerdir $pl;
    my $temp = "$path~$cf::RUNTIME~deleting~";
    for my $login (@$dirs) {
       my $path = path $login;
       # a .pst is a dead give-away for a valid player
-      unless (-e "$path.pst") {
+      # if no pst file found, open and chekc for blocked users
+      if (aio_stat "$path.pst") {
          my $fh = aio_open $path, Fcntl::O_RDONLY, 0 or next;
          aio_read $fh, 0, 512, my $buf, 0            or next;
          $buf !~ /^password -------------$/m         or next; # official not-valid tag
       }
 =item $protocol_xml = $player->expand_cfpod ($crossfire_pod)
 Expand crossfire pod fragments into protocol xml.
-=cut
-use re 'eval';
-my $group;
-my $interior; $interior = qr{
-   # match a pod interior sequence sans C<< >>
-   (?:
-      \ (.*?)\  (?{ $group = $^N })
-      | < (??{$interior}) >
-   )
-}x;
-sub expand_cfpod {
-   my ($self, $pod) = @_;
-   my $xml;
-   while () {
-      if ($pod =~ /\G( (?: [^BCGHITU]+ | .(?!<) )+ )/xgcs) {
-         $group = $1;
-         $group =~ s/&/&amp;/g;
-         $group =~ s/</&lt;/g;
-         $xml .= $group;
-      } elsif ($pod =~ m%\G
-                  ([BCGHITU])
-                  <
-                     (?:
-                        ([^<>]*) (?{ $group = $^N })
-                        | < $interior >
-                     )
-                  >
-               %gcsx
-      ) {
-         my ($code, $data) = ($1, $group);
-         if ($code eq "B") {
-            $xml .= "<b>" . expand_cfpod ($self, $data) . "</b>";
-         } elsif ($code eq "I") {
-            $xml .= "<i>" . expand_cfpod ($self, $data) . "</i>";
-         } elsif ($code eq "U") {
-            $xml .= "<u>" . expand_cfpod ($self, $data) . "</u>";
-         } elsif ($code eq "C") {
-            $xml .= "<tt>" . expand_cfpod ($self, $data) . "</tt>";
-         } elsif ($code eq "T") {
-            $xml .= "<big><b>" . expand_cfpod ($self, $data) . "</b></big>";
-         } elsif ($code eq "G") {
-            my ($male, $female) = split /\|/, $data;
-            $data =  $self->gender ? $female : $male;
-            $xml .= expand_cfpod ($self, $data);
-         } elsif ($code eq "H") {
-             $xml .= ("<fg name=\"lightblue\">[" . expand_cfpod ($self, $data) . " (Use hintmode to suppress hints)]</fg>",
-                      "<fg name=\"lightblue\">[Hint suppressed, see hintmode]</fg>",
-                      "")
-                        [$self->{hintmode}];
-         } else {
-            $xml .= "error processing '$code($data)' directive";
-         }
-      } else {
-         if ($pod =~ /\G(.+)/) {
-            warn "parse error while expanding $pod (at $1)";
-         }
-         last;
-      }
-   }
-   for ($xml) {
-      # create single paragraphs (very hackish)
-      s/(?<=\S)\n(?=\w)/ /g;
-      # compress some whitespace
-      s/\s+\n/\n/g; # ws line-ends
-      s/\n\n+/\n/g; # double lines
-      s/^\n+//;     # beginning lines
-      s/\n+$//;     # ending lines
-   }
-   $xml
-}
-no re 'eval';
-sub hintmode {
-   $_[0]{hintmode} = $_[1] if @_ > 1;
-   $_[0]{hintmode}
-}
 =item $player->ext_reply ($msgid, @msg)
 Sends an ext reply to the player.
 =cut
 our $MAX_RESET     = 3600;
 our $DEFAULT_RESET = 3000;
 sub generate_random_map {
    my ($self, $rmp) = @_;
+   my $lock = cf::lock_acquire "generate_random_map"; # the random map generator is NOT reentrant ATM
    # mit "rum" bekleckern, nicht
    $self->_create_random_map (
       $rmp->{wallstyle}, $rmp->{wall_name}, $rmp->{floorstyle}, $rmp->{monsterstyle},
       $rmp->{treasurestyle}, $rmp->{layoutstyle}, $rmp->{doorstyle}, $rmp->{decorstyle},
       $rmp->{origin_map}, $rmp->{final_map}, $rmp->{exitstyle}, $rmp->{this_map},
 # the temporary/swap location
 sub save_path {
    my ($self) = @_;
-   (my $path = $_[0]{path}) =~ s/\//$PATH_SEP/g;
+   (my $path = $_[0]{path}) =~ s/\//$PATH_SEP/go;
    "$TMPDIR/$path.map"
 }
 # the unique path, undef == no special unique path
 sub uniq_path {
    my ($self) = @_;
-   (my $path = $_[0]{path}) =~ s/\//$PATH_SEP/g;
+   (my $path = $_[0]{path}) =~ s/\//$PATH_SEP/go;
    "$UNIQUEDIR/$path"
 }
 # and all this just because we cannot iterate over
 # all maps in C++...
    cf::lock_wait "map_data:$path";#d#remove
    cf::lock_wait "map_find:$path";
    $cf::MAP{$path} || do {
-      my $guard1 = cf::lock_acquire "map_find:$path";
-      my $guard2 = cf::lock_acquire "map_data:$path"; # just for the fun of it
+      my $guard1 = cf::lock_acquire "map_data:$path"; # just for the fun of it
+      my $guard2 = cf::lock_acquire "map_find:$path";
       my $map = new_from_path cf::map $path
          or return;
       $map->{last_save} = $cf::RUNTIME;
          or return;
       if ($map->should_reset) {#d#TODO# disabled, crashy (locking issue?)
          # doing this can freeze the server in a sync job, obviously
          #$cf::WAIT_FOR_TICK->wait;
+         undef $guard2;
          undef $guard1;
-         undef $guard2;
          $map->reset;
          return find $path;
       }
       $cf::MAP{$path} = $map
       my $f = new_from_file cf::object::thawer $self->{load_path};
       $f->skip_block;
       $self->_load_objects ($f)
          or return;
-      $self->set_object_flag (cf::FLAG_OBJ_ORIGINAL, 1)
+      $self->post_load_original
          if delete $self->{load_original};
       if (my $uniq = $self->uniq_path) {
          utf8::encode $uniq;
          unless (aio_stat $uniq) {
       }
       $self->{last_save} = $cf::RUNTIME;
       $self->last_access ($cf::RUNTIME);
-      $self->in_memory (cf::MAP_IN_MEMORY);
+      $self->in_memory (cf::MAP_ACTIVE);
    }
    $self->post_load;
 }
    my ($path, $origin, $load) = @_;
    $path = normalise $path, $origin && $origin->{path};
    if (my $map = $cf::MAP{$path}) {
-      return $map if !$load || $map->in_memory == cf::MAP_IN_MEMORY;
+      return $map if !$load || $map->in_memory == cf::MAP_ACTIVE;
    }
    $MAP_PREFETCH{$path} |= $load;
    $MAP_PREFETCHER ||= cf::async {
    cf::async {
       $Coro::current->{desc} = "map player save";
       $_->contr->save for $self->players;
    };
+   cf::get_slot 0.02;
    if ($uniq) {
       $self->_save_objects ($save, cf::IO_HEADER | cf::IO_OBJECTS);
       $self->_save_objects ($uniq, cf::IO_UNIQUES);
    } else {
       $self->_save_objects ($save, cf::IO_HEADER | cf::IO_OBJECTS | cf::IO_UNIQUES);
    $self->save;
    my $lock = cf::lock_acquire "map_data:$self->{path}";
    return if $self->players;
-   return if $self->in_memory != cf::MAP_IN_MEMORY;
+   return if $self->in_memory != cf::MAP_ACTIVE;
    return if $self->{deny_save};
    $self->in_memory (cf::MAP_SWAPPED);
    $self->deactivate;
 sub unique_maps() {
    [
       map {
          utf8::decode $_;
-         /\.map$/
+         s/\.map$//; # TODO future compatibility hack
+         /\.pst$/ || !/^$PATH_SEP/o # TODO unique maps apparebntly lack the .map suffix :/
+            ? ()
-            ? normalise $_
+            : normalise $_
-            : ()
       } @{ aio_readdir $UNIQUEDIR or [] }
    ]
 }
-package cf;
 =back
 =head3 cf::object
 =cut
 =over 4
 =item $ob->inv_recursive
-Returns the inventory of the object _and_ their inventories, recursively.
+Returns the inventory of the object I<and> their inventories, recursively,
+but I<not> the object itself.
 =cut
 sub inv_recursive_;
 sub inv_recursive_ {
    inv_recursive_ inv $_[0]
 }
 =item $ref = $ob->ref
-creates and returns a persistent reference to an objetc that can be stored as a string.
+Creates and returns a persistent reference to an object that can be stored as a string.
 =item $ob = cf::object::deref ($refstring)
 returns the objetc referenced by refstring. may return undef when it cnanot find the object,
 even if the object actually exists. May block.
 can be C<undef>. Does the right thing when the player is currently in a
 dialogue with the given NPC character.
 =cut
+our $SAY_CHANNEL = {
+   id      => "say",
+   title   => "Map",
+   reply   => "say ",
+   tooltip => "Things said to and replied from npcs near you and other players on the same map only.",
+};
+our $CHAT_CHANNEL = {
+   id      => "chat",
+   title   => "Chat",
+   reply   => "chat ",
+   tooltip => "Player chat and shouts, global to the server.",
+};
 # rough implementation of a future "reply" method that works
 # with dialog boxes.
 #TODO: the first argument must go, split into a $npc->reply_to ( method
 sub cf::object::player::reply($$$;$) {
    my ($self, $npc, $msg, $flags) = @_;
          my $dialog = $pl->{npc_dialog};
          $dialog->{pl}->ext_msg ($dialog->{id}, update => msg => $dialog->{pl}->expand_cfpod ($msg));
       } else {
          $msg = $npc->name . " says: $msg" if $npc;
-         $self->message ($msg, $flags);
+         $self->send_msg ($SAY_CHANNEL => $msg, $flags);
       }
    }
 }
 =item $object->send_msg ($channel, $msg, $color, [extra...])
 Moves the player to the given map-path and coordinates by first freezing
 her, loading and preparing them map, calling the provided $check callback
 that has to return the map if sucecssful, and then unfreezes the player on
 the new (success) or old (failed) map position. In either case, $done will
 be called at the end of this process.
+Note that $check will be called with a potentially non-loaded map, so if
+it needs a loaded map it has to call C<< ->load >>.
 =cut
 our $GOTOGEN;
 }
 sub prepare_random_map {
    my ($exit) = @_;
-   my $guard = cf::lock_acquire "exit_prepare:$exit";
    # all this does is basically replace the /! path by
    # a new random map path (?random/...) with a seed
    # that depends on the exit object
    my $rmp = parse_random_map_params $exit->msg;
    if ($exit->map) {
       $rmp->{region}     = $exit->region->name;
       $rmp->{origin_map} = $exit->map->path;
       $rmp->{origin_x}   = $exit->x;
       $rmp->{origin_y}   = $exit->y;
+      $exit->map->touch;
    }
    $rmp->{random_seed} ||= $exit->random_seed;
-   my $data = cf::encode_json $rmp;
+   my $data = JSON::XS->new->utf8->pretty->canonical->encode ($rmp);
    my $md5 = Digest::MD5::md5_hex $data;
    my $meta = "$RANDOMDIR/$md5.meta";
    if (my $fh = aio_open "$meta~", O_WRONLY | O_CREAT, 0666) {
       aio_write $fh, 0, (length $data), $data, 0;
       undef $fh;
       aio_rename "$meta~", $meta;
+      my $slaying = "?random/$md5";
+      if ($exit->valid) {
-      $exit->slaying ("?random/$md5");
+         $exit->slaying ("?random/$md5");
-      $exit->msg (undef);
+         $exit->msg (undef);
+      }
    }
 }
 sub cf::object::player::enter_exit {
    my ($self, $exit) = @_;
    return unless $self->type == cf::PLAYER;
-   if ($exit->slaying eq "/!") {
-      #TODO: this should de-fi-ni-te-ly not be a sync-job
-      # the problem is that $exit might not survive long enough
-      # so it needs to be done right now, right here
-      cf::sync_job { prepare_random_map $exit };
-   }
-   my $slaying = cf::map::normalise $exit->slaying, $exit->map && $exit->map->path;
-   my $hp      = $exit->stats->hp;
-   my $sp      = $exit->stats->sp;
    $self->enter_link;
-   # if exit is damned, update players death & WoR home-position
-   $self->contr->savebed ($slaying, $hp, $sp)
-      if $exit->flag (FLAG_DAMNED);
    (async {
-      $Coro::current->{desc} = "enter_exit $slaying $hp $sp";
+      $Coro::current->{desc} = "enter_exit";
-      $self->deactivate_recursive; # just to be sure
       unless (eval {
+         $self->deactivate_recursive; # just to be sure
+         # random map handling
+         {
+            my $guard = cf::lock_acquire "exit_prepare:$exit";
+            prepare_random_map $exit
+               if $exit->slaying eq "/!";
+         }
+         my $map = cf::map::normalise $exit->slaying, $exit->map && $exit->map->path;
+         my $x   = $exit->stats->hp;
+         my $y   = $exit->stats->sp;
-         $self->goto ($slaying, $hp, $sp);
+         $self->goto ($map, $x, $y);
+         # if exit is damned, update players death & WoR home-position
+         $self->contr->savebed ($map, $x, $y)
+            if $exit->flag (cf::FLAG_DAMNED);
-         1;
+         1
       }) {
          $self->message ("Something went wrong deep within the crossfire server. "
                        . "I'll try to bring you back to the map you were before. "
                        . "Please report this to the dungeon master!",
                          cf::NDI_UNIQUE | cf::NDI_RED);
       id      => "infobox",
       title   => "Map Info",
       reply   => undef,
       tooltip => "Information related to the maps",
    },
+   "c/party" => {
+      id      => "party",
+      title   => "Party",
+      reply   => "gsay ",
+      tooltip => "Messages and chat related to your party",
+   },
 );
 sub cf::client::send_msg {
    my ($self, $channel, $msg, $color, @extra) = @_;
    if ($self->can_msg) {
       # default colour, mask it out
       $color &= ~(cf::NDI_COLOR_MASK | cf::NDI_DEF)
          if $color & cf::NDI_DEF;
-      $self->send_packet ("msg " . $self->{json_coder}->encode (
+      my $pkt = "msg "
+                . $self->{json_coder}->encode (
-         [$color & cf::NDI_CLIENT_MASK, $channel, $msg, @extra]));
+                   [$color & cf::NDI_CLIENT_MASK, $channel, $msg, @extra]
+                );
+      # try lzf for large packets
+      $pkt = "lzf " . Compress::LZF::compress $pkt
+         if 1024 <= length $pkt and $self->{can_lzf};
+      # split very large packets
+      if (8192 < length $pkt and $self->{can_lzf}) {
+         $self->send_packet ("frag $_") for unpack "(a8192)*", $pkt;
+         $pkt = "frag";
+      }
+      $self->send_packet ($pkt);
    } else {
       if ($color >= 0) {
          # replace some tags by gcfclient-compatible ones
          for ($msg) {
             1 while
 The following functions and methods are available within a safe environment:
   cf::object
      contr pay_amount pay_player map x y force_find force_add destroy
-     insert remove name archname title slaying race decrease_ob_nr
+     insert remove name archname title slaying race decrease split
   cf::object::player
      player
   cf::player
 =cut
 for (
    ["cf::object"         => qw(contr pay_amount pay_player map force_find force_add x y
-                               insert remove inv name archname title slaying race
+                               insert remove inv nrof name archname title slaying race
-                               decrease_ob_nr destroy)],
+                               decrease split destroy change_exp)],
    ["cf::object::player" => qw(player)],
    ["cf::player"         => qw(peaceful)],
    ["cf::map"            => qw(trigger)],
 ) {
    no strict 'refs';
             $RESOURCE{$name} = $info;
          }
          cf::cede_to_tick;
       }
-      if (my $soundconf = delete $res->{"res/sound.conf"}) {
-         $soundconf = $enc->decode (delete $soundconf->{data});
-         for (0 .. SOUND_CAST_SPELL_0 - 1) {
-            my $sound = $soundconf->{compat}[$_]
-               or next;
-            my $face = cf::face::find "sound/$sound->[1]";
-            cf::sound::set $sound->[0] => $face;
-            cf::sound::old_sound_index $_, $face; # gcfclient-compat
-         }
-         while (my ($k, $v) = each %{$soundconf->{event}}) {
-            my $face = cf::face::find "sound/$v";
-            cf::sound::set $k => $face;
-         }
-      }
    }
+   cf::global->invoke (EVENT_GLOBAL_RESOURCE_UPDATE);
    1
 }
+cf::global->attach (on_resource_update => sub {
+   if (my $soundconf = $RESOURCE{"res/sound.conf"}) {
+      $soundconf = JSON::XS->new->utf8->relaxed->decode ($soundconf->{data});
+      for (0 .. SOUND_CAST_SPELL_0 - 1) {
+         my $sound = $soundconf->{compat}[$_]
+            or next;
+         my $face = cf::face::find "sound/$sound->[1]";
+         cf::sound::set $sound->[0] => $face;
+         cf::sound::old_sound_index $_, $face; # gcfclient-compat
+      }
+      while (my ($k, $v) = each %{$soundconf->{event}}) {
+         my $face = cf::face::find "sound/$v";
+         cf::sound::set $k => $face;
+      }
+   }
+});
 register_exticmd fx_want => sub {
    my ($ns, $want) = @_;
    while (my ($k, $v) = each %$want) {
       $ns->fx_want ($k, $v);
    }
 };
+sub load_resource_file($) {
+   my $guard = lock_acquire "load_resource_file";
+   my $status = load_resource_file_ $_[0];
+   get_slot 0.1, 100;
+   cf::arch::commit_load;
+   $status
+}
 sub reload_regions {
    # HACK to clear player env face cache, we need some signal framework
    # for this (global event?)
    %ext::player_env::MUSIC_FACE_CACHE = ();
 }
 sub reload_archetypes {
    load_resource_file "$DATADIR/archetypes"
       or die "unable to load archetypes\n";
-   #d# NEED to laod twice to resolve forward references
-   # this really needs to be done in an extra post-pass
-   # (which needs to be synchronous, so solve it differently)
-   load_resource_file "$DATADIR/archetypes"
-      or die "unable to load archetypes\n";
 }
 sub reload_treasures {
    load_resource_file "$DATADIR/treasures"
       or die "unable to load treasurelists\n";
 }
 sub reload_resources {
    warn "reloading resource files...\n";
+   reload_facedata;
+   reload_archetypes;
    reload_regions;
-   reload_facedata;
-   #reload_archetypes;#d#
-   reload_archetypes;
    reload_treasures;
    warn "finished reloading resource files\n";
 }
 sub init {
+   my $guard = freeze_mainloop;
+   evthread_start IO::AIO::poll_fileno;
    reload_resources;
 }
 sub reload_config {
    open my $fh, "<:utf8", "$CONFDIR/config"
       or return;
    local $/;
-   *CFG = YAML::Syck::Load <$fh>;
+   *CFG = YAML::Load <$fh>;
    $EMERGENCY_POSITION = $CFG{emergency_position} || ["/world/world_105_115", 5, 37];
    $cf::map::MAX_RESET     = $CFG{map_max_reset}     if exists $CFG{map_max_reset};
    $cf::map::DEFAULT_RESET = $CFG{map_default_reset} if exists $CFG{map_default_reset};
       };
       warn $@ if $@;
    }
 }
+sub pidfile() {
+   sysopen my $fh, $PIDFILE, O_RDWR | O_CREAT
+      or die "$PIDFILE: $!";
+   flock $fh, &Fcntl::LOCK_EX
+      or die "$PIDFILE: flock: $!";
+   $fh
+}
+# make sure only one server instance is running at any one time
+sub atomic {
+   my $fh = pidfile;
+   my $pid = <$fh>;
+   kill 9, $pid if $pid > 0;
+   seek $fh, 0, 0;
+   print $fh $$;
+}
 sub main {
+   atomic;
    # we must not ever block the main coroutine
    local $Coro::idle = sub {
       Carp::cluck "FATAL: Coro::idle was called, major BUG, use cf::sync_job!\n";#d#
       (async {
          $Coro::current->{desc} = "IDLE BUG HANDLER";
          EV::loop EV::LOOP_ONESHOT;
       })->prio (Coro::PRIO_MAX);
    };
+   {
+      my $guard = freeze_mainloop;
-   reload_config;
+      reload_config;
-   db_init;
+      db_init;
-   load_extensions;
+      load_extensions;
-   $TICK_WATCHER->start;
-   $Coro::current->prio (Coro::PRIO_MAX); # give the main loop max. priority
+      $Coro::current->prio (Coro::PRIO_MAX); # give the main loop max. priority
+   }
+   utime time, time, $RUNTIMEFILE;
+   # no (long-running) fork's whatsoever before this point(!)
+   POSIX::close delete $ENV{LOCKUTIL_LOCK_FD} if exists $ENV{LOCKUTIL_LOCK_FD};
    EV::loop;
 }
 #############################################################################
 # initialisation and cleanup
          cf::cleanup "SIG$signal";
       };
    }
 }
-sub write_runtime {
+sub write_runtime_sync {
-   my $runtime = "$LOCALDIR/runtime";
    # first touch the runtime file to show we are still running:
    # the fsync below can take a very very long time.
-   IO::AIO::aio_utime $runtime, undef, undef;
+   IO::AIO::aio_utime $RUNTIMEFILE, undef, undef;
    my $guard = cf::lock_acquire "write_runtime";
-   my $fh = aio_open "$runtime~", O_WRONLY | O_CREAT, 0644
+   my $fh = aio_open "$RUNTIMEFILE~", O_WRONLY | O_CREAT, 0644
       or return;
    my $value = $cf::RUNTIME + 90 + 10;
    # 10 is the runtime save interval, for a monotonic clock
    # 60 allows for the watchdog to kill the server.
    aio_utime $fh, undef, undef;
    close $fh
       or return;
-   aio_rename "$runtime~", $runtime
+   aio_rename "$RUNTIMEFILE~", $RUNTIMEFILE
       and return;
    warn "runtime file written.\n";
    1
+}
+our $uuid_lock;
+our $uuid_skip;
+sub write_uuid_sync($) {
+   $uuid_skip ||= $_[0];
+   return if $uuid_lock;
+   local $uuid_lock = 1;
+   my $uuid = "$LOCALDIR/uuid";
+   my $fh = aio_open "$uuid~", O_WRONLY | O_CREAT, 0644
+      or return;
+   my $value = uuid_str $uuid_skip + uuid_seq uuid_cur;
+   $uuid_skip = 0;
+   (aio_write $fh, 0, (length $value), $value, 0) <= 0
+      and return;
+   # always fsync - this file is important
+   aio_fsync $fh
+      and return;
+   close $fh
+      or return;
+   aio_rename "$uuid~", $uuid
+      and return;
+   warn "uuid file written ($value).\n";
+   1
+}
+sub write_uuid($$) {
+   my ($skip, $sync) = @_;
+   $sync ? write_uuid_sync $skip
+         : async { write_uuid_sync $skip };
 }
 sub emergency_save() {
    my $freeze_guard = cf::freeze_mainloop;
       warn "end emergency map save\n";
       warn "begin emergency database checkpoint\n";
       BDB::db_env_txn_checkpoint $DB_ENV;
       warn "end emergency database checkpoint\n";
+      warn "begin write uuid\n";
+      write_uuid_sync 1;
+      warn "end write uuid\n";
    };
    warn "leave emergency perl save\n";
 }
 sub post_cleanup {
    my ($make_core) = @_;
    warn Carp::longmess "post_cleanup backtrace"
       if $make_core;
+   my $fh = pidfile;
+   unlink $PIDFILE if <$fh> == $$;
 }
+# a safer delete_package, copied from Symbol
+sub clear_package($) {
+   my $pkg = shift;
+   # expand to full symbol table name if needed
+   unless ($pkg =~ /^main::.*::$/) {
+      $pkg = "main$pkg"       if      $pkg =~ /^::/;
+      $pkg = "main::$pkg"     unless  $pkg =~ /^main::/;
+      $pkg .= '::'            unless  $pkg =~ /::$/;
+   }
+   my($stem, $leaf) = $pkg =~ m/(.*::)(\w+::)$/;
+   my $stem_symtab = *{$stem}{HASH};
+   defined $stem_symtab and exists $stem_symtab->{$leaf}
+      or return;
+   # clear all symbols
+   my $leaf_symtab = *{$stem_symtab->{$leaf}}{HASH};
+   for my $name (keys %$leaf_symtab) {
+      _gv_clear *{"$pkg$name"};
+#      use PApp::Util; PApp::Util::sv_dump *{"$pkg$name"};
+   }
+   warn "cleared package #$pkg\n";#d#
+}
+our $RELOAD; # how many times to reload
 sub do_reload_perl() {
    # can/must only be called in main
    if ($Coro::current != $Coro::main) {
       warn "can only reload from main coroutine";
       return;
    }
+   return if $RELOAD++;
+   while ($RELOAD) {
-   warn "reloading...";
+      warn "reloading...";
-   warn "entering sync_job";
+      warn "entering sync_job";
-   cf::sync_job {
+      cf::sync_job {
-      cf::write_runtime; # external watchdog should not bark
+         cf::write_runtime_sync; # external watchdog should not bark
-      cf::emergency_save;
+         cf::emergency_save;
-      cf::write_runtime; # external watchdog should not bark
+         cf::write_runtime_sync; # external watchdog should not bark
-      warn "syncing database to disk";
+         warn "syncing database to disk";
-      BDB::db_env_txn_checkpoint $DB_ENV;
+         BDB::db_env_txn_checkpoint $DB_ENV;
-      # if anything goes wrong in here, we should simply crash as we already saved
+         # if anything goes wrong in here, we should simply crash as we already saved
-      warn "flushing outstanding aio requests";
+         warn "flushing outstanding aio requests";
-      for (;;) {
-         BDB::flush;
-         IO::AIO::flush;
-         Coro::cede_notself;
-         last unless IO::AIO::nreqs || BDB::nreqs;
+         while (IO::AIO::nreqs || BDB::nreqs) {
-         warn "iterate...";
+            Coro::EV::timer_once 0.01; # let the sync_job do it's thing
-      }
-      ++$RELOAD;
-      warn "cancelling all extension coros";
-      $_->cancel for values %EXT_CORO;
-      %EXT_CORO = ();
-      warn "removing commands";
-      %COMMAND = ();
-      warn "removing ext/exti commands";
-      %EXTCMD  = ();
-      %EXTICMD = ();
-      warn "unloading/nuking all extensions";
-      for my $pkg (@EXTS) {
-         warn "... unloading $pkg";
-         if (my $cb = $pkg->can ("unload")) {
-            eval {
-               $cb->($pkg);
-               1
-            } or warn "$pkg unloaded, but with errors: $@";
          }
-         warn "... nuking $pkg";
+         warn "cancelling all extension coros";
-         Symbol::delete_package $pkg;
+         $_->cancel for values %EXT_CORO;
-      }
+         %EXT_CORO = ();
-      warn "unloading all perl modules loaded from $LIBDIR";
+         warn "removing commands";
-      while (my ($k, $v) = each %INC) {
+         %COMMAND = ();
-         next unless $v =~ /^\Q$LIBDIR\E\/.*\.pm$/;
+         warn "removing ext/exti commands";
+         %EXTCMD  = ();
+         %EXTICMD = ();
+         warn "unloading/nuking all extensions";
+         for my $pkg (@EXTS) {
-         warn "... unloading $k";
+            warn "... unloading $pkg";
-         delete $INC{$k};
-         $k =~ s/\.pm$//;
-         $k =~ s/\//::/g;
-         if (my $cb = $k->can ("unload_module")) {
+            if (my $cb = $pkg->can ("unload")) {
+               eval {
-            $cb->();
+                  $cb->($pkg);
+                  1
+               } or warn "$pkg unloaded, but with errors: $@";
+            }
+            warn "... clearing $pkg";
+            clear_package $pkg;
          }
-         Symbol::delete_package $k;
+         warn "unloading all perl modules loaded from $LIBDIR";
+         while (my ($k, $v) = each %INC) {
+            next unless $v =~ /^\Q$LIBDIR\E\/.*\.pm$/;
+            warn "... unloading $k";
+            delete $INC{$k};
+            $k =~ s/\.pm$//;
+            $k =~ s/\//::/g;
+            if (my $cb = $k->can ("unload_module")) {
+               $cb->();
+            }
+            clear_package $k;
-      }
+         }
-      warn "getting rid of safe::, as good as possible";
+         warn "getting rid of safe::, as good as possible";
-      Symbol::delete_package "safe::$_"
+         clear_package "safe::$_"
-         for qw(cf::attachable cf::object cf::object::player cf::client cf::player cf::map cf::party cf::region);
+            for qw(cf::attachable cf::object cf::object::player cf::client cf::player cf::map cf::party cf::region);
-      warn "unloading cf.pm \"a bit\"";
+         warn "unloading cf.pm \"a bit\"";
-      delete $INC{"cf.pm"};
+         delete $INC{"cf.pm"};
-      delete $INC{"cf/pod.pm"};
+         delete $INC{"cf/pod.pm"};
-      # don't, removes xs symbols, too,
+         # don't, removes xs symbols, too,
-      # and global variables created in xs
+         # and global variables created in xs
-      #Symbol::delete_package __PACKAGE__;
+         #clear_package __PACKAGE__;
-      warn "unload completed, starting to reload now";
+         warn "unload completed, starting to reload now";
-      warn "reloading cf.pm";
+         warn "reloading cf.pm";
-      require cf;
+         require cf;
-      cf::_connect_to_perl; # nominally unnecessary, but cannot hurt
+         cf::_connect_to_perl; # nominally unnecessary, but cannot hurt
-      warn "loading config and database again";
+         warn "loading config and database again";
-      cf::reload_config;
+         cf::reload_config;
-      warn "loading extensions";
+         warn "loading extensions";
-      cf::load_extensions;
+         cf::load_extensions;
-      warn "reattaching attachments to objects/players";
+         warn "reattaching attachments to objects/players";
-      _global_reattach; # objects, sockets
+         _global_reattach; # objects, sockets
-      warn "reattaching attachments to maps";
+         warn "reattaching attachments to maps";
-      reattach $_ for values %MAP;
+         reattach $_ for values %MAP;
-      warn "reattaching attachments to players";
+         warn "reattaching attachments to players";
-      reattach $_ for values %PLAYER;
+         reattach $_ for values %PLAYER;
-      warn "leaving sync_job";
+         warn "leaving sync_job";
-      1
+         1
-   } or do {
+      } or do {
-      warn $@;
+         warn $@;
-      warn "error while reloading, exiting.";
+         cf::cleanup "error while reloading, exiting.";
-      exit 1;
-   };
+      };
-   warn "reloaded";
+      warn "reloaded";
+      --$RELOAD;
+   }
 };
 our $RELOAD_WATCHER; # used only during reload
 sub reload_perl() {
    # doing reload synchronously and two reloads happen back-to-back,
    # coro crashes during coro_state_free->destroy here.
    $RELOAD_WATCHER ||= EV::timer 0, 0, sub {
+      do_reload_perl;
       undef $RELOAD_WATCHER;
-      do_reload_perl;
    };
 }
 register_command "reload" => sub {
    my ($who, $arg) = @_;
 our @WAIT_FOR_TICK;
 our @WAIT_FOR_TICK_BEGIN;
 sub wait_for_tick {
-   return unless $TICK_WATCHER->is_active;
-   return if $Coro::current == $Coro::main;
+   return if tick_inhibit || $Coro::current == $Coro::main;
    my $signal = new Coro::Signal;
    push @WAIT_FOR_TICK, $signal;
    $signal->wait;
 }
 sub wait_for_tick_begin {
-   return unless $TICK_WATCHER->is_active;
-   return if $Coro::current == $Coro::main;
+   return if tick_inhibit || $Coro::current == $Coro::main;
    my $signal = new Coro::Signal;
    push @WAIT_FOR_TICK_BEGIN, $signal;
    $signal->wait;
 }
-$TICK_WATCHER = EV::periodic_ns 0, $TICK, 0, sub {
+sub tick {
    if ($Coro::current != $Coro::main) {
       Carp::cluck "major BUG: server tick called outside of main coro, skipping it"
          unless ++$bug_warning > 10;
       return;
    }
-   $NOW = $tick_start = EV::now;
    cf::server_tick; # one server iteration
-   $RUNTIME += $TICK;
-   $NEXT_TICK = $_[0]->at;
    if ($NOW >= $NEXT_RUNTIME_WRITE) {
       $NEXT_RUNTIME_WRITE = List::Util::max $NEXT_RUNTIME_WRITE + 10, $NOW + 5.;
       Coro::async_pool {
          $Coro::current->{desc} = "runtime saver";
-         write_runtime
+         write_runtime_sync
             or warn "ERROR: unable to write runtime file: $!";
       };
    }
    if (my $sig = shift @WAIT_FOR_TICK_BEGIN) {
    }
    while (my $sig = shift @WAIT_FOR_TICK) {
       $sig->send;
    }
-   $LOAD = ($NOW - $tick_start) / $TICK;
+   $LOAD = ($NOW - $TICK_START) / $TICK;
    $LOADAVG = $LOADAVG * 0.75 + $LOAD * 0.25;
-   _post_tick;
+   if (0) {
-};
+      if ($NEXT_TICK) {
-$TICK_WATCHER->priority (EV::MAXPRI);
+         my $jitter = $TICK_START - $NEXT_TICK;
+         $JITTER = $JITTER * 0.75 + $jitter * 0.25;
+         warn "jitter $JITTER\n";#d#
+      }
+   }
+}
 {
    # configure BDB
    BDB::min_parallel 8;
    BDB::max_poll_reqs $TICK * 0.1;
-   $Coro::BDB::WATCHER->priority (1);
+   $AnyEvent::BDB::WATCHER->priority (1);
    unless ($DB_ENV) {
       $DB_ENV = BDB::db_env_create;
-      $DB_ENV->set_flags (BDB::AUTO_COMMIT | BDB::REGION_INIT | BDB::TXN_NOSYNC
+      $DB_ENV->set_flags (BDB::AUTO_COMMIT | BDB::REGION_INIT);
-                          | BDB::LOG_AUTOREMOVE, 1);
+      $DB_ENV->set_flags      (&BDB::LOG_AUTOREMOVE ) if BDB::VERSION v0, v4.7;
+      $DB_ENV->log_set_config (&BDB::LOG_AUTO_REMOVE) if BDB::VERSION v4.7;
       $DB_ENV->set_timeout (30, BDB::SET_TXN_TIMEOUT);
       $DB_ENV->set_timeout (30, BDB::SET_LOCK_TIMEOUT);
       cf::sync_job {
          eval {
 {
    # configure IO::AIO
    IO::AIO::min_parallel 8;
    IO::AIO::max_poll_time $TICK * 0.1;
-   $Coro::AIO::WATCHER->priority (1);
+   undef $AnyEvent::AIO::WATCHER;
 }
 my $_log_backtrace;
 sub _log_backtrace {

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/lib/cf.pm (file contents): Revision 1.405 by root, Mon Dec 17 08:03:22 2007 UTC vs. Revision 1.445 by root, Wed Sep 10 18:18:10 2008 UTC

Diff Legend

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.405 by root, Mon Dec 17 08:03:22 2007 UTC vs.
Revision 1.445 by root, Wed Sep 10 18:18:10 2008 UTC