[ViewVC] Diff of: cvs/deliantra/server/lib/cf.pm

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.565 by root, Sat Apr 30 05:41:17 2011 UTC vs.
Revision 1.582 by root, Fri Feb 3 03:01:45 2012 UTC

 #
 # This file is part of Deliantra, the Roguelike Realtime MMORPG.
 #
-# Copyright (©) 2006,2007,2008,2009,2010,2011 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
+# Copyright (©) 2006,2007,2008,2009,2010,2011,2012 Marc Alexander Lehmann / Robin Redeker / the Deliantra team
 #
 # Deliantra is free software: you can redistribute it and/or modify it under
 # the terms of the Affero GNU General Public License as published by the
 # Free Software Foundation, either version 3 of the License, or (at your
 # option) any later version.
 our $RANDOMDIR   = "$LOCALDIR/random";
 our $BDBDIR      = "$LOCALDIR/db";
 our $PIDFILE     = "$LOCALDIR/pid";
 our $RUNTIMEFILE = "$LOCALDIR/runtime";
-our %RESOURCE; # unused
+#our %RESOURCE; # unused
 our $OUTPUT_RATE_MIN =    3000;
 our $OUTPUT_RATE_MAX = 1000000;
 our $MAX_LINKS       = 32; # how many chained exits to follow
 our $DB_ENV;
 our @EXTRA_MODULES = qw(pod match mapscript incloader);
 our %CFG;
+our %EXT_CFG; # cfgkeyname => [var-ref, defaultvalue]
 our $UPTIME; $UPTIME ||= time;
-our $RUNTIME;
+our $RUNTIME     = 0;
+our $SERVER_TICK = 0;
 our $NOW;
 our (%PLAYER, %PLAYER_LOADING); # all users
 our (%MAP,    %MAP_LOADING   ); # all maps
 our $LINK_MAP; # the special {link} map, which is always available
 our @POST_INIT;
 our $REATTACH_ON_RELOAD; # set to true to force object reattach on reload (slow)
 our $REALLY_UNLOOP;      # never set to true, please :)
+our $WAIT_FOR_TICK = new Coro::Signal;
+our @WAIT_FOR_TICK_BEGIN;
 binmode STDOUT;
 binmode STDERR;
 # read virtual server time, if available
 =over 4
 =item $cf::UPTIME
-The timestamp of the server start (so not actually an uptime).
+The timestamp of the server start (so not actually an "uptime").
+=item $cf::SERVER_TICK
+An unsigned integer that starts at zero when the server is started and is
+incremented on every tick.
+=item $cf::NOW
+The (real) time of the last (current) server tick - updated before and
+after tick processing, so this is useful only as a rough "what time is it
+now" estimate.
+=item $cf::TICK
+The interval between each server tick, in seconds.
 =item $cf::RUNTIME
 The time this server has run, starts at 0 and is increased by $cf::TICK on
 every server tick.
 Various directories - "/etc", read-only install directory, perl-library
 directory, pod-directory, read-only maps directory, "/var", "/var/tmp",
 unique-items directory, player file directory, random maps directory and
 database environment.
-=item $cf::NOW
-The time of the last (current) server tick.
-=item $cf::TICK
-The interval between server ticks, in seconds.
 =item $cf::LOADAVG
 The current CPU load on the server (alpha-smoothed), as a value between 0
 (none) and 1 (overloaded), indicating how much time is spent on processing
 objects per tick. Healthy values are < 0.5.
 =item cf::wait_for_tick, cf::wait_for_tick_begin
 These are functions that inhibit the current coroutine one tick. cf::wait_for_tick_begin only
 returns directly I<after> the tick processing (and consequently, can only wake one thread
 per tick), while cf::wait_for_tick wakes up all waiters after tick processing.
+Note that cf::Wait_for_tick will immediately return when the server is not
+ticking, making it suitable for small pauses in threads that need to run
+when the server is paused. If that is not applicable (i.e. you I<really>
+want to wait, use C<$cf::WAIT_FOR_TICK>).
+=item $cf::WAIT_FOR_TICK
+Note that C<cf::wait_for_tick> is probably the correct thing to use. This
+variable contains a L<Coro::Signal> that is broadcats after every server
+tick. Calling C<< ->wait >> on it will suspend the caller until after the
+next server tick.
 =cut
 sub wait_for_tick();
 sub wait_for_tick_begin();
       $d =~ s/([\x00-\x07\x09\x0b\x0c\x0e-\x1f])/sprintf "\\x%02x", ord($1)/ge;
       $d
    } || "[unable to dump $_[0]: '$@']";
 }
-=item $scalar = load_file $path
+=item $scalar = cf::load_file $path
 Loads the given file from path and returns its contents. Croaks on error
 and can block.
 =cut
 sub load_file($) {
    0 <= aio_load $_[0], my $data
       or Carp::croak "$_[0]: $!";
    $data
+}
+=item $success = cf::replace_file $path, $data, $sync
+Atomically replaces the file at the given $path with new $data, and
+optionally $sync the data to disk before replacing the file.
+=cut
+sub replace_file($$;$) {
+   my ($path, $data, $sync) = @_;
+   my $lock = cf::lock_acquire ("replace_file:$path");
+   my $fh = aio_open "$path~", Fcntl::O_WRONLY | Fcntl::O_CREAT | Fcntl::O_TRUNC, 0644
+      or return;
+   $data = $data->() if ref $data;
+   length $data == aio_write $fh, 0, (length $data), $data, 0
+      or return;
+   !$sync
+      or !aio_fsync $fh
+      or return;
+   aio_close $fh
+      and return;
+   aio_rename "$path~", $path
+      and return;
+   if ($sync) {
+      $path =~ s%/[^/]*$%%;
+      aio_pathsync $path;
+   }
+   1
 }
 =item $ref = cf::decode_json $json
 Converts a JSON string into the corresponding perl data structure.
          }
       }
       if (@SLOT_QUEUE) {
          # we do not use wait_for_tick() as it returns immediately when tick is inactive
-         push @cf::WAIT_FOR_TICK, $signal;
+         $WAIT_FOR_TICK->wait;
-         $signal->wait;
       } else {
          $busy = 0;
          Coro::schedule;
       }
    }
       my ($pl, $buf) = @_;
       my $msg = eval { $pl->ns->{json_coder}->decode ($buf) };
       if (ref $msg) {
-         my ($type, $reply, @payload) =
+         my ($type, $reply, @payload) = @$msg; # version 1 used %type, $id, %$hash
-            "ARRAY" eq ref $msg
-               ? @$msg
-               : ($msg->{msgtype}, $msg->{msgid}, %$msg); # TODO: version 1, remove
          my @reply;
          if (my $cb = $EXTCMD{$type}) {
             @reply = $cb->($pl, @payload);
    };
    $grp
 }
+sub _ext_cfg_reg($$$$) {
+   my ($rvar, $varname, $cfgname, $default) = @_;
+   $cfgname = lc $varname
+      unless length $cfgname;
+   $EXT_CFG{$cfgname} = [$rvar, $default];
+   $$rvar = exists $CFG{$cfgname} ? $CFG{$cfgname} : $default;
+}
 sub load_extensions {
    info "loading extensions...";
+   %EXT_CFG = ();
    cf::sync_job {
       my %todo;
       for my $path (<$LIBDIR/*.ext>) {
                   unless exists $done{$_};
             }
             trace "... pass $pass, loading '$k' into '$v->{pkg}'\n";
+            my $source = $v->{source};
+            # support "CONF varname :confname = default" pseudo-statements
+            $source =~ s{
+               ^ CONF \s+ ([^\s:=]+) \s* (?:: \s* ([^\s:=]+) \s* )? = ([^\n#]+)
+            }{
+               "our \$$1; BEGIN { cf::_ext_cfg_reg \\\$$1, q\x00$1\x00, q\x00$2\x00, $3 }";
+            }gmxe;
-            my $active = eval $v->{source};
+            my $active = eval $source;
             if (length $@) {
                error "$v->{path}: $@\n";
                cf::cleanup "mandatory extension '$k' failed to load, exiting."
    # {...        are special paths that are not being touched
    # ?xxx/...    are special absolute paths
    # ?random/... random maps
    # /...        normal maps
    # ~user/...   per-player map of a specific user
-   # !up !down   for quad maps, or other maps with up/down layers
    $path =~ s/$PATH_SEP/\//go;
    # treat it as relative path if it starts with
    # something that looks reasonable
    if ($path =~ m{^(?:\./|\.\./|\w)}) {
       $base or Carp::carp "normalise called with relative path and no base: '$path'";
       $base =~ s{[^/]+/?$}{};
       $path = "$base/$path";
-   } elsif ($path eq '!up') {
-      $base && ref $base
-         or Carp::carp "normalise called with relative tile path and no base: '$path'";
-      my $uppth = $base->tile_path (cf::TILE_UP);
-      $path = $uppth if $uppth;
-   } elsif ($path eq '!down') {
-      $base && ref $base
-         or Carp::carp "normalise called with relative tile path and no base: '$path'";
-      my $dpth = $base->tile_path (cf::TILE_DOWN);
-      $path = $dpth if $dpth;
    }
    for ($path) {
       redo if s{/\.?/}{/};
       redo if s{/[^/]+/\.\./}{/};
    $self->{load_path} = $path;
    1
 }
+# used to laod the header of an original map
 sub load_header_orig {
    my ($self) = @_;
    $self->load_header_from ($self->load_path)
 }
+# used to laod the header of an instantiated map
 sub load_header_temp {
    my ($self) = @_;
    $self->load_header_from ($self->save_path)
 }
+# called after loading the header from an instantiated map
 sub prepare_temp {
    my ($self) = @_;
    $self->last_access ((delete $self->{last_access})
                        || $cf::RUNTIME); #d#
    # safety
    $self->{instantiate_time} = $cf::RUNTIME
       if $self->{instantiate_time} > $cf::RUNTIME;
 }
+# called after loading the header from an original map
 sub prepare_orig {
    my ($self) = @_;
    $self->{load_original} = 1;
    $self->{instantiate_time} = $cf::RUNTIME;
    {
       my $guard = cf::lock_acquire "map_data:$path";
       return unless $self->valid;
-      return unless $self->in_memory == cf::MAP_SWAPPED;
+      return unless $self->state == cf::MAP_SWAPPED;
-      $self->in_memory (cf::MAP_LOADING);
       $self->alloc;
       $self->pre_load;
       cf::cede_to_tick;
                }
             }
          }
          $f->resolve_delayed_derefs;
+      } else {
+         $self->post_load_original
+            if delete $self->{load_original};
       }
+      $self->state (cf::MAP_INACTIVE);
       cf::cede_to_tick;
       # now do the right thing for maps
       $self->link_multipart_objects;
       $self->difficulty ($self->estimate_difficulty)
       unless ($self->{deny_activate}) {
          $self->decay_objects;
          $self->fix_auto_apply;
          $self->update_buttons;
          cf::cede_to_tick;
-         $self->activate;
+         #$self->activate; # no longer activate maps automatically
       }
       $self->{last_save} = $cf::RUNTIME;
       $self->last_access ($cf::RUNTIME);
-      $self->in_memory (cf::MAP_ACTIVE);
    }
    $self->post_load;
    1
 #      if $self->per_party;
    $self
 }
-# find and load all maps in the 3x3 area around a map
-sub load_neighbours {
-   my ($map) = @_;
-   my @neigh; # diagonal neighbours
-   for (0 .. 3) {
-      my $neigh = $map->tile_path ($_)
-         or next;
-      $neigh = find $neigh, $map
-         or next;
-      $neigh->load;
-      # now find the diagonal neighbours
-      push @neigh,
-         [$neigh->tile_path (($_ + 3) % 4), $neigh],
-         [$neigh->tile_path (($_ + 1) % 4), $neigh];
-   }
-   for (grep defined $_->[0], @neigh) {
-      my ($path, $origin) = @$_;
-      my $neigh = find $path, $origin
-         or next;
-      $neigh->load;
-   }
-}
 sub find_sync {
    my ($path, $origin) = @_;
+   # it's a bug to call this from the main context
    return cf::LOG cf::llevError | cf::logBacktrace, "do_find_sync"
       if $Coro::current == $Coro::main;
    find $path, $origin
 }
 sub do_load_sync {
    my ($map) = @_;
+   # it's a bug to call this from the main context
    return cf::LOG cf::llevError | cf::logBacktrace, "do_load_sync"
       if $Coro::current == $Coro::main;
    $map->load;
 }
    my ($path, $origin, $load) = @_;
    $path = normalise $path, $origin;
    if (my $map = $cf::MAP{$path}) {
-      return $map if !$load || $map->in_memory == cf::MAP_ACTIVE;
+      return $map if !$load || $map->linkable;
    }
    $MAP_PREFETCH{$path} |= $load;
    $MAP_PREFETCHER ||= cf::async {
 sub swap_out {
    my ($self) = @_;
    my $lock = cf::lock_acquire "map_data:$self->{path}";
-   return if $self->in_memory != cf::MAP_ACTIVE;
+   return if !$self->linkable;
    return if $self->{deny_save};
    return if $self->players;
    # first deactivate the map and "unlink" it from the core
    $self->deactivate;
    $_->clear_links_to ($self) for values %cf::MAP;
-   $self->in_memory (cf::MAP_SWAPPED);
+   $self->state (cf::MAP_SWAPPED);
    # then atomically save
    $self->_save;
    # then free the map
    return if $self->players;
    cf::trace "resetting map ", $self->path, "\n";
-   $self->in_memory (cf::MAP_SWAPPED);
+   $self->state (cf::MAP_SWAPPED);
    # need to save uniques path
    unless ($self->{deny_save}) {
       my $uniq = $self->uniq_path; utf8::encode $uniq;
    # use -1 or undef as default coordinates, not 0, 0
    ($x, $y) = ($map->enter_x, $map->enter_y)
       if $x <= 0 && $y <= 0;
    $map->load;
-   $map->load_neighbours;
    return unless $self->contr->active;
    local $self->{_prev_pos} = $link_pos; # ugly hack for rent.ext
    if ($self->enter_map ($map, $x, $y)) {
       $Coro::current->{desc} = "enter_exit";
       unless (eval {
          $self->deactivate_recursive; # just to be sure
-         # random map handling
-         {
-            my $guard = cf::lock_acquire "exit_prepare:$exit";
-            prepare_random_map $exit
-               if $exit->slaying eq "/!";
-         }
          my $map = cf::map::normalise $exit->slaying, $exit->map;
          my $x   = $exit->stats->hp;
          my $y   = $exit->stats->sp;
+         # special map handling
+         my $slaying = $exit->slaying;
+         # special map handling
+         if ($slaying eq "/!") {
+            my $guard = cf::lock_acquire "exit_prepare:$exit";
+            prepare_random_map $exit
+               if $exit->slaying eq "/!"; # need to re-check after getting the lock
+            $map = $exit->slaying;
+         } elsif ($slaying eq '!up') {
+            $map = $exit->map->tile_path (cf::TILE_UP);
+            $x = $exit->x;
+            $y = $exit->y;
+         } elsif ($slaying eq '!down') {
+            $map = $exit->map->tile_path (cf::TILE_DOWN);
+            $x = $exit->x;
+            $y = $exit->y;
+         }
          $self->goto ($map, $x, $y);
          # if exit is damned, update players death & WoR home-position
          $self->contr->savebed ($map, $x, $y)
 =cut
 sub cf::client::ext_reply($$@) {
    my ($self, $id, @msg) = @_;
-   if ($self->extcmd == 2) {
+   return unless $self->extcmd == 2;
-      $self->send_big_packet ("ext " . $self->{json_coder}->encode (["reply-$id", @msg]));
+   $self->send_big_packet ("ext " . $self->{json_coder}->encode (["reply-$id", @msg]));
-   } elsif ($self->extcmd == 1) {
-      #TODO: version 1, remove
-      unshift @msg, msgtype => "reply", msgid => $id;
-      $self->send_big_packet ("ext " . $self->{json_coder}->encode ({@msg}));
-   }
 }
 =item $success = $client->query ($flags, "text", \&cb)
 Queues a query to the client, calling the given callback with
       my ($ns, $buf) = @_;
       my $msg = eval { $ns->{json_coder}->decode ($buf) };
       if (ref $msg) {
-         my ($type, $reply, @payload) =
+         my ($type, $reply, @payload) = @$msg; # version 1 used %type, $id, %$hash
-            "ARRAY" eq ref $msg
-               ? @$msg
-               : ($msg->{msgtype}, $msg->{msgid}, %$msg); # TODO: version 1, remove
          my @reply;
          if (my $cb = $EXTICMD{$type}) {
             @reply = $cb->($ns, @payload);
    {
       my $res = $facedata->{resource};
       while (my ($name, $info) = each %$res) {
-         if (defined $info->{type}) {
+         if (defined (my $type = $info->{type})) {
+            # TODO: different hash - must free and use new index, or cache ixface data queue
             my $idx = (cf::face::find $name) || cf::face::alloc $name;
             cf::face::set_data $idx, 0, $info->{data}, $info->{hash};
-            cf::face::set_type $idx, $info->{type};
+            cf::face::set_type $idx, $type;
+            cf::face::set_meta $idx, $type & 1 ? undef : $info->{meta}; # preserve meta unless prepended already
          } else {
-            $RESOURCE{$name} = $info; # unused
+#            $RESOURCE{$name} = $info; # unused
          }
          cf::cede_to_tick;
       }
    }
 sub main {
    cf::init_globals; # initialise logging
    LOG llevInfo, "Welcome to Deliantra, v" . VERSION;
-   LOG llevInfo, "Copyright (C) 2005-2011 Marc Alexander Lehmann / Robin Redeker / the Deliantra team.";
+   LOG llevInfo, "Copyright (C) 2005-2012 Marc Alexander Lehmann / Robin Redeker / the Deliantra team.";
    LOG llevInfo, "Copyright (C) 1994 Mark Wedel.";
    LOG llevInfo, "Copyright (C) 1992 Frank Tore Johansen.";
    $Coro::current->prio (Coro::PRIO_MAX); # give the main loop max. priority
    };
    cf::object::thawer::errors_are_fatal 0;
    info "parse errors in files are no longer fatal from this point on.\n";
-   my $free_main; $free_main = EV::idle sub {
+   AE::postpone {
-      undef $free_main;
       undef &main; # free gobs of memory :)
    };
    goto &main_loop;
 }
       cf::write_runtime_sync; # external watchdog should not bark
       trace "emergency_perl_save: flushing outstanding aio requests";
       while (IO::AIO::nreqs || BDB::nreqs) {
-         Coro::EV::timer_once 0.01; # let the sync_job do it's thing
+         Coro::AnyEvent::sleep 0.01; # let the sync_job do it's thing
       }
       cf::write_runtime_sync; # external watchdog should not bark
    };
 #############################################################################
 my $bug_warning = 0;
-our @WAIT_FOR_TICK;
-our @WAIT_FOR_TICK_BEGIN;
 sub wait_for_tick() {
-   return Coro::cede if tick_inhibit || $Coro::current == $Coro::main;
+   return Coro::AnyEvent::poll if tick_inhibit || $Coro::current == $Coro::main;
-   my $signal = new Coro::Signal;
+   $WAIT_FOR_TICK->wait;
-   push @WAIT_FOR_TICK, $signal;
-   $signal->wait;
 }
 sub wait_for_tick_begin() {
-   return Coro::cede if tick_inhibit || $Coro::current == $Coro::main;
+   return Coro::AnyEvent::poll if tick_inhibit || $Coro::current == $Coro::main;
    my $signal = new Coro::Signal;
    push @WAIT_FOR_TICK_BEGIN, $signal;
    $signal->wait;
 }
       Carp::cluck "major BUG: server tick called outside of main coro, skipping it"
          unless ++$bug_warning > 10;
       return;
    }
-   cf::server_tick; # one server iteration
+   cf::one_tick; # one server iteration
    #for(1..3e6){} AE::now_update; $NOW=AE::now; # generate load #d#
    if ($NOW >= $NEXT_RUNTIME_WRITE) {
       $NEXT_RUNTIME_WRITE = List::Util::max $NEXT_RUNTIME_WRITE + 10, $NOW + 5.;
    }
    if (my $sig = shift @WAIT_FOR_TICK_BEGIN) {
       $sig->send;
    }
-   while (my $sig = shift @WAIT_FOR_TICK) {
+   $WAIT_FOR_TICK->broadcast;
-      $sig->send;
-   }
    $LOAD = ($NOW - $TICK_START) / $TICK;
    $LOADAVG = $LOADAVG * 0.75 + $LOAD * 0.25;
    if (0) {
 {
    # configure BDB
    BDB::min_parallel 16;
    BDB::max_poll_reqs $TICK * 0.1;
-   $AnyEvent::BDB::WATCHER->priority (1);
+   #$AnyEvent::BDB::WATCHER->priority (1);
    unless ($DB_ENV) {
       $DB_ENV = BDB::db_env_create;
       $DB_ENV->set_flags (BDB::AUTO_COMMIT | BDB::REGION_INIT);
       $DB_ENV->set_flags      (&BDB::LOG_AUTOREMOVE ) if BDB::VERSION v0, v4.7;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/lib/cf.pm (file contents): Revision 1.565 by root, Sat Apr 30 05:41:17 2011 UTC vs. Revision 1.582 by root, Fri Feb 3 03:01:45 2012 UTC

Diff Legend

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.565 by root, Sat Apr 30 05:41:17 2011 UTC vs.
Revision 1.582 by root, Fri Feb 3 03:01:45 2012 UTC