[ViewVC] Diff of: cvs/deliantra/server/lib/cf.pm

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.611 by root, Tue Nov 20 14:54:17 2012 UTC vs.
Revision 1.621 by root, Fri Nov 18 20:55:00 2016 UTC

 =item $cf::RUNTIME
 The time this server has run, starts at 0 and is increased by $cf::TICK on
 every server tick.
-=item $cf::CONFDIR $cf::DATADIR $cf::LIBDIR  $cf::PODDIR
+=item $cf::CONFDIR $cf::DATADIR $cf::LIBDIR $cf::PODDIR
 $cf::MAPDIR $cf::LOCALDIR $cf::TMPDIR $cf::UNIQUEDIR
 $cf::PLAYERDIR $cf::RANDOMDIR $cf::BDBDIR
 Various directories - "/etc", read-only install directory, perl-library
 directory, pod-directory, read-only maps directory, "/var", "/var/tmp",
    }
 }
 =item cf::lock_wait $string
 Wait until the given lock is available. See cf::lock_acquire.
 =item my $lock = cf::lock_acquire $string
 Wait until the given lock is available and then acquires it and returns
 a L<Guard> object. If the guard object gets destroyed (goes out of scope,
    my $signal = new Coro::Signal;
    my $busy;
    while () {
       next_job:
+      Coro::cede;
       my $avail = cf::till_tick;
       for (0 .. $#SLOT_QUEUE) {
          if ($SLOT_QUEUE[$_][0] <= $avail) {
             $busy = 0;
             my $job = splice @SLOT_QUEUE, $_, 1, ();
             $job->[2]->send;
-            Coro::cede;
             goto next_job;
          } else {
             $SLOT_QUEUE[$_][0] *= $SLOT_DECAY;
          }
       }
       if (@SLOT_QUEUE) {
-         # we do not use wait_for_tick() as it returns immediately when tick is inactive
+         wait_for_tick;
-         $WAIT_FOR_TICK->wait;
       } else {
          $busy = 0;
          Coro::schedule;
       }
    }
 BEGIN { *async = \&Coro::async_pool }
 =item cf::sync_job { BLOCK }
 The design of Deliantra requires that the main coroutine ($Coro::main)
-is always able to handle events or runnable, as Deliantra is only
+is always able to handle events or is runnable, as Deliantra is only
 partly reentrant. Thus "blocking" it by e.g. waiting for I/O is not
 acceptable.
 If it must be done, put the blocking parts into C<sync_job>. This will run
 the given BLOCK in another coroutine while waiting for the result. The
       while ($busy) {
          if (Coro::nready) {
             Coro::cede_notself;
          } else {
-            EV::loop EV::LOOP_ONESHOT;
+            EV::run EV::RUN_ONCE;
          }
       }
       my $time = AE::time - $time;
    $MAP_PREFETCHER ||= cf::async {
       $Coro::current->{desc} = "map prefetcher";
       while (%MAP_PREFETCH) {
-         while (my ($k, $v) = each %MAP_PREFETCH) {
+         for my $k (keys %MAP_PREFETCH) {
             if (my $map = find $k) {
-               $map->load if $v;
+               $map->load if $MAP_PREFETCH{$k};
             }
             delete $MAP_PREFETCH{$k};
          }
       }
 =item $player_object->may ("access")
 Returns wether the given player is authorized to access resource "access"
 (e.g. "command_wizcast").
+This is implemented by checking a config setting of C<may_access> where
+C<access> is replaced by the access string. The following alternatives are
+possible (and are tested in order):
+=over 4
+=item * Player is DM
+The request will succeed.
+=item * may_access is an array reference
+If either the player nickname or UUID is in the array, the request will
+succeed, otherwise it will fail.
+=item * may_access is a true value
+The request will succeed.
+=item * may_access is missing or false
+The request will fail.
+=back
 =cut
 sub cf::object::player::may {
    my ($self, $access) = @_;
    $self->flag (cf::FLAG_WIZ) ||
       (ref $cf::CFG{"may_$access"}
-         ? scalar grep $self->name eq $_, @{$cf::CFG{"may_$access"}}
+         ? scalar grep $self->name eq $_ || $self->uuid eq $_, @{$cf::CFG{"may_$access"}}
          : $cf::CFG{"may_$access"})
 }
 =item $player_object->enter_link
 The player should be reasonably safe there for short amounts of time (e.g.
 for loading a map). You I<MUST> call C<leave_link> as soon as possible,
 though, as the player cannot control the character while it is on the link
 map.
-Will never block.
+This method will never block, which is the whole reaosn for it's
+existance: you can I<always> put a player onto the link map, which is the
+only place to put objects that is guaranteed to exist.
+A typical usage pattern is to call C<enter_link> synchronously from the
+server, then start a new thread, do your blocking stuff there and then
+call C<leave_link> from that thread.
 =item $player_object->leave_link ($map, $x, $y)
 Moves the player out of the special C<{link}> map onto the specified
 map. If the map is not valid (or omitted), the player will be moved back
 sub cf::client::update_command_faces {
    my ($self) = @_;
    my @faces = grep $_,
+      $COMMAND_FACE{preferred},
       $COMMAND_FACE{standard},
-      $COMMAND_FACE{emote},
       $COMMAND_FACE{skill},
       $self->pl->ob->flag (cf::FLAG_WIZ) ? $COMMAND_FACE{dm} : (),
+      $COMMAND_FACE{emote},
    ;
    $self->send_face ($_)
       for @faces;
    $self->flush_fx;
    seek $fh, 0, 0;
    print $fh $$;
 }
 sub main_loop {
-   trace "EV::loop starting\n";
+   trace "EV::run starting\n";
    if (1) {
-      EV::loop;
+      EV::run;
    }
-   trace "EV::loop returned\n";
+   trace "EV::run returned\n";
    goto &main_loop unless $REALLY_UNLOOP;
 }
 sub main {
    cf::init_globals; # initialise logging
    # we must not ever block the main coroutine
    $Coro::idle = sub {
       Carp::cluck "FATAL: Coro::idle was called, major BUG, use cf::sync_job!\n";#d#
       (async {
          $Coro::current->{desc} = "IDLE BUG HANDLER";
-         EV::loop EV::LOOP_ONESHOT;
+         EV::run EV::RUN_ONCE;
       })->prio (Coro::PRIO_MAX);
    };
    evthread_start IO::AIO::poll_fileno;

Diff Legend

-–
+Removed lines
-+
+Added lines
-<
+Changed lines
->
+Changed lines

Comparing deliantra/server/lib/cf.pm (file contents): Revision 1.611 by root, Tue Nov 20 14:54:17 2012 UTC vs. Revision 1.621 by root, Fri Nov 18 20:55:00 2016 UTC

Diff Legend

Comparing deliantra/server/lib/cf.pm (file contents):
Revision 1.611 by root, Tue Nov 20 14:54:17 2012 UTC vs.
Revision 1.621 by root, Fri Nov 18 20:55:00 2016 UTC