ViewVC Help
View File | Revision Log | Show Annotations | Download File
/cvs/cvsroot/IO-AIO/Changes
Revision: 1.423
Committed: Tue Sep 22 20:43:56 2026 UTC (3 days, 8 hours ago) by root
Branch: MAIN
CVS Tags: HEAD
Changes since 1.422: +1 -0 lines
Log Message:
*** empty log message ***

File Contents

# User Rev Content
1 root 1.31 Revision history for IO::AIO
2 root 1.30
3 root 1.313 TODO: scandir - some dirs mostly contain subdirs - invert logic?
4 root 1.114 TODO: aio_cptree/mvtree
5 root 1.293 TODO: vmsplice? (http://kerneltrap.org/node/6505 http://lwn.net/Articles/178199/)
6 root 1.340 TODO: getxattr, setxattr, listxattr, removexattr etc.?
7 root 1.293 TODO: emulation for splice?
8 root 1.312 TODO: syncfs/sync windows:
9 root 1.319 TODO: posix_fallocate when flags=0
10 root 1.312 http://stackoverflow.com/questions/65170/how-to-get-name-associated-with-open-handle/5286888#5286888
11     http://blogs.msdn.com/b/adioltean/archive/2005/04/16/408947.aspx
12     http://msdn.microsoft.com/en-us/library/aa366789%28v=vs.85%29.aspx
13     http://msdn.microsoft.com/en-us/library/windows/desktop/aa366789%28v=vs.85%29.aspx
14     http://msdn.microsoft.com/en-us/library/windows/desktop/aa364425%28v=vs.85%29.aspx
15     http://msdn.microsoft.com/en-us/library/windows/desktop/aa364963%28v=vs.85%29.aspx
16     http://msdn.microsoft.com/en-us/library/windows/desktop/aa364996%28v=vs.85%29.aspx
17     http://msdn.microsoft.com/en-us/library/windows/desktop/aa364994%28v=vs.85%29.aspx
18 root 1.315 TODO: extra socket/tcp constants &c?
19 root 1.320 TODO: name_to_handle_At + open_by_handle_at = clone fds
20 root 1.328 TODO: lchown
21 root 1.401 TODO: ioprio_get/set
22 root 1.260
23 root 1.318 TODO: rewrite rmtree et al. to support working directories (also speed them up)
24 root 1.319 TODO: maybe IO::AIO leaks fds when requests are cancelled? maybe initialise result to -1?
25 root 1.325 TODO: aio_wd should use O_PATH on linux, due to lacking O_SEARCH (http://comments.gmane.org/gmane.linux.file-systems/33611)
26     http://www.openwall.com/lists/musl/2013/02/23/4
27 root 1.330 TODO: FIDEDUPERANGE, file_ioctl.c
28 root 1.332 TODO: mincore
29 root 1.334 TODO: SOCK_CLOEXEc etc.
30 root 1.361 TODO: unlinkat flags, linkat flags, statat, renameat2 flags
31 root 1.342 TODO: https://kernelnewbies.org/Linux_4.11
32 root 1.345 TODO: define useful rules for [[$wd, $path], $path] &c and implement them
33 root 1.353 TODO: https://github.com/coreutils/coreutils/blob/master/src/stat.c maybe IO::AIO::FSID
34 root 1.355 TODO: mlock2, MLOCK_ONFAULT
35 root 1.359 TODO: dup3, pipe2, accept4
36 root 1.368 TODO: dump config.log when automated testign and configure fails
37 root 1.372 TODO: ns time resolution in utime
38 root 1.381 TODO: statx
39 root 1.390 TODO: aio_fchdir/chdir? emulate chdirat?
40 root 1.388 TODO: rt-4.0.18-20109-1573826674-1229.126277-5-0@rt.cpan.org
41 root 1.386 TODO: aio_splice, aio_tee
42 root 1.387 TODO: copy_file_range
43 root 1.390 TODO: write more abpout the thread model, maybe bump some defaults?
44     TODO: io_uring, but it's so broken :/
45     TODO: allow import of fds as aio_wd
46 root 1.392 TODO: close_range
47 root 1.405 TODO: move_mount, open_tree, fsmount, fspick, fsconfig, fsopen https://lwn.net/Articles/759499/
48 root 1.413 TODO: aio_mmap
49 root 1.417 TODO: getrandom
50 root 1.419 TODO: IO::AIO::utime, IO::AIO::allocate &c
51 root 1.422 TODO: MEMFD_SEAL, ...
52 root 1.405
53 root 1.418 - add security considerations section.
54     - added st_[amcb]time2 functions to return times in [sec, nsec] format.
55     - support [sec, nsec] in aio_utime.
56     - new constants:
57     MADV_FREE, MADV_REMOVE, MADV_DONTFORK, MADV_DOFORK, MADV_MERGEABLE,
58     MADV_UNMERGEABLE, MADV_HUGEPAGE, MADV_NOHUGEPAGE, MADV_DONTDUMP,
59     MADV_DODUMP, MADV_WIPEONFORK, MADV_KEEPONFORK, MADV_COLD, MADV_PAGEOUT,
60     MADV_POPULATE_READ, MADV_POPULATE_WRITE, MADV_DONTNEED_LOCKED,
61     MADV_HWPOISON, MADV_SOFT_OFFLINE, MAP_DENYWRITE, MAP_EXECUTABLE,
62 root 1.422 MAP_LOCKED, MAP_DROPPABLE, FILE_DEDUPE_RANGE_SAME, FILE_DEDUPE_RANGE_DIFFERS.
63 root 1.420 - provide atimsec, mtimesec and ctimesec accessors.
64 root 1.421 - do not async close $INVALID_WD and $CWD objects.
65 root 1.423 - treescan: new --quote option.
66 root 1.416
67 root 1.415 4.81 Tue 20 Feb 2024 07:38:35 CET
68 root 1.414 - work around a bug in musl w.r.t to O_SEARCH and use EIO_O_PATH instead,
69     vertifying the semantics against the subset of O_PATH and O_SEARCH
70     (based on a report by Steve Dondley).
71 root 1.413 - aio_copy now tries to preallocate the destination file.
72     - fexecve configure test used the wrong püointer type (patch by Paul Howarth).
73 root 1.412
74 root 1.411 4.80 Sat 01 Apr 2023 04:13:37 CEST
75     - remove long obsolete "paths must be absolute" text in aio_open/stat
76     descriptions.
77 root 1.409 - another workaround for the low-quality musl libc.
78 root 1.408 - test for umount seperately, as it is more portable.
79 root 1.410 - some low-quality posix attempts (openbsd, osx) declare the availability
80     of fexecve but then don't even bother to implemnent a stub.
81 root 1.408
82 root 1.407 4.79 Sun 25 Sep 2022 18:25:53 CEST
83     - the autoconf result of the mount check was not used, so it failed to
84     compile on most systems (reported by crackoff@tutanota.com).
85     - work around fedora not having a working C compiler setup by design
86     (reported by Paul Howarth).
87    
88 root 1.406 4.78 Tue 06 Sep 2022 12:54:43 CEST
89 root 1.405 - add IO::AIO::mount and IO::AIO::umount.
90     - add a bunch of symbols from sys/mount.h.
91 root 1.392
92 root 1.404 4.77 Mon 05 Sep 2022 02:03:38 CEST
93 root 1.402 - add MFD_HUGETLB_2MB and MFD_HUGETLB_1GB constants.
94 root 1.403 - add fexecve.
95     - add lots of missing functions to @EXPORT_OK.
96 root 1.402
97 root 1.401 4.76 Tue Jul 27 20:45:01 CEST 2021
98 root 1.400 - add autoconf test for siginfo_t, which is, of course, not
99 root 1.401 available on windows (reported by Peter Petky).
100 root 1.398 - disable syscalls on solaris, as perl seems to provide an
101     incompatible syscall prototype that clashes with sys/syscall.h.
102 root 1.399 - add MAP_FIXED_NOREPLACE, MAP_SHARED_VALIDATE, MAP_SYNC and
103     MAP_UNINITIALIZED.
104 root 1.398
105 root 1.397 4.75 Wed Dec 30 08:44:55 CET 2020
106     - removed leftover debug output from treescan.
107 root 1.396 - added (but not documented) waitid-P_*, FSPICK_*, FSOPEN_*,
108     FSCONFIG_*, MOUNT_ATTR_* constants.
109 root 1.394
110 root 1.393 4.74 Tue Dec 29 16:19:28 CET 2020
111 root 1.392 - added pidfd_open, pidfd_getfd and pidfd_send_signal functions.
112     - rework bin/treescan to avoid recursion. This fixes two bugs
113     where a deep directory traversal or a lot of command line
114     arguments could cause it to crash.
115     - added (but not documented) open_tree, AT_* and move_mount flags.
116     - support defining syscall numbers in gendef0.
117 root 1.391
118     4.73 Fri Dec 4 02:08:37 CET 2020
119     - def0.h was not uptodate, running into musl problems
120     (reported by B Fraser).
121 root 1.386 - IO::AIO::splice and IO::AIO::tee didn't properly return
122     64 bit values.
123 root 1.385 - added IO::AIO::accept4.
124 root 1.383 - add various F_SEAL related fcntl constants.
125 root 1.391 - removed experimental marker for fdlimit functions.
126 root 1.389 - fiemap now includes the last segment even if it overflows
127 root 1.390 the end offset, which is arguably the correct behaviour.
128 root 1.383
129 root 1.382 4.72 Wed Apr 3 04:56:03 CEST 2019
130 root 1.381 - (libeio) if fd 0 is available do not use it for aio_wd, as it
131     collides with IO::AIO::CWD.
132 root 1.382 - added IO::AIO::memfd_create.
133 root 1.380 - correctly include <sys/uio.h> in the vmsplice test.
134 root 1.381 - reduce codesize by ~7% on amd64 by declaring more functions
135     as noinline.
136 root 1.382 - documentation fixes and updates.
137     - experimental and undocumented preliminary support for synchronous statx.
138 root 1.380
139 root 1.379 4.71 Sun Mar 10 13:09:26 CET 2019
140     - due to an error in the linux manpages, the configure tests
141     for readahead, sync_file_range, splice etc. failed. This has been fixed.
142    
143 root 1.378 4.7 Mon Mar 4 11:28:13 CET 2019
144 root 1.376 - majorly speed up scandir for the very special case of a non-POSIX
145     filesystem that nevertheless reports valid dt_type information.
146     The only known filesystem of this type is currently btrfs, which
147     didn't get it's act together to implement POSIX semantics in all
148     these years, and I am tired of waiting.
149 root 1.375 - add IO::AIO::MCL_ONFAULT for mlockall, add IO::AIO::mlockall.
150 root 1.373 - neither sys/mkdev.h nor sys/sysmacros.h were included, even when they
151     were detected by autoconf.
152    
153 root 1.371 4.6 Sat Aug 25 21:58:36 CEST 2018
154 root 1.369 - add st_btime, st_btimesec, st_btimensec and st_gen accessors,
155     mostly for bsds which expose birthtime and st_gen members (netbsd, freebsd
156     but only st_gen on openbsd because they compiled their perl without support
157     for birthtimes).
158     - fix madvise and munlock to properly support negative offsets.
159     - allocate fd for the aio_close at boot time, to guarantee it working
160     later, rather than calling abort when it fails. also avoids
161     close-on-exec race issues after module load.
162     - #undef utime on win32, maybe this helps some reports of utime hangs.
163     - minor doc improvements.
164     - minor configure cleanups.
165 root 1.370 - use $Config{perllibs} instead of libs for configure. might help people
166 root 1.378 who didn't install all perl dependencies (might break things as well).
167 root 1.369
168 root 1.367 4.54 Tue Aug 14 13:54:48 CEST 2018
169 root 1.366 - include sys/mkdev.h or sys/sysmacros.h if available.
170 root 1.367 - further tweaks to configure invocation for systems requiring --rpath.
171     - no longer rely on custom paths on win32 platforms.
172     - try to work around buggy PAGESIZE macro on solaris.
173 root 1.365
174 root 1.364 4.53 Tue Aug 14 11:27:50 CEST 2018
175     - add $Config{libs} to LIBS for configure, to work around systems
176     with broken library dependencies (... openbsd).
177    
178 root 1.363 4.52 Sun Aug 12 08:09:45 CEST 2018
179     - config.h.in was missing in distribution.
180    
181 root 1.362 4.51 Sun Aug 12 07:24:14 CEST 2018
182 root 1.361 - complete rework of the autoconf framework: IO::AIO now uses its own
183     config.h, separate from libeio, and tries to test the actual perl
184     environment, not the standard system environment.
185     - provide nanosecond-accracy stat time accessors for both perl and IO::AIO
186     stat functions.
187     - removed non-portable C++ syntax from eio.c.
188 root 1.362 - try to fix readdir tests on cygwin spuriously failing.
189 root 1.361
190 root 1.360 4.5 Wed Aug 1 00:23:55 CEST 2018
191 root 1.355 - aio_mtouch touch all pages as requested, not just the first page in most cases.
192 root 1.356 - new function: IO::AIO::mremap, linux-specific mremap, with constants MREMAP_MAYMOVE
193     and MREMAP_FIXED.
194 root 1.357 - add O_ACCMODE.
195 root 1.359 - add (undocumented) MSG_CMSG_CLOEXEC and SOCK_CLOEXEC constants.
196 root 1.320
197 root 1.354 4.4 Tue Feb 20 07:54:12 CET 2018
198 root 1.347 - new aio_slurp request.
199 root 1.353 - add (experimental) IO::AIO::eventfd and timerfd* function.
200     - add (experimental) IO::AIO::get_fdlimit and IO::AIO::min_fdlimit.
201     - point out that aio_copy overwrites existing files.
202 root 1.350 - removed filesystem magic number table from aio_statvfs docs as
203     statvfs doesn't actually return this info at all (statfs does).
204 root 1.330 - add a bunch of (mostly linux-specific) constants for use in ioctls
205     (see aio_ioctl docs).
206 root 1.333 - treescan now has a proper manpage and useful --help output.
207     - new option --sync in treescan, to sync everything in a subtree.
208 root 1.335 - changed default for aio_msync flags to MSYNC_SYNC.
209 root 1.336 - document offset/length behaviour of mprotect/madvise.
210 root 1.337 - support linux's renameat2 (via aio_rename2).
211     - add aio_rename2, an aio_rename with flags.
212 root 1.341 - add F_DUPPFD_CLOEXEC, F_OFD_[SG]ETLKW? constants.
213     - add FALLOC_FL_INSERT_RANGE, FALLOC_FL_UNSHARE_RANGE.
214 root 1.347 - (libeio) use posix_close if available.
215     - (libeio) internal close() calls no longer disturb errno.
216 root 1.349 - add IO:AIO::FALLOC_FL_UNSHARE.
217 root 1.353 - update schmorp.h for removal of USE_SOCKETS_AS_HANDLES
218     and better eventfd detection.
219 root 1.329
220 root 1.328 4.34 Sun May 1 19:18:24 CEST 2016
221     - def0.h was not properly generated during previous release, causing
222     compile errors on various platforms.
223     - major/minor were accidentally switched (reported by Alexander Lishenyuk).
224 root 1.326 - removed duplicate definition of MAP_HUGETLB, that was found due to
225     a bug in Perl::Tidy (testcase by alaska332@gmail.com).
226 root 1.327 - added (untested!) aio_fcntl, aio_ioctl requests.
227 root 1.328 - (libeio) names set via prctl are truncated to 15 chars + nul, not 16,
228     as manpages-dev originally claimed.
229 root 1.326
230 root 1.325 4.33 Mon Jan 18 12:50:10 CET 2016
231 root 1.322 - add IO::AIO::pipe2 function.
232 root 1.323 - added support for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE
233     constants.
234     - added support for O_TMPFILE and O_PATH constants.
235 root 1.324 - added support for MAP_FIXED, MAP_GROWSDOWN,MAP_32BIT, MAP_HUGETLB, MAP_STACK
236     consdtants, whether they can be sensibly used or not.
237 root 1.321 - use NO_INIT where applicable.
238     - update libecb.
239     - added stability canary support.
240 root 1.325 - updated linux super magic table to 4.3.3.
241 root 1.321
242 root 1.320 4.32 Wed Feb 11 20:32:11 CET 2015
243     - replace off_t by STRLEN where appropriate, should not result in
244     user-visible changes.
245     - update ecb.h for C11 compatibility.
246    
247 root 1.317 4.31 Tue Jun 3 03:29:27 CEST 2014
248     - work around more 5.20 bugs. backwards compatibility my ass.
249    
250 root 1.316 4.3 Fri Apr 11 06:22:38 CEST 2014
251     - perl5porters broke Async::Interrupt, BDB, EV, IO::AIO, OpenCL
252     without warning by switching the meaning of USE_SOCKETS_AS_HANDLES
253     in 5.18. What's so attractive about giving a shit about backwards
254     compatibility - I will never understand.
255    
256 root 1.315 4.2 Sat Jan 25 01:13:14 CET 2014
257 root 1.314 - aio_group could corrupt memory because it didn't restore
258     the stack after req_submit.
259 root 1.315 - be more careful on (e.g. permission) errors in bin/treescan.
260 root 1.314 - work around changes in ExtUtils::MakeMaker.
261 root 1.311 - (libeio) implement aio_realpath for win32.
262     - (xthread) work around compile time bugs in ptw32.
263 root 1.313 - added IO::AIO::pipesize.
264 root 1.314 - (libecb) insignificant update.
265 root 1.311
266 root 1.310 4.19 Sun Jan 6 12:47:26 CET 2013
267     - avoid endless loop in fiemap with some XFS files.
268 root 1.309 - in aio_rename and aio_rmdir, specialcase the case of [$wd, "."]
269     and call rename/rmdir instead of renameat/unlinkat.
270    
271 root 1.308 4.18 Thu Oct 11 07:01:26 CEST 2012
272     - fix unintended xthread_create by intentionalising it :)
273    
274 root 1.307 4.17 Thu Oct 11 05:19:47 CEST 2012
275 root 1.304 - rename aio_fallocate to aio_allocate, to match documentation.
276 root 1.303 - add list of linux fsid values to aio_statvfs docs.
277 root 1.305 - work around a bug in btrfs' FIEMAP ioctl implementation.
278 root 1.307 - work around AIX bug: statvfs.f_fsid is a struct, not unsigned long
279     as per unix spec.
280 root 1.303
281     4.16 Tue Aug 14 05:39:03 CEST 2012
282     - aio_statvfs was wromgly marked for wd emulation, causing
283 root 1.306 it to malfunction for paths.
284 root 1.302 - fix a crash in aio_fiemap, when used on ranges without any
285 root 1.301 extents.
286     - work around linux kernel bug (at least in 3.2): kernel might
287     trash fiemap input arguments.
288     - work around linux kernel bug (at least in 3.2): kernel does not
289     set FIEMAP_EXTENT_LAST on last segment.
290 root 1.302 - work around linux kernel bug (at least in 3.2): kernel silently
291     truncates segment count if a file.
292 root 1.294 - make fh argument of IO::AIO::mmap optional, also add mmap/munmap
293     to quick overview.
294 root 1.295 - splice can corrupt data.
295 root 1.296 - (libeio) remove pread/pwrite emulation.
296 root 1.297 - do not grow mmaped scalars in aio_read.
297 root 1.299 - add FALLOC_FL_PUNCH_HOLE and document fallocate.
298 root 1.303 - provide pread/pwrite for win32, making it link again on native win32.
299 root 1.294
300 root 1.293 4.15 Tue Apr 10 06:59:00 CEST 2012
301     - always include linux/types.h for fiemap, for compatibility to
302 root 1.292 ancient systems (Paul Howarth).
303 root 1.293 - experimental support for IO::AIO::splice and ::tee (no aio_...).
304     - provide SEEK_HOLE and SEEK_DATA, if available.
305     - work around (again!) an immensely stupid bug in RHEL, defining
306     autoconf macros in linux system headers (analysed by Paul Howarth).
307 root 1.292
308 root 1.291 4.14 Sat Apr 7 02:45:18 CEST 2012
309     - fix stat structure usage on windows, which caused bogus stat results.
310     - (libeio) make readahead emulation behave more like actual readahead by never failing.
311 root 1.288 - new request aio_seek.
312 root 1.289 - new request aio_fiemap.
313     - autogenerate the #ifdef/#define 0 blocks for symbols we export.
314 root 1.286
315 root 1.285 4.12 Fri Dec 30 08:51:25 CET 2011
316     - realpath would return a random value if the name was too long,
317     instead of -1.
318     - port to c89.
319    
320 root 1.284 4.11 Mon Oct 10 00:24:11 CEST 2011
321     - libeio didn't compile on !linux (Paul Howarth).
322    
323 root 1.283 4.1 Sun Oct 9 10:24:11 CEST 2011
324 root 1.277 - IO::AIO did access uninitialised memory on unsuccessful stats.
325 root 1.272 - (libeio) added syncfs syscall wrapper.
326 root 1.273 - (libeio) set thread name on linux (ps -L/Hcx, top, gdb).
327 root 1.276 - (libeio) support multiple indepenent working directories.
328 root 1.274 - applied speling corrections by Nicholas Bamber.
329 root 1.279 - tune treescan #threads and #outstanding requests a bit.
330     - reduce the number of file descriptors in use at any one time
331     in treescan, to avoid running out of them (and using too much ram).
332     - take advantage of working directoriy abstractions
333     in aio_scandir and treescan.
334 root 1.280 - reduce compiled size by ~10% by not inlining some key functionality.
335 root 1.282 - added --progress switch to treescan.
336 root 1.272
337 root 1.271 4.0 Mon Jul 18 05:01:10 CEST 2011
338 root 1.269 - INCOMPATIBLE CHANGE: fork is no longer supported (indeed, it never was),
339     see FORK BEHAVIOUR in manpage for details.
340 root 1.271 - passes testsuite on win32 now and may actually work
341     (activestate 5.10.1 / MSVC6, YMMV).
342 root 1.267 - (libeio) fix a deadlock where a wakeup signal could be missed when
343     a timeout occured at the same time.
344 root 1.263 - (libeio) added realpath.
345 root 1.266 - (libeio) added fallocate.
346     - (libeio) disabling sendfile on darwin unfortunately broke the emulation.
347 root 1.267 - (libeio) do not acquire any locks when forking.
348     - (libeio) use fewer time() syscalls when waiting for new requests.
349 root 1.263
350 root 1.262 3.93 Wed Jun 29 23:44:18 CEST 2011
351     - ECB.H WAS MISSING.
352    
353 root 1.261 3.92 Wed Jun 29 14:45:41 CEST 2011
354     - ecb.h was missing.
355    
356 root 1.260 3.91 Wed Jun 29 13:24:42 CEST 2011
357 root 1.253 - (libeio) work around a Linux (and likely FreeBSD and other
358     kernels) bug where sendfile would not transfer all the requested
359     bytes on large transfers, using a heuristic.
360 root 1.254 - buggy sendfile caused aio_move/copy to sometimes fail for big
361 root 1.260 files (fortunately it checks that the whole file has been
362 root 1.254 transferred...)
363 root 1.255 - use libecb for higher performance and higher portability.
364 root 1.256 - (libeio) disable sendfile on darwin, it's too broken.
365 root 1.257 - disable fork tests on !linux, as only linux supports mixing
366     pthread and fork in perl.
367 root 1.258 - document the fact that fork doesn't work anymore when using
368     this module, on anything !GNU/Linux.
369 root 1.259 - increase timeout in t/04_fork.t, as too many CPAN-tester setups
370     run on a 0.1MHz cpu. Or so.
371 root 1.252
372 root 1.251 3.9 Fri May 27 02:43:47 CEST 2011
373 root 1.250 - (libeio) fix memory corruption in aio_readdirx for the flags
374     combination READDIR_STAT_ORDER | READDIR_DIRS_FIRST.
375 root 1.267 - add lots of newer POSIX and GNU/Linux-specific open
376 root 1.251 flags.
377 root 1.238
378 root 1.247 3.8 Sun Mar 27 12:25:33 CEST 2011
379 root 1.245 - use nonstandard but maybe-working-on-bsd fork technique.
380     - support a max_idle value of 0.
381 root 1.246 - support setting of idle timeout value (IO::AIO::idle_timeout).
382 root 1.245
383     3.72 Fri Feb 11 04:25:38 CET 2011
384 root 1.248 - use _POSIX_MEMLOCK_RANGE to detect mlock/munlock.
385 root 1.244 - aio_mknod always used a dev_t value of 0.
386 root 1.242 - new treescan option: --grep.
387 root 1.244 - add more S_IF macros, and major/minor/makedev "macros".
388 root 1.241
389 root 1.240 3.71 Thu Dec 30 08:18:46 CET 2010
390     - the numerical result value passed to callbacks did not stringify
391     correctly, due to internal reuse and failure to reset the sv flags.
392 root 1.239 - actually test for posix_[mf]advise, as at least uClibc defines
393     _POSIX_ADVISORY_INFO without actually having any of the required
394     funcitonality. ugh.
395    
396 root 1.238 3.7 Mon Nov 1 23:00:34 CET 2010
397     - implement/add madvise, mmap, munmap, aio_mlockall, munlockall,
398     aio_mlock, munlock, msync and mtouch to @EXPORT_OK.
399     - document the sad state of affairs w.r.t. pthread on many bsds.
400     - do not enable mmap on systems without _POSIX_MAPPED_FILES
401     (openbsd 4.8).
402 root 1.231 - do not leak memory in IO::AIO::mmap when the scalar already
403     had string-data.
404 root 1.238 - add O_RDWR, O_APPEND and O_EXCL symbols and semi-document
405 root 1.228 them.
406 root 1.230 - cache the result IV, for a minor speedup in the common case.
407 root 1.231 - croak when an mmapped-scalar changes location, to detect
408     user-errors better.
409 root 1.237 - fix aio_readlink prototype.
410 root 1.228
411 root 1.227 3.65 Wed Mar 31 02:45:05 CEST 2010
412 root 1.225 - actually use PATH_MAX instead of NAME_MAX for readlink, as to not
413     cut off long pathnames in aio_readlink (based on patch by
414     Rasmus Andersson).
415 root 1.227 - a double fork partially killed the event pipe (great testcase
416     by dormando). affects IO::AIO, BDB and Async::Interrupt.
417     - suck steve's dick and rename our symbols to avoid colliding
418     with nonstandard identifier spam on the broken os x pseudo-os.
419     affects IO::AIO and BDB.
420 root 1.225
421 root 1.224 3.6 Mon Jan 11 00:43:39 CET 2010
422 root 1.219 - (libeio) more fixes for the freebsd/apple sendfile - broken by
423     manpage standards, but apparently correct accoridng to actual
424     kernel sources.
425 root 1.222 - add IO::AIO::mmap/munmap support.
426 root 1.220 - add IO::AIO::m(un)lockall support.
427 root 1.221 - clean up manpage.
428 root 1.218
429 root 1.217 3.5 Thu Jan 7 21:25:04 CET 2010
430 root 1.214 - (liebio) fix freebsd sendfile (Vanilla Hsu).
431     - (libeio) also fix darwin sendfile that suffered from a similar bug.
432 root 1.215 - add aio_statvfs as interface to statvfs/fstatvfs.
433 root 1.216 - work around buggy symlink() on cygwin in the testsuite.
434 root 1.217 - wtf. freebsd-8.0 actually passes the testsuite! I knew
435     they could implement fork and semaphores one day! cheers!
436 root 1.214
437 root 1.213 3.4 Sat Jan 2 15:13:04 CET 2010
438 root 1.209 - (libeio) max_poll_time was not properly converted to ticks.
439     - clarify cancel_subs description.
440 root 1.210 - IO::AIO::sendfile did not actually return the return value
441     from the sendfile call.
442 root 1.212 - implement aio_msync, aio_mtouch.
443 root 1.211 - (libeio) tentatively support darwin in sendfile.
444 root 1.209
445 root 1.208 3.31 Thu Nov 12 02:14:29 CET 2009
446 root 1.206 - fix result status documentation of aio_copy, aio_move.
447 root 1.207 - speed up object creation considerably by avoiding
448     hash lookups.
449 root 1.206
450 root 1.205 3.3 Wed Aug 5 13:52:58 CEST 2009
451 root 1.202 - use common::sense.
452     - use common schmorp.h header.
453     - allow integers (file descriptors) in addition to file handles.
454 root 1.203 - take advantage of linux' eventfd (but it seems slower on smp?).
455 root 1.204 - use poll not select on posix platforms.
456 root 1.202
457 root 1.201 3.261 Wed Jul 1 10:11:51 CEST 2009
458 root 1.207 - more 0S X workarounds (patch by Tokuhiro Matsuno).
459 root 1.200
460 root 1.199 3.26 Tue Jun 30 09:33:26 CEST 2009
461 root 1.207 - 0S X of course claims to be posix 2008 but lacks posix_fadvise.
462     try to work around this horribly broken OS in a somewhat hackish
463     way. might help other os's too.
464 root 1.199
465 root 1.198 3.25 Sat Jun 27 05:18:26 CEST 2009
466 root 1.197 - added IO::AIO::fadvise and IO::AIO::sendfile.
467 root 1.195 - (libeio) replaced quicksort+insertion sort by a tuned radix
468     sort + insertion sort, resulting in comparable runtime (usually
469     faster) to the old version, but without any ill side effects on
470     degenerated (for quicksort) data.
471     - (libeio) correctly sort dirs by inodes if we have perfect type
472 root 1.194 knowledge and DIRS_FIRST is used.
473 root 1.195 - (libeio) internally the wrong DT_* constants were used, but no
474     known system has differing EIO_DT_*/DT_* values, so not an issue.
475     - removed a (harmless) assert that was left over on the code
476     but should not have been.
477 root 1.196 - use more correct types (change IO length from IV to VAL64,
478     which makes a difference on systems without 64 bit perls).
479 root 1.194
480 root 1.193 3.23 Sat Jun 13 16:57:58 CEST 2009
481     - fix off-by-one bug in aio_readdir that was introduced in the
482     rushed 3.22 release.
483    
484 root 1.192 3.22 Sat Jun 13 15:32:40 CEST 2009
485 root 1.191 - speed up readdirx sort algorithm slightly.
486 root 1.192 - bin/treescan was missing from distro tarball.
487 root 1.191
488 root 1.190 3.21 Fri Jun 12 18:45:53 CEST 2009
489 root 1.187 - new options --dirs and --files for treescan.
490 root 1.188 - install bin/treescan by default.
491 root 1.189 - (libeio) aio_readdir can now be cancelled while executing.
492 root 1.190 - fix a printf format string for 64 bit systems (could lead
493     to problems on big endian 64 bit systems).
494     - do not use qsort() but our own algorithm: glibc initialises
495     the whole locale and I/O subsystem inside qsort, causing
496     a stack overflow on 32 bit machines. The new sort uses much less
497     stack and is more than twice as fast in typical situations.
498 root 1.187
499 root 1.186 3.2 Sun Jun 7 20:30:05 CEST 2009
500 root 1.182 - (libeio) pwrite emulation was even more flawed than intended and did
501     not restore the file offset.
502 root 1.183 - add aio_readdirx, which can return inode and filetype and sort
503     the names in various ways.
504 root 1.182 - unfortunately, utime, chmod, chown on an open file that has just
505     been written can easily block, which caused aio_copy to block the
506     process. no more!
507     - no longer rely on dst path in aio_copy when futime is available.
508    
509 root 1.181 3.19 Tue Apr 21 22:05:21 CEST 2009
510     - more perl 5.10 workarounds for aio_read and write.
511     - aio_write no longer modifies the sv (if possible).
512     - aio_read now works correctly with magic values.
513    
514 root 1.180 3.18 Sun Apr 19 21:17:32 CEST 2009
515 root 1.179 - better diagnostics when some aio_* functions get passed an illegal fh.
516 root 1.180 - try to avoid crashes due to incompatible 5.10 API changes. grmbl.
517 root 1.178
518 root 1.177 3.17 Thu Nov 20 08:45:36 CET 2008
519 root 1.176 - (libeio) added aio_sync_file_range (untested).
520 root 1.177 - add aio_busy to @IO::AIO::AIO_REQ.
521 root 1.175
522 root 1.174 3.16 Wed Oct 22 18:28:01 CEST 2008
523 root 1.173 - use SvREFCNT_inc instead of SvREFCNT_inc_NN in a non-speed critical
524     part to improve portability to perl 5.8 (reported by szymon).
525    
526 root 1.172 3.15 Mon Oct 13 00:39:55 CEST 2008
527 root 1.171 - automatic removal of feeders was broken.
528     - (libeio) use a more robust method to detect whether a feeder
529     has added something to the group or not.
530    
531 root 1.170 3.1 Thu Oct 2 13:34:40 CEST 2008
532 root 1.168 - pre-deref the passed callback object, for increased speed
533     and decreased memory usage.
534 root 1.167 - call on_next_submit callback even for aio_group - impact unknown,
535 root 1.166 but seems more correct.
536 root 1.168 - $req->cb now returns the original callback.
537 root 1.166 - (libeio) pass EIO_GROUP/aio_group requests through the queue without
538     requiring a thread switch.
539 root 1.169 - (libeio) status code of aio_futime and aio_utime was always passed 0.
540 root 1.166 - do some other µ-optimisations.
541    
542 root 1.165 3.07 Sat Aug 2 16:06:13 CEST 2008
543     - do not include LIBS in autoconf tests.
544    
545 root 1.164 3.06 Tue Jul 15 12:41:32 CEST 2008
546 root 1.162 - move preadwritelock definition before it's first reference,
547 root 1.164 to make it compile again on broken platforms (they still exist)
548     or badly cofngiured perls (redhat...), reported by Rob Bloodgood.
549 root 1.162
550 root 1.161 3.05 Thu Jun 19 23:23:52 CEST 2008
551 root 1.160 - work around perl overriding readdir etc. with thread-unsafe
552 root 1.161 (sic!) versions.
553 root 1.160
554 root 1.159 3.04 Wed Jun 18 01:35:38 CEST 2008
555     - (libeio) fix eio_mknod, which confused it's arguments.
556 root 1.158 - (libeio) do not use readdir_r, as Ulrich Drepper pointed out that this
557     is stupid.
558 root 1.159 - (libeio) fix eio__readahead prototype, patch by Jost Krieger.
559     - (libeio) fix a bug that could potentially cause IO::AIO
560     not to get initialised properly.
561 root 1.158
562 root 1.157 3.03 Thu May 29 05:33:30 CEST 2008
563 root 1.153 - (libeio) correctly call pthread_attr_destroy ().
564 root 1.155 - (libeio) work around broken bsd headers once more.
565 root 1.154 - reduce shared library size again by not including wrappers.
566 root 1.156 - max_outstanding could cause poll to enter a busy-waiting loop.
567     - document the new IO::AIO::poll_cb result value.
568 root 1.153
569 root 1.152 3.02 Mon May 12 02:32:02 CEST 2008
570 root 1.150 - fix a memory leak on aio_readlink.
571     - bring back working fchmod.
572 root 1.151 - nop and busy now set result to 0.
573     - set errno to ENOMEM when allocation fails.
574 root 1.150
575 root 1.149 3.01 Sun May 11 03:07:03 CEST 2008
576     - (libeio) make it compile on systems without readahead or readdir_r.
577 root 1.148 - (libeio) improve configure check for readahead availability.
578     - do not try to link against -lrt.
579 root 1.147 - use a separate configure script for IO::AIO (not the libeio one).
580    
581 root 1.146 3.0 Sun May 11 00:57:14 CEST 2008
582 root 1.145 - added bin/treescan to the distribution.
583     - switched to using libeio.
584     - LOTS OF INCOMPATIBLE CHANGES:
585     - remove signal functionality, it is not worth the effort.
586     - max_outstanding no longer returns the previous number of requests.
587     - poll_cb no longer returns number of requests.
588 root 1.143
589 root 1.142 2.62 Sat Apr 26 13:59:33 CEST 2008
590 root 1.141 - port to solaris perls configured for old posix
591     (analysed by Jost Krieger).
592 root 1.142 - keep a reference to the perl filehandle object in aio_close,
593     so it doesn't get closed prematurely, leading to ugly races.
594 root 1.141
595 root 1.140 2.61 Wed Apr 16 18:45:02 CEST 2008
596 root 1.137 - fix treescan output duplication and improve output ordering.
597     also display files given on the commandline.
598 root 1.140 - use a different algorithm for aio_close that is faster
599     and probably has even lower chances of blocking.
600 root 1.138 - do our own stack memory management for threads - linux
601     allocates outrageous amounts of VM (not so bad unless you
602     use mlockall...), which severely limits the number of threads
603 root 1.139 on 32-bit arches: stack size is the larger of PTHREAD_STACK_MIN
604     and 4096 * sizeof (long) (usually this is 16..64k).
605 root 1.137
606 root 1.136 2.6 Sun Mar 30 08:28:11 CEST 2008
607 root 1.134 - added aio_sync.
608 root 1.135 - added aio_pathsync.
609 root 1.136 - fix prototypes of (void) functions.
610 root 1.134
611 root 1.133 2.51 Sat Oct 6 16:04:54 CEST 2007
612     - perlio isn't generally threadsafe, so aio_close could not work reliably.
613     aio_close now tries a safe hack that might not be that asynchronous
614     (see the manpage for details).
615     - discard callback return values as to not grow the stack endlessly
616     when poll_cb handles many requests without returning.
617     - minor code cleanups.
618    
619 root 1.132 2.5 Thu Oct 4 14:49:08 CEST 2007
620 root 1.131 - replaced _fd2fh with faster xs code.
621     - aio_close will now try to do "the right thing" and thus might
622     work sensibly for the very first time.
623    
624 root 1.130 2.41 Mon Sep 24 21:28:21 CEST 2007
625 root 1.129 - after fork, invest some work to make sure that the poll_fileno
626     stays stable (by dup2'ing the new fd over the old one), to make
627     it easier for programs/libs that don't control their forking
628     behaviour and cannot recreate their watchers.
629    
630 root 1.128 2.4 Sun Aug 5 18:44:22 CEST 2007
631 root 1.127 - add aio_truncate, aio_chmod, aio_chown, aio_utime (linux
632     successfully demonstrated that you can block on futimes...).
633 root 1.124 - allow undef as fileoffset for aio_read/write and use read/write(2)
634     internally (useful for sockets or O_APPEND handles).
635 root 1.126 - allow undef for length in aio_write.
636     - negative dataoffsets work as expected now in aio_read/aio_write.
637 root 1.124 - use NV instead of UV for 32 bit perls and file offsets, as NVs
638 root 1.125 have a larger range then.
639 root 1.120 - shared code between BDB and IO::AIO.
640 root 1.127 - aio_busy was completely broken. now fixed.
641     - readahead emulation now returns something.
642 root 1.121 - correctly set errno to ENOSYS on unimplemented functions
643     (should never happen, though).
644 root 1.127 - large changes to make it partially compile and run on win32,
645     but win32 lacks too much functionality, and perl overrides way
646     too many functions with crashing versions.
647 root 1.120
648 root 1.119 2.33 Tue Jan 23 23:55:41 CET 2007
649     - fix install path (Andreas J. Koenig).
650    
651 root 1.118 2.32 Mon Jan 22 16:56:23 CET 2007
652 root 1.114 - added aio_rmtree.
653 root 1.115 - wow, aio_mkdir was missing.
654 root 1.116 - aio_load did return undef on error, not -1.
655 root 1.117 - use prefixexp not prefix in autoconf.pm
656     (suggested by ... rt.cpan.org unreachable).
657 root 1.118 - avoid installing autoconf.pm.
658 root 1.114
659 root 1.113 2.31 Sat Jan 6 03:46:02 CET 2007
660 root 1.112 - added aio_load.
661    
662 root 1.111 2.3 Sat Dec 23 05:48:07 CET 2006
663     - fix off-by-one bug in aio_read, causing memory corruption
664     or crashes.
665    
666 root 1.110 2.21 Fri Dec 22 05:03:38 CET 2006
667 root 1.108 - minor doc updates.
668 root 1.107 - minor cleanups.
669     - IO::AIO::poll returns request count.
670 root 1.109 - undocumented and unfinished async-signal-reporting.
671 root 1.107
672 root 1.103 2.2 Tue Oct 31 00:31:00 CET 2006
673 root 1.100 - minor doc updates.
674 root 1.101 - added aio_readlink.
675     - properly zero-terminate aio_read buffer.
676     - fix aio_read/write with nonzero dataoffset.
677 root 1.104 - reduced size of aio request structure.
678 root 1.106 - better diagnostics when pathnames etc. are not byte-encoded;
679 root 1.105 do not leak request in that case, either.
680 root 1.94
681 root 1.99 2.1 Sun Oct 29 02:01:57 CET 2006
682 root 1.98 - INCOMPATIBLE CHANGE: replace IO::AIO::poll_some by
683     IO::AIO::max_poll_reqs and IO::AIO::max_poll_time.
684 root 1.95 - fix a bug in aio_move where it would fail everytime
685     it would have to copy files manually.
686 root 1.98 - doc updates.
687 root 1.94 - start threads only on (very low) demand.
688 root 1.97 - end superfluous threads automatically after 10s idling.
689 root 1.98 - add IO::AIO::max_idle to control this.
690 root 1.94 - some tuning applied to random places.
691 root 1.95 - add aio_mknod.
692 root 1.59
693 root 1.92 2.0 Thu Oct 26 18:27:58 CEST 2006
694 root 1.90 - minor incompatibility: max_outstanding semantics have changed.
695 root 1.86 - major rewrite, consider all functionality EXPERIMENTAL.
696 root 1.68 - aio requests can be cancelled.
697 root 1.81 - callbacks can be (re-)set later.
698 root 1.93 - aio requests can choose between 9 priorities.
699 root 1.83 - add aio_group: aio requests can be grouped
700     into composite requests.
701     - generator interface for groups.
702 root 1.89 - add IO::AIO::poll_some.
703 root 1.72 - major documentation improvements.
704     - very minor bugfixes.
705 root 1.76 - add aio_nop for dummy requests.
706 root 1.84 - add aio_busy mainly for benchmarking and debugging.
707 root 1.79 - use "fast" mutexes on linux.
708 root 1.80 - use dynamic (and larger) buffers instead of
709     putting them onto the stack.
710     - optimise x86 and amd64 a bit.
711     - better error checking when ENOMEM.
712 root 1.85 - hopefully fix mem and dirp leaks on fork.
713 root 1.92 - warn about broken perl malloc.
714 root 1.88 - compiles on cygwin (but pread is broken on cygwin
715     which is not detected by autoconf, so you have to
716     edit autoconf/config.h yourself to enable emulation).
717 root 1.68
718 root 1.67 1.8 Sat Jun 24 22:20:44 CEST 2006
719 root 1.66 - add and/or document aio_rename, aio_link, aio_symlink and aio_move.
720    
721 root 1.65 1.73 Wed Mar 1 22:49:32 CET 2006
722     - codename "jost"
723     - AIX/Solaris(?) aren't being helpful again, hardcode a value
724     for NAME_MAX and drive with your eyes closed (reported by
725     wcooley@nakedape.cc).
726 root 1.63
727 root 1.62 1.72 Thu Feb 2 00:40:44 CET 2006
728 root 1.61 - another minor bug in aio_scandir, again, the callback was called
729     twice when the directory can't be stat'ed.
730    
731 root 1.60 1.71 Mon Dec 26 20:20:03 CET 2005
732     - grr, another minor bug in aio_scandir, this time resulting
733     in a runtime error.
734    
735 root 1.59 1.7 Mon Dec 26 19:29:48 CET 2005
736 root 1.58 - aio_scandir errornously called callback twice in some cases.
737 root 1.57 - added AnyEvent example.
738    
739 root 1.55 1.61 Wed Sep 7 19:40:42 CEST 2005
740 root 1.54 - no longer include $Config{libs}, as distros include too much
741 root 1.56 garbage in there that is not installed on typical systems
742 root 1.54 (for example, debian links perl against -lgdbm and many more
743     libraries despite perl not needing it, slowing down startup and
744     wasting memory).
745    
746 root 1.53 1.6 Tue Aug 30 17:44:44 CEST 2005
747     - added aio_readdir, aio_scandir.
748 root 1.51 - added aio_sendfile, including sendfile emulation when sendfile
749     isn't available. Linux, FreeBSD and HP-UX might work (sendfilev
750     support is unavailable on my solaris 8 machine, but preliminary
751     code is there. What's lacking is configury stuff and testing...).
752 root 1.46
753 root 1.44 1.5 Sat Aug 20 02:32:19 CEST 2005
754 root 1.51 - create the aio threads on demand only (good after forking).
755 root 1.41 - somebody nagged about C89 compatibility, so this release should
756 root 1.42 be C89 compatible, but no guarantees for future ones.
757 root 1.43 - abort when the configure script fails.
758 root 1.41
759 root 1.40 1.4 Wed Aug 17 08:07:27 CEST 2005
760 root 1.93 - forgot to recreate the pipe after forking, this could cause
761 root 1.40 deadlocks.
762    
763 root 1.39 1.3 Wed Aug 17 07:25:54 CEST 2005
764 root 1.33 - properly propagate exceptions from callbacks, instead of silently
765     eating them.
766 root 1.38 - use a different fork algorithm that avoids recursive callback
767     invocations and reduces fork latency in busy processes.
768 root 1.37 - fix a bug where the buffer scalar in aio_read got assigned the wrong
769     length after reading.
770     - fix a bug where the child would process some outstanding requests
771     from the parent.
772     - make a copy of the callback scalar, to avoid some very uncommon
773     (but valid) usages where the callback scalar changes.
774     - the callback was never freed in aio_read/aio_write.
775 root 1.38 - aio_read/aio_write will now set the readonly flag on the data
776     scalar for better error reporting.
777 root 1.33
778 root 1.32 1.2 Wed Aug 17 01:22:58 CEST 2005
779     - verified on cygwin, linux/amd64+ia32+alpha, solaris.
780 root 1.31 - use SvPVbyte for filenames now. You *need* to encode your strings to
781     the external filename encoding first.
782 root 1.32 - fix the bug where filehandles could leak (again).
783 root 1.31 - clarify freebsd situation: make it work and tell me how, or go away
784     with your underdocumented, broken and outdated OS.
785     - fork'ing should now be officially supported (where linux and
786     posix contradict each other, I followed posix).
787 root 1.32 - only call read() once per poll, not twice (speedup).
788     - new functions: aio_rmdir, aio_symlink.
789 root 1.31 - force callback arguments to be undef or a reference, for better
790     error catching.
791 root 1.1
792 root 1.29 1.1 Sun Aug 7 05:27:23 CEST 2005
793 root 1.25 - added configure script to detect availability of some calls.
794 root 1.27 (imperfect, as we cannot detect things like -lrt due to missing
795 root 1.23 feedback yet).
796 root 1.27 - emulate fdatasync via fsync, pread/pwrite via unsafe read/write
797     and readahead via manual reading on platforms lacking those.
798 root 1.19 - ported t/03_errors.t+framework by Brad Fitzpatrick
799     from Linux::AIO.
800 root 1.18 - removed XOPEN_SOURCE because stupid solaris 9 doesn't
801     compile with it enabled. Probably breaks others. Oh well.
802 root 1.24 - try to be more careful with errno on non-threaded perls.
803 root 1.26 - cygwins perl insisted on a matching open mode when morphing
804     the fd to an fh.
805 root 1.28 - convert sv's to "byte" encoding in aio_read/aio_write. Might
806     do that for pathnames, too, in the future, so make sure you
807     properly encode your pathnames.
808 root 1.18
809 root 1.17 1.0 Fri Jul 22 10:43:30 CEST 2005
810     - aio_open did not reliably deliver (open) filehandles.
811 root 1.16 - all aio_*-functions keep a reference to the filehandle so
812     it doesn't go away while the aio requests is working on it.
813     - disable warnings in AIO.pm.
814    
815 root 1.15 0.9 Wed Jul 20 23:55:04 CEST 2005
816     - allow recursive calls to poll_cb, use less locking calls, too.
817     - fix the Gtk2-example in the SYNOPSIS.
818 root 1.14 - use pread/pwrite not pread64/pwrite64. this was simply a leftover
819     from Linux::AIO.
820     (found by compiling on cygwin. Unfortunately, cygwin declares but
821     does not implement pread/pwrite).
822     - only include <sys/syscall.h> on linux.
823    
824 root 1.13 0.5 Tue Jul 12 13:03:09 CEST 2005
825 root 1.12 - removed #include <endian.h>, it's not portable, and we don't
826     need it anyway.
827     - link against -lrt, as it might contain goodies such as fdatasync,
828     and often aio_read, which we do not use yet, but it shouldn't hurt.
829    
830 root 1.11 0.4 Mon Jul 11 05:28:25 CEST 2005
831 root 1.9 - added IO::AIO::flush, IO::AIO::poll.
832 root 1.10 - make callback argument optional for all calls.
833 root 1.8
834 root 1.7 0.3 Mon Jul 11 01:42:37 CEST 2005
835 root 1.5 - restructured manpage.
836 root 1.7 - added SYNOPSIS with examples for Event, Glib, Tk.
837     - remove explicit context support so I don't have to maintain
838     it for threaded perls (i.e. it should work now :).
839 root 1.5
840 root 1.4 0.2 Sun Jul 10 22:57:12 CEST 2005
841 root 1.2 - return immediately from poll_wait if nreqs==0.
842     - get rid of the request pipe and use faster thread-thread
843 root 1.3 communications for most requests and responses.
844 root 1.2
845 root 1.1 0.1
846     - cloned from Linux::AIO, which is very similar.
847